GNU bug report logs - #50935
minibuffer-electric-default-mode interface

Previous Next

Package: emacs;

Reported by: Stefan Kangas <stefan <at> marxist.se>

Date: Fri, 1 Oct 2021 11:45:02 UTC

Severity: minor

Tags: patch

Fixed in version 29.1

Done: Lars Ingebrigtsen <larsi <at> gnus.org>

Bug is archived. No further changes may be made.

Full log


View this message in rfc822 format

From: Stefan Kangas <stefan <at> marxist.se>
To: Juri Linkov <juri <at> linkov.net>
Cc: 50935 <at> debbugs.gnu.org
Subject: bug#50935: minibuffer-electric-default-mode interface
Date: Tue, 5 Oct 2021 12:55:52 -0400
[Message part 1 (text/plain, inline)]
tags 50935 + patch
thanks

Juri Linkov <juri <at> linkov.net> writes:

>> A third option is to add 'minibuffer-default-prompt-format' on emacs-28,
>> but make the suggested deletion on master -- which give us more time to
>> get `minibuffer-default-prompt-format' up to scrap.
>
> I guess the answer depends on the question how many prompts
> are already converted to 'minibuffer-default-prompt-format',
> and how many remain.  I checked a few commands, and noticed
> only one command that doesn't use the new format.  It's 'M-.'
> ('xref-find-definitions').  But maybe it can't use the new option
> 'minibuffer-default-prompt-format' because xref.el should be
> available in old versions?  Still it could use
>
>   (if (boundp 'minibuffer-default-prompt-format) ...

I've now updated any prompt I could find to use `format-prompt' (by
grepping for " (default ").  Maybe I've missed one or two, but that
should mean that that the overwhelming majority of our prompts now
respect `minibuffer-default-prompt-format'.  See commit 6640942221.

With that, I think the option `minibuffer-eldef-shorten-default' should
be declared obsolete, as in the attached patch, and consequently removed
from the manual.  This change should go to master, of course.

The command `minibuffer-electric-default-mode' shouldn't be declared
obsolete as it does something different.
[0001-Make-minibuffer-eldef-shorten-default-obsolete.patch (text/x-diff, attachment)]

This bug report was last modified 2 years and 348 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.