GNU bug report logs - #50920
28.0.50; patch for image-dired.el (master or emacs-28?)

Previous Next

Package: emacs;

Reported by: Peter Münster <pm <at> a16n.net>

Date: Thu, 30 Sep 2021 20:08:02 UTC

Severity: normal

Found in version 28.0.50

Fixed in version 29.1

Done: Lars Ingebrigtsen <larsi <at> gnus.org>

Bug is archived. No further changes may be made.

Full log


Message #11 received at 50920 <at> debbugs.gnu.org (full text, mbox):

From: Peter Münster <pm <at> a16n.net>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: 50920 <at> debbugs.gnu.org
Subject: Re: bug#50920: 28.0.50; patch for image-dired.el (master or emacs-28?)
Date: Fri, 01 Oct 2021 08:29:52 +0200
[Message part 1 (text/plain, inline)]
On Fri, Oct 01 2021, Eli Zaretskii wrote:

> Please prepare a patch for master.

Please find it here attached.

-- 
           Peter
[0001-New-command-for-unmarking-all-images.patch (text/x-patch, inline)]
From 45a823990bc8e1917b4cfa107b9e8697a094b067 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Peter=20M=C3=BCnster?= <pm <at> a16n.net>
Date: Fri, 1 Oct 2021 08:28:53 +0200
Subject: [PATCH] New command for unmarking all images

* lisp/image-dired.el (image-dired-unmark-all-marks): Remove marks from
Dired buffer and update the view of the thumbnails.
---
 etc/NEWS            | 7 +++++++
 lisp/image-dired.el | 9 +++++++++
 2 files changed, 16 insertions(+)

diff --git a/etc/NEWS b/etc/NEWS
index d0e41baaeb..9e9c90c7e5 100644
--- a/etc/NEWS
+++ b/etc/NEWS
@@ -36,6 +36,13 @@ applies, and please also update docstrings as needed.
 
 * Changes in Specialized Modes and Packages in Emacs 29.1
 
+** image-dired
+
+---
+*** New command for the thumbnail buffer.
+The new command 'image-dired-unmark-all-marks' has been added with a
+binding in the menu.
+
 
 * New Modes and Packages in Emacs 29.1
 
diff --git a/lisp/image-dired.el b/lisp/image-dired.el
index 3ca47300a9..ec3f988bfb 100644
--- a/lisp/image-dired.el
+++ b/lisp/image-dired.el
@@ -1433,6 +1433,14 @@ image-dired-toggle-mark-thumb-original-file
   (interactive)
   (image-dired-modify-mark-on-thumb-original-file 'toggle))
 
+(defun image-dired-unmark-all-marks ()
+  "Remove all marks from all files.
+Do this in the Dired buffer and update this thumbnail buffer."
+  (interactive)
+  (with-current-buffer (image-dired-associated-dired-buffer)
+    (dired-unmark-all-marks))
+  (image-dired-thumb-update-marks))
+
 (defun image-dired-jump-original-dired-buffer ()
   "Jump to the dired buffer associated with the current image file.
 You probably want to use this together with
@@ -1536,6 +1544,7 @@ image-dired-thumbnail-mode-map
         ["Quit" quit-window]
         ["Delete thumbnail from buffer" image-dired-delete-char]
         ["Delete marked images" image-dired-delete-marked]
+        ["Unmark all marks" image-dired-unmark-all-marks]
         ["Remove tag from current or marked thumbnails"
          image-dired-tag-thumbnail-remove]
         ["Tag current or marked thumbnails" image-dired-tag-thumbnail]
-- 
2.31.1

[signature.asc (application/pgp-signature, inline)]

This bug report was last modified 3 years and 234 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.