GNU bug report logs - #50905
[PATCH core-updates 00/38] Clean up TODO(core-updates)

Previous Next

Package: guix-patches;

Reported by: Maxime Devos <maximedevos <at> telenet.be>

Date: Wed, 29 Sep 2021 22:19:01 UTC

Severity: normal

Tags: patch

Done: Mathieu Othacehe <othacehe <at> gnu.org>

Bug is archived. No further changes may be made.

Full log


View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Maxime Devos <maximedevos <at> telenet.be>
Subject: bug#50905: closed (Re: bug#50905: [PATCH core-updates 00/38]
 Clean up TODO(core-updates))
Date: Sat, 02 Oct 2021 16:55:02 +0000
[Message part 1 (text/plain, inline)]
Your bug report

#50905: [PATCH core-updates 00/38] Clean up TODO(core-updates)

which was filed against the guix-patches package, has been closed.

The explanation is attached below, along with your original report.
If you require more details, please reply to 50905 <at> debbugs.gnu.org.

-- 
50905: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=50905
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems
[Message part 2 (message/rfc822, inline)]
From: Mathieu Othacehe <othacehe <at> gnu.org>
To: Maxime Devos <maximedevos <at> telenet.be>
Cc: 50905-done <at> debbugs.gnu.org
Subject: Re: bug#50905: [PATCH core-updates 00/38] Clean up TODO(core-updates)
Date: Sat, 02 Oct 2021 16:54:04 +0000
> * guix/build-system/mozilla.scm
>   (lower-mozilla): New procedure.
>   (mozilla-build-system): New variable.
> * Makefile.am (MODULES): Add it.
> * doc/guix.texi (Build Systems): Document it.

Pushed the v2 on core-updates,

Thanks,

Mathieu

[Message part 3 (message/rfc822, inline)]
From: Maxime Devos <maximedevos <at> telenet.be>
To: guix-patches <at> gnu.org
Subject: [PATCH core-updates 00/38] Clean up TODO(core-updates)
Date: Thu, 30 Sep 2021 00:18:11 +0200
[Message part 4 (text/plain, inline)]
Hi guix,

This addresses things like

     ;; TODO(core-updates): make this unconditional
     `(,@(if (%current-target-system)
             `(("bash-minimal" ,bash-minimal)) ; for glib-or-gtk-wrap
             '())

It also introduces a mozilla-build-system, which is like gnu-build-system
except it overrides --target and --host to what mozilla software expects
and uses it for all Mozilla software I could identify that needs this.

I also removed a 'canonical-package' in isc-dhcp's input, because as I
understand it, ‘canonical packages’ aren't supposed to appear in the
references, except for gcc:lib and glibc perhaps?  (Not 100% sure,
but noone suggested using canonical-package when I told people to add
bash-minimal to package inputs.)

I also added a #:sh argument to wrap-qt-program to address a TODO(core-updates)
in guix/lint.scm and for consistency with wrap-program, but didn't test it
because of the many rebuilds.

I noted #:tests? wasn't respected in some packages I modified, which I fixed in
a few places.  I also removed trailing #t for some packages.

avahi and atk appear to (cross-)compile.  (I reverted
‘build/minetest-build-system: Move png-file? to (guix build utils).’ first to avoid
some rebuilds though.)

Greetings,
Maxime
[signature.asc (application/pgp-signature, inline)]

This bug report was last modified 3 years and 232 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.