GNU bug report logs - #50905
[PATCH core-updates 00/38] Clean up TODO(core-updates)

Previous Next

Package: guix-patches;

Reported by: Maxime Devos <maximedevos <at> telenet.be>

Date: Wed, 29 Sep 2021 22:19:01 UTC

Severity: normal

Tags: patch

Done: Mathieu Othacehe <othacehe <at> gnu.org>

Bug is archived. No further changes may be made.

Full log


View this message in rfc822 format

From: Maxime Devos <maximedevos <at> telenet.be>
To: Mathieu Othacehe <othacehe <at> gnu.org>
Cc: Maxime Devos <maximedevos <at> telenet.be>, 50905 <at> debbugs.gnu.org
Subject: [bug#50905] [PATCH core-updates v2 24/38] gnu: at-spi2-core: Respect #:tests?.
Date: Fri,  1 Oct 2021 16:21:26 +0200
* gnu/packages/gtk.scm (at-spi2-core)[arguments]<#:phases>{check}:
  Don't run tests if the value of #:tests? if false.
---
 gnu/packages/gtk.scm | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/gnu/packages/gtk.scm b/gnu/packages/gtk.scm
index adb4d847a4..d829218305 100644
--- a/gnu/packages/gtk.scm
+++ b/gnu/packages/gtk.scm
@@ -768,14 +768,15 @@ scaled, composited, modified, saved, or rendered.")
                         (string-append out "/share/gtk-doc")))
                      #t))))
          (add-after 'install 'check
-           (lambda _
+           (lambda* (#:key tests? #:allow-other-keys)
              (setenv "HOME" (getenv "TMPDIR")) ; xfconfd requires a writable HOME
              ;; Run test-suite under a dbus session.
              (setenv "XDG_DATA_DIRS" ; for finding org.xfce.Xfconf.service
                      (string-append %output "/share"))
              ;; Don't fail on missing  '/etc/machine-id'.
              (setenv "DBUS_FATAL_WARNINGS" "0") ;
-             (invoke "dbus-launch" "ninja" "test")))
+             (when tests?
+               (invoke "dbus-launch" "ninja" "test"))))
          (delete 'check))))
     (inputs
      `(("bash-minimal" ,bash-minimal)))
-- 
2.33.0





This bug report was last modified 3 years and 232 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.