GNU bug report logs - #50905
[PATCH core-updates 00/38] Clean up TODO(core-updates)

Previous Next

Full log

Message #116 received at 50905 <at> debbugs.gnu.org (full text, mbox):

From: Maxime Devos <maximedevos <at> telenet.be>
To: 50905 <at> debbugs.gnu.org
Cc: Maxime Devos <maximedevos <at> telenet.be>
Subject: [PATCH 38/38] lint: check-wrapper-inputs: Remove mentions of
 core-updates.
Date: Thu, 30 Sep 2021 00:19:38 +0200

The #:sh argument of 'wrap-program' and 'wrap-qt-program' is
now in the current branch, so some comments aren't relevant anymore.

* guix/lint.scm (check-wrapper-inputs)[check-procedure-body]: Remove mentions
  of core-updates.
---
 guix/lint.scm | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/guix/lint.scm b/guix/lint.scm
index 217a0d6696..2a703f9b6d 100644
--- a/guix/lint.scm
+++ b/guix/lint.scm
@@ -552,13 +552,10 @@ or \"bash-minimal\" is not in its inputs. 'wrap-script' is not supported."
   (define (check-procedure-body body)
     (match body
       ;; Explicitely setting an interpreter is acceptable,
-      ;; #:sh support is added on 'core-updates'.
-      ;; TODO(core-updates): remove mention of core-updates.
       (('wrap-program _ '#:sh . _) '())
       (('wrap-program _ . _)
        (list (report-wrap-program-error package 'wrap-program)))
       ;; Wrapper of 'wrap-program' for Qt programs.
-      ;; TODO #:sh is not yet supported but probably will be.
       (('wrap-qt-program _ '#:sh . _) '())
       (('wrap-qt-program _ . _)
        (list (report-wrap-program-error package 'wrap-qt-program)))
-- 
2.33.0

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.