From debbugs-submit-bounces@debbugs.gnu.org Wed Sep 29 04:51:04 2021 Received: (at submit) by debbugs.gnu.org; 29 Sep 2021 08:51:04 +0000 Received: from localhost ([127.0.0.1]:47763 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mVVIt-00035V-SI for submit@debbugs.gnu.org; Wed, 29 Sep 2021 04:51:04 -0400 Received: from lists.gnu.org ([209.51.188.17]:33722) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mVVIs-00035N-BG for submit@debbugs.gnu.org; Wed, 29 Sep 2021 04:51:02 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:36554) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mVVIp-0001WF-PM for guix-patches@gnu.org; Wed, 29 Sep 2021 04:51:01 -0400 Received: from wout1-smtp.messagingengine.com ([64.147.123.24]:52067) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mVVIh-0007FA-8P for guix-patches@gnu.org; Wed, 29 Sep 2021 04:50:54 -0400 Received: from compute6.internal (compute6.nyi.internal [10.202.2.46]) by mailout.west.internal (Postfix) with ESMTP id 4824E3201C4A; Wed, 29 Sep 2021 04:50:48 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute6.internal (MEProxy); Wed, 29 Sep 2021 04:50:48 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fastmail.net; h= from:to:subject:date:message-id:mime-version:content-type; s= fm1; bh=/ApVXU8GXTipK7+MgVXMlg6I7MxWimsAyLfXuuM0nEs=; b=Mnq/olpQ avm/R0c9ll3uZNotTbF5ps9OfTJVaauYWphb3nxtoMMe9hZOi3FxV0NcuCMHP67A eL27rihBZpvD+uqVt41pmp55ZSDGFTC9t051Iqf1pDlyobicbkOHuJhHO+UL/EjE HJ/nSJ0wOxVWJGv+MPp3u/4lqcflBI2PrNPfpqHH8Tp12gJPfGXz0xf7qlfJLZb3 Jvi+uumiknfvTxc0uq55tbs1lBEdUjQZg3SQD79jMtEO4XWwJlBv9kyERP57OY10 zN4O3gfRvzwh38S3Z0OPL1TiYydjb4h/koYQ49whfY0hRz/9yELVgquqoVXgkI7/ CXOxWR1AXKskMA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=content-type:date:from:message-id :mime-version:subject:to:x-me-proxy:x-me-proxy:x-me-sender :x-me-sender:x-sasl-enc; s=fm3; bh=/ApVXU8GXTipK7+MgVXMlg6I7MxWi msAyLfXuuM0nEs=; b=p63SuZZGxTZA0yLZ7x/ESn1fTmuPJsmTaBzRigwEAXbJm ScAdWrpM9+fjLZC5k6My2DiRSERkOI/ykGlioBxkN20gKYNQNQsrIQKADQPztlNl L71BMMzVY3bhkI/9fTe7sQGCjK2uhdOZU5gCDvJzb38qNwC/5TuCnjc9jsHvHn8t 5KuOJESVJ2VT5ckI6sZw2A+XPrIpy6GmjFTBWw9jBC8LMYZVyF4jNJlnvl1YTbiJ dryOfh2bi8WYHQhKN7+QpA5msZjC81ZSyeq3Q1ahYGrSmYmH41PrYzRDUXh2wr4y totSZGYi+MgHcvKDPS9fCZODDSNoENqgcfgeiwzFg== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvtddrudekvddgtdekucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucenucfjughrpefhvffufffkgggtsehttdertddttd dtnecuhfhrohhmpefmohhnrhgrugcujfhinhhsvghnuceokhhonhhrrggurdhhihhnshgv nhesfhgrshhtmhgrihhlrdhnvghtqeenucggtffrrghtthgvrhhnpefffeetuefhkeelud ehjeefkeelvefhkeeklefhgfeljeetgfefveeuleekgedvheenucffohhmrghinhepghhi thhhuhgsrdgtohhmnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilh hfrhhomhepkhhonhhrrggurdhhihhnshgvnhesfhgrshhtmhgrihhlrdhnvght X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA; Wed, 29 Sep 2021 04:50:47 -0400 (EDT) From: Konrad Hinsen To: guix-patches@gnu.org Subject: [PATCH] gnu: Add python-fitsio. Date: Wed, 29 Sep 2021 10:47:39 +0200 Message-ID: MIME-Version: 1.0 Content-Type: text/plain Received-SPF: pass client-ip=64.147.123.24; envelope-from=konrad.hinsen@fastmail.net; helo=wout1-smtp.messagingengine.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -0.3 (/) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.6 (--) * gnu/packages/astronomy.scm (python-fitsio): New variable. --- gnu/packages/astronomy.scm | 43 ++++++++++++++++++++++++++++++++++++++ 1 file changed, 43 insertions(+) diff --git a/gnu/packages/astronomy.scm b/gnu/packages/astronomy.scm index a3f7d5cbf4..4fba3aae99 100644 --- a/gnu/packages/astronomy.scm +++ b/gnu/packages/astronomy.scm @@ -96,6 +96,49 @@ in FITS files.") (license (license:non-copyleft "file://License.txt" "See License.txt in the distribution.")))) +(define-public python-fitsio + (package + (name "python-fitsio") + (version "1.1.5") + (source + (origin + (method url-fetch) + (uri (pypi-uri "fitsio" version)) + (sha256 + (base32 "1llql2i6xr9lkdl81jx5nvz80kspamvira90546y32ldy551hq1l")))) + (build-system python-build-system) + (arguments + `(#:phases + (modify-phases %standard-phases + (add-after 'unpack 'unbundle-cfitsio + (lambda* (#:key inputs #:allow-other-keys) + (let* ((cfitsio (assoc-ref inputs "cfitsio")) + (includedir (string-append "\"" cfitsio "/include\"")) + (libdir (string-append "\"" cfitsio "/lib\""))) + ;; Use Guix' cfitsio instead of the bundled one + (substitute* "setup.py" + (("self.use_system_fitsio = False") "pass") + (("self.system_fitsio_includedir = None") "pass") + (("self.system_fitsio_libdir = None") "pass") + (("self.use_system_fitsio") "True") + (("self.system_fitsio_includedir") includedir) + (("self.system_fitsio_libdir") libdir))) + ;; The bzip2 test fails because Guix' cfitsio + ;; is built without bzip2 support. + (substitute* "fitsio/test.py" + (("'SKIP_BZIP_TEST' in os.environ") "True")) + #t))))) + (propagated-inputs + `(("python-numpy" ,python-numpy) + ("cfitsio" ,cfitsio))) + (home-page "https://github.com/esheldon/fitsio") + (synopsis + "Python library to read from and write to FITS files") + (description + "A compact Python library for reading from and writing to FITS files, +based on the CFITSIO library.") + (license license:gpl2))) + (define-public qfits (package (name "qfits") -- 2.33.0 From debbugs-submit-bounces@debbugs.gnu.org Fri Oct 01 10:05:53 2021 Received: (at 50887) by debbugs.gnu.org; 1 Oct 2021 14:05:53 +0000 Received: from localhost ([127.0.0.1]:56791 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mWJAf-00055h-0X for submit@debbugs.gnu.org; Fri, 01 Oct 2021 10:05:53 -0400 Received: from h87-96-130-155.cust.a3fiber.se ([87.96.130.155]:50386 helo=mail.yoctocell.xyz) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mWJAd-00055O-5U for 50887@debbugs.gnu.org; Fri, 01 Oct 2021 10:05:51 -0400 From: Xinglu Chen DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=yoctocell.xyz; s=mail; t=1633097145; bh=8y82Dee5zwESpsWWC0dt1IhhkAb9W0YhooCYBULMTtI=; h=From:To:Subject:In-Reply-To:Date; b=QhiQ3m6bO4hUfPwYvUXsQDJxRnFvt1KsbhjRM5Fs+KJPk1XtMxwf96Isvw5+Rdbd5 B0eDEZ6OEo4uaaq3ZE6WK9g1So0fnRqM6dc/RvMkr9xTOvSJDsX2ntQrWxfucb/KvN gRJCdk+CwAyQPD4zN8Hk1aXjWptopi34QZ0iKBL8= To: Konrad Hinsen , 50887@debbugs.gnu.org Subject: Re: [bug#50887] [PATCH] gnu: Add python-fitsio. In-Reply-To: Date: Fri, 01 Oct 2021 16:05:44 +0200 Message-ID: <87r1d4lu13.fsf@yoctocell.xyz> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha256; protocol="application/pgp-signature" X-Spam-Score: 2.9 (++) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: On Wed, Sep 29 2021, Konrad Hinsen wrote: > * gnu/packages/astronomy.scm (python-fitsio): New variable. > --- > gnu/packages/astronomy.scm | 43 ++++++++++++++++++++++++++++++++++++++ > 1 file changed, 43 insertions(+) > > diff --git a/gnu/pac [...] Content analysis details: (2.9 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 SPF_PASS SPF: sender matches SPF record 2.0 PDS_OTHER_BAD_TLD Untrustworthy TLDs [URI: yoctocell.xyz (xyz)] 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record 0.5 FROM_SUSPICIOUS_NTLD From abused NTLD 0.4 RDNS_DYNAMIC Delivered to internal network by host with dynamic-looking rDNS 0.0 PDS_RDNS_DYNAMIC_FP RDNS_DYNAMIC with FP steps X-Debbugs-Envelope-To: 50887 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 2.9 (++) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: On Wed, Sep 29 2021, Konrad Hinsen wrote: > * gnu/packages/astronomy.scm (python-fitsio): New variable. > --- > gnu/packages/astronomy.scm | 43 ++++++++++++++++++++++++++++++++++++++ > 1 file changed, 43 insertions(+) > > diff --git a/gnu/pac [...] Content analysis details: (2.9 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 SPF_PASS SPF: sender matches SPF record 2.0 PDS_OTHER_BAD_TLD Untrustworthy TLDs [URI: yoctocell.xyz (xyz)] 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record 0.5 FROM_SUSPICIOUS_NTLD From abused NTLD 0.4 RDNS_DYNAMIC Delivered to internal network by host with dynamic-looking rDNS 1.0 BULK_RE_SUSP_NTLD Precedence bulk and RE: from a suspicious TLD -1.0 MAILING_LIST_MULTI Multiple indicators imply a widely-seen list manager 0.0 PDS_RDNS_DYNAMIC_FP RDNS_DYNAMIC with FP steps --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On Wed, Sep 29 2021, Konrad Hinsen wrote: > * gnu/packages/astronomy.scm (python-fitsio): New variable. > --- > gnu/packages/astronomy.scm | 43 ++++++++++++++++++++++++++++++++++++++ > 1 file changed, 43 insertions(+) > > diff --git a/gnu/packages/astronomy.scm b/gnu/packages/astronomy.scm > index a3f7d5cbf4..4fba3aae99 100644 > --- a/gnu/packages/astronomy.scm > +++ b/gnu/packages/astronomy.scm > @@ -96,6 +96,49 @@ in FITS files.") > (license (license:non-copyleft "file://License.txt" > "See License.txt in the distribution.")))) >=20=20 > +(define-public python-fitsio > + (package > + (name "python-fitsio") > + (version "1.1.5") > + (source > + (origin > + (method url-fetch) > + (uri (pypi-uri "fitsio" version)) > + (sha256 > + (base32 "1llql2i6xr9lkdl81jx5nvz80kspamvira90546y32ldy551hq1l"))= )) > + (build-system python-build-system) > + (arguments > + `(#:phases > + (modify-phases %standard-phases > + (add-after 'unpack 'unbundle-cfitsio > + (lambda* (#:key inputs #:allow-other-keys) > + (let* ((cfitsio (assoc-ref inputs "cfitsio")) > + (includedir (string-append "\"" cfitsio "/include\""= )) > + (libdir (string-append "\"" cfitsio "/lib\""))) > + ;; Use Guix' cfitsio instead of the bundled one > + (substitute* "setup.py" > + (("self.use_system_fitsio =3D False") "pass") > + (("self.system_fitsio_includedir =3D None") "pass") > + (("self.system_fitsio_libdir =3D None") "pass") > + (("self.use_system_fitsio") "True") > + (("self.system_fitsio_includedir") includedir) > + (("self.system_fitsio_libdir") libdir))) Maybe the bundled cfitsio should also be deleted in a =E2=80=98snippet=E2= =80=99 in the =E2=80=98origin=E2=80=99? > + ;; The bzip2 test fails because Guix' cfitsio > + ;; is built without bzip2 support. > + (substitute* "fitsio/test.py" > + (("'SKIP_BZIP_TEST' in os.environ") "True")) This part should probably be put in a separate phase, maybe you could call it =E2=80=98skip-bzip-test=E2=80=99. > + #t))))) Phases don=E2=80=99t need to return #t. > + (propagated-inputs > + `(("python-numpy" ,python-numpy) > + ("cfitsio" ,cfitsio))) > + (home-page "https://github.com/esheldon/fitsio") > + (synopsis > + "Python library to read from and write to FITS files") > + (description > + "A compact Python library for reading from and writing to FITS file= s, > +based on the CFITSIO library.") The sentence is lacking a subject; the meaning of =E2=80=9CFITS=E2=80=9D sh= ould be written (I had no idea what it meant). I suggest something like This package provides a Python library for reading from and writing to @acronym{FITS, Flexible Image Transport System} files using the CFITSIO library. Among other things, it can @itemize @item read and write image, binary, and ascii table extensions; @item read arbitrary subsets of tables in a lazy manner; @item query the rows and columns of a table; @item read and write header keywords; @item read and write Gzip files directory; @item read Zip and Bzip2 files. @end itemize > + (license license:gpl2))) =E2=80=98LICENSE.txt=E2=80=99 looks like gpl2+ Could you send an updated patch? --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQJJBAEBCAAzFiEEAVhh4yyK5+SEykIzrPUJmaL7XHkFAmFXFbgVHHB1YmxpY0B5 b2N0b2NlbGwueHl6AAoJEKz1CZmi+1x5FcwQAJ9m3sKsIAHjtkpccXgU1XBnF/8k uHLZJ//ggjVgYK8kZLuGUj+cYuoKLMgxNEl2b//UnKpulxzpNRzQ9RAFcqFms9sy ShywjgdF89hqEBSR+eqgEgX2gqceRvjInpFqdQ7KSxX5FRZJ+x1s4jO+KP6A/Pef loup0IAKW0iYAs/hBpj6uX0CrS0vJxkJCOIepVcZK2cfVbSSdrOiZfXO7tptfoq9 WItvA0VRxgT5SL9gVkhwz2/b4w1lOHo15mxHfAmlbB2uefcPHSwvIAFOztWxIyf0 7PTrvPe8hTCKMmYSlJwxpaFoLwrq8+YV7qWedif2CItLUJ5q1SRqcYcBPj0vTyz0 B/OjPl523O06nJkJ+PFUm2VYMGDM0ChlBj0y/i2f/GJIgXL/eKhhof4IK3PfEwxY ZOvK9ktgPcFLo7ebzVDzhjICQnGlHU28aAqo0KhtAAD2BjCiawqzOqm26SN+MbwY boa6uwUdsv4g9CWgRcdjhPqZgBkqaeh+8JN1mSo8BBHUEDpxj1OFbrGekPfi8k2b 8ePBj6p+IEkTpnJesqazmDxCZHFo97MEOdgc1J4shKwrMgtux/jF8jTtVREbjjTF TAIfbal97RBFt2hKaGP77EY/jGa/iJvVfFG3YigaxTIumDzVXWlQghXrTauc2wBt MWIvt8klIfAiv3v5 =y5x9 -----END PGP SIGNATURE----- --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Fri Oct 01 13:03:27 2021 Received: (at 50887) by debbugs.gnu.org; 1 Oct 2021 17:03:27 +0000 Received: from localhost ([127.0.0.1]:57249 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mWLwQ-0003kQ-HA for submit@debbugs.gnu.org; Fri, 01 Oct 2021 13:03:27 -0400 Received: from wout3-smtp.messagingengine.com ([64.147.123.19]:50103) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mWLwM-0003kB-H7 for 50887@debbugs.gnu.org; Fri, 01 Oct 2021 13:03:20 -0400 Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.west.internal (Postfix) with ESMTP id 674BD3202834; Fri, 1 Oct 2021 13:03:12 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Fri, 01 Oct 2021 13:03:12 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fastmail.net; h= from:to:subject:in-reply-to:references:date:message-id :mime-version:content-type; s=fm1; bh=YElrlFj0pLcnZmhk+d20YnG8zO MFcXgFhamG1AK8qco=; b=hPbignTWkhKkYiQ6Wg1qSCzD7VBddlC9HiovCPVre+ zBgcWzkHGuqqYikEqrTH7KmXw7Ie60Qwq9Vd7U7qnYJ/K+RaseF201T6TIuR8Sh7 yMjJCtwbLFb63rnPD3vNWl04p09KtcQ5sUXan/3DtcSVwVndNlZWTJEGOCr6Wie2 ZH8DdRG/lpPYt2XM4ltJftZQ+NGanWhuaZRtcAcxl+c+vH1MfpkuXjuCjHITVwTG rBSwG/YUQVPxVXlv09h22pMTJ+D6trTuPWLqrdgGUNBjExO8tCchvyP4XJYWCt4F IhZy0nKFQNHgybh59XnQswHUcYL2SIjO52O7ngHAMpyA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm3; bh=YElrlF j0pLcnZmhk+d20YnG8zOMFcXgFhamG1AK8qco=; b=hVi7rRABNcZTafDKM2KY3Y 581bAVbCCmFz4yUO25Vt54/uL6WxEsi0KykkhpOxM0meEmd03uEalu+Pi0aBRBTZ sZAHUtxgu++EKGDgvGWAfUVromJM4A1Ex8Q9fz6FxwrI64Y6/lWFTUNXhx/oZd/a GFlclPahI7RvXbbnCSEUQPU38OOE40kCCWQ3ZKlEgm7TQtm4FJczLcPNn936txSZ 3kFAKqKzCVE5UQZ5aLMg8axdLqqmIj4oXgzo0YD61d4gi0oPo+Kuwj2n5ajB74nM xHkfhAd8eWUIRc/Gv2Tz9tJ7EXPgcmOQv635YMONOzC6dXYHGnEvt6bXoERlHJ7Q == X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvtddrudekiedguddtfecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecufghrlhcuvffnffculdefhedmnecujfgurhephf fvufgjfhffkfggtgesmhdtreertddttdenucfhrhhomhepmfhonhhrrgguucfjihhnshgv nhcuoehkohhnrhgrugdrhhhinhhsvghnsehfrghsthhmrghilhdrnhgvtheqnecuggftrf grthhtvghrnhephedvgedvjedvtdeuueduueegvdeuhfefueeffeetvedtvdelveekveeg gefggfeinecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomh epkhhonhhrrggurdhhihhnshgvnhesfhgrshhtmhgrihhlrdhnvght X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA; Fri, 1 Oct 2021 13:03:11 -0400 (EDT) From: Konrad Hinsen To: Xinglu Chen , 50887@debbugs.gnu.org Subject: Re: [bug#50887] [PATCH] gnu: Add python-fitsio. In-Reply-To: <87r1d4lu13.fsf@yoctocell.xyz> References: <87r1d4lu13.fsf@yoctocell.xyz> Date: Fri, 01 Oct 2021 19:03:10 +0200 Message-ID: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Spam-Score: 1.3 (+) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: Xinglu Chen writes: > Could you send an updated patch? Here it comes. Thanks for the careful code review! I learned a few things from this: I didn't know about snippets, nor about the subtle differences between gpl2 and gpl2+. Content analysis details: (1.3 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 SPF_PASS SPF: sender matches SPF record 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (konrad.hinsen[at]fastmail.net) 2.0 PDS_OTHER_BAD_TLD Untrustworthy TLDs [URI: yoctocell.xyz (xyz)] -0.0 SPF_HELO_PASS SPF: HELO matches SPF record -0.7 RCVD_IN_DNSWL_LOW RBL: Sender listed at https://www.dnswl.org/, low trust [64.147.123.19 listed in list.dnswl.org] -0.0 RCVD_IN_MSPIKE_H2 RBL: Average reputation (+2) [64.147.123.19 listed in wl.mailspike.net] X-Debbugs-Envelope-To: 50887 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 1.0 (+) --=-=-= Content-Type: text/plain Xinglu Chen writes: > Could you send an updated patch? Here it comes. Thanks for the careful code review! I learned a few things from this: I didn't know about snippets, nor about the subtle differences between gpl2 and gpl2+. Thanks, Konrad. --=-=-= Content-Type: text/x-diff Content-Disposition: inline; filename=0001-gnu-Add-python-fitsio.patch >From c95c0b18b4c2da6af7432a3dcf11c5f9984772f8 Mon Sep 17 00:00:00 2001 From: Konrad Hinsen Date: Wed, 29 Sep 2021 10:47:39 +0200 Subject: [PATCH] gnu: Add python-fitsio. * gnu/packages/astronomy.scm (python-fitsio): New variable. --- gnu/packages/astronomy.scm | 65 ++++++++++++++++++++++++++++++++++++++ 1 file changed, 65 insertions(+) diff --git a/gnu/packages/astronomy.scm b/gnu/packages/astronomy.scm index a3f7d5cbf4..287cf4a94c 100644 --- a/gnu/packages/astronomy.scm +++ b/gnu/packages/astronomy.scm @@ -96,6 +96,71 @@ in FITS files.") (license (license:non-copyleft "file://License.txt" "See License.txt in the distribution.")))) +(define-public python-fitsio + (package + (name "python-fitsio") + (version "1.1.5") + (source + (origin + (method url-fetch) + (uri (pypi-uri "fitsio" version)) + (sha256 + (base32 "1llql2i6xr9lkdl81jx5nvz80kspamvira90546y32ldy551hq1l")) + (modules '((guix build utils))) + (snippet + ;; Remove the bundled cfitsio + `(begin + (delete-file-recursively "cfitsio3490") + (substitute* "MANIFEST.in" + (("recursive-include cfitsio3490.*$\n") "")) + #t)))) + (build-system python-build-system) + (arguments + `(#:phases + (modify-phases %standard-phases + (add-after 'unpack 'unbundle-cfitsio + (lambda* (#:key inputs #:allow-other-keys) + (let* ((cfitsio (assoc-ref inputs "cfitsio")) + (includedir (string-append "\"" cfitsio "/include\"")) + (libdir (string-append "\"" cfitsio "/lib\""))) + ;; Use Guix' cfitsio instead of the bundled one + (substitute* "setup.py" + (("self.use_system_fitsio = False") "pass") + (("self.system_fitsio_includedir = None") "pass") + (("self.system_fitsio_libdir = None") "pass") + (("self.use_system_fitsio") "True") + (("self.system_fitsio_includedir") includedir) + (("self.system_fitsio_libdir") libdir))))) + (add-after 'unpack 'skip-bzip2-test + (lambda* (#:key inputs #:allow-other-keys) + ;; The bzip2 test fails because Guix' cfitsio + ;; is built without bzip2 support. + (substitute* "fitsio/test.py" + (("'SKIP_BZIP_TEST' in os.environ") "True"))))))) + (propagated-inputs + `(("python-numpy" ,python-numpy) + ("cfitsio" ,cfitsio))) + (home-page "https://github.com/esheldon/fitsio") + (synopsis + "Python library to read from and write to FITS files") + (description + "This package provides a Python library for reading from and writing +to @acronym{FITS, Flexible Image Transport System} files using the +CFITSIO library. Among other things, it can + +@itemize +@item read and write image, binary, and ascii table extensions; + +@item read arbitrary subsets of tables in a lazy manner; + +@item query the rows and columns of a table; + +@item read and write header keywords; + +@item read and write Gzip files. +@end itemize") + (license license:gpl2+))) + (define-public qfits (package (name "qfits") -- 2.33.0 --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Mon Oct 04 10:10:41 2021 Received: (at 50887-done) by debbugs.gnu.org; 4 Oct 2021 14:10:41 +0000 Received: from localhost ([127.0.0.1]:37991 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mXOfx-00053b-MC for submit@debbugs.gnu.org; Mon, 04 Oct 2021 10:10:41 -0400 Received: from eggs.gnu.org ([209.51.188.92]:39978) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mXOfv-00053G-FV for 50887-done@debbugs.gnu.org; Mon, 04 Oct 2021 10:10:39 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:55250) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mXOfq-0000ov-2J; Mon, 04 Oct 2021 10:10:34 -0400 Received: from [2001:660:6102:320:e120:2c8f:8909:cdfe] (port=60562 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mXOfP-0000yM-By; Mon, 04 Oct 2021 10:10:25 -0400 From: =?utf-8?Q?Ludovic_Court=C3=A8s?= To: Konrad Hinsen Subject: Re: bug#50887: [PATCH] gnu: Add python-fitsio. References: <87r1d4lu13.fsf@yoctocell.xyz> Date: Mon, 04 Oct 2021 16:10:05 +0200 In-Reply-To: (Konrad Hinsen's message of "Fri, 01 Oct 2021 19:03:10 +0200") Message-ID: <87v92cop8i.fsf_-_@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 50887-done Cc: Xinglu Chen , 50887-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Hi Konrad, Konrad Hinsen skribis: >>>From c95c0b18b4c2da6af7432a3dcf11c5f9984772f8 Mon Sep 17 00:00:00 2001 > From: Konrad Hinsen > Date: Wed, 29 Sep 2021 10:47:39 +0200 > Subject: [PATCH] gnu: Add python-fitsio. > > * gnu/packages/astronomy.scm (python-fitsio): New variable. Applied. Thank you & thanks Xinglu for reviewing! Ludo=E2=80=99. From unknown Sun Aug 17 01:00:22 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Tue, 02 Nov 2021 11:24:09 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator