GNU bug report logs - #50885
[PATCH] import: go: Recognize major version suffixes.

Previous Next

Full log

Message #10 received at 50885-done <at> debbugs.gnu.org (full text, mbox):

From: Ludovic Courtès <ludo <at> gnu.org>
To: Sarah Morgensen <iskarian <at> mgsn.dev>
Cc: 50885-done <at> debbugs.gnu.org
Subject: Re: bug#50885: [PATCH] import: go: Recognize major version suffixes.
Date: Mon, 04 Oct 2021 16:08:29 +0200

Sarah Morgensen <iskarian <at> mgsn.dev> skribis:

> Do not treat major version suffixes (such as "/v3") as repository
> subdirectories.  See <https://golang.org/ref/mod#major-version-suffixes>.
>
> * guix/import/go.scm (go-module->guix-package): When determining the
> unpack path, compare 'root-module-path' to 'module-path-sans-suffix'
> instead of 'module-path'.

Applied as well, but I feel that it may be useful to have tests for
these fine points that where regressions would otherwise be hard to
notice.

Thanks,
Ludo’.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.