GNU bug report logs - #50884
[PATCH] import: go: Handle extra whitespace in "go-import" meta tags.

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Ludovic Courtès <ludo <at> gnu.org>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#50884: closed ([PATCH] import: go: Handle extra whitespace in
 "go-import" meta tags.)
Date: Mon, 04 Oct 2021 14:08:02 +0000

[Message part 1 (text/plain, inline)]

Your message dated Mon, 04 Oct 2021 16:07:21 +0200
with message-id <874k9wq3xi.fsf <at> gnu.org>
and subject line Re: bug#50884: [PATCH] import: go: Handle extra whitespace in "go-import" meta tags.
has caused the debbugs.gnu.org bug report #50884,
regarding [PATCH] import: go: Handle extra whitespace in "go-import" meta tags.
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
50884: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=50884
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Sarah Morgensen <iskarian <at> mgsn.dev>
To: guix-patches <at> gnu.org
Subject: [PATCH] import: go: Handle extra whitespace in "go-import" meta tags.
Date: Tue, 28 Sep 2021 19:49:58 -0700

Some packages sites use extra whitespace in the content portion of <meta
name="go-import" ...> tags, so handle that.  Example:
<https://k8s.io/api?go-get=1>

* guix/import/go.scm (fetch-module-meta-data)[go-import->module-meta]:
Use 'string-tokenize' instead of 'string-split'.
---
 guix/import/go.scm | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/guix/import/go.scm b/guix/import/go.scm
index 9769b557ae..ca909ab35a 100644
--- a/guix/import/go.scm
+++ b/guix/import/go.scm
@@ -474,7 +474,7 @@ Optionally include a VERSION string to append to the name."
 because goproxy servers don't currently provide all the information needed to
 build a package."
   (define (go-import->module-meta content-text)
-    (match (string-split content-text #\space)
+    (match (string-tokenize content-text char-set:graphic)
       ((root-path vcs repo-url)
        (make-module-meta root-path (string->symbol vcs)
                          (strip-.git-suffix/maybe repo-url)))))

base-commit: c582be4c38596a6a31a39c6799723dcd8b6eb909
-- 
2.33.0

[Message part 3 (message/rfc822, inline)]

From: Ludovic Courtès <ludo <at> gnu.org>
To: Sarah Morgensen <iskarian <at> mgsn.dev>
Cc: 50884-done <at> debbugs.gnu.org
Subject: Re: bug#50884: [PATCH] import: go: Handle extra whitespace in
 "go-import" meta tags.
Date: Mon, 04 Oct 2021 16:07:21 +0200

Sarah Morgensen <iskarian <at> mgsn.dev> skribis:

> Some packages sites use extra whitespace in the content portion of <meta
> name="go-import" ...> tags, so handle that.  Example:
> <https://k8s.io/api?go-get=1>
>
> * guix/import/go.scm (fetch-module-meta-data)[go-import->module-meta]:
> Use 'string-tokenize' instead of 'string-split'.

Applied, thanks!  Would it make sense to have a regression test?

Ludo’.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.