Subject: bug#50884: closed (Re: bug#50884: [PATCH] import: go: Handle extra whitespace in "go-import" meta tags.)

From: [email-masked] (GNU bug Tracking System)
Date: Mon, 04 Oct 2021 14:08:02 +0000

Your bug report

#50884: [PATCH] import: go: Handle extra whitespace in "go-import" meta tags.

which was filed against the guix-patches package, has been closed.

The explanation is attached below, along with your original report.
If you require more details, please reply to [email-masked].

-- 
50884: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=50884
GNU Bug Tracking System
Contact [email-masked] with problems

Subject: Re: bug#50884: [PATCH] import: go: Handle extra whitespace in "go-import" meta tags.
From: Ludovic Courtès <[email-masked]>
To: Sarah Morgensen <[email-masked]>
Cc: [email-masked]
Date: Mon, 04 Oct 2021 16:07:21 +0200
List-Id: <debbugs-submit.debbugs.gnu.org>

Sarah Morgensen <[email-masked]> skribis:

> Some packages sites use extra whitespace in the content portion of <meta
> name="go-import" ...> tags, so handle that.  Example:
> <https://k8s.io/api?go-get=1>
>
> * guix/import/go.scm (fetch-module-meta-data)[go-import->module-meta]:
> Use 'string-tokenize' instead of 'string-split'.

Applied, thanks!  Would it make sense to have a regression test?

Ludo’.

Subject: [PATCH] import: go: Handle extra whitespace in "go-import" meta tags.
From: Sarah Morgensen <[email-masked]>
To: [email-masked]
Date: Tue, 28 Sep 2021 19:49:58 -0700
List-Id: <debbugs-submit.debbugs.gnu.org>

Some packages sites use extra whitespace in the content portion of <meta
name="go-import" ...> tags, so handle that.  Example:
<https://k8s.io/api?go-get=1>

* guix/import/go.scm (fetch-module-meta-data)[go-import->module-meta]:
Use 'string-tokenize' instead of 'string-split'.
---
 guix/import/go.scm | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/guix/import/go.scm b/guix/import/go.scm
index 9769b557ae..ca909ab35a 100644
--- a/guix/import/go.scm
+++ b/guix/import/go.scm
@@ -474,7 +474,7 @@ Optionally include a VERSION string to append to the name."
 because goproxy servers don't currently provide all the information needed to
 build a package."
   (define (go-import->module-meta content-text)
-    (match (string-split content-text #\space)
+    (match (string-tokenize content-text char-set:graphic)
       ((root-path vcs repo-url)
        (make-module-meta root-path (string->symbol vcs)
                          (strip-.git-suffix/maybe repo-url)))))

base-commit: c582be4c38596a6a31a39c6799723dcd8b6eb909
-- 
2.33.0