From unknown Fri Aug 15 20:56:12 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#50884] [PATCH] import: go: Handle extra whitespace in "go-import" meta tags. Resent-From: Sarah Morgensen Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Wed, 29 Sep 2021 02:51:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 50884 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 50884@debbugs.gnu.org X-Debbugs-Original-To: guix-patches@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.16328838101063 (code B ref -1); Wed, 29 Sep 2021 02:51:02 +0000 Received: (at submit) by debbugs.gnu.org; 29 Sep 2021 02:50:10 +0000 Received: from localhost ([127.0.0.1]:47408 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mVPfd-0000H5-Uz for submit@debbugs.gnu.org; Tue, 28 Sep 2021 22:50:10 -0400 Received: from lists.gnu.org ([209.51.188.17]:47404) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mVPfc-0000Gy-SX for submit@debbugs.gnu.org; Tue, 28 Sep 2021 22:50:09 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:59436) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mVPfc-0004DK-GW for guix-patches@gnu.org; Tue, 28 Sep 2021 22:50:08 -0400 Received: from out1.migadu.com ([2001:41d0:2:863f::]:61068) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mVPfZ-0006u0-2H for guix-patches@gnu.org; Tue, 28 Sep 2021 22:50:08 -0400 X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mgsn.dev; s=key1; t=1632883800; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=qN80aSUN4S99rCh39H1P3SNUaiGOx0cU2B8iRxYdeBY=; b=ax8YCDaIILpAQ9U2qsxYYUGRcTnC1SbB/65O2NK0T4DZJXPEzGK+61ZPBxse3BifWXQj7Y 8Gy1cCFS75KjqzdPD5PNkBIoCj9mrMz/5hG/fJHvwjdhEoft49SjMgfDe3T9+7klgbGh3F WjUJj18z5PpxRl01f5LUP7efl+JCqj8= From: Sarah Morgensen Date: Tue, 28 Sep 2021 19:49:58 -0700 Message-Id: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Migadu-Flow: FLOW_OUT X-Migadu-Auth-User: iskarian@mgsn.dev Received-SPF: pass client-ip=2001:41d0:2:863f::; envelope-from=iskarian@mgsn.dev; helo=out1.migadu.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.4 (-) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.4 (--) Some packages sites use extra whitespace in the content portion of tags, so handle that. Example: * guix/import/go.scm (fetch-module-meta-data)[go-import->module-meta]: Use 'string-tokenize' instead of 'string-split'. --- guix/import/go.scm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/guix/import/go.scm b/guix/import/go.scm index 9769b557ae..ca909ab35a 100644 --- a/guix/import/go.scm +++ b/guix/import/go.scm @@ -474,7 +474,7 @@ Optionally include a VERSION string to append to the name." because goproxy servers don't currently provide all the information needed to build a package." (define (go-import->module-meta content-text) - (match (string-split content-text #\space) + (match (string-tokenize content-text char-set:graphic) ((root-path vcs repo-url) (make-module-meta root-path (string->symbol vcs) (strip-.git-suffix/maybe repo-url))))) base-commit: c582be4c38596a6a31a39c6799723dcd8b6eb909 -- 2.33.0 From unknown Fri Aug 15 20:56:12 2025 MIME-Version: 1.0 X-Mailer: MIME-tools 5.505 (Entity 5.505) X-Loop: help-debbugs@gnu.org From: help-debbugs@gnu.org (GNU bug Tracking System) To: Sarah Morgensen Subject: bug#50884: closed (Re: bug#50884: [PATCH] import: go: Handle extra whitespace in "go-import" meta tags.) Message-ID: References: <874k9wq3xi.fsf@gnu.org> X-Gnu-PR-Message: they-closed 50884 X-Gnu-PR-Package: guix-patches X-Gnu-PR-Keywords: patch Reply-To: 50884@debbugs.gnu.org Date: Mon, 04 Oct 2021 14:08:02 +0000 Content-Type: multipart/mixed; boundary="----------=_1633356482-19061-1" This is a multi-part message in MIME format... ------------=_1633356482-19061-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Your bug report #50884: [PATCH] import: go: Handle extra whitespace in "go-import" meta tag= s. which was filed against the guix-patches package, has been closed. The explanation is attached below, along with your original report. If you require more details, please reply to 50884@debbugs.gnu.org. --=20 50884: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D50884 GNU Bug Tracking System Contact help-debbugs@gnu.org with problems ------------=_1633356482-19061-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at 50884-done) by debbugs.gnu.org; 4 Oct 2021 14:07:32 +0000 Received: from localhost ([127.0.0.1]:37975 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mXOct-0004wD-Nx for submit@debbugs.gnu.org; Mon, 04 Oct 2021 10:07:31 -0400 Received: from eggs.gnu.org ([209.51.188.92]:39080) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mXOcs-0004vy-GU for 50884-done@debbugs.gnu.org; Mon, 04 Oct 2021 10:07:31 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:55104) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mXOcm-0006eL-N2; Mon, 04 Oct 2021 10:07:24 -0400 Received: from [2001:660:6102:320:e120:2c8f:8909:cdfe] (port=60556 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mXOcl-0002Cp-Af; Mon, 04 Oct 2021 10:07:23 -0400 From: =?utf-8?Q?Ludovic_Court=C3=A8s?= To: Sarah Morgensen Subject: Re: bug#50884: [PATCH] import: go: Handle extra whitespace in "go-import" meta tags. References: Date: Mon, 04 Oct 2021 16:07:21 +0200 In-Reply-To: (Sarah Morgensen's message of "Tue, 28 Sep 2021 19:49:58 -0700") Message-ID: <874k9wq3xi.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 50884-done Cc: 50884-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Sarah Morgensen skribis: > Some packages sites use extra whitespace in the content portion of name=3D"go-import" ...> tags, so handle that. Example: > > > * guix/import/go.scm (fetch-module-meta-data)[go-import->module-meta]: > Use 'string-tokenize' instead of 'string-split'. Applied, thanks! Would it make sense to have a regression test? Ludo=E2=80=99. ------------=_1633356482-19061-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at submit) by debbugs.gnu.org; 29 Sep 2021 02:50:10 +0000 Received: from localhost ([127.0.0.1]:47408 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mVPfd-0000H5-Uz for submit@debbugs.gnu.org; Tue, 28 Sep 2021 22:50:10 -0400 Received: from lists.gnu.org ([209.51.188.17]:47404) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mVPfc-0000Gy-SX for submit@debbugs.gnu.org; Tue, 28 Sep 2021 22:50:09 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:59436) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mVPfc-0004DK-GW for guix-patches@gnu.org; Tue, 28 Sep 2021 22:50:08 -0400 Received: from out1.migadu.com ([2001:41d0:2:863f::]:61068) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mVPfZ-0006u0-2H for guix-patches@gnu.org; Tue, 28 Sep 2021 22:50:08 -0400 X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mgsn.dev; s=key1; t=1632883800; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=qN80aSUN4S99rCh39H1P3SNUaiGOx0cU2B8iRxYdeBY=; b=ax8YCDaIILpAQ9U2qsxYYUGRcTnC1SbB/65O2NK0T4DZJXPEzGK+61ZPBxse3BifWXQj7Y 8Gy1cCFS75KjqzdPD5PNkBIoCj9mrMz/5hG/fJHvwjdhEoft49SjMgfDe3T9+7klgbGh3F WjUJj18z5PpxRl01f5LUP7efl+JCqj8= From: Sarah Morgensen To: guix-patches@gnu.org Subject: [PATCH] import: go: Handle extra whitespace in "go-import" meta tags. Date: Tue, 28 Sep 2021 19:49:58 -0700 Message-Id: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Migadu-Flow: FLOW_OUT X-Migadu-Auth-User: iskarian@mgsn.dev Received-SPF: pass client-ip=2001:41d0:2:863f::; envelope-from=iskarian@mgsn.dev; helo=out1.migadu.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.4 (-) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.4 (--) Some packages sites use extra whitespace in the content portion of tags, so handle that. Example: * guix/import/go.scm (fetch-module-meta-data)[go-import->module-meta]: Use 'string-tokenize' instead of 'string-split'. --- guix/import/go.scm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/guix/import/go.scm b/guix/import/go.scm index 9769b557ae..ca909ab35a 100644 --- a/guix/import/go.scm +++ b/guix/import/go.scm @@ -474,7 +474,7 @@ Optionally include a VERSION string to append to the name." because goproxy servers don't currently provide all the information needed to build a package." (define (go-import->module-meta content-text) - (match (string-split content-text #\space) + (match (string-tokenize content-text char-set:graphic) ((root-path vcs repo-url) (make-module-meta root-path (string->symbol vcs) (strip-.git-suffix/maybe repo-url))))) base-commit: c582be4c38596a6a31a39c6799723dcd8b6eb909 -- 2.33.0 ------------=_1633356482-19061-1--