Subject: Re: bug#50880: Add "Contributing to Emacs" help command (see C-h C-h)

From: Stefan Kangas <[email-masked]>
Date: Wed, 29 Sep 2021 18:10:38 -0700

tags 50880 + patch
thanks

Stefan Kangas <[email-masked]> writes:

> We could pick any key, like "b" for "contriButing".  Or, you know, "h"
> for "Happens to be free".  ;-)

So how about the attached?  I put it on `C-h C-x' because I figured that
we might want to use "b" for "bugs" in the future perhaps, and "u" just
wasn't that nice.  Most of the other ones are taken except for "i", "q",
"r", "y" and "z".
From f05c916f2c37cbdf419d214f6d6b8bd11c9ffbcd Mon Sep 17 00:00:00 2001
From: Stefan Kangas <[email-masked]>
Date: Thu, 30 Sep 2021 02:52:58 +0200
Subject: [PATCH] New help function view-emacs-contributing

* lisp/help.el (view-emacs-contributing): New function.
(help-for-help): Display new function.
(help-map): Bind it to "C-h C-x".  (Bug#50880)
* lisp/startup.el (fancy-about-text, normal-about-screen): Use
above new function.
---
 lisp/help.el    | 7 +++++++
 lisp/startup.el | 4 ++--
 2 files changed, 9 insertions(+), 2 deletions(-)

diff --git a/lisp/help.el b/lisp/help.el
index 02e9b9e8e4..3d15ce2530 100644
--- a/lisp/help.el
+++ b/lisp/help.el
@@ -70,6 +70,7 @@ help-map
     (define-key map "\C-s" 'search-forward-help-for-help)
     (define-key map "\C-t" 'view-emacs-todo)
     (define-key map "\C-w" 'describe-no-warranty)
+    (define-key map "\C-x" 'view-emacs-contributing)
 
     ;; This does not fit the pattern, but it is natural given the C-\ command.
     (define-key map "\C-\\" 'describe-input-method)
@@ -292,6 +293,7 @@ 'help
        ("describe-distribution"
         "Emacs ordering and distribution information")
        ("C-m" "Order printed manuals")
+       ("view-emacs-contributing" "Contributing to Emacs")
        ("view-emacs-todo" "Emacs TODO")
        ("describe-no-warranty"
         "Information on absence of warranty"))
@@ -504,6 +506,11 @@ view-emacs-problems
   (interactive)
   (view-help-file "PROBLEMS"))
 
+(defun view-emacs-contributing ()
+  "Display info on how to contribute to Emacs."
+  (interactive)
+  (info "(emacs) Contributing"))
+
 (defun view-emacs-debugging ()
   "Display info on how to debug Emacs problems."
   (interactive)
diff --git a/lisp/startup.el b/lisp/startup.el
index 505d7b83f4..af22908b35 100644
--- a/lisp/startup.el
+++ b/lisp/startup.el
@@ -1649,7 +1649,7 @@ fancy-about-text
 	      (goto-char (point-min))))
      "\tMany people have contributed code included in GNU Emacs\n"
      :link ("Contributing"
-	    ,(lambda (_button) (info "(emacs)Contributing")))
+            ,(lambda (_button) (view-emacs-contributing)))
      "\tHow to report bugs and contribute improvements to Emacs\n"
      "\n"
      :link ("GNU and Freedom" ,(lambda (_button) (describe-gnu-project)))
@@ -2237,7 +2237,7 @@ normal-about-screen
 
   (insert-button "Contributing"
 		 'action
-		 (lambda (_button) (info "(emacs)Contributing"))
+                 (lambda (_button) (view-emacs-contributing))
 		 'follow-link t)
   (insert "\tHow to report bugs and contribute improvements to Emacs\n\n")
 
-- 
2.30.2