GNU bug report logs - #50873
[PATCH 0/5] Fixes to ‘guix home import’

Previous Next

Full log

View this message in rfc822 format

From: Ludovic Courtès <ludo <at> gnu.org>
To: Xinglu Chen <public <at> yoctocell.xyz>
Cc: Oleg Pykhalov <go.wigust <at> gmail.com>, 50873 <at> debbugs.gnu.org, Andrew Tropin <andrew <at> trop.in>
Subject: [bug#50873] [PATCH 0/5] Fixes to ‘guix home import’
Date: Sun, 31 Oct 2021 01:01:30 +0200

Hi!

Xinglu Chen <public <at> yoctocell.xyz> skribis:

>   guix home: import: Make the user to specify a destination directory.
>   guix home: import: Allow multiple modules to be imported for each
>     service.
>   guix home: import: Fix module name for Bash service.
>   guix home: import: Don’t use 'slurp-file-gexp'.
>   guix home: import: Delete duplicate modules when importing.
>   doc: Document the ‘guix home import’ subcommand.
>   Add tests for ‘guix home import’.
>   guix home: import: Call ‘local-file’ with ‘name’ argument.

That’s a nice improvement.  In the interest of moving forward, I applied
the whole series and followed up with a few changes:

  c4ac8cf4f6 doc: Mention 'guix home reconfigure' upfront.
  971a69d8e3 doc: Avoid misuse of @ref.
  7711a6c3f4 doc: Mention "guix home import" upfront.
  6f4ca78761 home: import: Avoid duplication of 'manifest->code'.
  96728c54df home: import: Factorize triplicated 'version-spec' procedure.
  f3933ae40d home: import: Clarify "destination directory".
  341fba217f home: import: Compare procedures with 'eq?'.

Part of it is about removing duplicated code, in particular
‘manifest->code’.  It’s important to factorize non-trivial code like
this.

The last commits improve documentation so users learn about ‘guix home
import’ when they get started.

It’s really nice to have this tool!  I find it perhaps a bit confusing
to have to specify a target directory to ‘guix home import’; simply
trying to document it shows that it’s non-obvious.

I wonder if the argument should be optional (in which case the files
wouldn’t be copied).  But then people are likely to run into the
problems this addresses.

Or perhaps it would be more consistent to have:

  guix home import ~/foo

create ~/foo/config.scm, instead of printing it to stdout?

The documentation would be clearer: “populate ~/foo with all the
configuration files of your home environment.”  Thoughts?

Ludo’.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.