GNU bug report logs - #50854
[PATCH 0/2] Make the PyPI importer honor the ‘upstream-name’ package property

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Xinglu Chen <public <at> yoctocell.xyz>
Subject: bug#50854: closed (Re: bug#50854: [PATCH 0/2] Make the PyPI
 importer honor the ‘upstream-name’ package
 property)
Date: Thu, 30 Sep 2021 21:25:02 +0000

[Message part 1 (text/plain, inline)]

Your bug report

#50854: [PATCH 0/2] Make the PyPI importer honor the ‘upstream-name’ package property

which was filed against the guix-patches package, has been closed.

The explanation is attached below, along with your original report.
If you require more details, please reply to 50854 <at> debbugs.gnu.org.

-- 
50854: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=50854
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Ludovic Courtès <ludo <at> gnu.org>
To: Xinglu Chen <public <at> yoctocell.xyz>
Cc: 50854-done <at> debbugs.gnu.org
Subject: Re: bug#50854: [PATCH 0/2] Make the PyPI importer honor the
 ‘upstream-name’ package property
Date: Thu, 30 Sep 2021 23:24:12 +0200

Xinglu Chen <public <at> yoctocell.xyz> skribis:

> If a PyPI package contains a “-” followed by one or more digits, e.g.,
> “AV-98”, the PyPI importer/updater will think that the digits after the
> “-” is the version of the package, and instead of trying to update
> “AV-98” it will try to update “AV”.
>
> $ ./pre-inst-env guix refresh av-98
> following redirection to `https://pypi.org/pypi/av/json'...
> /home/yoctocell/src/guix/gnu/packages/web-browsers.scm:914:13: av-98 would be upgraded from 1.0.1 to 8.0.3
>
> The first patch makes the PyPI importer honor the ‘upstream-name’
> property; it will also generate a package with an ‘upstream-name’
> property if the package name contains a “-” followed by one or more
> digits.
>
> The second patch sets the ‘upstream-name’ property for the ‘av-98’
> package.

Nice.

> Xinglu Chen (2):
>   import: pypi: Honor the 'upstream-name' package property.
>   gnu: av-98: Set 'upstream-name' property.

Applied, thanks!

Ludo'.

[Message part 3 (message/rfc822, inline)]

From: Xinglu Chen <public <at> yoctocell.xyz>
To: guix-patches <at> gnu.org
Subject: [PATCH 0/2] Make the PyPI importer honor the ‘upstream-name’ package property
Date: Mon, 27 Sep 2021 22:09:21 +0200

[Message part 4 (text/plain, inline)]

If a PyPI package contains a “-” followed by one or more digits, e.g.,
“AV-98”, the PyPI importer/updater will think that the digits after the
“-” is the version of the package, and instead of trying to update
“AV-98” it will try to update “AV”.

--8<---------------cut here---------------start------------->8---
$ ./pre-inst-env guix refresh av-98
following redirection to `https://pypi.org/pypi/av/json'...
/home/yoctocell/src/guix/gnu/packages/web-browsers.scm:914:13: av-98 would be upgraded from 1.0.1 to 8.0.3
--8<---------------cut here---------------end--------------->8---

The first patch makes the PyPI importer honor the ‘upstream-name’
property; it will also generate a package with an ‘upstream-name’
property if the package name contains a “-” followed by one or more
digits.

The second patch sets the ‘upstream-name’ property for the ‘av-98’
package.

Xinglu Chen (2):
  import: pypi: Honor the 'upstream-name' package property.
  gnu: av-98: Set 'upstream-name' property.

 gnu/packages/web-browsers.scm |   2 +
 guix/import/pypi.scm          |  20 +++++--
 tests/pypi.scm                | 106 +++++++++++++++++++++++++++++++---
 3 files changed, 115 insertions(+), 13 deletions(-)


base-commit: 6ae4644984608b7eff7ab54d3a5787c661d85b2e
-- 
2.33.0

[signature.asc (application/pgp-signature, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.