GNU bug report logs - #50852
[PATCH] Fix search of the look program.

Previous Next

Full log

View this message in rfc822 format

From: Stefan Kangas <stefan <at> marxist.se>
To: André A. Gomes <andremegafone <at> gmail.com>
Cc: Eli Zaretskii <eliz <at> gnu.org>, 50852 <at> debbugs.gnu.org, Lars Ingebrigtsen <larsi <at> gnus.org>
Subject: bug#50852: [PATCH] Fix search of the look program.
Date: Sat, 30 Oct 2021 09:09:34 -0700

André A. Gomes <andremegafone <at> gmail.com> writes:

> Eli Zaretskii <eliz <at> gnu.org> writes:
>
>>> From: Lars Ingebrigtsen <larsi <at> gnus.org>
>>> Cc: Stefan Kangas <stefan <at> marxist.se>,  andremegafone <at> gmail.com,
>>>   50852 <at> debbugs.gnu.org
>>> Date: Tue, 28 Sep 2021 08:11:18 +0200
>>>
>>> Eli Zaretskii <eliz <at> gnu.org> writes:
>>>
>>> > In this case, why not simply have the value as "look" with no leading
>>> > directories?  If the program is installed, it will be found when it's
>>> > invoked, and if it isn't installed, the user gets an error message at
>>> > that time.
>>>
>>> That's a good point.  And the ispell-look-p variable is itself rather
>>> odd -- why have both ispell-look-command and that variable (with a
>>> non-standard name)?
>>
>> Right.  The existence of "look" should IMO be tested as part of
>> ispell-lookup-words, not when the package loads.  Then the command
>> could decide whether to use "look" or Grep at that time, and the need
>> for the ispell-look-p variable would disappear.
>
> You're both right.  I was actually silly.  I can prepare a patch
> following these ideas.

It seems like we are still waiting for this patch.  So here's a friendly
reminder to take a look at this when you find some time.  :-)

Thanks in advance.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.