GNU bug report logs - #50834
Feature request: cl-remove-method (prototyped) and buttons for it

Previous Next

Full log

View this message in rfc822 format

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: Stefan Monnier <monnier <at> iro.umontreal.ca>
Cc: akater <nuclearspace <at> gmail.com>, 50834 <at> debbugs.gnu.org
Subject: bug#50834: Feature request: cl-remove-method (prototyped) and buttons for it
Date: Tue, 04 Oct 2022 14:19:44 +0200

Stefan Monnier <monnier <at> iro.umontreal.ca> writes:

> Not much to say, except:
>
>> +  (cl-loop for k being hash-key in cl--generic-combined-method-memoization
>> +           when (and (eq generic-function (car k))
>> +                     (memq method (cdr k)))
>> +           do (remhash k cl--generic-combined-method-memoization))
>
> I don't see why we'd need this.
>
> This is a cache that tries to speed up the construction of combined
> methods, whereas in `cl-remove-method` we should only need to flush the
> cache that maps tags to their corresponding combined methods and this is
> done implicitly by `cl--generic-make-function` (which returns a new
> function with a branch new fresh cache).

Akater, do you have any comments (or an amended patch)?

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.