GNU bug report logs - #50808
[PATCH] services: rsync: support binding rsync to a specific IP address

Previous Next

Full log

Message #16 received at 50808 <at> debbugs.gnu.org (full text, mbox):

From: Oleg Pykhalov <go.wigust <at> gmail.com>
To: Jacob Adams <jacob <at> tookmund.com>
Cc: 50808 <at> debbugs.gnu.org
Subject: Re: [bug#50808] [PATCH] services: rsync: support binding rsync to a
 specific IP address
Date: Sun, 26 Sep 2021 18:24:46 +0300

[Message part 1 (text/plain, inline)]

Hi Jacob,

Nice catch, I would like to have this configurable, too.

Jacob Adams <jacob <at> tookmund.com> writes:

[…]

> +  (address       rsync-configuration-address              ; string
> +                 (default ""))

We could just use ‘#f’ here with ‘string | #f’ comment.

[…]

> +      (if (not (string=? address "")) (string-append "address = " address "\n") "")
>        "port = " (number->string port-number) "\n"
>        "use chroot = " (if use-chroot? "true" "false") "\n"
>        (if uid (string-append "uid = " uid "\n") "")

And here we could just ‘(if address (string-append ...) "")’.

Could you send an updated patch, please?

Thanks,
Oleg.

[signature.asc (application/pgp-signature, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.