Subject: Re: bug#50798: 28.0.50; Tab line close button is off-center until it is highlighted with the mouse

From: Eli Zaretskii <[email-masked]>
Date: Sun, 03 Oct 2021 20:22:32 +0300

> From: Juri Linkov <[email-masked]>
> Cc: [email-masked],  [email-masked],  [email-masked]
> Date: Sun, 03 Oct 2021 19:51:40 +0300
> 
> >            `(
> >              tab ,tab
> >              ,@(if selected-p '(selected t))
> >              face ,face
> >              mouse-face tab-line-highlight))))
> >
> > You should be able not to do that for the close button.  Or am I
> > missing something?
> 
> It's possible to put properties on the close button only, but wouldn't this be
> too ugly?  This means that hovering the mouse over the tab name will highlight only
> the tab name without highlighting the close button.  And hovering the mouse
> over the close button will highlight only the close button without highlighting
> the tab name.

How did you intend this to look?  You said previously:

> 'tab-line-close-highlight' was supposed to be applied to the close button
> to emulate how the close button behaves on the tab bar where hovering mouse
> over the button displays it with the face style 'released-button'.
> 
> But mouse-face of the face 'tab-line-highlight' overrides the mouse-face
> 'tab-line-close-highlight' in 'tab-line-tab-name-format-default'
> that applies 'propertize' with 'mouse-face tab-line-highlight'.

If what you intended was not to highlight the close button
differently, then what was the intent?

> So highlighting will be separate for the close button and
> the rest of the tab with such patch:

Does this solve the problem with vertical movement of the button?