From debbugs-submit-bounces@debbugs.gnu.org Fri Sep 24 21:38:58 2021 Received: (at submit) by debbugs.gnu.org; 25 Sep 2021 01:38:58 +0000 Received: from localhost ([127.0.0.1]:59738 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mTweY-0006OU-Gm for submit@debbugs.gnu.org; Fri, 24 Sep 2021 21:38:58 -0400 Received: from lists.gnu.org ([209.51.188.17]:58662) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mTweW-0006OI-5p for submit@debbugs.gnu.org; Fri, 24 Sep 2021 21:38:57 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:48418) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mTweV-0008EG-5y for guix-patches@gnu.org; Fri, 24 Sep 2021 21:38:55 -0400 Received: from singpolyma.net ([2607:5300:60:9e74:1000::]:35849) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mTweT-0007w4-Sh for guix-patches@gnu.org; Fri, 24 Sep 2021 21:38:54 -0400 Received: by singpolyma.net (Postfix, from userid 1000) id F0D504861689; Sat, 25 Sep 2021 01:38:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=singpolyma.net; s=iweb; t=1632533929; bh=np/+xvmdgDmWby0zxsm1vMQlcQZQVG7MkkpCS1kCE+A=; h=Date:From:To:Subject:From; b=ZJ/KXlaTff2WjnmpWbaGXYUOxh/FaxzMTMG1r71SacfCNcXvI+bnrEcyxtCwVIu6B p7FwnzivZCQKBxxJyi092KQb63nFxmSyYKf6m9h1ODvs2eVKpskXvDeuievdt0JgA7 +SJJtDgAH1bUfvl3Y+l+PHy8QgS/OxEPYrWKPks0= Date: Fri, 24 Sep 2021 20:38:48 -0500 From: Stephen Paul Weber To: guix-patches@gnu.org Subject: [PATCH 0/2] cloudflare-cli and dependency JSON.sh Message-ID: <20210925013848.GA2384@singpolyma-beefy.lan> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="zYM0uCDKw75PZbzx" Content-Disposition: inline Jabber-ID: singpolyma@singpolyma.net OpenPGP: id=CE519CDE; url=https://singpolyma.net/public.asc X-URL: https://singpolyma.net User-Agent: Mutt/1.10.1 (2018-07-13) Received-SPF: pass client-ip=2607:5300:60:9e74:1000::; envelope-from=singpolyma@singpolyma.net; helo=singpolyma.net X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.4 (-) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.4 (--) --zYM0uCDKw75PZbzx Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline This series submits two new packages: cloudflare-cli and its dependency JSON.sh --zYM0uCDKw75PZbzx Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEEWeaCw+rzmiEMpzU00RwpEc5RnN4FAmFOfagACgkQ0RwpEc5R nN721A//YPSkpqyRkrKCZrcqLdwCQMSyqAsTcnidKrjuS1vux5ozpZZyVX5Fq87d sit3BPBai0ihfgmUxppQuxIin1fB3UF1Xa8eSR6po3HjsP+igoaYOGVodt0U2N+R lQyQEKLEg1O1TomT4qh9AChkEFAKsY9BAA6Wa38MpzcC4+DeT5o6karXtbajIEpe JbV236CEo7LXYRbBZzuF+AA+tAyFhUb8IGfEl7np7yfAd8stXkWM7zJr/BIqdZ97 oBl2S7uuLgKe2K94WVtmTEvWENVJINSQOzYw3N8csKYmgz8cz0IXytEQkVghR7Ra HmE9NqdwFPPcqrRy2Ouf28l733ksAqU8NIztfG5Qx07vRTJyQxtTa/wODJ4ipkmh wjlTmqgmvvM8MGt2Uld5TsHSbaYSE7ert7NWDrkiveA8vj/toW8d71uagY8O66Yf 9jfxWJxI6BqhcAaAKrwfa1t0wGO9L4uBjuIbJQIG5NpxWMXZfZTJvyEK8muzvyqx Qbi/a1G7UWMGDpSTk6SBhMrlYNu+tlSv3eYE2WnqWifkBCX7H1DZsAVEt1bD1xdO bPuq/xR32OhOa00x/pxn2ndEwKnOm6S9q14rhNgIl65Xx8vxWWgqBT0iU11FwWCo yOPMOQ3f5c3E7Vea9w9Pu2P6x21pz/dciGIR3kLN162VIYEPMeE= =2EJF -----END PGP SIGNATURE----- --zYM0uCDKw75PZbzx-- From debbugs-submit-bounces@debbugs.gnu.org Fri Sep 24 21:39:44 2021 Received: (at 50793) by debbugs.gnu.org; 25 Sep 2021 01:39:44 +0000 Received: from localhost ([127.0.0.1]:59754 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mTwfI-0006RF-7W for submit@debbugs.gnu.org; Fri, 24 Sep 2021 21:39:44 -0400 Received: from singpolyma.net ([192.99.233.116]:50493) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mTwfE-0006Qp-AE for 50793@debbugs.gnu.org; Fri, 24 Sep 2021 21:39:40 -0400 Received: by singpolyma.net (Postfix, from userid 1000) id 12884486168A; Sat, 25 Sep 2021 01:39:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=singpolyma.net; s=iweb; t=1632533980; bh=iTxKdYxqtfnOmeCPtmvT1LjdlbceHS8pM1TZTVaFFLA=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=OVqjKFcVnhTcQuyN9pTmoYNmWr206ukId5fOadFU01m9Tha4M8XkbtBjFMPtx9qqN X9AQM2UV3zJfNrJN5wMvjZPmIutjC+P6tR88mijBmmIx4HYntdEjumnRCpSQ64fHUX 6zk+IC9oawp6PAcQVsrJpnaLp4WqgkMDdpO057Mc= From: Stephen Paul Weber To: 50793@debbugs.gnu.org Subject: [PATCH 2/2] gnu: Add cloudflare-cli Date: Fri, 24 Sep 2021 20:39:34 -0500 Message-Id: <20210925013934.2763-2-singpolyma@singpolyma.net> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20210925013934.2763-1-singpolyma@singpolyma.net> References: <20210925013934.2763-1-singpolyma@singpolyma.net> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 50793 Cc: Stephen Paul Weber X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) * gnu/packages/dns.scm (cloudflare-cli): New variable. --- gnu/packages/dns.scm | 52 ++++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 52 insertions(+) diff --git a/gnu/packages/dns.scm b/gnu/packages/dns.scm index 45e250138e..9e68d76a93 100644 --- a/gnu/packages/dns.scm +++ b/gnu/packages/dns.scm @@ -42,6 +42,7 @@ #:use-module (gnu packages bash) #:use-module (gnu packages certs) #:use-module (gnu packages check) + #:use-module (gnu packages curl) #:use-module (gnu packages databases) #:use-module (gnu packages documentation) #:use-module (gnu packages compression) @@ -69,6 +70,7 @@ #:use-module (gnu packages python) #:use-module (gnu packages python-xyz) #:use-module (gnu packages ragel) + #:use-module (gnu packages serialization) #:use-module (gnu packages shells) #:use-module (gnu packages sphinx) #:use-module (gnu packages swig) @@ -82,11 +84,61 @@ #:use-module (guix download) #:use-module (guix git-download) #:use-module (guix utils) + #:use-module (guix build-system copy) #:use-module (guix build-system glib-or-gtk) #:use-module (guix build-system gnu) #:use-module (guix build-system meson) #:use-module (guix build-system trivial)) +(define-public cloudflare-cli + (package + (name "cloudflare-cli") + (version "2d986d3") + (source + (origin + (method git-fetch) + (uri (git-reference + (url "https://github.com/earlchew/cloudflare-cli") + (commit version))) + (file-name (git-file-name name version)) + (sha256 + (base32 + "0f86g6n86kwykl3jnhqjrdfy8ybkp03ghr3dlr70q2552qw4axw2")))) + (build-system copy-build-system) + (arguments + `(#:install-plan '(("cloudflare-cli" "bin/") ("cloudflare-cli.sh" "bin/")) + #:phases + (modify-phases %standard-phases + (add-after 'unpack 'find-jsonsh + (lambda* (#:key inputs #:allow-other-keys) + (substitute* "cloudflare-cli.sh" + (("\\$\\{0%/\\*\\}/jsonsh") + (string-append (assoc-ref inputs "JSON.sh") "/bin/JSON.sh"))) + #t)) + (add-after 'install 'wrap-program + (lambda* (#:key inputs outputs #:allow-other-keys) + (wrap-program (string-append (assoc-ref outputs "out") "/bin/cloudflare-cli") + `("PATH" ":" prefix + (,(string-join + (map (lambda (in) (string-append (assoc-ref inputs in) "/bin")) + '("grep" "curl" "coreutils")) + ":"))))))))) + (inputs + `(("bash-minimal" ,bash-minimal) + ("coreutils" ,coreutils) + ("curl" ,curl) + ("grep" ,grep) + ("JSON.sh" ,JSON.sh))) + (synopsis + "CLI to edit Cloudflare DNS records") + (description + "This command line tool to update Cloudfare DNS records is useful in the +following scenarios: +* Keeping dynamic DNS records up to date +* Updating DNS records as part of the ACME DNS-01 protocol") + (home-page "https://github.com/earlchew/cloudflare-cli") + (license license:expat))) + (define-public ldns (package (name "ldns") -- 2.20.1 From debbugs-submit-bounces@debbugs.gnu.org Fri Sep 24 21:39:44 2021 Received: (at 50793) by debbugs.gnu.org; 25 Sep 2021 01:39:45 +0000 Received: from localhost ([127.0.0.1]:59756 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mTwfI-0006RH-Hr for submit@debbugs.gnu.org; Fri, 24 Sep 2021 21:39:44 -0400 Received: from singpolyma.net ([192.99.233.116]:49443) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mTwfE-0006Qo-7W for 50793@debbugs.gnu.org; Fri, 24 Sep 2021 21:39:41 -0400 Received: by singpolyma.net (Postfix, from userid 1000) id E65144861689; Sat, 25 Sep 2021 01:39:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=singpolyma.net; s=iweb; t=1632533979; bh=jPVWIXxQZ18+K1pGgNHlOqfl7bHGIDPDzs3rXLfVTOA=; h=From:To:Cc:Subject:Date:From; b=HpfaX3gcUwFVIcKXtPSz9hmJmsMY0L4d3NcdQIMD8z+AZ1nbK0QMQGpvszDhsj+FM A1tsdcatrQLvpiLqzpEScn3dV9zqGrMX+gJt9mGnGXy8iaR0HjyaXmCPn2Cw0S5MQu f3k4IAHT3EaNz5apx6qLM/tGskCLMzf2YHwIoGIA= From: Stephen Paul Weber To: 50793@debbugs.gnu.org Subject: [PATCH 1/2] gnu: Add JSON.sh Date: Fri, 24 Sep 2021 20:39:33 -0500 Message-Id: <20210925013934.2763-1-singpolyma@singpolyma.net> X-Mailer: git-send-email 2.20.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 50793 Cc: Stephen Paul Weber X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) * gnu/packages/serialization.scm (JSON.sh): New variable. --- gnu/packages/serialization.scm | 45 ++++++++++++++++++++++++++++++++++ 1 file changed, 45 insertions(+) diff --git a/gnu/packages/serialization.scm b/gnu/packages/serialization.scm index 196141ace8..f5677d9e5f 100644 --- a/gnu/packages/serialization.scm +++ b/gnu/packages/serialization.scm @@ -34,10 +34,13 @@ #:use-module (guix git-download) #:use-module (guix utils) #:use-module (guix build-system cmake) + #:use-module (guix build-system copy) #:use-module (guix build-system gnu) #:use-module (guix build-system python) #:use-module (gnu packages) #:use-module (gnu packages autotools) + #:use-module (gnu packages base) + #:use-module (gnu packages bash) #:use-module (gnu packages boost) #:use-module (gnu packages check) #:use-module (gnu packages compression) @@ -458,6 +461,48 @@ it a convenient format to store user input files.") (base32 "1180ln8blrb0mwzpcf78k49hlki6di65q77rsvglf83kfcyh4d7z")))))) +(define-public JSON.sh + (package + (name "JSON.sh") + (version "0d5e5c7") + (source + (origin + (method git-fetch) + (uri (git-reference + (url "https://github.com/dominictarr/JSON.sh") + (commit version))) + (file-name (git-file-name name version)) + (sha256 + (base32 + "14lxvp5xbdk0dcwkjbdp098z1108j8z48zaibndh4i731kkcz43i")))) + (build-system copy-build-system) + (arguments + `(#:install-plan '(("JSON.sh" "bin/")) + #:phases + (modify-phases %standard-phases + (add-before 'install 'check + (lambda _ + (invoke "./all-tests.sh") + #t)) + (add-after 'install 'wrap-program + (lambda* (#:key inputs outputs #:allow-other-keys) + (wrap-program (string-append (assoc-ref outputs "out") "/bin/JSON.sh") + `("PATH" ":" prefix + (,(string-join + (map (lambda (in) (string-append (assoc-ref inputs in) "/bin")) + '("grep" "coreutils")) + ":"))))))))) + (inputs + `(("bash-minimal" ,bash-minimal) + ("grep" ,grep) + ("coreutils" ,coreutils))) + (synopsis + "Pipeable JSON parser written in shell") + (description + "JSON parser written in shell, compatible with ash, bash, dash and zsh") + (home-page "https://github.com/dominictarr/JSON.sh") + (license license:asl2.0))) + (define-public capnproto (package (name "capnproto") -- 2.20.1 From debbugs-submit-bounces@debbugs.gnu.org Fri Sep 24 22:58:52 2021 Received: (at 50793) by debbugs.gnu.org; 25 Sep 2021 02:58:52 +0000 Received: from localhost ([127.0.0.1]:59952 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mTxts-0002y4-5n for submit@debbugs.gnu.org; Fri, 24 Sep 2021 22:58:52 -0400 Received: from out1.migadu.com ([91.121.223.63]:41409) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mTxto-0002xp-CZ for 50793@debbugs.gnu.org; Fri, 24 Sep 2021 22:58:50 -0400 X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mgsn.dev; s=key1; t=1632538726; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=lbzrmqMmZOTzsXmftroFsnuD3qbKzk+BGIayl0GdVp0=; b=US3S43wsyO69ZiUUfR3V4t8HZ1x/kZC0M1HgS5+5ibFJH2BsorNc1gsy02asYnUj3DtM69 VJryNSQc9PN+XPbHXFwkjf/Nky3w110LpQDQkWFDWKEQ6r2/HjppaIWLPZjnX5EdTNGh01 HftDOBAe8UiEpaC92+QANXbX/g6Y/wQ= From: Sarah Morgensen To: Stephen Paul Weber Subject: Re: [bug#50793] [PATCH 1/2] gnu: Add JSON.sh References: <20210925013848.GA2384@singpolyma-beefy.lan> <20210925013934.2763-1-singpolyma@singpolyma.net> Date: Fri, 24 Sep 2021 19:58:44 -0700 In-Reply-To: <20210925013934.2763-1-singpolyma@singpolyma.net> (Stephen Paul Weber's message of "Fri, 24 Sep 2021 20:39:33 -0500 (49 minutes, 6 seconds ago)") Message-ID: <86k0j5wecb.fsf@mgsn.dev> MIME-Version: 1.0 Content-Type: text/plain X-Migadu-Flow: FLOW_OUT X-Migadu-Auth-User: iskarian@mgsn.dev X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 50793 Cc: 50793@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Hi, Thanks for the patches! Just a couple quick comments: Stephen Paul Weber writes: > * gnu/packages/serialization.scm (JSON.sh): New variable. > --- > gnu/packages/serialization.scm | 45 ++++++++++++++++++++++++++++++++++ > 1 file changed, 45 insertions(+) > > diff --git a/gnu/packages/serialization.scm b/gnu/packages/serialization.scm > index 196141ace8..f5677d9e5f 100644 > --- a/gnu/packages/serialization.scm > +++ b/gnu/packages/serialization.scm > @@ -34,10 +34,13 @@ > #:use-module (guix git-download) > #:use-module (guix utils) > #:use-module (guix build-system cmake) > + #:use-module (guix build-system copy) > #:use-module (guix build-system gnu) > #:use-module (guix build-system python) > #:use-module (gnu packages) > #:use-module (gnu packages autotools) > + #:use-module (gnu packages base) > + #:use-module (gnu packages bash) > #:use-module (gnu packages boost) > #:use-module (gnu packages check) > #:use-module (gnu packages compression) > @@ -458,6 +461,48 @@ it a convenient format to store user input files.") > (base32 > "1180ln8blrb0mwzpcf78k49hlki6di65q77rsvglf83kfcyh4d7z")))))) > > +(define-public JSON.sh > + (package > + (name "JSON.sh") I can't find a rule for this per se, but it's convention that package names to be lowercase (and for the variable name to match). > + (version "0d5e5c7") Since this isn't a tagged version, this should follow the 'git-version' pattern (search for usages of 'git-version' for examples). > + (source > + (origin > + (method git-fetch) > + (uri (git-reference > + (url "https://github.com/dominictarr/JSON.sh") > + (commit version))) > + (file-name (git-file-name name version)) > + (sha256 > + (base32 > + "14lxvp5xbdk0dcwkjbdp098z1108j8z48zaibndh4i731kkcz43i")))) > + (build-system copy-build-system) > + (arguments > + `(#:install-plan '(("JSON.sh" "bin/")) > + #:phases > + (modify-phases %standard-phases > + (add-before 'install 'check > + (lambda _ > + (invoke "./all-tests.sh") > + #t)) Check phases should respect #:tests?, like so: (lambda* (#:key tests? #:allow-other-keys) (when tests? [...])) Also, it doesn't hurt, but phases no longer have to end in #t. :) > + (add-after 'install 'wrap-program > + (lambda* (#:key inputs outputs #:allow-other-keys) > + (wrap-program (string-append (assoc-ref outputs "out") "/bin/JSON.sh") > + `("PATH" ":" prefix > + (,(string-join > + (map (lambda (in) (string-append (assoc-ref inputs in) "/bin")) > + '("grep" "coreutils")) Does this script actually use coreutils? On the other hand, it looks like it does use gawk and sed. > + ":"))))))))) > + (inputs > + `(("bash-minimal" ,bash-minimal) > + ("grep" ,grep) > + ("coreutils" ,coreutils))) > + (synopsis > + "Pipeable JSON parser written in shell") > + (description > + "JSON parser written in shell, compatible with ash, bash, dash and zsh") This is a bit nit-picky since it's just a dependency, but descriptions should use full sentences, and be a bit more descriptive than this (see "Synopses and Descriptions" in the Guix manual). > + (home-page "https://github.com/dominictarr/JSON.sh") > + (license license:asl2.0))) This is actually dual-licensed with expat, so: (license (list license:expat license:asl2.0)) Could you please send an updated patch? -- Sarah From debbugs-submit-bounces@debbugs.gnu.org Fri Sep 24 22:58:58 2021 Received: (at 50793) by debbugs.gnu.org; 25 Sep 2021 02:58:58 +0000 Received: from localhost ([127.0.0.1]:59955 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mTxtx-0002yN-KU for submit@debbugs.gnu.org; Fri, 24 Sep 2021 22:58:57 -0400 Received: from out1.migadu.com ([91.121.223.63]:41440) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mTxtw-0002yE-73 for 50793@debbugs.gnu.org; Fri, 24 Sep 2021 22:58:57 -0400 X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mgsn.dev; s=key1; t=1632538735; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Bylx/aJnf3IcRZKm3OOW6wviIy+ifWg/44zgcGvG11c=; b=VjQ+A4PrJczBjptdYfISucXP7jvazZGgSwNQS48qB63JsMo+O3W6DUtJUnd4mRhW+Pims4 w3ztz35y0lz0zTke8Cz9O1lVKkQuJdlcuXy+m7ERHdhrJXK0hrURaE98v01I0ZuMefLqTs jNHAOTXs3HFXNiStNu4iZ3BPy3qf6Rk= From: Sarah Morgensen To: Stephen Paul Weber Subject: Re: [bug#50793] [PATCH 2/2] gnu: Add cloudflare-cli References: <20210925013934.2763-1-singpolyma@singpolyma.net> <20210925013934.2763-2-singpolyma@singpolyma.net> Date: Fri, 24 Sep 2021 19:58:54 -0700 In-Reply-To: <20210925013934.2763-2-singpolyma@singpolyma.net> (Stephen Paul Weber's message of "Fri, 24 Sep 2021 20:39:34 -0500 (1 hour, 5 minutes, 51 seconds ago)") Message-ID: <86ilypwec1.fsf@mgsn.dev> MIME-Version: 1.0 Content-Type: text/plain X-Migadu-Flow: FLOW_OUT X-Migadu-Auth-User: iskarian@mgsn.dev X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 50793 Cc: 50793@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Hi, I've (naturally) got a few suggestions for this one, too. Stephen Paul Weber writes: > * gnu/packages/dns.scm (cloudflare-cli): New variable. > --- > gnu/packages/dns.scm | 52 ++++++++++++++++++++++++++++++++++++++++++++ > 1 file changed, 52 insertions(+) > > diff --git a/gnu/packages/dns.scm b/gnu/packages/dns.scm > index 45e250138e..9e68d76a93 100644 > --- a/gnu/packages/dns.scm > +++ b/gnu/packages/dns.scm > @@ -42,6 +42,7 @@ > #:use-module (gnu packages bash) > #:use-module (gnu packages certs) > #:use-module (gnu packages check) > + #:use-module (gnu packages curl) > #:use-module (gnu packages databases) > #:use-module (gnu packages documentation) > #:use-module (gnu packages compression) > @@ -69,6 +70,7 @@ > #:use-module (gnu packages python) > #:use-module (gnu packages python-xyz) > #:use-module (gnu packages ragel) > + #:use-module (gnu packages serialization) > #:use-module (gnu packages shells) > #:use-module (gnu packages sphinx) > #:use-module (gnu packages swig) > @@ -82,11 +84,61 @@ > #:use-module (guix download) > #:use-module (guix git-download) > #:use-module (guix utils) > + #:use-module (guix build-system copy) > #:use-module (guix build-system glib-or-gtk) > #:use-module (guix build-system gnu) > #:use-module (guix build-system meson) > #:use-module (guix build-system trivial)) > > +(define-public cloudflare-cli > + (package > + (name "cloudflare-cli") > + (version "2d986d3") Please use the 'git-version' pattern as I mentioned in the other patch. > + (source > + (origin > + (method git-fetch) > + (uri (git-reference > + (url "https://github.com/earlchew/cloudflare-cli") > + (commit version))) > + (file-name (git-file-name name version)) > + (sha256 > + (base32 > + "0f86g6n86kwykl3jnhqjrdfy8ybkp03ghr3dlr70q2552qw4axw2")))) > + (build-system copy-build-system) > + (arguments > + `(#:install-plan '(("cloudflare-cli" "bin/") ("cloudflare-cli.sh" "bin/")) > + #:phases > + (modify-phases %standard-phases > + (add-after 'unpack 'find-jsonsh > + (lambda* (#:key inputs #:allow-other-keys) > + (substitute* "cloudflare-cli.sh" > + (("\\$\\{0%/\\*\\}/jsonsh") > + (string-append (assoc-ref inputs "JSON.sh") "/bin/JSON.sh"))) > + #t)) > + (add-after 'install 'wrap-program > + (lambda* (#:key inputs outputs #:allow-other-keys) > + (wrap-program (string-append (assoc-ref outputs "out") "/bin/cloudflare-cli") > + `("PATH" ":" prefix > + (,(string-join > + (map (lambda (in) (string-append (assoc-ref inputs in) "/bin")) > + '("grep" "curl" "coreutils")) I don't think this uses anything from coreutils either, but I just took a quick look. > + ":"))))))))) > + (inputs > + `(("bash-minimal" ,bash-minimal) > + ("coreutils" ,coreutils) > + ("curl" ,curl) > + ("grep" ,grep) > + ("JSON.sh" ,JSON.sh))) > + (synopsis > + "CLI to edit Cloudflare DNS records") > + (description > + "This command line tool to update Cloudfare DNS records is useful in the > +following scenarios: > +* Keeping dynamic DNS records up to date > +* Updating DNS records as part of the ACME DNS-01 protocol") Could you update this description to use sentences rather than bullets (and, preferably, use active rather than passive verbiage)? (If you do ever need to write a list in the description, you can use @itemize (info "(texinfo) Lists and Tables"); see other packages for examples.) > + (home-page "https://github.com/earlchew/cloudflare-cli") > + (license license:expat))) > + > (define-public ldns > (package > (name "ldns") Thank you! -- Sarah From debbugs-submit-bounces@debbugs.gnu.org Sat Sep 25 21:08:29 2021 Received: (at 50793) by debbugs.gnu.org; 26 Sep 2021 01:08:29 +0000 Received: from localhost ([127.0.0.1]:35187 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mUIeb-0004wr-55 for submit@debbugs.gnu.org; Sat, 25 Sep 2021 21:08:29 -0400 Received: from singpolyma.net ([192.99.233.116]:51673) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mUIea-0004wk-9i for 50793@debbugs.gnu.org; Sat, 25 Sep 2021 21:08:28 -0400 Received: by singpolyma.net (Postfix, from userid 1000) id 6FBFB486167C; Sun, 26 Sep 2021 01:08:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=singpolyma.net; s=iweb; t=1632618507; bh=Z1+Gr/OdzkV6SxAVxIG8OJ1Rt4tW/DVWfOT6ig013dY=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Pi1lrsDJbVLEzEvLBxkRJWmV3FuOxSt9Z4nU9cfmOEiOXufO31MOR93Ex8VwbKoLD 55iQfVLwAO4CdpCVyOh9cduwULemraSFhw3xju+qVYBseudsJJYzWklP+F0ou2MUg/ wqDA/H1yb7vWn06ixzeI6HMTGeEiGUe725f5fdXQ= Date: Sat, 25 Sep 2021 20:08:27 -0500 From: Stephen Paul Weber To: Sarah Morgensen Subject: Re: [bug#50793] [PATCH 1/2] gnu: Add JSON.sh Message-ID: <20210926010827.GA16766@singpolyma-beefy.lan> References: <20210925013848.GA2384@singpolyma-beefy.lan> <20210925013934.2763-1-singpolyma@singpolyma.net> <86k0j5wecb.fsf@mgsn.dev> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="ikeVEW9yuYc//A+q" Content-Disposition: inline In-Reply-To: <86k0j5wecb.fsf@mgsn.dev> Jabber-ID: singpolyma@singpolyma.net OpenPGP: id=CE519CDE; url=https://singpolyma.net/public.asc X-URL: https://singpolyma.net User-Agent: Mutt/1.10.1 (2018-07-13) X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 50793 Cc: 50793@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --ikeVEW9yuYc//A+q Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline >> +(define-public JSON.sh >> + (package >> + (name "JSON.sh") > >I can't find a rule for this per se, but it's convention that package >names to be lowercase (and for the variable name to match). Ok. Should I keep the . for "json.sh" or go with "jsonsh" ? Should I change the script/command name to match? >> + (version "0d5e5c7") > >Since this isn't a tagged version, this should follow the 'git-version' >pattern (search for usages of 'git-version' for examples). Will do. >> + (add-before 'install 'check >> + (lambda _ >> + (invoke "./all-tests.sh") >> + #t)) > >Check phases should respect #:tests?, like so: > > (lambda* (#:key tests? #:allow-other-keys) > (when tests? > [...])) Ok >> + '("grep" "coreutils")) > >Does this script actually use coreutils? It uses printf > On the other hand, it looks >like it does use gawk gawk is only used if egrep is not present > and sed. Missed this, will add. --ikeVEW9yuYc//A+q Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEEWeaCw+rzmiEMpzU00RwpEc5RnN4FAmFPyAAACgkQ0RwpEc5R nN7L6A//Qdjw8aYXNpCgfpIZSIvdeG0BFhTpIkfku19LVyokPJaRotXj0QA5DhLz uXu4Y9BixmXyqkOQCKM/oRv5aeLQVx78AmTV3Us+hUVk6ZT2mOOn8mpA+reuPk59 xqvUWM7LZvnmqlQ+aSvJRwSQ/yWX0bMqEUA1+/eSEQYhopdUn+USYu6y2umk0FQQ +49o2WK/conJ1UfFOMaL8KUqc5pOuwL9oCYZjhNCHDe+88dK62hWwZpVw9yOmM4a BcT7yOK2sX//CW03k3/Q24g/tGMGoFHZZQgCuZiPRjRBidd3FqxDIN7eCdL+GNZg R7sVWEZa/o3/yzB/e+EB2OokSBkqR1QlsSi5/9nOaucR0roaF8bFMPoVJ/zg5Fce l/fy/yu9+uFZJrDMoYczL8U3swyGadoNxfw2FWKEwLuRIIqNfaLQxXP39/R8JBGn f3nQAPhkzZU7AkGv2+my/XOBy9dV+gfolOIdzRLeYe3yGJXNpHCoUJon6euteIuk qsZ0Rzp8UhhDc6pAvLwm5QK6heCxyJyTZx6ogBpSsXR1CdJA6I2I6FOjzM/sR6iJ dvBOtt31JdUV26LLv5U/1NM2dyhMCsksFVQuEDtSlcW9wEkeh9/zkoD8baxKzZyn v5lyTqBaWnMhCXsDZESafouVF8f0FRpfLq6qQDR1n+3uKZRJNL0= =aXki -----END PGP SIGNATURE----- --ikeVEW9yuYc//A+q-- From debbugs-submit-bounces@debbugs.gnu.org Sat Sep 25 21:21:52 2021 Received: (at 50793) by debbugs.gnu.org; 26 Sep 2021 01:21:52 +0000 Received: from localhost ([127.0.0.1]:35196 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mUIrY-0005G0-KV for submit@debbugs.gnu.org; Sat, 25 Sep 2021 21:21:52 -0400 Received: from singpolyma.net ([192.99.233.116]:46361) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mUIrW-0005Fq-Tv for 50793@debbugs.gnu.org; Sat, 25 Sep 2021 21:21:51 -0400 Received: by singpolyma.net (Postfix, from userid 1000) id 1FDA8486167C; Sun, 26 Sep 2021 01:21:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=singpolyma.net; s=iweb; t=1632619310; bh=nZgNGWFKLoBWnOlp6+HnMrzQNicMhru58lZsgIv3GHg=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=nWIqbeuFIto7PvOM4UXouO2jqdupi5YlEtCV6XBz+3TKjGA6z+g6sptWRuwWeHL2/ oFSrsGgzAZL8UPDBBm0sniupG5k0izB9ndjHiCa5QwPthb+mAbEK/4y+4ETSPQDjiJ seeECKaFz0bE1Dhl1IqbI6sOllR6vOL+mtUR3IM4= Date: Sat, 25 Sep 2021 20:21:49 -0500 From: Stephen Paul Weber To: Sarah Morgensen Subject: Re: [bug#50793] [PATCH 2/2] gnu: Add cloudflare-cli Message-ID: <20210926012149.GB16766@singpolyma-beefy.lan> References: <20210925013934.2763-1-singpolyma@singpolyma.net> <20210925013934.2763-2-singpolyma@singpolyma.net> <86ilypwec1.fsf@mgsn.dev> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="3lcZGd9BuhuYXNfi" Content-Disposition: inline In-Reply-To: <86ilypwec1.fsf@mgsn.dev> Jabber-ID: singpolyma@singpolyma.net OpenPGP: id=CE519CDE; url=https://singpolyma.net/public.asc X-URL: https://singpolyma.net User-Agent: Mutt/1.10.1 (2018-07-13) X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 50793 Cc: 50793@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --3lcZGd9BuhuYXNfi Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline >> + '("grep" "curl" "coreutils")) > >I don't think this uses anything from coreutils either, but I just took >a quick look. printf again --3lcZGd9BuhuYXNfi Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEEWeaCw+rzmiEMpzU00RwpEc5RnN4FAmFPyykACgkQ0RwpEc5R nN5xHA//XZC7+zLTQSpvxtLuxjdkjeAnKLJ2QD9x5DRoDBKhP6qUe9ZWtNTbo78S SHC1vxhHhGRPHpkRPwl4YdhYFghw0r7kfCOAKVqqMe4mRIeFI0xSC5u4nre33P8C rj156UOHQlINZifIRUPoNMYmqjPxjccs89JX9s0UNusEmKgB6usAPsdZ9H2NihLE CRPlOALLFFpeW148DLilqZF3gyUOT+9T8faVtjtpvZaMyEanXetJ+sLZv7N0HqSM wkzQfEqXPaXpUK/+sqasDT/97AXtNtv0pub5HiMoSV7A3NdrKPDHLbxBoFJtL6om N1r4L3GAzatSStDovSWDIbf2RuLWAjLFqUlEGJSy1K3HTyMhFBxK2qFupwe6JDOg hEDHTuZ/QHlresB5n8l2e7LEG1jFP2e2zFLhRo5eAyNwofdvaajMGMPOMRGyTTqX 40IaSFStSNi6tsFMdfSfgDTuj6lRSwohJBhMpZPKqFzdwCBMPuObFcQf9F+wzlcS WyBHAMBkSGy7dBAseJO02o3rBRIgPb9EQKZARqZ/pFtZHNWt6kX6ZIXRx0RUZIDl yAOZUF1bTlEyiRPrg2KMhePW1NA5GLpWiEdu1hcpAUYXuG+XDIbtHVsO2nF5VF8O u5NfSlYl3+vsT7t+NnbBu5kz8DP5YHyyi+6dMA9g6I2E2ei24mk= =ma34 -----END PGP SIGNATURE----- --3lcZGd9BuhuYXNfi-- From debbugs-submit-bounces@debbugs.gnu.org Sat Sep 25 21:29:57 2021 Received: (at 50793) by debbugs.gnu.org; 26 Sep 2021 01:29:57 +0000 Received: from localhost ([127.0.0.1]:35201 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mUIzN-0005RB-DX for submit@debbugs.gnu.org; Sat, 25 Sep 2021 21:29:57 -0400 Received: from singpolyma.net ([192.99.233.116]:41933) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mUIzL-0005Qz-Tw for 50793@debbugs.gnu.org; Sat, 25 Sep 2021 21:29:56 -0400 Received: by singpolyma.net (Postfix, from userid 1000) id 3CB47486167C; Sun, 26 Sep 2021 01:29:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=singpolyma.net; s=iweb; t=1632619795; bh=4T9TQ6QWmVM5oSF0nkP6zKNIWa7OcmcvqYgrCDvgItA=; h=From:To:Cc:Subject:Date:From; b=YsKahkBcUMOp5H1jPWEbdjl+X6zIT5FnRDVsdGp494M7qYUznx/gbPRSyIgFqGIGE /6HEslAuse8kBYgGH7IM08eu8mHLRn5R/vz9I/DfndIhgE3OqzdyT03CcT3BOJ+xtt hsn7z8RAhGf7hc2ss0kDeeMl3Ocqp8quNYrIGB+g= From: Stephen Paul Weber To: 50793@debbugs.gnu.org Subject: [PATCH v2 1/2] gnu: Add JSON.sh Date: Sat, 25 Sep 2021 20:29:45 -0500 Message-Id: <20210926012946.621-1-singpolyma@singpolyma.net> X-Mailer: git-send-email 2.20.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 50793 Cc: Stephen Paul Weber X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) * gnu/packages/serialization.scm (JSON.sh): New variable. --- gnu/packages/serialization.scm | 51 ++++++++++++++++++++++++++++++++++ 1 file changed, 51 insertions(+) diff --git a/gnu/packages/serialization.scm b/gnu/packages/serialization.scm index 196141ace8..b8cdfdc048 100644 --- a/gnu/packages/serialization.scm +++ b/gnu/packages/serialization.scm @@ -34,10 +34,13 @@ #:use-module (guix git-download) #:use-module (guix utils) #:use-module (guix build-system cmake) + #:use-module (guix build-system copy) #:use-module (guix build-system gnu) #:use-module (guix build-system python) #:use-module (gnu packages) #:use-module (gnu packages autotools) + #:use-module (gnu packages base) + #:use-module (gnu packages bash) #:use-module (gnu packages boost) #:use-module (gnu packages check) #:use-module (gnu packages compression) @@ -458,6 +461,54 @@ it a convenient format to store user input files.") (base32 "1180ln8blrb0mwzpcf78k49hlki6di65q77rsvglf83kfcyh4d7z")))))) +(define-public json.sh + (let ((commit "0d5e5c77365f63809bf6e77ef44a1f34b0e05840") + (revision "1")) + (package + (name "json.sh") + (version (git-version "0.0.0" revision commit)) + (source + (origin + (method git-fetch) + (uri (git-reference + (url "https://github.com/dominictarr/JSON.sh") + (commit commit))) + (file-name (git-file-name name version)) + (sha256 + (base32 + "14lxvp5xbdk0dcwkjbdp098z1108j8z48zaibndh4i731kkcz43i")))) + (build-system copy-build-system) + (arguments + `(#:install-plan '(("JSON.sh" "bin/")) + #:phases + (modify-phases %standard-phases + (add-before 'install 'check + (lambda* (#:key tests? #:allow-other-keys) + (when tests? (invoke "./all-tests.sh")) + #t)) + (add-after 'install 'wrap-program + (lambda* (#:key inputs outputs #:allow-other-keys) + (wrap-program (string-append (assoc-ref outputs "out") "/bin/JSON.sh") + `("PATH" ":" prefix + (,(string-join + (map (lambda (in) (string-append (assoc-ref inputs in) "/bin")) + '("grep" "sed" "coreutils")) + ":")))) + #t))))) + (inputs + `(("bash-minimal" ,bash-minimal) + ("grep" ,grep) + ("sed" ,sed) + ("coreutils" ,coreutils))) + (synopsis + "Pipeable JSON parser written in shell") + (description + "A JSON parser written in shell, compatible with ash, bash, dash and zsh. +Pipe json to it, and it traverses the json objects and prints out the path to +the current object (as a JSON array) and then the object, without whitespace.") + (home-page "https://github.com/dominictarr/JSON.sh") + (license (list license:expat license:asl2.0))))) + (define-public capnproto (package (name "capnproto") -- 2.20.1 From debbugs-submit-bounces@debbugs.gnu.org Sat Sep 25 21:29:58 2021 Received: (at 50793) by debbugs.gnu.org; 26 Sep 2021 01:29:58 +0000 Received: from localhost ([127.0.0.1]:35203 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mUIzN-0005RD-N9 for submit@debbugs.gnu.org; Sat, 25 Sep 2021 21:29:58 -0400 Received: from singpolyma.net ([192.99.233.116]:56357) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mUIzL-0005Qy-Tu for 50793@debbugs.gnu.org; Sat, 25 Sep 2021 21:29:56 -0400 Received: by singpolyma.net (Postfix, from userid 1000) id 5B658486168A; Sun, 26 Sep 2021 01:29:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=singpolyma.net; s=iweb; t=1632619795; bh=cRPFdkbZLBLrXzlstS8c4NEosyEh8V7PiBg542ee0jM=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=cWktJbB0TorjVzONYrTGpNog73uK32D0a/Zu05M64gyUTgkSY+Ndvrej+iaNw0XVT Xfxyemd7bbdrQ9Vapk8F+34acoVZKYSOFhotNqqMWqab5NbHxozPTj3z1TAMxjokTX r6mLs1A9ZE+byOzvoCcIU1K6RX1kOsYXN+BNtYq4= From: Stephen Paul Weber To: 50793@debbugs.gnu.org Subject: [PATCH v2 2/2] gnu: Add cloudflare-cli Date: Sat, 25 Sep 2021 20:29:46 -0500 Message-Id: <20210926012946.621-2-singpolyma@singpolyma.net> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20210926012946.621-1-singpolyma@singpolyma.net> References: <20210926012946.621-1-singpolyma@singpolyma.net> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 50793 Cc: Stephen Paul Weber X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) * gnu/packages/dns.scm (cloudflare-cli): New variable. --- gnu/packages/dns.scm | 54 ++++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 54 insertions(+) diff --git a/gnu/packages/dns.scm b/gnu/packages/dns.scm index 45e250138e..d9ef88af99 100644 --- a/gnu/packages/dns.scm +++ b/gnu/packages/dns.scm @@ -42,6 +42,7 @@ #:use-module (gnu packages bash) #:use-module (gnu packages certs) #:use-module (gnu packages check) + #:use-module (gnu packages curl) #:use-module (gnu packages databases) #:use-module (gnu packages documentation) #:use-module (gnu packages compression) @@ -69,6 +70,7 @@ #:use-module (gnu packages python) #:use-module (gnu packages python-xyz) #:use-module (gnu packages ragel) + #:use-module (gnu packages serialization) #:use-module (gnu packages shells) #:use-module (gnu packages sphinx) #:use-module (gnu packages swig) @@ -82,11 +84,63 @@ #:use-module (guix download) #:use-module (guix git-download) #:use-module (guix utils) + #:use-module (guix build-system copy) #:use-module (guix build-system glib-or-gtk) #:use-module (guix build-system gnu) #:use-module (guix build-system meson) #:use-module (guix build-system trivial)) +(define-public cloudflare-cli + (let ((commit "2d986d3ec1b0e3158c4bd40e8918947cb74aa392") + (revision "1")) + (package + (name "cloudflare-cli") + (version (git-version "0.0.0" revision commit)) + (source + (origin + (method git-fetch) + (uri (git-reference + (url "https://github.com/earlchew/cloudflare-cli") + (commit commit))) + (file-name (git-file-name name version)) + (sha256 + (base32 + "0f86g6n86kwykl3jnhqjrdfy8ybkp03ghr3dlr70q2552qw4axw2")))) + (build-system copy-build-system) + (arguments + `(#:install-plan '(("cloudflare-cli" "bin/") ("cloudflare-cli.sh" "bin/")) + #:phases + (modify-phases %standard-phases + (add-after 'unpack 'find-jsonsh + (lambda* (#:key inputs #:allow-other-keys) + (substitute* "cloudflare-cli.sh" + (("\\$\\{0%/\\*\\}/jsonsh") + (string-append (assoc-ref inputs "json.sh") "/bin/JSON.sh"))) + #t)) + (add-after 'install 'wrap-program + (lambda* (#:key inputs outputs #:allow-other-keys) + (wrap-program (string-append (assoc-ref outputs "out") "/bin/cloudflare-cli") + `("PATH" ":" prefix + (,(string-join + (map (lambda (in) (string-append (assoc-ref inputs in) "/bin")) + '("grep" "curl" "coreutils")) + ":")))) + #t))))) + (inputs + `(("bash-minimal" ,bash-minimal) + ("coreutils" ,coreutils) + ("curl" ,curl) + ("grep" ,grep) + ("json.sh" ,json.sh))) + (synopsis + "CLI to edit Cloudflare DNS records") + (description + "This command line tool to update Cloudfare DNS records is useful for tasks +such as updating dynamic DNS records or updating DNS records for the ACME DNS-01 +protocol.") + (home-page "https://github.com/earlchew/cloudflare-cli") + (license license:expat)))) + (define-public ldns (package (name "ldns") -- 2.20.1 From debbugs-submit-bounces@debbugs.gnu.org Sat Sep 25 23:02:25 2021 Received: (at 50793) by debbugs.gnu.org; 26 Sep 2021 03:02:25 +0000 Received: from localhost ([127.0.0.1]:35272 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mUKQq-0007gc-UN for submit@debbugs.gnu.org; Sat, 25 Sep 2021 23:02:25 -0400 Received: from out2.migadu.com ([188.165.223.204]:21872) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mUKQn-0007gT-R1 for 50793@debbugs.gnu.org; Sat, 25 Sep 2021 23:02:23 -0400 X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mgsn.dev; s=key1; t=1632625340; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=q5+gGajz27mfua8TEFb5LoUdgcwUO3peWDcBRGImZPI=; b=ficB8HIIkPGgTVUHHrxmqruO03BrHE9c5uo6o+F8WkdfYGl2BSAhbSDYS/nrJoNkjzJ4zs oxJvNbltNkBRBYe7LDU/WkS0g7h1hb/y7/3UUaNiEHFXzmOkgBsiatFIvXWBMnWShJNoT1 0hVmZa2Y2v9tTcxpHhIXO2l5220Bsmg= From: Sarah Morgensen To: Stephen Paul Weber Subject: Re: [bug#50793] [PATCH 1/2] gnu: Add JSON.sh References: <20210925013848.GA2384@singpolyma-beefy.lan> <20210925013934.2763-1-singpolyma@singpolyma.net> <86k0j5wecb.fsf@mgsn.dev> <20210926010827.GA16766@singpolyma-beefy.lan> Date: Sat, 25 Sep 2021 20:02:18 -0700 In-Reply-To: <20210926010827.GA16766@singpolyma-beefy.lan> (Stephen Paul Weber's message of "Sat, 25 Sep 2021 20:08:27 -0500 (1 hour, 49 minutes, 58 seconds ago)") Message-ID: <86o88gujid.fsf@mgsn.dev> MIME-Version: 1.0 Content-Type: text/plain X-Migadu-Flow: FLOW_OUT X-Migadu-Auth-User: iskarian@mgsn.dev X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 50793 Cc: 50793@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hi, Stephen Paul Weber writes: >>> +(define-public JSON.sh >>> + (package >>> + (name "JSON.sh") >> >>I can't find a rule for this per se, but it's convention that package >>names to be lowercase (and for the variable name to match). > > Ok. Should I keep the . for "json.sh" or go with "jsonsh" ? Should I change the > script/command name to match? I'd keep the dot in the package name. We don't want to modify the actual script name in the package, though (we try to leave the actual contents of packages as unmodified as possible). > >>> + '("grep" "coreutils")) >> >>Does this script actually use coreutils? > > It uses printf 'printf' should just be calling the shell builtin: --8<---------------cut here---------------start------------->8--- $ type printf printf is a shell builtin --8<---------------cut here---------------end--------------->8--- -- Sarah From debbugs-submit-bounces@debbugs.gnu.org Sun Sep 26 19:32:27 2021 Received: (at 50793) by debbugs.gnu.org; 26 Sep 2021 23:32:27 +0000 Received: from localhost ([127.0.0.1]:38989 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mUddC-0006gv-RN for submit@debbugs.gnu.org; Sun, 26 Sep 2021 19:32:27 -0400 Received: from singpolyma.net ([192.99.233.116]:36109) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mUddB-0006gn-2V for 50793@debbugs.gnu.org; Sun, 26 Sep 2021 19:32:25 -0400 Received: by singpolyma.net (Postfix, from userid 1000) id 3E7FE4861607; Sun, 26 Sep 2021 23:32:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=singpolyma.net; s=iweb; t=1632699144; bh=umQb+F+93O8Gg70l7Ulb3L8LaG4Ln8Nagqvh/PqEEHo=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=UKSxOb3qeSdS5UQRYlWHKHMba+13qt75HogYkfP1EVIvNSpbYZlmnlIXG0+jRJZp3 AmzE4onT+6GUFvGqIHOxbgvbDWpU2zz/SGtzF/iffuP4UdQY/oQXa2JzS9baWlDLSa 6+SSIJuR9xMGCg5n9d6dK2IHxcr1vp72ecJjNGuY= Date: Sun, 26 Sep 2021 18:32:24 -0500 From: Stephen Paul Weber To: Sarah Morgensen Subject: Re: [bug#50793] [PATCH 1/2] gnu: Add JSON.sh Message-ID: <20210926233224.GB2089@singpolyma-beefy.lan> References: <20210925013848.GA2384@singpolyma-beefy.lan> <20210925013934.2763-1-singpolyma@singpolyma.net> <86k0j5wecb.fsf@mgsn.dev> <20210926010827.GA16766@singpolyma-beefy.lan> <86o88gujid.fsf@mgsn.dev> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="T4sUOijqQbZv57TR" Content-Disposition: inline In-Reply-To: <86o88gujid.fsf@mgsn.dev> Jabber-ID: singpolyma@singpolyma.net OpenPGP: id=CE519CDE; url=https://singpolyma.net/public.asc X-URL: https://singpolyma.net User-Agent: Mutt/1.10.1 (2018-07-13) X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 50793 Cc: 50793@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --T4sUOijqQbZv57TR Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline >'printf' should just be calling the shell builtin: > >--8<---------------cut here---------------start------------->8--- >$ type printf >printf is a shell builtin >--8<---------------cut here---------------end--------------->8--- Oh of course, silly me, I'll submit a version without coreutils input. --T4sUOijqQbZv57TR Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEEWeaCw+rzmiEMpzU00RwpEc5RnN4FAmFRAwMACgkQ0RwpEc5R nN5U5RAAqXhfIX6jIZRhQCOw66QV13FrsEPG0lMIHtMYqVfhxCa8qx1La8WgHWiU epnp5FvNRjEAj+VNWquii1gjdMY+wX94Hubx5l/CNSjZNxwyf6oEoO9N6yapzUc4 tTaviS0yDuq1wU/kjH9FBRXOvD1P24jZDk5rxCw1uUOTfBe/tqtGrrrt1Nxb8SGs Xh6/5ZQCiGrDOOaWvuhQO5IN7YDUo/p11PbRLWCafNnSK4E0dEzMWanv+zH59Ox7 9REE7S0R7w1HKonlqyK24iR4Oo0Yqn4VnD5oMs9n+QUibswS59gFnh7KrPW1RqvF oPqVDZkelRyPolrj4NGl1ezOnGjk1pT7ctQjGGK+LSKk9uRCTM9Fu23JbXeQdg8K BzasuPhF4VTfuYfl9xxTqIyaZUIYebBNyuwHhCYpEJ7/94Ct24omrmhrngDM25bp klfR3ipu6+RvF7Gg0OWTTtiNLEIh9xDgtfaZXHHrO1yzN3dw7pr86TkCkmxJMNhY iTMgGiCsOJ8267GZr4RkQ20TTQHtZmA/tTArPPI/aIAP21uDfQPoPpvCZDGNovqR lKcw4pu8xV37SSwHbLYAimtiDxM6dTsMG8ZYzzR8Im0mYyjNrgmyCmB44E7RKILz h16qMmVg+iBu8MYnlbScSax+Tvn6QIotaMhaoAwOqN68ILau+pY= =iRLD -----END PGP SIGNATURE----- --T4sUOijqQbZv57TR-- From debbugs-submit-bounces@debbugs.gnu.org Sun Sep 26 19:35:23 2021 Received: (at 50793) by debbugs.gnu.org; 26 Sep 2021 23:35:23 +0000 Received: from localhost ([127.0.0.1]:38994 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mUdg3-0006l7-85 for submit@debbugs.gnu.org; Sun, 26 Sep 2021 19:35:23 -0400 Received: from singpolyma.net ([192.99.233.116]:55359) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mUdg0-0006ku-VF for 50793@debbugs.gnu.org; Sun, 26 Sep 2021 19:35:21 -0400 Received: by singpolyma.net (Postfix, from userid 1000) id BE5E6486168C; Sun, 26 Sep 2021 23:35:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=singpolyma.net; s=iweb; t=1632699320; bh=9elv09fvN+FnXaxyacwCu6FmQGb0qLz0kBgNiSKQD4s=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=b5Re4QTVc113jma/oL9zpr13WLeHd+JkTb5tGps6eiQcMwm6uaNieFZcbnyqJopwk A21KfPox8FFZjze6TyJgvylUksyNof16/Dvy2R7m/rwJ86KmXNIorJAO5vqip/1HXy 11e1Op9/C+dpxZd/eKBHaYXB849kBM42nPL0deZs= From: Stephen Paul Weber To: 50793@debbugs.gnu.org Subject: [PATCH v3 2/2] gnu: Add cloudflare-cli Date: Sun, 26 Sep 2021 18:35:13 -0500 Message-Id: <20210926233513.3710-2-singpolyma@singpolyma.net> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20210926233513.3710-1-singpolyma@singpolyma.net> References: <20210926233513.3710-1-singpolyma@singpolyma.net> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 50793 Cc: Stephen Paul Weber , iskarian@mgsn.dev X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) * gnu/packages/dns.scm (cloudflare-cli): New variable. --- gnu/packages/dns.scm | 53 ++++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 53 insertions(+) diff --git a/gnu/packages/dns.scm b/gnu/packages/dns.scm index 45e250138e..3b0da466f5 100644 --- a/gnu/packages/dns.scm +++ b/gnu/packages/dns.scm @@ -42,6 +42,7 @@ #:use-module (gnu packages bash) #:use-module (gnu packages certs) #:use-module (gnu packages check) + #:use-module (gnu packages curl) #:use-module (gnu packages databases) #:use-module (gnu packages documentation) #:use-module (gnu packages compression) @@ -69,6 +70,7 @@ #:use-module (gnu packages python) #:use-module (gnu packages python-xyz) #:use-module (gnu packages ragel) + #:use-module (gnu packages serialization) #:use-module (gnu packages shells) #:use-module (gnu packages sphinx) #:use-module (gnu packages swig) @@ -82,11 +84,62 @@ #:use-module (guix download) #:use-module (guix git-download) #:use-module (guix utils) + #:use-module (guix build-system copy) #:use-module (guix build-system glib-or-gtk) #:use-module (guix build-system gnu) #:use-module (guix build-system meson) #:use-module (guix build-system trivial)) +(define-public cloudflare-cli + (let ((commit "2d986d3ec1b0e3158c4bd40e8918947cb74aa392") + (revision "1")) + (package + (name "cloudflare-cli") + (version (git-version "0.0.0" revision commit)) + (source + (origin + (method git-fetch) + (uri (git-reference + (url "https://github.com/earlchew/cloudflare-cli") + (commit commit))) + (file-name (git-file-name name version)) + (sha256 + (base32 + "0f86g6n86kwykl3jnhqjrdfy8ybkp03ghr3dlr70q2552qw4axw2")))) + (build-system copy-build-system) + (arguments + `(#:install-plan '(("cloudflare-cli" "bin/") ("cloudflare-cli.sh" "bin/")) + #:phases + (modify-phases %standard-phases + (add-after 'unpack 'find-jsonsh + (lambda* (#:key inputs #:allow-other-keys) + (substitute* "cloudflare-cli.sh" + (("\\$\\{0%/\\*\\}/jsonsh") + (string-append (assoc-ref inputs "json.sh") "/bin/JSON.sh"))) + #t)) + (add-after 'install 'wrap-program + (lambda* (#:key inputs outputs #:allow-other-keys) + (wrap-program (string-append (assoc-ref outputs "out") "/bin/cloudflare-cli") + `("PATH" ":" prefix + (,(string-join + (map (lambda (in) (string-append (assoc-ref inputs in) "/bin")) + '("grep" "curl")) + ":")))) + #t))))) + (inputs + `(("bash-minimal" ,bash-minimal) + ("curl" ,curl) + ("grep" ,grep) + ("json.sh" ,json.sh))) + (synopsis + "CLI to edit Cloudflare DNS records") + (description + "This command line tool to update Cloudfare DNS records is useful for tasks +such as updating dynamic DNS records or updating DNS records for the ACME DNS-01 +protocol.") + (home-page "https://github.com/earlchew/cloudflare-cli") + (license license:expat)))) + (define-public ldns (package (name "ldns") -- 2.20.1 From debbugs-submit-bounces@debbugs.gnu.org Sun Sep 26 19:35:23 2021 Received: (at 50793) by debbugs.gnu.org; 26 Sep 2021 23:35:24 +0000 Received: from localhost ([127.0.0.1]:38996 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mUdg3-0006lA-IY for submit@debbugs.gnu.org; Sun, 26 Sep 2021 19:35:23 -0400 Received: from singpolyma.net ([192.99.233.116]:43041) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mUdg0-0006kt-Qn for 50793@debbugs.gnu.org; Sun, 26 Sep 2021 19:35:21 -0400 Received: by singpolyma.net (Postfix, from userid 1000) id A2429486168B; Sun, 26 Sep 2021 23:35:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=singpolyma.net; s=iweb; t=1632699320; bh=5KLt7LaSb4Z+UElHZbhhyY7lHfT+6SXwCvGIkERU79M=; h=From:To:Cc:Subject:Date:From; b=Ls693d7WV5xSs57jRHqOTPTWmpaTFe8OOQ0NXrvA6InJ+/gcHL8SdGY9J4pjyKV5m uifnfzP+TbywlLb+Bx2aTCITk5m9geEpLJa7GOOXtuG1wMwMl8QckQRT0t9pimFAWg 5gHgnJypJLXVRtRxHmxtOXbgiNlp3mXuS0/FsjoI= From: Stephen Paul Weber To: 50793@debbugs.gnu.org Subject: [PATCH v3 1/2] gnu: Add JSON.sh Date: Sun, 26 Sep 2021 18:35:12 -0500 Message-Id: <20210926233513.3710-1-singpolyma@singpolyma.net> X-Mailer: git-send-email 2.20.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 50793 Cc: Stephen Paul Weber , iskarian@mgsn.dev X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) * gnu/packages/serialization.scm (JSON.sh): New variable. --- gnu/packages/serialization.scm | 50 ++++++++++++++++++++++++++++++++++ 1 file changed, 50 insertions(+) diff --git a/gnu/packages/serialization.scm b/gnu/packages/serialization.scm index 196141ace8..07ce5f2537 100644 --- a/gnu/packages/serialization.scm +++ b/gnu/packages/serialization.scm @@ -34,10 +34,13 @@ #:use-module (guix git-download) #:use-module (guix utils) #:use-module (guix build-system cmake) + #:use-module (guix build-system copy) #:use-module (guix build-system gnu) #:use-module (guix build-system python) #:use-module (gnu packages) #:use-module (gnu packages autotools) + #:use-module (gnu packages base) + #:use-module (gnu packages bash) #:use-module (gnu packages boost) #:use-module (gnu packages check) #:use-module (gnu packages compression) @@ -458,6 +461,53 @@ it a convenient format to store user input files.") (base32 "1180ln8blrb0mwzpcf78k49hlki6di65q77rsvglf83kfcyh4d7z")))))) +(define-public json.sh + (let ((commit "0d5e5c77365f63809bf6e77ef44a1f34b0e05840") + (revision "1")) + (package + (name "json.sh") + (version (git-version "0.0.0" revision commit)) + (source + (origin + (method git-fetch) + (uri (git-reference + (url "https://github.com/dominictarr/JSON.sh") + (commit commit))) + (file-name (git-file-name name version)) + (sha256 + (base32 + "14lxvp5xbdk0dcwkjbdp098z1108j8z48zaibndh4i731kkcz43i")))) + (build-system copy-build-system) + (arguments + `(#:install-plan '(("JSON.sh" "bin/")) + #:phases + (modify-phases %standard-phases + (add-before 'install 'check + (lambda* (#:key tests? #:allow-other-keys) + (when tests? (invoke "./all-tests.sh")) + #t)) + (add-after 'install 'wrap-program + (lambda* (#:key inputs outputs #:allow-other-keys) + (wrap-program (string-append (assoc-ref outputs "out") "/bin/JSON.sh") + `("PATH" ":" prefix + (,(string-join + (map (lambda (in) (string-append (assoc-ref inputs in) "/bin")) + '("grep" "sed")) + ":")))) + #t))))) + (inputs + `(("bash-minimal" ,bash-minimal) + ("grep" ,grep) + ("sed" ,sed))) + (synopsis + "Pipeable JSON parser written in shell") + (description + "A JSON parser written in shell, compatible with ash, bash, dash and zsh. +Pipe json to it, and it traverses the json objects and prints out the path to +the current object (as a JSON array) and then the object, without whitespace.") + (home-page "https://github.com/dominictarr/JSON.sh") + (license (list license:expat license:asl2.0))))) + (define-public capnproto (package (name "capnproto") -- 2.20.1 From debbugs-submit-bounces@debbugs.gnu.org Wed Oct 13 05:05:57 2021 Received: (at 50793) by debbugs.gnu.org; 13 Oct 2021 09:05:57 +0000 Received: from localhost ([127.0.0.1]:58250 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1maaCy-0006RJ-WB for submit@debbugs.gnu.org; Wed, 13 Oct 2021 05:05:57 -0400 Received: from eggs.gnu.org ([209.51.188.92]:52004) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1maaCw-0006R5-Nn for 50793@debbugs.gnu.org; Wed, 13 Oct 2021 05:05:55 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:50770) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1maaCq-00040W-36; Wed, 13 Oct 2021 05:05:48 -0400 Received: from 91-160-117-201.subs.proxad.net ([91.160.117.201]:53910 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1maaC9-0003NI-T5; Wed, 13 Oct 2021 05:05:33 -0400 From: =?utf-8?Q?Ludovic_Court=C3=A8s?= To: Stephen Paul Weber Subject: Re: bug#50793: [PATCH 0/2] cloudflare-cli and dependency JSON.sh References: <20210925013848.GA2384@singpolyma-beefy.lan> <20210926233513.3710-1-singpolyma@singpolyma.net> Date: Wed, 13 Oct 2021 11:05:03 +0200 In-Reply-To: <20210926233513.3710-1-singpolyma@singpolyma.net> (Stephen Paul Weber's message of "Sun, 26 Sep 2021 18:35:12 -0500") Message-ID: <87czo9s3b4.fsf_-_@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 50793 Cc: 50793@debbugs.gnu.org, iskarian@mgsn.dev X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Hi, Stephen Paul Weber skribis: > * gnu/packages/serialization.scm (JSON.sh): New variable. Applied with the cosmetic changes below. Thanks, Ludo=E2=80=99. --=-=-= Content-Type: text/x-patch Content-Disposition: inline diff --git a/gnu/packages/serialization.scm b/gnu/packages/serialization.scm index 07ce5f2537..e24ef973b5 100644 --- a/gnu/packages/serialization.scm +++ b/gnu/packages/serialization.scm @@ -462,7 +462,7 @@ (define-public jsoncpp-for-tensorflow "1180ln8blrb0mwzpcf78k49hlki6di65q77rsvglf83kfcyh4d7z")))))) (define-public json.sh - (let ((commit "0d5e5c77365f63809bf6e77ef44a1f34b0e05840") + (let ((commit "0d5e5c77365f63809bf6e77ef44a1f34b0e05840") ;no releases (revision "1")) (package (name "json.sh") @@ -499,14 +499,14 @@ (define-public json.sh `(("bash-minimal" ,bash-minimal) ("grep" ,grep) ("sed" ,sed))) - (synopsis - "Pipeable JSON parser written in shell") + (synopsis "Pipeable JSON parser written in shell") (description - "A JSON parser written in shell, compatible with ash, bash, dash and zsh. -Pipe json to it, and it traverses the json objects and prints out the path to -the current object (as a JSON array) and then the object, without whitespace.") + "This package provides a JSON parser written in shell, compatible with +ash, Bash, Dash and Zsh. Pipe JSON to it, and it traverses the JSON objects +and prints out the path to the current object (as a JSON array) and then the +object, without whitespace.") (home-page "https://github.com/dominictarr/JSON.sh") - (license (list license:expat license:asl2.0))))) + (license (list license:expat license:asl2.0))))) ;dual-licensed (define-public capnproto (package --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Wed Oct 13 05:08:35 2021 Received: (at 50793-done) by debbugs.gnu.org; 13 Oct 2021 09:08:35 +0000 Received: from localhost ([127.0.0.1]:58254 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1maaFX-0006VF-Fd for submit@debbugs.gnu.org; Wed, 13 Oct 2021 05:08:35 -0400 Received: from eggs.gnu.org ([209.51.188.92]:53094) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1maaFW-0006V3-3N for 50793-done@debbugs.gnu.org; Wed, 13 Oct 2021 05:08:34 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:50796) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1maaFP-0006RA-Fk; Wed, 13 Oct 2021 05:08:28 -0400 Received: from 91-160-117-201.subs.proxad.net ([91.160.117.201]:61471 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1maaFK-0002gg-OV; Wed, 13 Oct 2021 05:08:27 -0400 From: =?utf-8?Q?Ludovic_Court=C3=A8s?= To: Stephen Paul Weber Subject: Re: bug#50793: [PATCH 0/2] cloudflare-cli and dependency JSON.sh References: <20210926233513.3710-1-singpolyma@singpolyma.net> <20210926233513.3710-2-singpolyma@singpolyma.net> Date: Wed, 13 Oct 2021 11:08:21 +0200 In-Reply-To: <20210926233513.3710-2-singpolyma@singpolyma.net> (Stephen Paul Weber's message of "Sun, 26 Sep 2021 18:35:13 -0500") Message-ID: <878ryxs35m.fsf_-_@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 50793-done Cc: 50793-done@debbugs.gnu.org, iskarian@mgsn.dev X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Stephen Paul Weber skribis: > * gnu/packages/dns.scm (cloudflare-cli): New variable. Applied. Thank you, and thanks Sarah! Ludo=E2=80=99. From debbugs-submit-bounces@debbugs.gnu.org Wed Oct 13 15:03:43 2021 Received: (at 50793) by debbugs.gnu.org; 13 Oct 2021 19:03:43 +0000 Received: from localhost ([127.0.0.1]:33443 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1majXS-0007I9-SJ for submit@debbugs.gnu.org; Wed, 13 Oct 2021 15:03:43 -0400 Received: from mail-qk1-f178.google.com ([209.85.222.178]:47077) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1majXO-0007Hg-Rx for 50793@debbugs.gnu.org; Wed, 13 Oct 2021 15:03:41 -0400 Received: by mail-qk1-f178.google.com with SMTP id bk7so3206743qkb.13 for <50793@debbugs.gnu.org>; Wed, 13 Oct 2021 12:03:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version:content-transfer-encoding; bh=5xeHjv7R06TQzmkLzNZnMiVO2tXft1wsBv0TfTzWxz0=; b=N0xRl+sMqVjGdexpx40d+UKiV5be9/aJ+3rZrBzor+ewKV54fMKV18R4uCmzTnNT+j xG11JWauTUaZByuOACF43Yw/DxUOQThfFXb4wH3gTpPs5LmHi0Z9mPV5ll6gqG/JxIX+ 2T6nN7ZHORpVdKnXmUDuxh2a8ubHzqbqcxWS7m+tOw9EFE9GClrqXU89XCpK59Ew/7RN PPVX0O4K38QHHGbpHuhY1r3H/vR8PfE4FQRJcLBAj0o8Td087LnQUfRxJL413DmvSdDF Yiw3LgGJUH4zjJ+z6KaJYj8RHgS4fzsde233HUQRENC+Ld8aTu2QEG8yl0UmbsSvpmn5 L3aA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version:content-transfer-encoding; bh=5xeHjv7R06TQzmkLzNZnMiVO2tXft1wsBv0TfTzWxz0=; b=Yc24hg31k8TYP9ex24Mu/c+0AbRvLvCN/tiPGg7x262e3TAuMyv9abwWmKXyvJNfuJ FuK9d4dyxfpegHLMFgosBBOGRlAnkOyzsTuYmN4NFWvhCGhckGLvDjjW9s1/j+MId9mL R6Aubx3g9yc5adkxYgxDARMFwhBCDhYjgnot4CdMGtQpD4juJtoxuq+nY6x83+r/hMrq fH4lMFbBqPwD+dTt7fcMLjWZf95meYmDm82QtFpTB82sTLOvoATuOSFfUx9wWm1LBSoN XJ0/G/3BWg8FOhaouhQseui7rwokw7YhMMDBxsqsDE89KsSa+g2/cUpYkRDeszSSUzW1 cy2A== X-Gm-Message-State: AOAM533bMteBAbTtDUnnembmvoif1VKuoCcRo741i6+txfHCOQvNuJcx DuKFxLg7u1RYj+LRMuE59Y8= X-Google-Smtp-Source: ABdhPJxaO/o+i4OoUvxTdkmO10xgTZ5WD4lfznSyjF/DWPEcntf66taHBgcpujCev7oYZHyKNjywlw== X-Received: by 2002:a37:a642:: with SMTP id p63mr947007qke.193.1634151813363; Wed, 13 Oct 2021 12:03:33 -0700 (PDT) Received: from kwak ([70.50.251.9]) by smtp.gmail.com with ESMTPSA id 187sm258610qkk.2.2021.10.13.12.03.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 13 Oct 2021 12:03:32 -0700 (PDT) From: Maxim Cournoyer To: Ludovic =?utf-8?Q?Court=C3=A8s?= Subject: Re: [bug#50793] [PATCH 0/2] cloudflare-cli and dependency JSON.sh References: <20210925013848.GA2384@singpolyma-beefy.lan> <20210926233513.3710-1-singpolyma@singpolyma.net> <87czo9s3b4.fsf_-_@gnu.org> Date: Wed, 13 Oct 2021 15:03:31 -0400 In-Reply-To: <87czo9s3b4.fsf_-_@gnu.org> ("Ludovic =?utf-8?Q?Court=C3=A8s?= =?utf-8?Q?=22's?= message of "Wed, 13 Oct 2021 11:05:03 +0200") Message-ID: <87lf2wwxvg.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 50793 Cc: Stephen Paul Weber , 50793@debbugs.gnu.org, iskarian@mgsn.dev X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hello! Ludovic Court=C3=A8s writes: > Hi, > > Stephen Paul Weber skribis: > >> * gnu/packages/serialization.scm (JSON.sh): New variable. > > Applied with the cosmetic changes below. Didn't we have some coding style preferring hyphens over '.' ? I can't find any of this in our manual, but ISTR that there were some commits made to adjust package names that had '.' in them. Thanks! From debbugs-submit-bounces@debbugs.gnu.org Thu Oct 14 04:56:35 2021 Received: (at 50793) by debbugs.gnu.org; 14 Oct 2021 08:56:35 +0000 Received: from localhost ([127.0.0.1]:34627 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mawXT-0000lh-Bf for submit@debbugs.gnu.org; Thu, 14 Oct 2021 04:56:35 -0400 Received: from mail-wr1-f46.google.com ([209.85.221.46]:46933) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mawXO-0000lR-K3 for 50793@debbugs.gnu.org; Thu, 14 Oct 2021 04:56:34 -0400 Received: by mail-wr1-f46.google.com with SMTP id k7so16947816wrd.13 for <50793@debbugs.gnu.org>; Thu, 14 Oct 2021 01:56:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version:content-transfer-encoding; bh=m57S633dSxoxzDzSOiPBtoA7I+fQ/tYCOSFFvZuFX90=; b=TM6M9B/7YaIKmL0KT7P4W4ceXPG4gSCxgsS2fo6ALcEmoeaYVSpxywZBK0eENcwPPq /aYviUItcAn8AYGArx1IrdM9N4B1Wuhp1XNKwn2xF6puIk+WbrFuStvL0OcmE+zcyoiL W1gEZgIkCWp9SxaRyft8LS9BzV8vjBN9OHlZw5/GN/xMsXCqZeMeVDHMJx0WXSIJs5Aq uETAu1blediQFGjY+pbebM3A8IlgJg1MlRjqubUAK3cHljor8Hc+/Lf6noc7PHBMN7do zT3s2JGznj92aFyE2C4URPaMN4zGieDXUTucRaPdy3txz/TsumEhhVZ53CER/o9fN3Cn e32g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version:content-transfer-encoding; bh=m57S633dSxoxzDzSOiPBtoA7I+fQ/tYCOSFFvZuFX90=; b=k8o1Jt8i+MXvGUf/akwcPt6JVL2ZKy24BjX9mpaBpbbZ8PN3yddwifQgF2bCtK4+ms wvb4lEooKv3XtWVNETUyAfiTYFpr29+vJPR4C0uTx0L/F+N4xixpiJkeGApyndI2+e// 6JoW334UNoiHbQvSjSwGewGGhqBeh3qbOi4gjoWp/j+j5gzLLhtRLYHNhmHhu5Y4BCAR ikerup0VyR9YGPeLqGiZPvtyv2VGGPLADB8XnGhBD/KMFwC7S4Ny7gKm+1zZmyuzbMVL jkCQlffO9+Lf9Amq9+HhYn4hhaCTKRfTE29DCMxO8vfvmtHfbUeagaF3RNSXk9sScSiX n5FA== X-Gm-Message-State: AOAM531i6hLEnDvzxU4MdqUD9dlv2g0FPxR7Cur/gtOi4nvJ1zqW0rfp c4tnxY+jxgywCJWVSCvaS98= X-Google-Smtp-Source: ABdhPJw4ZdgOTJdU3TLvxfrqILf1Ksm03AygI+f+nr5UazKJEvIHUyUq1injq6GAczNAg6W9E4ik3g== X-Received: by 2002:adf:a2d7:: with SMTP id t23mr5334209wra.156.1634201784693; Thu, 14 Oct 2021 01:56:24 -0700 (PDT) Received: from lili ([2a01:e0a:59b:9120:65d2:2476:f637:db1e]) by smtp.gmail.com with ESMTPSA id z5sm9321899wmp.26.2021.10.14.01.56.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 14 Oct 2021 01:56:24 -0700 (PDT) From: zimoun To: Maxim Cournoyer Subject: Re: [bug#50793] [PATCH 0/2] cloudflare-cli and dependency JSON.sh References: <20210925013848.GA2384@singpolyma-beefy.lan> <20210926233513.3710-1-singpolyma@singpolyma.net> <87czo9s3b4.fsf_-_@gnu.org> <87lf2wwxvg.fsf@gmail.com> Date: Thu, 14 Oct 2021 10:54:30 +0200 In-Reply-To: <87lf2wwxvg.fsf@gmail.com> (Maxim Cournoyer's message of "Wed, 13 Oct 2021 15:03:31 -0400") Message-ID: <86v920q94p.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 50793 Cc: Stephen Paul Weber , 50793@debbugs.gnu.org, Ludovic =?utf-8?Q?Court=C3=A8s?= , iskarian@mgsn.dev X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hi, On Wed, 13 Oct 2021 at 15:03, Maxim Cournoyer w= rote: > Didn't we have some coding style preferring hyphens over '.' ? I can't > find any of this in our manual, but ISTR that there were some commits > made to adjust package names that had '.' in them. Yes, the implicit rule of thumb is to prefer hyphens =E2=80=99-=E2=80=99 ov= er dot =E2=80=99.=E2=80=99 for naming variable. Indeed, I do not find neither this in manual. Is it better to add a lint checker? Or just add an item to ? Cheers, simon From debbugs-submit-bounces@debbugs.gnu.org Thu Oct 14 23:26:39 2021 Received: (at 50793) by debbugs.gnu.org; 15 Oct 2021 03:26:39 +0000 Received: from localhost ([127.0.0.1]:37622 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mbDri-0008Vn-Vi for submit@debbugs.gnu.org; Thu, 14 Oct 2021 23:26:39 -0400 Received: from mail-qk1-f172.google.com ([209.85.222.172]:46713) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mbDre-0008VW-7I for 50793@debbugs.gnu.org; Thu, 14 Oct 2021 23:26:37 -0400 Received: by mail-qk1-f172.google.com with SMTP id h20so2962126qko.13 for <50793@debbugs.gnu.org>; Thu, 14 Oct 2021 20:26:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version:content-transfer-encoding; bh=fL8BdHWHJXx7bZq6ITfPdkTlvcEVpt/DmDKpPYo7DAM=; b=bB5L7OADQzDjC8dRES5apfbqUjIQBtzuCIHYyK8WZqieUwr6H+qyWnl1y5LFC8bmDO AKdRZiUU05STGiO9NSchGUysGVq8YWOiLR6fv7gquPyDbPty3jETpH0EVZgBtt6tMxfl p1MAjdJLcxa+Oosj+AZ+LrcoRJucdGf+bMy59k0EIBIuNkefrYurUINtXQ/LyoUfYh8w O/ewZ3Yt1jCfzG5micLb+fwnA9ZCInzN/cPndVStkzPiU9VEk4rUPdCwos5kK2Zjdc64 Yv6qRcVgILslp0cn91NV6hqV/keUu+pDpWapTPZIjdFnYzreCWnglXMox4BYe7StpVup /e4A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version:content-transfer-encoding; bh=fL8BdHWHJXx7bZq6ITfPdkTlvcEVpt/DmDKpPYo7DAM=; b=sXVwUlwPT9Zl0A3Tfyw0ZcaWn0N0ei7u95ZEQM53L0ropN698D/y+KmHtcPxc3kwIb JiC18hl3lYuHDEc3yh3w33WjCqZCnnSu2NNSGVVLhMp/In+h4cupyn+nsZVIwkhWH7nR QFx6zqN56xxaQs7u7OD7XWeR9q+rNtsWcbLh9zDw14uYJp6ctIsyJ5HPQQzgK/1uCASK s5QdzW+9xYM45cmH6kjPQN9mtn0tmqBWbC9wq/ZXUG1VGx0n0ND3zFO1huW/b9EbEdLz DeXhrz3E+dR2V/VxloBRBDLMt8YcCjwTvT2+jAcwY7FkhQUbyZA/foatbPrrjG29Urg5 apGQ== X-Gm-Message-State: AOAM533/qcdCTmI1qp6cLhP1BSi+u4F+SLFkN/zUI17E2aBm7svOdh9/ /dnNCpe25cSLPN2k4Ek0oNfAnLJWcX4= X-Google-Smtp-Source: ABdhPJw3CCtETQr3Vh9SyLLfx/m0o+WbEYaqIX0OTZe0ucihg4ddHOWL5J4y5Flvi3p8tf4ETLrMRg== X-Received: by 2002:a37:6194:: with SMTP id v142mr8249183qkb.351.1634268388605; Thu, 14 Oct 2021 20:26:28 -0700 (PDT) Received: from hurd (dsl-236-123-199.b2b2c.ca. [207.236.123.199]) by smtp.gmail.com with ESMTPSA id e10sm25056qtx.66.2021.10.14.20.26.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 14 Oct 2021 20:26:28 -0700 (PDT) From: Maxim Cournoyer To: zimoun Subject: Re: [bug#50793] [PATCH 0/2] cloudflare-cli and dependency JSON.sh References: <20210925013848.GA2384@singpolyma-beefy.lan> <20210926233513.3710-1-singpolyma@singpolyma.net> <87czo9s3b4.fsf_-_@gnu.org> <87lf2wwxvg.fsf@gmail.com> <86v920q94p.fsf@gmail.com> Date: Thu, 14 Oct 2021 23:26:03 -0400 In-Reply-To: <86v920q94p.fsf@gmail.com> (zimoun's message of "Thu, 14 Oct 2021 10:54:30 +0200") Message-ID: <87h7djnf3o.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 50793 Cc: Stephen Paul Weber , 50793@debbugs.gnu.org, Ludovic =?utf-8?Q?Court=C3=A8s?= , iskarian@mgsn.dev X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hello Simon, zimoun writes: > Hi, > > On Wed, 13 Oct 2021 at 15:03, Maxim Cournoyer = wrote: > >> Didn't we have some coding style preferring hyphens over '.' ? I can't >> find any of this in our manual, but ISTR that there were some commits >> made to adjust package names that had '.' in them. > > Yes, the implicit rule of thumb is to prefer hyphens =E2=80=99-=E2=80=99 = over dot =E2=80=99.=E2=80=99 > for naming variable. Indeed, I do not find neither this in manual. > > Is it better to add a lint checker? Or just add an item to > > I'd say both! Were you volunteering to add it? :-) Thanks, Maxim From debbugs-submit-bounces@debbugs.gnu.org Fri Oct 15 11:28:12 2021 Received: (at 50793) by debbugs.gnu.org; 15 Oct 2021 15:28:13 +0000 Received: from localhost ([127.0.0.1]:40322 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mbP80-0003iX-Lo for submit@debbugs.gnu.org; Fri, 15 Oct 2021 11:28:12 -0400 Received: from eggs.gnu.org ([209.51.188.92]:36768) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mbP7y-0003iL-N9 for 50793@debbugs.gnu.org; Fri, 15 Oct 2021 11:28:11 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:34060) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mbP7t-0007UN-8h; Fri, 15 Oct 2021 11:28:05 -0400 Received: from [193.50.110.252] (port=58218 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mbP7s-0000QK-Vb; Fri, 15 Oct 2021 11:28:05 -0400 From: =?utf-8?Q?Ludovic_Court=C3=A8s?= To: Maxim Cournoyer Subject: Re: [bug#50793] [PATCH 0/2] cloudflare-cli and dependency JSON.sh References: <20210925013848.GA2384@singpolyma-beefy.lan> <20210926233513.3710-1-singpolyma@singpolyma.net> <87czo9s3b4.fsf_-_@gnu.org> <87lf2wwxvg.fsf@gmail.com> X-URL: http://www.fdn.fr/~lcourtes/ X-Revolutionary-Date: 24 =?utf-8?Q?Vend=C3=A9miaire?= an 230 de la =?utf-8?Q?R=C3=A9volution?= X-PGP-Key-ID: 0x090B11993D9AEBB5 X-PGP-Key: http://www.fdn.fr/~lcourtes/ludovic.asc X-PGP-Fingerprint: 3CE4 6455 8A84 FDC6 9DB4 0CFB 090B 1199 3D9A EBB5 X-OS: x86_64-pc-linux-gnu Date: Fri, 15 Oct 2021 17:28:03 +0200 In-Reply-To: <87lf2wwxvg.fsf@gmail.com> (Maxim Cournoyer's message of "Wed, 13 Oct 2021 15:03:31 -0400") Message-ID: <87bl3qi9z0.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 50793 Cc: Stephen Paul Weber , 50793@debbugs.gnu.org, iskarian@mgsn.dev X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Hi, Maxim Cournoyer skribis: > Ludovic Court=C3=A8s writes: > >> Hi, >> >> Stephen Paul Weber skribis: >> >>> * gnu/packages/serialization.scm (JSON.sh): New variable. >> >> Applied with the cosmetic changes below. > > Didn't we have some coding style preferring hyphens over '.' ? I can't > find any of this in our manual, but ISTR that there were some commits > made to adjust package names that had '.' in them. Ah, I wasn=E2=80=99t sure, but I can change it to a hyphen. Thanks! Ludo=E2=80=99. From unknown Sun Jun 22 22:47:00 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Sat, 13 Nov 2021 12:24:04 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator