GNU bug report logs - #50778
[PATCH] m4: Don't require courage on unsupported systems.

Previous Next

Package: guix-patches;

Reported by: Efraim Flashner <efraim <at> flashner.co.il>

Date: Fri, 24 Sep 2021 13:42:01 UTC

Severity: normal

Tags: patch

Done: Efraim Flashner <efraim <at> flashner.co.il>

Bug is archived. No further changes may be made.

Full log


Message #25 received at 50778-done <at> debbugs.gnu.org (full text, mbox):

From: Efraim Flashner <efraim <at> flashner.co.il>
To: Ludovic Courtès <ludo <at> gnu.org>, 50778-done <at> debbugs.gnu.org
Subject: Re: [bug#50778] [PATCH] m4: Don't require courage on unsupported
 systems.
Date: Tue, 14 Dec 2021 18:36:48 +0200
[Message part 1 (text/plain, inline)]
Finally took care of this today.

On Mon, Oct 18, 2021 at 03:15:54PM +0300, Efraim Flashner wrote:
> On Mon, Oct 18, 2021 at 10:43:54AM +0200, Ludovic Courtès wrote:
> > Hello!
> > 
> > Efraim Flashner <efraim <at> flashner.co.il> skribis:
> > 
> > > On Wed, Oct 13, 2021 at 11:00:16AM +0200, Ludovic Courtès wrote:
> > 
> > [...]
> > 
> > >> Yes, I’d rather mark i586-gnu as supported in m4/guix.m4 (it should have
> > >> been the case long ago) and keep the error and ‘--with-courage’ flag.
> > >> 
> > >> WDYT?
> > >
> > > I'm OK with changing i586-gnu to supported in m4/guix.m4. However, part
> > > of the plan was to make it so that we didn't have to have the
> > > --with-courage flag when building for mips64el, and so we could remove
> > > powerpc-linux so it would also say that it is unsupported but we
> > > wouldn't need people to make special versions of the guix package so
> > > they can try to build it. I can make it bigger and flashier, so it looks
> > > more like
> > 
> > Ah!  So I think you’re asking that there be three levels:
> > 
> >   1. Fully supported (should include i586-gnu).
> > 
> >   2. “Half supported” or “in the works”, like mips64el-linux and
> >      powerpc-linux: in that case, maybe just emit a warning with
> >      AC_MSG_WARN?
> > 
> >   3. Unsupported: error asking users to pass ‘--with-courage’.
> > 
> > How does that sound?
> 
> I hadn't really planned on keeping the third category, but thinking
> about it more it would make sense to keep it for architectures that we
> don't even have bootstrap binaries for. Vagrant said he was able to
> build the guix package for riscv64-linux, I think without even adding my
> patches for adding the bootstrap binaries. By forcing people to pass
> --with-courage it goes past "it doesn't really work" and all the way
> into "really really unsupported"
> 
> So yes, I like the idea of the three levels.
> 
> -- 
> Efraim Flashner   <efraim <at> flashner.co.il>   רנשלפ םירפא
> GPG key = A28B F40C 3E55 1372 662D  14F7 41AA E7DC CA3D 8351
> Confidentiality cannot be guaranteed on emails sent or received unencrypted



-- 
Efraim Flashner   <efraim <at> flashner.co.il>   רנשלפ םירפא
GPG key = A28B F40C 3E55 1372 662D  14F7 41AA E7DC CA3D 8351
Confidentiality cannot be guaranteed on emails sent or received unencrypted
[signature.asc (application/pgp-signature, inline)]

This bug report was last modified 3 years and 252 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.