From debbugs-submit-bounces@debbugs.gnu.org Thu Sep 23 13:59:56 2021 Received: (at submit) by debbugs.gnu.org; 23 Sep 2021 17:59:56 +0000 Received: from localhost ([127.0.0.1]:55800 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mTT0m-0000jo-1u for submit@debbugs.gnu.org; Thu, 23 Sep 2021 13:59:56 -0400 Received: from lists.gnu.org ([209.51.188.17]:35642) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mTT0l-0000ja-5N for submit@debbugs.gnu.org; Thu, 23 Sep 2021 13:59:55 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:52908) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mTT0k-0000Ja-QZ for guix-patches@gnu.org; Thu, 23 Sep 2021 13:59:54 -0400 Received: from tobias.gr ([2a02:c205:2020:6054::1]:59872) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mTT0i-0004yq-DL for guix-patches@gnu.org; Thu, 23 Sep 2021 13:59:54 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; s=2018; bh=hIAGlE4TSiBnP mp/kxhod9qhzDMjHGtF0K3mu74bUaI=; h=date:subject:to:from; d=tobias.gr; b=EK77ClHPMi2iBCP6gPxbMMSGO+a/o2o0iReBa1xapxFViu9oq6Zb/4vKiwCWWEx0sOHx ndZ2WiU0Qce7BYlrX8rjP2M371QnxN/zEb33Y2oI8W5FdOvvTOX9UnwLKfBMunazxnDqua yxwmXgYVWlVk7d/ecKs+p++Z+xQvQivHCuiU6PHJOfD1wEuuQCLiYqlGyVUuL5Q8+oGcCo RsMlOiXbx28mfUI4bJ1DC49vBgkq85vpX1pPsqzwgSnoabCtKxCS5kpL/PV2LR6sp/v3K1 4xsLhlS9BH3fVR9DQZcqN8y/YVdxbjHPfxGA7UNJPt9zEU1LSIcJZBt+paD1/X+w== Received: by submission.tobias.gr (OpenSMTPD) with ESMTPSA id cb73e9e9 (TLSv1.3:AEAD-AES256-GCM-SHA384:256:NO) for ; Thu, 23 Sep 2021 17:59:45 +0000 (UTC) From: Tobias Geerinckx-Rice To: guix-patches@gnu.org Subject: [PATCH] installer: Reorder file system type listbox. Date: Thu, 23 Sep 2021 19:59:50 +0200 Message-Id: <20210923175950.13586-1-me@tobias.gr> X-Mailer: git-send-email 2.33.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=2a02:c205:2020:6054::1; envelope-from=me@tobias.gr; helo=tobias.gr X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.6 (-) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.6 (--) Recommending ext4 over btrfs is probably ill-advised nowadays. See the regular bug reports about running out of /gnu/store directory entries, for which the documented fix then breaks booting with GRUB. Instead, just list regular file systems alphabetically. We can bikeshed bcachefs later ;-) Move second-class file systems like NTFS to their own section at the end of the list. * gnu/packages/package-management.scm (run-fs-type-page): Reorder the LISTBOX-ITEMS. --- gnu/installer/newt/partition.scm | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/gnu/installer/newt/partition.scm b/gnu/installer/newt/partition.scm index ea524eb4c3..70c11ed8ad 100644 --- a/gnu/installer/newt/partition.scm +++ b/gnu/installer/newt/partition.scm @@ -119,31 +119,35 @@ Be careful, all data on the disk will be lost.") '(extended))))) (run-listbox-selection-page #:info-text (G_ "Please select a partition type.") #:title (G_ "Partition type") #:listbox-items items #:listbox-item->text symbol->string #:sort-listbox-items? #f #:button-text (G_ "Exit") #:button-callback-procedure button-exit-action))) (define (run-fs-type-page) "Run a page asking the user to select a file-system type." (run-listbox-selection-page #:info-text (G_ "Please select the file-system type for this partition.") #:title (G_ "File-system type") - #:listbox-items '(ext4 btrfs fat16 fat32 jfs ntfs xfs swap) + #:listbox-items '(btrfs ext4 jfs xfs + swap + ;; These lack basic Unix features. Their only use + ;; on GNU is for interoperation, e.g., with UEFI. + fat32 fat16 ntfs) #:listbox-item->text user-fs-type-name #:sort-listbox-items? #f #:button-text (G_ "Exit") #:button-callback-procedure button-exit-action)) (define (inform-can-create-partition? user-partition) "Return #t if it is possible to create USER-PARTITION. This is determined by calling CAN-CREATE-PARTITION? procedure. If an exception is raised, catch it an inform the user with an appropriate error-page and return #f." (guard (c ((max-primary-exceeded? c) (run-error-page (G_ "Primary partitions count exceeded.") (G_ "Creation error")) #f) ((extended-creation-error? c) -- 2.33.0 From debbugs-submit-bounces@debbugs.gnu.org Fri Sep 24 17:24:25 2021 Received: (at 50768) by debbugs.gnu.org; 24 Sep 2021 21:24:25 +0000 Received: from localhost ([127.0.0.1]:59353 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mTsgD-0006L7-F7 for submit@debbugs.gnu.org; Fri, 24 Sep 2021 17:24:25 -0400 Received: from mail-4322.protonmail.ch ([185.70.43.22]:17883) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mTsgB-0006Kl-0H for 50768@debbugs.gnu.org; Fri, 24 Sep 2021 17:24:23 -0400 Date: Fri, 24 Sep 2021 21:24:11 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=protonmail.com; s=protonmail; t=1632518656; bh=anOOtdKuX10ilH1SmFbvuDjhj7KGIjJjWJx47bwyNZ4=; h=Date:To:From:Reply-To:Subject:From; b=hTD1dz4aY2fpg6+L9EgdF6FVzGyghw5qpDjw+T4M06eNM0vGfLZSx5Tir5aqmaqgy wMZW45zsPv5aXWiN7Qt65AHI+rF7VS3qQXnmvupEiHclwU4YmvNiPbBYMdOc9XOrCy giFUyePrb0MV5tRZS59uIrugm2FqQT7/j6yTP/Zg= To: "50768@debbugs.gnu.org" <50768@debbugs.gnu.org> From: John Kehayias Subject: [PATCH] installer: Reorder file system type listbox. Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-1.2 required=10.0 tests=ALL_TRUSTED,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM shortcircuit=no autolearn=disabled version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on mailout.protonmail.ch X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 50768 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: John Kehayias Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hello, On this front, a related issue has been ext4 and large directories in Guix.= Namely, that /gnu/store/.links quickly has many, many files (I'm at 9.9 mi= llion right now). This leads to warnings on ext4 and usually one will find = that enabling large_dir will increase the file directory cap. Unfortunately= , that is not compatible with Grub. This is what happened to me and was a b= it of a mess (I reinstalled with Btrfs), and I know you (Tobias) also saw t= his in this thread: https://lists.gnu.org/archive/html/help-guix/2020-06/ms= g00015.html So to the patch at hand, I'm wondering if we should make a note of this in = file system selection in the installer (and in the manual in a few places).= I don't know the actual ramifications of getting those directory full warn= ings in ext4, but I can see it easily leading to a problem booting a system= with large_dir, as happened to me. I've submitted a bug to Grub, though th= is is well known, without response in plans to support a 4-year-old ext4 op= tion. Since we expect Guix to have this huge directory, at least currently,= I think we could avoid this issue with some warnings. Sorry if this is a little astray for this patch, but thought it would be go= od to bring up. Thanks, John From debbugs-submit-bounces@debbugs.gnu.org Wed Oct 13 04:58:01 2021 Received: (at 50768) by debbugs.gnu.org; 13 Oct 2021 08:58:01 +0000 Received: from localhost ([127.0.0.1]:58204 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1maa5I-000424-Vo for submit@debbugs.gnu.org; Wed, 13 Oct 2021 04:58:01 -0400 Received: from eggs.gnu.org ([209.51.188.92]:47922) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1maa5H-00041W-An for 50768@debbugs.gnu.org; Wed, 13 Oct 2021 04:57:59 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:50458) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1maa5B-0003KN-7g; Wed, 13 Oct 2021 04:57:53 -0400 Received: from 91-160-117-201.subs.proxad.net ([91.160.117.201]:58954 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1maa56-0002E8-Ou; Wed, 13 Oct 2021 04:57:51 -0400 From: =?utf-8?Q?Ludovic_Court=C3=A8s?= To: Tobias Geerinckx-Rice Subject: Re: bug#50768: [PATCH] installer: Reorder file system type listbox. References: <20210923175950.13586-1-me@tobias.gr> Date: Wed, 13 Oct 2021 10:57:47 +0200 In-Reply-To: <20210923175950.13586-1-me@tobias.gr> (Tobias Geerinckx-Rice's message of "Thu, 23 Sep 2021 19:59:50 +0200") Message-ID: <87lf2xs3n8.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 50768 Cc: 50768@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Hello, Tobias Geerinckx-Rice skribis: > Recommending ext4 over btrfs is probably ill-advised nowadays. See the > regular bug reports about running out of /gnu/store directory entries, > for which the documented fix then breaks booting with GRUB. I=E2=80=99ve seen Keyras mention such a problem here, but again, I have not= seen =E2=80=9Cregular bug reports=E2=80=9D. Are there open bug reports about ex= t4 issues? What I do regularly see is rants about ext4 :-), which might be justified, but in my many years with a store I have never had problems with ext4. Also, the deduplication code gracefully handles ENOSPC on /gnu/store/.links. > Instead, just list regular file systems alphabetically. We can bikeshed > bcachefs later ;-) > > Move second-class file systems like NTFS to their own section at the end > of the list. > > * gnu/packages/package-management.scm (run-fs-type-page): Reorder the > LISTBOX-ITEMS. Otherwise LGTM, thanks! Ludo=E2=80=99. From debbugs-submit-bounces@debbugs.gnu.org Thu Oct 21 15:03:59 2021 Received: (at 50768) by debbugs.gnu.org; 21 Oct 2021 19:03:59 +0000 Received: from localhost ([127.0.0.1]:58570 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mddM7-0003yM-Ed for submit@debbugs.gnu.org; Thu, 21 Oct 2021 15:03:59 -0400 Received: from tobias.gr ([80.241.217.52]:53328) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mddM5-0003yA-70 for 50768@debbugs.gnu.org; Thu, 21 Oct 2021 15:03:57 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; s=2018; bh=i5CfYLIVoB2m3 Flatjnh9ZHHWZWYEj2eDvNjju9RGu4=; h=in-reply-to:date:subject:cc:to: from:references; d=tobias.gr; b=fTfCYzOxYAoMElvn1MJKdzfotWjUQY2A5KUkZv mz5pi0iDBQR/Aa/ImKIEbYKTym1dPPX79vaJB1GfTQe4N5elrH/AojMzHWcnF+DH3CZRIc 4D96yHACh3q/Ifa1fPy5CU3uJ5rMIDxs3fB9ICtLSzKdZvBnFHn9o6HrsBGIh2FMHaw78V yOJMWrX5r7UcDZTVhZwcdHHMyeqGgul0K8+aoxGQBZTq3JPQPczdM4wRCCjwglh5QHrsxB D/gWQZK9JWKKYI0/NvsJer/FwBgNOmylKXY++SJy8AEi6liQzknQ6oD2RTveSerUMMN14l v3aG7k40Tf01WN5AnGNToBgw== Received: by submission.tobias.gr (OpenSMTPD) with ESMTPSA id 79e08be3 (TLSv1.3:AEAD-AES256-GCM-SHA384:256:NO); Thu, 21 Oct 2021 19:03:51 +0000 (UTC) References: <20210923175950.13586-1-me@tobias.gr> <87lf2xs3n8.fsf@gnu.org> From: Tobias Geerinckx-Rice To: Ludovic =?utf-8?Q?Court=C3=A8s?= Subject: Re: bug#50768: [PATCH] installer: Reorder file system type listbox. Date: Thu, 21 Oct 2021 20:41:53 +0200 In-reply-to: <87lf2xs3n8.fsf@gnu.org> BIMI-Selector: v=BIMI1; s=default; Message-ID: <87y26m5het.fsf@nckx> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 50768 Cc: 50768@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --=-=-= Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: quoted-printable Ludo', Ludovic Court=C3=A8s =E5=86=99=E9=81=93=EF=BC=9A > I=E2=80=99ve seen Keyras mention such a problem here, but again, I have=20 > not seen > =E2=80=9Cregular bug reports=E2=80=9D. I've seen enough. s/bug reports/worried questions, not always=20 prior to messing with file system options/ for accuracy. > Are there open bug reports about ext4 issues? =20=20 As in issues: no idea. I would expect them to be closed, so it's=20 not much of a metric. > What I do regularly see is rants about ext4 :-), which might be > justified, but in my many years with a store I have never had=20 > problems > with ext4. Also, the deduplication code gracefully handles=20 > ENOSPC on > /gnu/store/.links. The kernel doesn't discriminate and logs warnings. Several people=20 do notice these, don't realise that they are =E2=80=98harmless=E2=80=99, an= d=20 follow some on-line tutorial to enable large_dir. Which=20 apparently breaks GRUB. None of this is Guix's fault. It does happen. I'm not happy with this patch: it's the tiniest possible tweak and=20 puts a lot of implicit meaning into the default ordering. I didn't find a good way to dynamically display a description of=20 each file system, but I wouldn't know what kind of Newt UI=20 primitives/concepts to search for. Kind regards, T G-R --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iIMEARYKACsWIQT12iAyS4c9C3o4dnINsP+IT1VteQUCYXG5mg0cbWVAdG9iaWFz LmdyAAoJEA2w/4hPVW15NeQBAMsnCBzpSyuHqhiOKvAzuWjUU/ZFrOsBO3fHHGfC kPywAQCKyFLnJeMLUovntmhTamRJPlCI0dvbr8bBNMbDJCd5Dw== =5sE6 -----END PGP SIGNATURE----- --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Mon Oct 25 05:30:05 2021 Received: (at 50768) by debbugs.gnu.org; 25 Oct 2021 09:30:05 +0000 Received: from localhost ([127.0.0.1]:41669 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mewIu-0007Oi-TY for submit@debbugs.gnu.org; Mon, 25 Oct 2021 05:30:05 -0400 Received: from eggs.gnu.org ([209.51.188.92]:41626) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mewIt-0007Nk-1T for 50768@debbugs.gnu.org; Mon, 25 Oct 2021 05:30:03 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:35394) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mewIm-00071M-Uu; Mon, 25 Oct 2021 05:29:56 -0400 Received: from [2001:660:6102:320:e120:2c8f:8909:cdfe] (port=51378 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mewIm-00068V-LS; Mon, 25 Oct 2021 05:29:56 -0400 From: =?utf-8?Q?Ludovic_Court=C3=A8s?= To: Tobias Geerinckx-Rice Subject: ext4 & btrfs References: <20210923175950.13586-1-me@tobias.gr> <87lf2xs3n8.fsf@gnu.org> <87y26m5het.fsf@nckx> X-URL: http://www.fdn.fr/~lcourtes/ X-Revolutionary-Date: 4 Brumaire an 230 de la =?utf-8?Q?R=C3=A9volution?= X-PGP-Key-ID: 0x090B11993D9AEBB5 X-PGP-Key: http://www.fdn.fr/~lcourtes/ludovic.asc X-PGP-Fingerprint: 3CE4 6455 8A84 FDC6 9DB4 0CFB 090B 1199 3D9A EBB5 X-OS: x86_64-pc-linux-gnu Date: Mon, 25 Oct 2021 11:29:54 +0200 In-Reply-To: <87y26m5het.fsf@nckx> (Tobias Geerinckx-Rice's message of "Thu, 21 Oct 2021 20:41:53 +0200") Message-ID: <87bl3dmoz1.fsf_-_@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 50768 Cc: 50768@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Hello, Tobias Geerinckx-Rice skribis: > Ludovic Court=C3=A8s =E5=86=99=E9=81=93=EF=BC=9A [...] >> What I do regularly see is rants about ext4 :-), which might be >> justified, but in my many years with a store I have never had >> problems >> with ext4. Also, the deduplication code gracefully handles ENOSPC >> on >> /gnu/store/.links. > > The kernel doesn't discriminate and logs warnings. What do those warnings look like? > Several people do notice these, don't realise that they are > =E2=80=98harmless=E2=80=99, and follow some on-line tutorial to enable la= rge_dir. > Which apparently breaks GRUB. > > None of this is Guix's fault. It does happen. Oh, so it=E2=80=99s some tutorial out there that leads users to use =E2=80= =98large_dir=E2=80=99 when they see those warnings? Bah. > I'm not happy with this patch: it's the tiniest possible tweak and > puts a lot of implicit meaning into the default ordering. Yeah. That said, recommending btrfs (it=E2=80=99s now the first and default choic= e) has implications. It has its pros, but it doesn=E2=80=99t come for free ei= ther in terms of usability and observable change in behavior in some cases. For example, we=E2=80=99ll likely see reports of test suites that fail on u= ser machines (btrfs) but work on our build farms (ext4). So I think we should be careful here. Another option would be to document the =E2=80=98large_dir=E2=80=99 limitat= ion, or to use a newer GRUB if that limitation has been addressed in the meantime? WDYT? Thanks, Ludo=E2=80=99.