GNU bug report logs - #50767
28.0.50; Warnings about snprintf in image.c on armv7l

Previous Next

Full log

View this message in rfc822 format

From: "Basil L. Contovounesios" <contovob <at> tcd.ie>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: 50767 <at> debbugs.gnu.org, alan <at> idiocy.org
Subject: bug#50767: 28.0.50; Warnings about snprintf in image.c on armv7l
Date: Thu, 14 Oct 2021 17:37:23 +0100

Eli Zaretskii [2021-10-14 12:01 -0400] wrote:

>> From: "Basil L. Contovounesios" <contovob <at> tcd.ie>
>> Cc: Alan Third <alan <at> idiocy.org>,  50767 <at> debbugs.gnu.org
>> Date: Thu, 14 Oct 2021 16:42:24 +0100
>> 
>> > AFAIR, there's no need to check the return value of xmalloc, because
>> > it doesn't return if it cannot allocate memory.
>> 
>> Are you thinking about xalloc?
>
> No, I'm thinking xmalloc.
>
>> If not, could you please point me to the part of xmalloc that
>> doesn't return (except for the !initialized branch in memory_full)?
>> I'm afraid I couldn't spot it.
>
> This part:
>
>   if (!val && size)
>     memory_full (size);

Sorry, I thought xsignal in memory_full would return, because I confused
it with nonlocal exits in dynamic modules which do.

Thanks,

-- 
Basil

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.