GNU bug report logs - #50767
28.0.50; Warnings about snprintf in image.c on armv7l

Previous Next

Full log

View this message in rfc822 format

From: "Basil L. Contovounesios" <contovob <at> tcd.ie>
To: Alan Third <alan <at> idiocy.org>
Cc: 50767 <at> debbugs.gnu.org
Subject: bug#50767: 28.0.50; Warnings about snprintf in image.c on armv7l
Date: Thu, 14 Oct 2021 16:43:05 +0100

Alan Third [2021-10-04 22:45 +0100] wrote:

> On Thu, Sep 23, 2021 at 11:49:37PM +0100, Alan Third wrote:
>> On Thu, Sep 23, 2021 at 11:38:06PM +0100, Basil L. Contovounesios wrote:
>> > ...which would mean this only holds in the common case that
>> > face_font_size has fewer than 5 digits, right?
>> 
>> Looks that way.
>> 
>> I suppose in this particular case we could limit the font size to a
>> maximum of 9999 or something, but surely there's a better way of
>> calculating string sizes?
>
> I've implemented a pretty basic check so we shouldn't accidentally
> overrun the buffer. See attached.

Thanks, and sorry for the late reply.  I haven't had a chance to compile
this on armv7l yet, but I should be able to later today or tomorrow.  It
continues to compile without warnings on x86_64.

-- 
Basil

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.