From debbugs-submit-bounces@debbugs.gnu.org Thu Sep 23 11:57:01 2021 Received: (at submit) by debbugs.gnu.org; 23 Sep 2021 15:57:02 +0000 Received: from localhost ([127.0.0.1]:55592 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mTR5p-0001Cd-NH for submit@debbugs.gnu.org; Thu, 23 Sep 2021 11:57:01 -0400 Received: from lists.gnu.org ([209.51.188.17]:38568) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mTR5o-0001CQ-5c for submit@debbugs.gnu.org; Thu, 23 Sep 2021 11:57:00 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:55248) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mTR5n-0000ob-UB for bug-gnu-emacs@gnu.org; Thu, 23 Sep 2021 11:56:59 -0400 Received: from forward106p.mail.yandex.net ([2a02:6b8:0:1472:2741:0:8b7:109]:41382) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mTR5k-00027C-No for bug-gnu-emacs@gnu.org; Thu, 23 Sep 2021 11:56:59 -0400 Received: from iva3-d53c26eb10e1.qloud-c.yandex.net (iva3-d53c26eb10e1.qloud-c.yandex.net [IPv6:2a02:6b8:c0c:4987:0:640:d53c:26eb]) by forward106p.mail.yandex.net (Yandex) with ESMTP id 08BEC2FC03FB for ; Thu, 23 Sep 2021 18:56:49 +0300 (MSK) Received: from iva1-6c7d234f141c.qloud-c.yandex.net (iva1-6c7d234f141c.qloud-c.yandex.net [2a02:6b8:c0c:972c:0:640:6c7d:234f]) by iva3-d53c26eb10e1.qloud-c.yandex.net (mxback/Yandex) with ESMTP id TTgZVJXv37-umEKLgmM; Thu, 23 Sep 2021 18:56:48 +0300 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yandex.ru; s=mail; t=1632412608; bh=JZN00hdN4yNIPYkGb6XGIrgqlHyWGDngmeT7mP9ttnI=; h=Date:To:From:Subject:Message-ID; b=hYwMk+Ov9xEOuaE8JW4AGcRToILM9qEQKn2m5ucrTDcHm21xw6ZMlbBnpcSwrsEaF vvw5lqoNASKa6DR6s1YbjHsEVGQgzjCUm4Wqxot69J3byRMvHIQZ5T44AQXPRWyuwi hcQ5J9rrLaxzL2inCQcNtWCX68srxekmzhH4+n4w= Authentication-Results: iva3-d53c26eb10e1.qloud-c.yandex.net; dkim=pass header.i=@yandex.ru Received: by iva1-6c7d234f141c.qloud-c.yandex.net (smtp/Yandex) with ESMTPSA id TPAoJ7ZEMD-umxOe79C; Thu, 23 Sep 2021 18:56:48 +0300 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (Client certificate not present) Message-ID: Subject: diff-update-on-the-fly doesn't update hunk headers while regexp-replacing lines From: Konstantin Kharlamov To: bug-gnu-emacs@gnu.org Date: Thu, 23 Sep 2021 18:56:48 +0300 Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.40.4 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=2a02:6b8:0:1472:2741:0:8b7:109; envelope-from=hi-angel@yandex.ru; helo=forward106p.mail.yandex.net X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) As title says. I think due to this bug it would make sense to have diff-update-on-the-fly set to nil by default. # Steps to reproduce 1. In Emacs repo, `git checkout 72f8a9dd08132119a` (arbitrary commit for the sake of testcase) 2. Create a patch from Emacs repo with `git format-patch -1 --stdout > /tmp/1.patch`, open it. 3. Note that 1st hunk has value `-2883,10 +2883,13` 4. Use regexp-replace aka `C-M-%` with `(.*^J\+.* → line1` (please replace ^J here with C-q C-j) 5. When asked for matches, press `!`, so all lines are replaced 6. Look at the first hunk again ## Expected It changes its value to recalculation that should be happening ## Actual It still has the older value, no recalculation has happened. From debbugs-submit-bounces@debbugs.gnu.org Thu May 22 04:26:03 2025 Received: (at 50762) by debbugs.gnu.org; 22 May 2025 08:26:03 +0000 Received: from localhost ([127.0.0.1]:59634 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1uI1Fb-0005nY-2X for submit@debbugs.gnu.org; Thu, 22 May 2025 04:26:03 -0400 Received: from forward500b.mail.yandex.net ([2a02:6b8:c02:900:1:45:d181:d500]:49514) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1uI1FW-0005me-3a for 50762@debbugs.gnu.org; Thu, 22 May 2025 04:25:59 -0400 Received: from mail-nwsmtp-smtp-production-main-67.sas.yp-c.yandex.net (mail-nwsmtp-smtp-production-main-67.sas.yp-c.yandex.net [IPv6:2a02:6b8:c11:4ab1:0:640:c3ad:0]) by forward500b.mail.yandex.net (Yandex) with ESMTPS id 427DA60EDC for <50762@debbugs.gnu.org>; Thu, 22 May 2025 11:25:49 +0300 (MSK) Received: by mail-nwsmtp-smtp-production-main-67.sas.yp-c.yandex.net (smtp/Yandex) with ESMTPSA id mPKKE7KLjuQ0-2LT0uCmj; Thu, 22 May 2025 11:25:49 +0300 X-Yandex-Fwd: 1 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yandex.ru; s=mail; t=1747902349; bh=+LMOZoGcnsXxbvFeFz/hi3nTwsCfq5sRBD+pZqRRRUM=; h=In-Reply-To:Date:References:To:From:Subject:Message-ID; b=H8V5vjDpaX8DS6E91sqV9weLwq27T18rvVYjmNxssz97wxLePi5vhGe6sJiX9QQUV m6/Gum4NcFG02JLvrq+8X4lMrQ/MTNTg1TMhmN0teL5mRsNnbN7Uu2okBBbDs8WMXf X78Ee/llELEp+lAwm/FWSPBW0ZKp7WrPj8NQYxwQ= Authentication-Results: mail-nwsmtp-smtp-production-main-67.sas.yp-c.yandex.net; dkim=pass header.i=@yandex.ru Message-ID: Subject: Re: bug#50762: diff-update-on-the-fly doesn't update hunk headers while regexp-replacing lines From: Konstantin Kharlamov To: 50762@debbugs.gnu.org Date: Thu, 22 May 2025 11:25:48 +0300 In-Reply-To: References: Content-Type: multipart/mixed; boundary="=-yPap8G1RG5Zx5rz65q7J" User-Agent: Evolution 3.56.1 MIME-Version: 1.0 X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 50762 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) --=-yPap8G1RG5Zx5rz65q7J Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Seems fixed on master. I don't know when exactly it was fixed, I was running all that time with diff-update-on-the-fly set to nil. But just as I was writing a workaround patch (attached for history purposes, in case it might be useful at some point, but right now it isn't), I tested and it turns out both query-replace-regexp as well as delete- matching-lines result in hunks being updated on the fly. So bug has been fixed, the report can be closed. --=-yPap8G1RG5Zx5rz65q7J Content-Disposition: attachment; filename="1.patch" Content-Type: text/x-patch; name="1.patch"; charset="UTF-8" Content-Transfer-Encoding: base64 RnJvbSBkOTAyNDgwOWYwOGE5YTY4NzI5N2M3Y2VlYjVmZWMzN2FlNmNjYTIxIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBLb25zdGFudGluIEtoYXJsYW1vdiA8SGktQW5nZWxAeWFuZGV4 LnJ1PgpEYXRlOiBUaHUsIDIyIE1heSAyMDI1IDEwOjUzOjQ5ICswMzAwClN1YmplY3Q6IFtQQVRD SF0gZGlmZi1tb2RlOiBhbHdheXMgdXBkYXRlIGh1bmtzIG9uIHNhdmUgKGJ1ZyM1MDc2MikKCkRp ZmYtbW9kZSBkZWZhdWx0cyB0byB1cGRhdGluZyBodW5rcyBvbiB0aGUgZmx5LCB3aGljaCBoYXMg YSBidWcgdGhhdApub3QgZXZlcnkgYnVmZmVyIGNoYW5nZSBhY3R1YWxseSB0cmlnZ2VycyB0aGUg dXBkYXRlLiAgSW4gcGFydGljdWxhciwKdXNpbmcgYHF1ZXJ5LXJlcGxhY2UnIG92ZXIgdGhlIGJ1 ZmZlciBkb2Vzbid0IHRyaWdnZXIgdGhhdC4gIFdvcmsKYXJvdW5kIHRoZSBwcm9ibGVtIGJ5IGlu dm9raW5nIHRoZSB1cGRhdGUgb24gc2F2ZSB1bmNvbmRpdGlvbmFsbHkuCgoqIGxpc3AvdmMvZGlm Zi1tb2RlLmVsIChkaWZmLW1vZGUpOiBGYWN0b3Igb3V0IHNldHRpbmcgdXAgY2hhbmdlIGhvb2tz CnRvIGEgc2VwYXJhdGUgZnVuY3Rpb24gYGRpZmYtLXNldHVwLWNoYW5nZS1ob29rcycuCihkaWZm LW1pbm9yLW1vZGUpOiBGYWN0b3Igb3V0IHNldHRpbmcgdXAgY2hhbmdlIGhvb2tzIHRvIGEgc2Vw YXJhdGUKbmN0aW9uIGBkaWZmLS1zZXR1cC1jaGFuZ2UtaG9va3MnLCBhbmQgc3RvcCByZW1vdmlu ZwppZmYtd3JpdGUtY29udGVudHMtaG9va3MnIHNpbmNlIGl0IGlzIG5vdyBhZGRlZCB1bmNvbmRp dGlvbmFsbHkuCihkaWZmLS1zZXR1cC1jaGFuZ2UtaG9va3MpOiBOZXcgZnVuY3Rpb24gdG8gc2V0 IHVwIGRpZmYtbW9kZSBob29rcywKd2l0aCB0aGUgY29kZSBiZWluZyBmYWN0b3JlZCBvdXQgb2Yg ZGlmZiBtYWpvciBhbmQgbWlub3IgbW9kZXMKZGVmaW5pdGlvbiwgd2l0aCB0aGUgY2hhbmdlIHRo YXQgaHVua3MgYXJlIG5vdyB1cGRhdGVkCnVuY29uZGl0aW9uYWxseS4KLS0tCiBsaXNwL3ZjL2Rp ZmYtbW9kZS5lbCB8IDIyICsrKysrKysrKysrLS0tLS0tLS0tLS0KIDEgZmlsZSBjaGFuZ2VkLCAx MSBpbnNlcnRpb25zKCspLCAxMSBkZWxldGlvbnMoLSkKCmRpZmYgLS1naXQgYS9saXNwL3ZjL2Rp ZmYtbW9kZS5lbCBiL2xpc3AvdmMvZGlmZi1tb2RlLmVsCmluZGV4IDQ1OTE1NGY1MzRiLi40NTJk MzJhNzU2ZiAxMDA2NDQKLS0tIGEvbGlzcC92Yy9kaWZmLW1vZGUuZWwKKysrIGIvbGlzcC92Yy9k aWZmLW1vZGUuZWwKQEAgLTE2MDIsNiArMTYwMiwxNSBAQCBkaWZmLW1vZGUtcmVhZC1vbmx5CiAo ZGVmdmFyIHdoaXRlc3BhY2Utc3R5bGUpCiAoZGVmdmFyIHdoaXRlc3BhY2UtdHJhaWxpbmctcmVn ZXhwKQogCisoZGVmdW4gZGlmZi0tc2V0dXAtY2hhbmdlLWhvb2tzICgpCisgIDs7IFVwZGF0ZSBo dW5rcyBvbiBzYXZlIGRpc3JlZ2FyZGluZyB0aGUgYGRpZmYtdXBkYXRlLW9uLXRoZS1mbHknCisg IDs7IHNpbmNlIHNvbWUgY2hhbmdlcyBsaWtlIGBxdWVyeS1yZXBsYWNlJyBkb24ndCB0cmlnZ2Vy IGF1dG8tdXBkYXRlcywKKyAgOzsgc28gdGhleSBtYXkgbm90IGJlIHZhbGlkLiAoYnVnIzUwNzYy KQorICAoYWRkLWhvb2sgJ3dyaXRlLWNvbnRlbnRzLWZ1bmN0aW9ucyAjJ2RpZmYtd3JpdGUtY29u dGVudHMtaG9va3MgbmlsIHQpCisgICh3aGVuIGRpZmYtdXBkYXRlLW9uLXRoZS1mbHkKKyAgICAo c2V0cSBkaWZmLS10cmFjay1jaGFuZ2VzCisgICAgICAgICAgKHRyYWNrLWNoYW5nZXMtcmVnaXN0 ZXIgIydkaWZmLS10cmFjay1jaGFuZ2VzLXNpZ25hbCA6bm9iZWZvcmUgdCkpKSkKKwogOzsgUHJl dmVudCBhcHBseWluZyBgdmlldy1yZWFkLW9ubHknIHRvIGRpZmYtbW9kZSBidWZmZXJzIChidWcj NzU5OTMpLgogOzsgV2UgZG9uJ3QgZGVyaXZlIGZyb20gYHNwZWNpYWwtbW9kZScgYmVjYXVzZSB0 aGF0IHdvdWxkIGluaGliaXQgdGhlCiA7OyBgc2VsZi1pbnNlcnQtY29tbWFuZCcgYmluZGluZyBv ZiBub3JtYWwga2V5cy4KQEAgLTE2NTMsMTEgKzE2NjIsNyBAQCBkaWZmLW1vZGUKICAgICAgICAg ICAgICAgKHNldHEgZGlmZi1tb2RlLXJlYWQtb25seSBidWZmZXItcmVhZC1vbmx5KSkKICAgICAg ICAgICAgIG5pbCB0KQogCi0gIDs7IHNldHVwIGNoYW5nZSBob29rcwotICAoaWYgKG5vdCBkaWZm LXVwZGF0ZS1vbi10aGUtZmx5KQotICAgICAgKGFkZC1ob29rICd3cml0ZS1jb250ZW50cy1mdW5j dGlvbnMgIydkaWZmLXdyaXRlLWNvbnRlbnRzLWhvb2tzIG5pbCB0KQotICAgIChzZXRxIGRpZmYt LXRyYWNrLWNoYW5nZXMKLSAgICAgICAgICAodHJhY2stY2hhbmdlcy1yZWdpc3RlciAjJ2RpZmYt LXRyYWNrLWNoYW5nZXMtc2lnbmFsIDpub2JlZm9yZSB0KSkpCisgIChkaWZmLS1zZXR1cC1jaGFu Z2UtaG9va3MpCiAKICAgOzsgYWRkLWxvZyBzdXBwb3J0CiAgIChzZXRxLWxvY2FsIGFkZC1sb2ct Y3VycmVudC1kZWZ1bi1mdW5jdGlvbiAjJ2RpZmYtY3VycmVudC1kZWZ1bikKQEAgLTE2NzksMTMg KzE2ODQsOCBAQCBkaWZmLW1pbm9yLW1vZGUKICAgKHdoZW4gZGlmZi0tdHJhY2stY2hhbmdlcwog ICAgICh0cmFjay1jaGFuZ2VzLXVucmVnaXN0ZXIgZGlmZi0tdHJhY2stY2hhbmdlcykKICAgICAo c2V0cSBkaWZmLS10cmFjay1jaGFuZ2VzIG5pbCkpCi0gIChyZW1vdmUtaG9vayAnd3JpdGUtY29u dGVudHMtZnVuY3Rpb25zICMnZGlmZi13cml0ZS1jb250ZW50cy1ob29rcyB0KQogICAod2hlbiBk aWZmLW1pbm9yLW1vZGUKLSAgICAoaWYgKG5vdCBkaWZmLXVwZGF0ZS1vbi10aGUtZmx5KQotICAg ICAgICAoYWRkLWhvb2sgJ3dyaXRlLWNvbnRlbnRzLWZ1bmN0aW9ucyAjJ2RpZmYtd3JpdGUtY29u dGVudHMtaG9va3MgbmlsIHQpCi0gICAgICAoc2V0cSBkaWZmLS10cmFjay1jaGFuZ2VzCi0gICAg ICAgICAgICAodHJhY2stY2hhbmdlcy1yZWdpc3RlciAjJ2RpZmYtLXRyYWNrLWNoYW5nZXMtc2ln bmFsCi0gICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICA6bm9iZWZvcmUgdCkpKSkp CisgICAgKGRpZmYtLXNldHVwLWNoYW5nZS1ob29rcykpKQogCiA7OzsgSGFuZHkgaG9vayBmdW5j dGlvbnMgOzs7Ozs7Ozs7Ozs7Ozs7Ozs7Ozs7Ozs7Ozs7Ozs7Ozs7Ozs7Ozs7Ozs7Ozs7Ozs7Ozs7 OwogCi0tIAoyLjQ5LjAKCg== --=-yPap8G1RG5Zx5rz65q7J-- From debbugs-submit-bounces@debbugs.gnu.org Thu May 22 04:47:00 2025 Received: (at 50762-done) by debbugs.gnu.org; 22 May 2025 08:47:00 +0000 Received: from localhost ([127.0.0.1]:59749 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1uI1Zs-0006ut-4j for submit@debbugs.gnu.org; Thu, 22 May 2025 04:47:00 -0400 Received: from forward100b.mail.yandex.net ([178.154.239.147]:58118) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1uI1Zo-0006uU-97 for 50762-done@debbugs.gnu.org; Thu, 22 May 2025 04:46:57 -0400 Received: from mail-nwsmtp-smtp-production-main-73.sas.yp-c.yandex.net (mail-nwsmtp-smtp-production-main-73.sas.yp-c.yandex.net [IPv6:2a02:6b8:c37:f37c:0:640:1e45:0]) by forward100b.mail.yandex.net (Yandex) with ESMTPS id B055960E85 for <50762-done@debbugs.gnu.org>; Thu, 22 May 2025 11:46:47 +0300 (MSK) Received: by mail-nwsmtp-smtp-production-main-73.sas.yp-c.yandex.net (smtp/Yandex) with ESMTPSA id kkKiqgKLbuQ0-scZej44Z; Thu, 22 May 2025 11:46:47 +0300 X-Yandex-Fwd: 1 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yandex.ru; s=mail; t=1747903607; bh=m/DmI8f/MICcW0PZVlMLeJMMtSTZuELQ69siH+dK8OA=; h=Date:To:From:Subject:Message-ID; b=O/HuVJjRFOqgjV+sd4v02SbPm6S86wBtBNed2wccLbNIhDGkYZOdR2zHrFWMRa45F IcNsk0QCcZEzCrVRxwmwXABKReq1pZ9EKK/Z08VXVZouA0c3f6dkuMDIdRKGROVjgg K1Pbodn4Hdgl50zdqXd3YvgtabftyCSNIFeNR4eU= Authentication-Results: mail-nwsmtp-smtp-production-main-73.sas.yp-c.yandex.net; dkim=pass header.i=@yandex.ru Message-ID: <411446547bfeef624a04e3790cd1ddbb0eeeb84e.camel@yandex.ru> Subject: From: Konstantin Kharlamov To: 50762-done@debbugs.gnu.org Date: Thu, 22 May 2025 11:46:46 +0300 Content-Type: text/plain Content-Transfer-Encoding: 7bit User-Agent: Evolution 3.56.1 MIME-Version: 1.0 X-Spam-Score: 2.0 (++) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: Thus, closing Content analysis details: (2.0 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 0.0 RCVD_IN_VALIDITY_RPBL_BLOCKED RBL: ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. [178.154.239.147 listed in bl.score.senderscore.com] 0.0 RCVD_IN_VALIDITY_CERTIFIED_BLOCKED RBL: ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. [178.154.239.147 listed in sa-accredit.habeas.com] 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.0 SPF_PASS SPF: sender matches SPF record 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (hi-angel[at]yandex.ru) 2.0 BLANK_SUBJECT Subject is present but empty X-Debbugs-Envelope-To: 50762-done X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 1.0 (+) Thus, closing From debbugs-submit-bounces@debbugs.gnu.org Thu May 22 05:51:40 2025 Received: (at 50762-done) by debbugs.gnu.org; 22 May 2025 09:51:40 +0000 Received: from localhost ([127.0.0.1]:60178 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1uI2aR-0003lk-JN for submit@debbugs.gnu.org; Thu, 22 May 2025 05:51:39 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:34294) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1uI2aM-0003lC-5A for 50762-done@debbugs.gnu.org; Thu, 22 May 2025 05:51:35 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uI2aG-0000X9-Hi; Thu, 22 May 2025 05:51:28 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=NXjFyArdhM719LlMf/Pfp+Zpy9/qwUsEm5LqB9OUMDw=; b=pPNy1g0O6Pi6 zchiiBqz2VHLTwWLQt9BOcKOeFex3wD8d9ihOD2aiJeq/8ut7kanX0kK/k6nmu1R7Gaqyo/pC1FGB w+EEFSh8IeAHyqcVOCct1Aps0BuaJ15B8jP5nZR6AiNeuaI6RA+PkJB3WVhhn+fbQq69/WCDiEHup EhA99tKPkk1ILR/WhrTy1d54fn9ZoqlcjdrvKO7zC9ypHDxcZ3D0C7OLv/18BACkzicleLRWM0PjY vImDLbgFDtJj+E08Xt/l6JtcF0SsdA+CTYgUjBch+Hgqglq+Uf65yjgzwIqTCFxc6W51qPHc5FOaU LtAYSbIXTkwVEZv0TYLipg==; Date: Thu, 22 May 2025 12:51:26 +0300 Message-Id: <86a5756kip.fsf@gnu.org> From: Eli Zaretskii To: Konstantin Kharlamov In-Reply-To: (message from Konstantin Kharlamov on Thu, 22 May 2025 11:25:48 +0300) Subject: Re: bug#50762: diff-update-on-the-fly doesn't update hunk headers while regexp-replacing lines References: X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 50762-done Cc: 50762-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Konstantin Kharlamov > Date: Thu, 22 May 2025 11:25:48 +0300 > > Seems fixed on master. I don't know when exactly it was fixed, I was > running all that time with diff-update-on-the-fly set to nil. But just > as I was writing a workaround patch (attached for history purposes, in > case it might be useful at some point, but right now it isn't), I > tested and it turns out both query-replace-regexp as well as delete- > matching-lines result in hunks being updated on the fly. > > So bug has been fixed, the report can be closed. Thanks. I closed the bug, but please note that you could close it yourself (and if you were afraid to close by mistake, then reopening is also easy). From debbugs-submit-bounces@debbugs.gnu.org Thu May 22 05:52:38 2025 Received: (at 50762-done) by debbugs.gnu.org; 22 May 2025 09:52:38 +0000 Received: from localhost ([127.0.0.1]:60188 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1uI2bO-0003pq-9D for submit@debbugs.gnu.org; Thu, 22 May 2025 05:52:38 -0400 Received: from forward501a.mail.yandex.net ([178.154.239.81]:50982) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1uI2bJ-0003ox-2t for 50762-done@debbugs.gnu.org; Thu, 22 May 2025 05:52:34 -0400 Received: from mail-nwsmtp-smtp-production-main-95.vla.yp-c.yandex.net (mail-nwsmtp-smtp-production-main-95.vla.yp-c.yandex.net [IPv6:2a02:6b8:c1f:644d:0:640:2ef6:0]) by forward501a.mail.yandex.net (Yandex) with ESMTPS id 884F8615B3; Thu, 22 May 2025 12:52:26 +0300 (MSK) Received: by mail-nwsmtp-smtp-production-main-95.vla.yp-c.yandex.net (smtp/Yandex) with ESMTPSA id PqLEWLHLgKo0-ZGjTDaqM; Thu, 22 May 2025 12:52:26 +0300 X-Yandex-Fwd: 1 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yandex.ru; s=mail; t=1747907546; bh=6D0H9eYG/gRx0ZN54+TNaU2KZL4CxQlJeSmUmayxZgg=; h=References:Date:In-Reply-To:Cc:To:From:Subject:Message-ID; b=PFcH+7Owy4gG0zSnY3uITzqt4aJnxeET0iV2jCXZ0/FYTTiBwjvZXPyamHaD2iAOs DuQLQgb6Kcf8iJ0KeLEHv86FxNVf+Bo3wHlmY4Y8T5kbruOtStJun3q7Fw19U+tm4M 2vd3ZoiNpYlD/+VVN1OvlAq2KSHNq+3V9IBq467Y= Authentication-Results: mail-nwsmtp-smtp-production-main-95.vla.yp-c.yandex.net; dkim=pass header.i=@yandex.ru Message-ID: Subject: Re: bug#50762: diff-update-on-the-fly doesn't update hunk headers while regexp-replacing lines From: Konstantin Kharlamov To: Eli Zaretskii Date: Thu, 22 May 2025 12:52:25 +0300 In-Reply-To: <86a5756kip.fsf@gnu.org> References: <86a5756kip.fsf@gnu.org> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.56.1 MIME-Version: 1.0 X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 50762-done Cc: 50762-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) On Thu, 2025-05-22 at 12:51 +0300, Eli Zaretskii wrote: > > From: Konstantin Kharlamov > > Date: Thu, 22 May 2025 11:25:48 +0300 > >=20 > > Seems fixed on master.=C2=A0 I don't know when exactly it was fixed, I > > was > > running all that time with diff-update-on-the-fly set to nil.=C2=A0 But > > just > > as I was writing a workaround patch (attached for history purposes, > > in > > case it might be useful at some point, but right now it isn't), I > > tested and it turns out both query-replace-regexp as well as > > delete- > > matching-lines result in hunks being updated on the fly. > >=20 > > So bug has been fixed, the report can be closed. >=20 > Thanks.=C2=A0 I closed the bug, but please note that you could close it > yourself (and if you were afraid to close by mistake, then reopening > is also easy). Thank you! I did close it though =F0=9F=98=8A