Subject: [bug#50751] [PATCH] gnu: update Trezor support

From: Attila Lendvai <[email-masked]>
Date: Fri, 24 Sep 2021 11:05:00 +0000

> > Fetch everything from their git repos, instead of pypi.
>
> Given the resulting version mismatch, and having to pick apart the
> sources, is there a compelling reason for this? It looks like the same
> files are included.

an objective reason: one of these versions were not in pipy at the
time i was working on this.

a subjective reason: one less organization to rely on. if anything
would happen to pipy, e.g. some random API change, then that wouldn't
affect us anymore. if github went down or went hostile, then we could
just change the git URL and continue with a minor glitch.

> > -   gnu/packages/finance.scm (python-trezor-agent): Update to 0.14.2.
> >
> >     (python-trezor): Update to 0.12.3.
> >     (trezor-agent): Update to 0.11.0.
> >     (trezord): Update to 2.0.31.
> > -   gnu/packages/patches/trezor-agent-fix-argv0.patch: New file.
>
> When at all possible, version updates should be separate commits from changes.

ok, makes sense, because now that i think about it, it was broken with
the prior version, too. i'll resend it in two patches once i have tested them.

> > ;; overwrite the wrapper with the real thing.
> > (install-file "./trezor_agent.py"
> > -                               (string-append out "/bin"))
> > -               #t))))))
> > -                               (string-append out "/bin")))
> > -               #t)))))
>
> This wasn't added by your patch, but it's odd that the reason for
> overriding the wrapper wasn't documented....

i have added a comment explaining the situation.

thank you for the feedback! the updated patches will be coming a bit
later.

- attila
PGP: 5D5F 45C7 DFCD 0A39