From debbugs-submit-bounces@debbugs.gnu.org Wed Sep 22 02:53:04 2021 Received: (at submit) by debbugs.gnu.org; 22 Sep 2021 06:53:04 +0000 Received: from localhost ([127.0.0.1]:48665 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mSw7r-0000qj-P3 for submit@debbugs.gnu.org; Wed, 22 Sep 2021 02:53:03 -0400 Received: from lists.gnu.org ([209.51.188.17]:34632) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mSw7q-0000qc-GZ for submit@debbugs.gnu.org; Wed, 22 Sep 2021 02:53:02 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:59112) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mSw7q-0005C1-8N for bug-gnu-emacs@gnu.org; Wed, 22 Sep 2021 02:53:02 -0400 Received: from mail-pj1-f46.google.com ([209.85.216.46]:43837) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mSw7o-00071J-Mw for bug-gnu-emacs@gnu.org; Wed, 22 Sep 2021 02:53:02 -0400 Received: by mail-pj1-f46.google.com with SMTP id k23-20020a17090a591700b001976d2db364so1539067pji.2 for ; Tue, 21 Sep 2021 23:53:00 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:mime-version:date:message-id:subject:to; bh=tDWnzxDdhwu5tjnyvMRO+YD6RlDSjSGtj4qmNoq2tII=; b=JEXomlIPbuSpV0wLjCwKGFbjx9VvSTG+UzQLdoJsLlfJJofneH0PMcoYx3iGEySu26 +Pci5KuFdfv0nDXF+yid2ldES+l1FvaTxZJkQD3GUihYGubzxoRugPTdvI/UHjY8/rsj gvArQ9vt7FIqpkOunOTJFOszolvmE/MAqM/Xjdo2BFxlIt0m0X32WacVR1kTXjewSQHn knk6JzxyxM73odZzBW4BGsJ3h1x1xqkUwpDp50rD5BLr0+Pb6M5DhcOkasGHTvlK7eag Jd2LzkkMUscpl7YyaTNbq6jhun2j19XKS/ELKJGBlfv/CMcwTesXyqJs5/43cWZ8sR16 GtUg== X-Gm-Message-State: AOAM533xnTXJuSysGAD/M0AvSEYeoIPdOcYBnvW8n83QheFDXFKx3hQd el/FEQ55Q0c7C6du+xIp7zev61mlYEPDZm37TVIncRqh X-Google-Smtp-Source: ABdhPJzgabLE7/EzkV3E0JzufUC1iJeYFncESEUxIkQ/7f04OsgDIYwtCT1uomvJ3TDROnuDT76mi4yzXseVrKYfIlY= X-Received: by 2002:a17:902:d505:b0:13d:b037:2087 with SMTP id b5-20020a170902d50500b0013db0372087mr12681185plg.22.1632293578697; Tue, 21 Sep 2021 23:52:58 -0700 (PDT) Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Tue, 21 Sep 2021 23:52:58 -0700 From: Stefan Kangas MIME-Version: 1.0 Date: Tue, 21 Sep 2021 23:52:58 -0700 Message-ID: Subject: `progress-reporter-update' docstring and `backward-sexp' interaction To: bug-gnu-emacs@gnu.org Content-Type: text/plain; charset="UTF-8" Received-SPF: pass client-ip=209.85.216.46; envelope-from=stefankangas@gmail.com; helo=mail-pj1-f46.google.com X-Spam_score_int: 0 X-Spam_score: 0.0 X-Spam_bar: / X-Spam_report: (0.0 / 5.0 requ) BAYES_05=-0.5, FREEMAIL_FORGED_FROMDOMAIN=0.249, FREEMAIL_FROM=0.001, HEADER_FROM_DIFFERENT_DOMAINS=0.25, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-Spam-Score: -0.8 (/) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.8 (-) Severity: minor The docstring of `progress-reporter-update' contains the following text: If REPORTER is a numerical progress reporter---i.e. if it was made using non-nil MIN-VALUE and MAX-VALUE arguments to `make-progress-reporter'---then VALUE should be a number between MIN-VALUE and MAX-VALUE. If I place point on the space after "i.e." on the first row, and type C-M-b (backward-sexp), point ends up before "reporter". (This happens in `emacs-lisp-mode', but not in `message-mode'; `message-mode' seems to have no concept of an abbreviation and lands on the "e".) This in turn leads to checkdoc flagging this as a mistake, and asks you to put two spaces after dot. I'm not sure which of these options is true: A) We should support the above convention of using three dashes in `backward-sexp'. (This is the rough ASCII equivalent of an em dash.) B) We should just not use the above convention in `progress-reporter-update'. From debbugs-submit-bounces@debbugs.gnu.org Wed Sep 22 03:37:34 2021 Received: (at 50731) by debbugs.gnu.org; 22 Sep 2021 07:37:34 +0000 Received: from localhost ([127.0.0.1]:48745 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mSwow-0002PW-1i for submit@debbugs.gnu.org; Wed, 22 Sep 2021 03:37:34 -0400 Received: from eggs.gnu.org ([209.51.188.92]:51950) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mSwot-0002PG-Vp for 50731@debbugs.gnu.org; Wed, 22 Sep 2021 03:37:32 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:55156) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mSwoo-0004JN-G3; Wed, 22 Sep 2021 03:37:26 -0400 Received: from 84.94.185.95.cable.012.net.il ([84.94.185.95]:1153 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mSwoo-0002uT-02; Wed, 22 Sep 2021 03:37:26 -0400 Date: Wed, 22 Sep 2021 10:37:24 +0300 Message-Id: <83k0j9vz63.fsf@gnu.org> From: Eli Zaretskii To: Stefan Kangas In-Reply-To: (message from Stefan Kangas on Tue, 21 Sep 2021 23:52:58 -0700) Subject: Re: bug#50731: `progress-reporter-update' docstring and `backward-sexp' interaction References: X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 50731 Cc: 50731@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Stefan Kangas > Date: Tue, 21 Sep 2021 23:52:58 -0700 > > If REPORTER is a numerical progress reporter---i.e. if it was > made using non-nil MIN-VALUE and MAX-VALUE arguments to > `make-progress-reporter'---then VALUE should be a number between > MIN-VALUE and MAX-VALUE. > > If I place point on the space after "i.e." on the first row, and type > C-M-b (backward-sexp), point ends up before "reporter". (This happens > in `emacs-lisp-mode', but not in `message-mode'; `message-mode' seems to > have no concept of an abbreviation and lands on the "e".) > > This in turn leads to checkdoc flagging this as a mistake, and asks you > to put two spaces after dot. Why does it do that? because it doesn't recognize "i.e." as something that doesn't end a sentence? And if so, how does the "---" thing come into play here? > A) We should support the above convention of using three dashes in > `backward-sexp'. (This is the rough ASCII equivalent of an em dash.) > > B) We should just not use the above convention in > `progress-reporter-update'. None of the above? I guess I don't yet understand the root cause for the problem. From debbugs-submit-bounces@debbugs.gnu.org Wed Sep 22 16:35:38 2021 Received: (at 50731) by debbugs.gnu.org; 22 Sep 2021 20:35:38 +0000 Received: from localhost ([127.0.0.1]:51816 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mT8xu-0000oT-Kn for submit@debbugs.gnu.org; Wed, 22 Sep 2021 16:35:38 -0400 Received: from quimby.gnus.org ([95.216.78.240]:33874) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mT8xq-0000o6-FB for 50731@debbugs.gnu.org; Wed, 22 Sep 2021 16:35:37 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=8qGYBYOMytN0aVZoSqeSozj4OPDY6sAiJiGGLbz7z20=; b=bgoTIm13Aky+8YXUzyEWI+/gRz 4CbZLZaqZVfYjLiX9j6QG8UVmRvAvzbAN3xC845mrUmyvtNUAFTJdoaasA00xgkUFzlVKTyxSabrq Mcxev2CdNk9o0xrQwgZ61X5WExN+4gJzQP1ccO8j/4cC9Kuy+DJSdNE710/ri0MSsyLE=; Received: from [84.212.220.105] (helo=elva) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mT8xg-000731-9e; Wed, 22 Sep 2021 22:35:28 +0200 From: Lars Ingebrigtsen To: Stefan Kangas Subject: Re: bug#50731: `progress-reporter-update' docstring and `backward-sexp' interaction References: X-Now-Playing: Jerry Harrison's _The Red And The Black_: "Fast Karma, No Questions" Date: Wed, 22 Sep 2021 22:35:23 +0200 In-Reply-To: (Stefan Kangas's message of "Tue, 21 Sep 2021 23:52:58 -0700") Message-ID: <87a6k4tkl0.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Stefan Kangas writes: > The docstring of `progress-reporter-update' contains the following text: > > If REPORTER is a numerical progress reporter---i.e. if it was > made using non-nil MIN-VALUE and MAX-VALUE arguments to > [...] Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 50731 Cc: 50731@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Stefan Kangas writes: > The docstring of `progress-reporter-update' contains the following text: > > If REPORTER is a numerical progress reporter---i.e. if it was > made using non-nil MIN-VALUE and MAX-VALUE arguments to > `make-progress-reporter'---then VALUE should be a number between > MIN-VALUE and MAX-VALUE. I think the ---s here should just be made into parentheses. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Wed Sep 22 18:12:52 2021 Received: (at 50731) by debbugs.gnu.org; 22 Sep 2021 22:12:52 +0000 Received: from localhost ([127.0.0.1]:52049 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mTAU0-000647-9M for submit@debbugs.gnu.org; Wed, 22 Sep 2021 18:12:52 -0400 Received: from mail-il1-f182.google.com ([209.85.166.182]:33494) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mTATy-00063s-T6 for 50731@debbugs.gnu.org; Wed, 22 Sep 2021 18:12:51 -0400 Received: by mail-il1-f182.google.com with SMTP id b6so4533671ilv.0 for <50731@debbugs.gnu.org>; Wed, 22 Sep 2021 15:12:50 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:in-reply-to:references:mime-version:date :message-id:subject:to:cc; bh=YpLLZt1jNcvxWFXYT6c4gkcE+gHGt4248l6mNWAIAgU=; b=IDJF7dAh0U3YLq8jgbpaHjRF8VYYwix7qwl63Y7m4CsuQsTc9ebkC0N8SLZG8rlfyX dYU1A8oAVbDRkBvq+aer0doTcYeuOEh8SKEwuIXVjvg8PfxsLrkaq/Ls4ZaVvk7FP4Fr +qgUL/Zw3yGtQ07sZXkYkF+x7TWvS978/U8OXs08vtGKCnIAMYRNRx06kMYqAomrfPEG wnfItL9xwpmcaoVNHpxeryyyySNQfkSUHU8gLenu6WnovSeLmVemryxjgbM+sawOY2OK U3cGBMitgs00RhMUpG4wCqVW2Qb2VchMYTbyaB+g1FCwECQlPFkz30GIAhm9R+Bybf8n 1hfA== X-Gm-Message-State: AOAM532m0AUEtAC9dcBDW9xm1+ITGB53Oa0Equk4MhboKyjK5Itlfc3S DIcSY2gsFa/ivO3Tqfrp+sCr/+j6zS7Mygq4Cw4= X-Google-Smtp-Source: ABdhPJzKwqtS8Bqo1N2QBDgOZm9cCfSKBkgp9XcN/AbZgoCGgM52l5h4wH2gotRIBlka2vdjWFQVfy1uVEvNYcv9N00= X-Received: by 2002:a92:b703:: with SMTP id k3mr1000651ili.95.1632348765306; Wed, 22 Sep 2021 15:12:45 -0700 (PDT) Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Wed, 22 Sep 2021 15:12:44 -0700 From: Stefan Kangas In-Reply-To: <87a6k4tkl0.fsf@gnus.org> References: <87a6k4tkl0.fsf@gnus.org> MIME-Version: 1.0 Date: Wed, 22 Sep 2021 15:12:44 -0700 Message-ID: Subject: Re: bug#50731: `progress-reporter-update' docstring and `backward-sexp' interaction To: Lars Ingebrigtsen Content-Type: text/plain; charset="UTF-8" X-Spam-Score: 0.5 (/) X-Debbugs-Envelope-To: 50731 Cc: 50731@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.5 (/) Lars Ingebrigtsen writes: > Stefan Kangas writes: > >> The docstring of `progress-reporter-update' contains the following text: >> >> If REPORTER is a numerical progress reporter---i.e. if it was >> made using non-nil MIN-VALUE and MAX-VALUE arguments to >> `make-progress-reporter'---then VALUE should be a number between >> MIN-VALUE and MAX-VALUE. > > I think the ---s here should just be made into parentheses. That would be the easiest option by far. Maybe that's all we need to do here, really. From debbugs-submit-bounces@debbugs.gnu.org Wed Sep 22 18:13:01 2021 Received: (at 50731) by debbugs.gnu.org; 22 Sep 2021 22:13:01 +0000 Received: from localhost ([127.0.0.1]:52052 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mTAU9-00064X-GM for submit@debbugs.gnu.org; Wed, 22 Sep 2021 18:13:01 -0400 Received: from mail-io1-f46.google.com ([209.85.166.46]:46866) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mTAU5-00064A-LJ for 50731@debbugs.gnu.org; Wed, 22 Sep 2021 18:13:00 -0400 Received: by mail-io1-f46.google.com with SMTP id d18so5410377iof.13 for <50731@debbugs.gnu.org>; Wed, 22 Sep 2021 15:12:57 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:in-reply-to:references:mime-version:date :message-id:subject:to:cc; bh=5IP+cSmfSGHTv12z4xFC4nPjVIkgup/HKJJHni3c3gY=; b=fSkAC5mUdjso4/ceBPqzWtzB2rv8MkmXIdk2lek19JLDwsKcJwzSUrLvkKeMialByS xFRHC4LZkmnlQilPpdkqTIEF0ajch8AQrRMBT7YR27RvSIjD03po/lDrwUtckNSFyyKi K7tNk3sznqQf2Zgsv2Bd1jk2OO0fVtl2/xIZLhiTRZRYKGr5pGK6BC70V82O+pEuH/mu eRMcqND/nukrMMzN3IR3Bj1uXrJIr1HNIGVanMNiRf16+tPeYhEAAdBkGDAxbzTMK5yF rG7X0+H5WisDUZHF3NQEiTFobREIVdcxJk+7/oe1tjYK+nL+q5FkLjSjIdk7Dcb2fbyc MSEg== X-Gm-Message-State: AOAM533eBJU4BgGuA1mSEUm+dMHWe7pDyYW1aBatcgUKulV1TYaHBxru YRkWn5ApeeJaK11oMESyOccm7IfWJLTiC90CLEs= X-Google-Smtp-Source: ABdhPJwqSODGqjwpiVL2YVz3qSze3yU7V95SQB/Uf84SQsM/YrovGTkeqFg7tKa4auXzL2ssUWJ/M6RisHE0IoJTODQ= X-Received: by 2002:a05:6602:1581:: with SMTP id e1mr1107679iow.49.1632348772179; Wed, 22 Sep 2021 15:12:52 -0700 (PDT) Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Wed, 22 Sep 2021 15:12:51 -0700 From: Stefan Kangas In-Reply-To: <83k0j9vz63.fsf@gnu.org> References: <83k0j9vz63.fsf@gnu.org> MIME-Version: 1.0 Date: Wed, 22 Sep 2021 15:12:51 -0700 Message-ID: Subject: Re: bug#50731: `progress-reporter-update' docstring and `backward-sexp' interaction To: Eli Zaretskii Content-Type: text/plain; charset="UTF-8" X-Spam-Score: 0.5 (/) X-Debbugs-Envelope-To: 50731 Cc: 50731@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.5 (/) Eli Zaretskii writes: >> A) We should support the above convention of using three dashes in >> `backward-sexp'. (This is the rough ASCII equivalent of an em dash.) >> >> B) We should just not use the above convention in >> `progress-reporter-update'. > > None of the above? I guess I don't yet understand the root cause for > the problem. I guess I have mixed up two different things above. >From my point of view, the first thing to do is to decide is if this `backward-sexp' behavior is a bug or not. So this comes down to if we think that "---" should be treated as a delimiter, just as " - " is, in the context of ELisp docstrings. I don't have a strong opinion either way, but I did find the current behavior somewhat surprising when I saw it. On the other hand, even if this is a bug, it might very well not be worth fixing as the "---" delimiter is not very commonly used. From debbugs-submit-bounces@debbugs.gnu.org Thu Sep 23 02:17:12 2021 Received: (at 50731) by debbugs.gnu.org; 23 Sep 2021 06:17:12 +0000 Received: from localhost ([127.0.0.1]:52485 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mTI2h-00079L-TI for submit@debbugs.gnu.org; Thu, 23 Sep 2021 02:17:12 -0400 Received: from eggs.gnu.org ([209.51.188.92]:48660) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mTI2U-00078d-Rc for 50731@debbugs.gnu.org; Thu, 23 Sep 2021 02:17:11 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:34542) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mTI2O-0006a1-E0; Thu, 23 Sep 2021 02:16:52 -0400 Received: from 84.94.185.95.cable.012.net.il ([84.94.185.95]:1038 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mTI2O-0008Ro-1G; Thu, 23 Sep 2021 02:16:52 -0400 Date: Thu, 23 Sep 2021 09:16:52 +0300 Message-Id: <83v92rvmsr.fsf@gnu.org> From: Eli Zaretskii To: Stefan Kangas In-Reply-To: (message from Stefan Kangas on Wed, 22 Sep 2021 15:12:51 -0700) Subject: Re: bug#50731: `progress-reporter-update' docstring and `backward-sexp' interaction References: <83k0j9vz63.fsf@gnu.org> X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 50731 Cc: 50731@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Stefan Kangas > Date: Wed, 22 Sep 2021 15:12:51 -0700 > Cc: 50731@debbugs.gnu.org > > >From my point of view, the first thing to do is to decide is if this > `backward-sexp' behavior is a bug or not. How do we decide? What is TRT for backward-sexp in context that has no sexps? If we change anything here, it could potentially affect a lot of unrelated code out there. Once again, why does checkdoc want you to have 2 spaces there? what rule is it that ends up requiring that? From debbugs-submit-bounces@debbugs.gnu.org Thu Sep 23 03:12:16 2021 Received: (at 50731) by debbugs.gnu.org; 23 Sep 2021 07:12:16 +0000 Received: from localhost ([127.0.0.1]:52531 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mTIu0-0000CH-Iq for submit@debbugs.gnu.org; Thu, 23 Sep 2021 03:12:16 -0400 Received: from mail-pg1-f171.google.com ([209.85.215.171]:37824) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mTIty-0000C5-Jk for 50731@debbugs.gnu.org; Thu, 23 Sep 2021 03:12:15 -0400 Received: by mail-pg1-f171.google.com with SMTP id 17so5405374pgp.4 for <50731@debbugs.gnu.org>; Thu, 23 Sep 2021 00:12:14 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:in-reply-to:references:mime-version:date :message-id:subject:to:cc; bh=YxKk7zquni2Xv6uXx22NYNqTVLFl31LvM82AQ7b2FXk=; b=iywGiIM5ezbrt7Ro5WWYN/0/ErVWtzqSx7PV3yxbBtdMcUn3viudJna1xC1tkzSTag NZEOD4hKLdxnMOgzMTr0Z+3I4v5iTSWk3XDkXjl1KDTMBTBJmKmk7BxgvBTPntpN2Bpj 1g/OpFxUThhD4KbIPSE8MwdaNB2wNTiEFnTMFe3t3UZSOCCFO9oh+DAeRP2LtBV/dmGn 6WTVUme2o45vAWXALdBD/3A6xAq9w9izhsg1lIAQhycEDM4M429bAhWt+NBfb5wYioHM z9QuT4BM5KVca/zG9K2WvRzI5B813MrthmhzW6Bl5oORts4R51j8STUYMkMRDWjBdUjd 5AMQ== X-Gm-Message-State: AOAM533sB2kN5Od6pcWNQk5QGMKpSFAQLkkWfRExcNeYt6bCJ8KnnUQf wqjlPf0uDCIycPYjnpyJH6QwRjcHyvXdwSvuxNU= X-Google-Smtp-Source: ABdhPJxtxQUgjD/tgjrKhClXBhul0b2hQtRylTsxvzovdt/WT8byxUFoUrXUudWzPKkm9Ufu4Jqz2xnwhjO/7hMifoA= X-Received: by 2002:a63:6941:: with SMTP id e62mr2876906pgc.114.1632381128867; Thu, 23 Sep 2021 00:12:08 -0700 (PDT) Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Thu, 23 Sep 2021 00:12:08 -0700 From: Stefan Kangas In-Reply-To: <83v92rvmsr.fsf@gnu.org> References: <83k0j9vz63.fsf@gnu.org> <83v92rvmsr.fsf@gnu.org> MIME-Version: 1.0 Date: Thu, 23 Sep 2021 00:12:08 -0700 Message-ID: Subject: Re: bug#50731: `progress-reporter-update' docstring and `backward-sexp' interaction To: Eli Zaretskii Content-Type: text/plain; charset="UTF-8" X-Spam-Score: 0.5 (/) X-Debbugs-Envelope-To: 50731 Cc: 50731@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.5 (/) Eli Zaretskii writes: > How do we decide? What is TRT for backward-sexp in context that has > no sexps? If we change anything here, it could potentially affect a > lot of unrelated code out there. That's true. > Once again, why does checkdoc want you to have 2 spaces there? what > rule is it that ends up requiring that? Sorry, I didn't understand you were asking about checkdoc. The code there is really simple: find the next dot (that is also at a word boundary), run `backward-sexp', use a regexp to see if this is an abbreviation. So it lands on the "r" in "reporter---i.e." and says, no, this is not an abbreviation I know about, so there has to be two spaces after the dot. From debbugs-submit-bounces@debbugs.gnu.org Thu Sep 23 03:47:50 2021 Received: (at 50731) by debbugs.gnu.org; 23 Sep 2021 07:47:50 +0000 Received: from localhost ([127.0.0.1]:52587 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mTJSP-0001Da-VP for submit@debbugs.gnu.org; Thu, 23 Sep 2021 03:47:50 -0400 Received: from eggs.gnu.org ([209.51.188.92]:35402) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mTJSO-0001D6-AG for 50731@debbugs.gnu.org; Thu, 23 Sep 2021 03:47:49 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:36518) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mTJSI-0000Kv-Sy; Thu, 23 Sep 2021 03:47:42 -0400 Received: from 84.94.185.95.cable.012.net.il ([84.94.185.95]:2626 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mTJSI-00050U-GN; Thu, 23 Sep 2021 03:47:42 -0400 Date: Thu, 23 Sep 2021 10:47:41 +0300 Message-Id: <83mto3vile.fsf@gnu.org> From: Eli Zaretskii To: Stefan Kangas In-Reply-To: (message from Stefan Kangas on Thu, 23 Sep 2021 00:12:08 -0700) Subject: Re: bug#50731: `progress-reporter-update' docstring and `backward-sexp' interaction References: <83k0j9vz63.fsf@gnu.org> <83v92rvmsr.fsf@gnu.org> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 50731 Cc: 50731@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Stefan Kangas > Date: Thu, 23 Sep 2021 00:12:08 -0700 > Cc: 50731@debbugs.gnu.org > > > Once again, why does checkdoc want you to have 2 spaces there? what > > rule is it that ends up requiring that? > > Sorry, I didn't understand you were asking about checkdoc. Because you said: > This in turn leads to checkdoc flagging this as a mistake, and asks you > to put two spaces after dot. I read this as the issue you'd like to solve: to prevent checkdoc from flagging this as a mistake. Was I misinterpreting your report? > The code > there is really simple: find the next dot (that is also at a word > boundary), run `backward-sexp', use a regexp to see if this is an > abbreviation. > > So it lands on the "r" in "reporter---i.e." and says, no, this is not an > abbreviation I know about Isn't _that_ a bug, right there? Why does checkdoc use this strange strategy for identifying abbreviations? A punctuation character that precedes an abbreviation shouldn't interfere with recognizing the abbreviation, IMO. And using sexp movements in text that is not really a sexp is perhaps "the original sin" here? IOW, I see no reason whatsoever to believe backward-sexp is the problem here. The problem is in checkdoc, and IMO should be solved there. From debbugs-submit-bounces@debbugs.gnu.org Thu Sep 23 05:04:24 2021 Received: (at 50731) by debbugs.gnu.org; 23 Sep 2021 09:04:24 +0000 Received: from localhost ([127.0.0.1]:52712 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mTKeV-0003OR-PD for submit@debbugs.gnu.org; Thu, 23 Sep 2021 05:04:23 -0400 Received: from mail-pj1-f43.google.com ([209.85.216.43]:52140) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mTKeT-0003OB-TH for 50731@debbugs.gnu.org; Thu, 23 Sep 2021 05:04:22 -0400 Received: by mail-pj1-f43.google.com with SMTP id dw14so4007015pjb.1 for <50731@debbugs.gnu.org>; Thu, 23 Sep 2021 02:04:21 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=ewURN7kxsSI8wF4RktC1t50s/Q8sIxsfyKiVB19ZrQY=; b=d63kUD59Xg/Bd3snxcY8J6O6yvKXZIScr0CB4r/BT0mGC8CD8W2KUlggYE7xhYd2X9 li/Osg80nlZYca5txPLANkNiG+/R3sLsgr6CR53cZwA3YiCF67Z757BAhasaqmm5BjqD eieq6N82MicRjK2oj9W/WPEFAtAIUWftZUbiw5ZAokC5Ov8vWV4EXewW14eUX6501vZi S0ITysZ6lLahYQ/33AFqKaAt7m7sWVi6vkJ852wxEwZkaPbS8TMX+P9LkqYLCGqtPP94 g2SbtMUvNHgw9Ets3h9dlemXQBwev0rdePDL2htAt+yPVp5nqMuMVfEwluItSSkdVFY2 9T7w== X-Gm-Message-State: AOAM532+U3TWpp3W2NrcZ7pmfb4rjYt67CRu+GHOWZkkHoQh3mJUx/uC mehyO4h1kwVyo3I4e6AFHOxJIwhxsunvhwbWFasDBxmQ X-Google-Smtp-Source: ABdhPJz5MCfDcV2e0Ok5hhNnE4q3k30iJKRPfI52VmQ1IDzZ8YlZ+IsUwjlnYTydn97k6GOqrNBLVKMyoxGFzlFHPDY= X-Received: by 2002:a17:902:b691:b029:12d:2b6:d116 with SMTP id c17-20020a170902b691b029012d02b6d116mr3188495pls.71.1632387855837; Thu, 23 Sep 2021 02:04:15 -0700 (PDT) MIME-Version: 1.0 References: <83k0j9vz63.fsf@gnu.org> <83v92rvmsr.fsf@gnu.org> <83mto3vile.fsf@gnu.org> In-Reply-To: <83mto3vile.fsf@gnu.org> From: Stefan Kangas Date: Thu, 23 Sep 2021 11:04:04 +0200 Message-ID: Subject: Re: bug#50731: `progress-reporter-update' docstring and `backward-sexp' interaction To: Eli Zaretskii Content-Type: text/plain; charset="UTF-8" X-Spam-Score: 0.5 (/) X-Debbugs-Envelope-To: 50731 Cc: 50731@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.5 (/) Eli Zaretskii writes: > I read this as the issue you'd like to solve: to prevent checkdoc from > flagging this as a mistake. Was I misinterpreting your report? No, I guess this bug report touched on several different things is all. It seems productive to focus the discussion on checkdoc as you suggest. > IOW, I see no reason whatsoever to believe backward-sexp is the > problem here. The problem is in checkdoc, and IMO should be solved > there. True. I guess it makes sense to just use 'backward-word' instead. Unless anyone has any better suggestions, I will try this approach and see how well it works in practice. From debbugs-submit-bounces@debbugs.gnu.org Thu Sep 23 16:40:25 2021 Received: (at 50731) by debbugs.gnu.org; 23 Sep 2021 20:40:25 +0000 Received: from localhost ([127.0.0.1]:55955 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mTVW4-0007Rk-TS for submit@debbugs.gnu.org; Thu, 23 Sep 2021 16:40:25 -0400 Received: from mail-pj1-f52.google.com ([209.85.216.52]:36800) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mTVVz-0007RF-2d for 50731@debbugs.gnu.org; Thu, 23 Sep 2021 16:40:20 -0400 Received: by mail-pj1-f52.google.com with SMTP id z14-20020a17090a8b8e00b0019cc29ceef1so7834163pjn.1 for <50731@debbugs.gnu.org>; Thu, 23 Sep 2021 13:40:19 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:in-reply-to:references:mime-version:date :message-id:subject:to:cc; bh=cViCgilCSaPtxZxyvFXk04lQrC33gDs9oYlH0C+M8C0=; b=wfjMg48wSU5GrrvvQP8ODunEeX2/LlENtvWs/YAEnpJS1DDFhb69SoS+uLcA//2Lau Kj1Aw7CgA2IZyVWJkLG6cKzFdrrgWlWMWRTd5OBOiBc+Z5q2nS2W/eFyw5UeDgwH4Sxw wMpcwYiGrmIUDQ2iggBWMbHwUdY0LIu1McxpBtIDZaQl+adSMFog33Ga9PvflcO0Os5T 7nkO2WT/dRmOoRSN2SfoHn8oa+shTeF+JfjQ28JEYt6Xv0/wqyYisGNt9pEm8W+D7BNX 8M46QYUFABMPKCRWppTiOkSKcrN3eF/lkwKN6si0hKUxG2cH12tHI8ISOf2M10/9TEw/ mnOA== X-Gm-Message-State: AOAM5313gZgEAme+jP7bWlLheMZLszxuauqOZKwFZUqWDf3cAL+RWue+ XNUtl+vgJgdZ/llYAeKUWSKnLnYjQtQhJjCj1Os= X-Google-Smtp-Source: ABdhPJyWXGB4/un2w32QoxJvSF2ow3J9d/4pwwd9mP2HmPLO/QOsQPeYBGX5bht+S0YKmBpo+RynnkQWAvm+tGpaib4= X-Received: by 2002:a17:903:189:b0:13d:965f:e83f with SMTP id z9-20020a170903018900b0013d965fe83fmr5915657plg.32.1632429613112; Thu, 23 Sep 2021 13:40:13 -0700 (PDT) Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Thu, 23 Sep 2021 15:40:12 -0500 From: Stefan Kangas In-Reply-To: References: <83k0j9vz63.fsf@gnu.org> <83v92rvmsr.fsf@gnu.org> <83mto3vile.fsf@gnu.org> MIME-Version: 1.0 Date: Thu, 23 Sep 2021 15:40:12 -0500 Message-ID: Subject: Re: bug#50731: `progress-reporter-update' docstring and `backward-sexp' interaction To: Eli Zaretskii Content-Type: text/plain; charset="UTF-8" X-Spam-Score: 0.5 (/) X-Debbugs-Envelope-To: 50731 Cc: 50731@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.5 (/) tags 50731 fixed close 50731 28.1 thanks Stefan Kangas writes: > True. I guess it makes sense to just use 'backward-word' instead. > Unless anyone has any better suggestions, I will try this approach and > see how well it works in practice. This has now been fixed by using 'forward-word' instead of 'forward-sexp' in checkdoc (commit 55083d90a3). I also added three new test cases. I'm therefore closing this bug report. From unknown Thu Jun 19 14:14:23 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Fri, 22 Oct 2021 11:24:06 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator