From debbugs-submit-bounces@debbugs.gnu.org Tue Sep 21 07:16:07 2021 Received: (at submit) by debbugs.gnu.org; 21 Sep 2021 11:16:07 +0000 Received: from localhost ([127.0.0.1]:45073 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mSdks-0001Rt-Rp for submit@debbugs.gnu.org; Tue, 21 Sep 2021 07:16:07 -0400 Received: from lists.gnu.org ([209.51.188.17]:34906) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mSdkr-0001Rm-Oc for submit@debbugs.gnu.org; Tue, 21 Sep 2021 07:16:06 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:42968) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mSdkr-0005Rv-JI for bug-gnu-emacs@gnu.org; Tue, 21 Sep 2021 07:16:05 -0400 Received: from mail70c50.megamailservers.eu ([91.136.10.80]:56446) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mSdko-0004dP-TT for bug-gnu-emacs@gnu.org; Tue, 21 Sep 2021 07:16:05 -0400 X-Authenticated-User: mattiase@bredband.net DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=megamailservers.eu; s=maildub; t=1632222956; bh=77CfuNeGyZuT9bfBo/MSnAr8tS7V9rFPYizXMRRSGoE=; h=From:Subject:Date:To:From; b=bTnsMer1ah8+E8XPi2VD110o+XIaD+gLf3r4fIhSIgfjiRDEWZiydpLDwcQtBD+FJ G4qLZWUTDl7FWCRALhO+2pD3UfimBgrJPxBRwpvW5GIOLe5I2sVxhRLbgz2vUpVSry gGGZfBxiGcvDrMl1agqC4lsYZz2hwq8W7aGNHHOc= Feedback-ID: mattiase@acm.or Received: from stanniol.lan (c-b952e353.032-75-73746f71.bbcust.telenor.se [83.227.82.185]) (authenticated bits=0) by mail70c50.megamailservers.eu (8.14.9/8.13.1) with ESMTP id 18LBFskC021467 for ; Tue, 21 Sep 2021 11:15:56 +0000 From: =?utf-8?Q?Mattias_Engdeg=C3=A5rd?= Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable Mime-Version: 1.0 (Mac OS X Mail 12.4 \(3445.104.21\)) Subject: unnamed &rest broken Message-Id: Date: Tue, 21 Sep 2021 13:15:54 +0200 To: bug-gnu-emacs@gnu.org X-Mailer: Apple Mail (2.3445.104.21) X-CTCH-RefID: str=0001.0A742F23.6149BEEC.0074, ss=1, re=0.000, recu=0.000, reip=0.000, cl=1, cld=1, fgs=0 X-CTCH-VOD: Unknown X-CTCH-Spam: Unknown X-CTCH-Score: 0.000 X-CTCH-Rules: X-CTCH-Flags: 0 X-CTCH-ScoreCust: 0.000 X-CSC: 0 X-CHA: v=2.4 cv=ReDzt3hv c=1 sm=1 tr=0 ts=6149beec a=von4qPfY+hyqc0zmWf0tYQ==:117 a=von4qPfY+hyqc0zmWf0tYQ==:17 a=kj9zAlcOel0A:10 a=M51BFTxLslgA:10 a=vtB9HbqcwF9x0TkvSvEA:9 a=CjuIK1q_8ugA:10 X-Origin-Country: SE Received-SPF: softfail client-ip=91.136.10.80; envelope-from=mattiase@acm.org; helo=mail70c50.megamailservers.eu X-Spam_score_int: -11 X-Spam_score: -1.2 X-Spam_bar: - X-Spam_report: (-1.2 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, SPF_HELO_NONE=0.001, SPF_SOFTFAIL=0.665 autolearn=no autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.3 (-) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) The interpreter and compiler allow &rest to be used without a variable = name following but the generated byte code is completely broken: (funcall (byte-compile (lambda (&rest) 'ta))) crashes, and (defun boo (a &rest) (if a a (list 1 2 3 4))) (boo 'hiss) =3D> hiss ; interpreted =3D> (1 2 3 4) ; compiled The reason is that the compiler generates code from the argument = variable list but the byte-code interpreter will only look at the = signature code which was generated from the actual signature: (byte-compile (lambda (&rest) 'ta)) =3D> #[128 "\300\207" [ta] 1 "..."] The 128 indicates zero positional parameters and a &rest argument, and = the 1 is the maximum stack size required which is wrong; 2 stack slots = are needed and that's what we get if naming the argument: (byte-compile (lambda (&rest _r) 'ta)) =3D> #[128 "\300\207" [ta] 2 "..."] In the `boo` case above, it is clear that the compiler doesn't expect = any &rest param to have been pushed at all so the stack offsets are = wrong. Now, either we fix this bug or we stop pretending that unnamed &rest = arguments work at all and signal an error, because it's clear from the = above that they can't have seen much use. From debbugs-submit-bounces@debbugs.gnu.org Tue Sep 21 11:54:55 2021 Received: (at control) by debbugs.gnu.org; 21 Sep 2021 15:54:55 +0000 Received: from localhost ([127.0.0.1]:47609 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mSi6h-0006Ie-Fw for submit@debbugs.gnu.org; Tue, 21 Sep 2021 11:54:55 -0400 Received: from mab.sdf.org ([205.166.94.33]:42250 helo=ma.sdf.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mSi6e-0006IS-S7 for control@debbugs.gnu.org; Tue, 21 Sep 2021 11:54:54 -0400 Received: from akrl by ma.sdf.org with local (Exim 4.92) (envelope-from ) id 1mSi6c-0000wC-Kc for control@debbugs.gnu.org; Tue, 21 Sep 2021 15:54:50 +0000 To: control@debbugs.gnu.org From: Andrea Corallo Subject: control message for bug #50268 Message-Id: Date: Tue, 21 Sep 2021 15:54:50 +0000 X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) merge 50268 50720 quit From debbugs-submit-bounces@debbugs.gnu.org Tue Sep 21 12:11:50 2021 Received: (at 50720) by debbugs.gnu.org; 21 Sep 2021 16:11:50 +0000 Received: from localhost ([127.0.0.1]:47638 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mSiN4-0000Yr-BM for submit@debbugs.gnu.org; Tue, 21 Sep 2021 12:11:50 -0400 Received: from quimby.gnus.org ([95.216.78.240]:45624) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mSiN1-0000YW-Ry; Tue, 21 Sep 2021 12:11:48 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Transfer-Encoding:Content-Type:MIME-Version:Message-ID :In-Reply-To:Date:References:Subject:Cc:To:From:Sender:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=s9NkGr3aoYc/A0xeWRfrhbs2MymwpAJbSUA6mhtpZbw=; b=btozSbsm6ZkQJaEd9tsa8xf+iM +Y2AgC/AKEwh3rPhzsA0FfU4v2c//JnXjciWAK6ls5OOJTtqJ+aQUG/pK7bSL7wGXCjka6PtZc1Fm S9wcRRdSTRufICSrgFIcaFBnMh47/wbExROu7IKZ42nzNkk7WCmeCA11Rm4GW+pJlJ/U=; Received: from [84.212.220.105] (helo=elva) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mSiMs-0007kP-KY; Tue, 21 Sep 2021 18:11:41 +0200 From: Lars Ingebrigtsen To: Mattias =?utf-8?Q?Engdeg=C3=A5rd?= Subject: Re: bug#50268: 28.0.50; Assertion warning during native compilation References: X-Now-Playing: Joan as Police Woman's _Joanthology (3)_: "The Classic (Live at the BBC)" Date: Tue, 21 Sep 2021 18:11:34 +0200 In-Reply-To: ("Mattias =?utf-8?Q?Engdeg=C3=A5rd=22's?= message of "Tue, 21 Sep 2021 13:15:54 +0200") Message-ID: <87mto529jd.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Mattias Engdegård writes: > Now, either we fix this bug or we stop pretending that unnamed &rest > arguments work at all and signal an error, because it's clear from the > above that they can't have seen much use. Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 50720 Cc: Eli Zaretskii , 50720@debbugs.gnu.org, 50268@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Mattias Engdeg=C3=A5rd writes: > Now, either we fix this bug or we stop pretending that unnamed &rest > arguments work at all and signal an error, because it's clear from the > above that they can't have seen much use. I did a quick grep through core and GNU ELPA, and I couldn't find any instances of it being used, so I'd be fine with either solution (i.e., either fixing the bug or signalling an error). Perhaps Eli has an opinion (added to the CCs). --=20 (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Tue Sep 21 12:22:23 2021 Received: (at 50720) by debbugs.gnu.org; 21 Sep 2021 16:22:24 +0000 Received: from localhost ([127.0.0.1]:47647 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mSiXH-0000tM-L7 for submit@debbugs.gnu.org; Tue, 21 Sep 2021 12:22:23 -0400 Received: from mail18c50.megamailservers.eu ([91.136.10.28]:53426) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mSiXF-0000t7-71; Tue, 21 Sep 2021 12:22:22 -0400 X-Authenticated-User: mattiase@bredband.net DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=megamailservers.eu; s=maildub; t=1632241338; bh=Jmj5inle56jtpMzbf+1crrH3XSP+U4MGpg+xI82qR/I=; h=Subject:From:In-Reply-To:Date:Cc:References:To:From; b=OVcl5M0m8flHqbGMGvJqotn9YgvkzTWhiJKVVqCGTt2/qaqEMDVKVRVerZo00Fcae p3KuZz48pRwSyQ9sJ5KrpgjmAUpdYE2rwCkx64M2iodMbyowmNfucDOmZl/XF4szpg dG5eUGMtMYtES/KnOkd5oOG5Q3fSnZKuMRoRKfZM= Feedback-ID: mattiase@acm.or Received: from stanniol.lan (c-b952e353.032-75-73746f71.bbcust.telenor.se [83.227.82.185]) (authenticated bits=0) by mail18c50.megamailservers.eu (8.14.9/8.13.1) with ESMTP id 18LGMBRe008208; Tue, 21 Sep 2021 16:22:15 +0000 Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 12.4 \(3445.104.21\)) Subject: Re: bug#50268: 28.0.50; Assertion warning during native compilation From: =?utf-8?Q?Mattias_Engdeg=C3=A5rd?= In-Reply-To: <87mto529jd.fsf@gnus.org> Date: Tue, 21 Sep 2021 18:22:11 +0200 Content-Transfer-Encoding: quoted-printable Message-Id: <9CF7F0E1-3C92-4F79-B3F3-E51E0E2D43C3@acm.org> References: <87mto529jd.fsf@gnus.org> To: Lars Ingebrigtsen X-Mailer: Apple Mail (2.3445.104.21) X-CTCH-RefID: str=0001.0A742F23.614A06BA.0052, ss=1, re=0.000, recu=0.000, reip=0.000, cl=1, cld=1, fgs=0 X-CTCH-VOD: Unknown X-CTCH-Spam: Unknown X-CTCH-Score: 0.000 X-CTCH-Rules: X-CTCH-Flags: 0 X-CTCH-ScoreCust: 0.000 X-CSC: 0 X-CHA: v=2.4 cv=etO8cqlX c=1 sm=1 tr=0 ts=614a06ba a=von4qPfY+hyqc0zmWf0tYQ==:117 a=von4qPfY+hyqc0zmWf0tYQ==:17 a=kj9zAlcOel0A:10 a=M51BFTxLslgA:10 a=OocQHUDgAAAA:8 a=NRMGHQoppc5sI5ljP04A:9 a=CjuIK1q_8ugA:10 a=xUZTl98r3Qw_uB5NK3jt:22 X-Origin-Country: SE X-Spam-Score: 1.0 (+) X-Debbugs-Envelope-To: 50720 Cc: Eli Zaretskii , 50720@debbugs.gnu.org, Noam Postavsky , 50268@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) 21 sep. 2021 kl. 18.11 skrev Lars Ingebrigtsen : > I did a quick grep through core and GNU ELPA, and I couldn't find any > instances of it being used, so I'd be fine with either solution (i.e., > either fixing the bug or signalling an error). I know how to fix it but there's no really elegant way of doing it, and = unless a convincing case can be made for permitting anonymous &rest, I'd = favour disallowing it. Unless I'm mistaken it was Noam who added it = (1d47d777ef24c0be9153b0a1c8ba21918fa1025a), so let's ask him. From debbugs-submit-bounces@debbugs.gnu.org Tue Sep 21 12:26:35 2021 Received: (at 50720) by debbugs.gnu.org; 21 Sep 2021 16:26:35 +0000 Received: from localhost ([127.0.0.1]:47659 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mSibK-000110-O7 for submit@debbugs.gnu.org; Tue, 21 Sep 2021 12:26:34 -0400 Received: from eggs.gnu.org ([209.51.188.92]:57464) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mSibF-00010i-Os; Tue, 21 Sep 2021 12:26:33 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:57696) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mSibA-0000EN-F8; Tue, 21 Sep 2021 12:26:24 -0400 Received: from 84.94.185.95.cable.012.net.il ([84.94.185.95]:1240 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mSib8-0008LS-TO; Tue, 21 Sep 2021 12:26:24 -0400 Date: Tue, 21 Sep 2021 19:26:19 +0300 Message-Id: <83ee9hyjx0.fsf@gnu.org> From: Eli Zaretskii To: Lars Ingebrigtsen In-Reply-To: <87mto529jd.fsf@gnus.org> (message from Lars Ingebrigtsen on Tue, 21 Sep 2021 18:11:34 +0200) Subject: Re: bug#50268: 28.0.50; Assertion warning during native compilation References: <87mto529jd.fsf@gnus.org> MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 50720 Cc: mattiase@acm.org, 50720@debbugs.gnu.org, 50268@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Lars Ingebrigtsen > Cc: 50720@debbugs.gnu.org, 50268@debbugs.gnu.org, Eli Zaretskii > Date: Tue, 21 Sep 2021 18:11:34 +0200 > > Mattias Engdegård writes: > > > Now, either we fix this bug or we stop pretending that unnamed &rest > > arguments work at all and signal an error, because it's clear from the > > above that they can't have seen much use. > > I did a quick grep through core and GNU ELPA, and I couldn't find any > instances of it being used, so I'd be fine with either solution (i.e., > either fixing the bug or signalling an error). > > Perhaps Eli has an opinion (added to the CCs). I think I'd like to at least see the prototype of the fix to have an opinion. From unknown Sat Aug 09 13:17:57 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Sun, 24 Oct 2021 11:24:05 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator