GNU bug report logs - #50689
28.0.50; Wrong VC repo URL detection in bug-reference-mode

Previous Next

Full log

View this message in rfc822 format

From: Tassilo Horn <tsdh <at> gnu.org>
To: "Basil L. Contovounesios" <contovob <at> tcd.ie>
Cc: 50689 <at> debbugs.gnu.org
Subject: bug#50689: 28.0.50; Wrong VC repo URL detection in bug-reference-mode
Date: Mon, 20 Sep 2021 08:45:18 +0200

"Basil L. Contovounesios" <contovob <at> tcd.ie> writes:

Hey Basil,

> Tags: patch
>
> In a clone of https://github.com/abo-abo/swiper.git, with the following
> remotes:
>
>     $ git remote -v
>     elpa	savannah:/srv/git/emacs/elpa.git (fetch)
>     elpa	savannah:/srv/git/emacs/elpa.git (push)
>     origin	git <at> github.com:basil-conto/swiper.git (fetch)
>     origin	git <at> github.com:basil-conto/swiper.git (push)
>     upstream	git <at> github.com:abo-abo/swiper.git (fetch)
>     upstream	git <at> github.com:abo-abo/swiper.git (push)
>
> 0. emacs -Q ivy.el
> 1. M-: (vc-call-backend 'Git 'repository-url "upstream") RET
>
> This returns: "git <at> github.com:basil-conto/swiper.git"
> instead of:   "git <at> github.com:abo-abo/swiper.git"
>
> Step 1 is effectively what bug-reference-try-setup-from-vc does, and I
> believe the incorrect result is due to vc-git-repository-url expecting
> a file name, not a Git remote name, as its first argument.

Oh, good catch!

BTW, I've thought I've checked that previously <fork>/issues/X
redirected you to <originalrepo>/issues/X but that doesn't seem to be
the case right anymore...

> How's the attached fix?

LGTM.  Not sure about when-let/seq-fns.  I refrained from using them in
bug-reference.el so that it doesn't require subr-x.el and seq.el.  But
OTHO, I very much like them and would happily use them once they are
loaded anyway.

Bye,
Tassilo

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.