From debbugs-submit-bounces@debbugs.gnu.org Sun Sep 19 19:43:20 2021 Received: (at submit) by debbugs.gnu.org; 19 Sep 2021 23:43:20 +0000 Received: from localhost ([127.0.0.1]:40289 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mS6Su-0005NK-9Y for submit@debbugs.gnu.org; Sun, 19 Sep 2021 19:43:20 -0400 Received: from lists.gnu.org ([209.51.188.17]:44440) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mS6Ss-0005NC-5n for submit@debbugs.gnu.org; Sun, 19 Sep 2021 19:43:19 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:43392) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mS6Sr-0003MX-Rt for bug-gnu-emacs@gnu.org; Sun, 19 Sep 2021 19:43:17 -0400 Received: from mail-wm1-x331.google.com ([2a00:1450:4864:20::331]:43873) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mS6Sn-0003w2-Ne for bug-gnu-emacs@gnu.org; Sun, 19 Sep 2021 19:43:17 -0400 Received: by mail-wm1-x331.google.com with SMTP id a194-20020a1c98cb000000b0030b41ac389fso6082466wme.2 for ; Sun, 19 Sep 2021 16:43:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tcd.ie; s=google21; h=from:to:subject:date:message-id:user-agent:mime-version; bh=XrpFe6eRkItV+xZRSLe2vBefSb7qgq0sTQtXcD72764=; b=C4pY01P4x9N30VGUkbY2M93/etZjRAjBlKTVpg0JY9B5wt+OMBlEoRR4qWk3Suu0y4 1QD/0mx1pMJdXfoboflDx1xsrSYF3R9oJvvBhXkzHvDu/gsect7fgEQtIqRk3f5ZF5ma 4eWHWSF3NLlIWaZQGZ10Gr/CqTrNGkz7bePCeFcq1p9Z+VdIPRqhISnQMdT65D5+MdOf yBeCM2uKAbd/UhlSWxqBZEhBvW7Djgcr5LGBCVeQKtOIcQj8ZWXbNX0Om6q0W94nDjl1 ljkSjwbOGbJ7BONM+uURZeeYUZNd842SawN+jgIMHArezkxEt5iKiVDS3FAsDscL/+bx zJSQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:subject:date:message-id:user-agent :mime-version; bh=XrpFe6eRkItV+xZRSLe2vBefSb7qgq0sTQtXcD72764=; b=IdWnmFdnXTyMW448YuLgqERHy3H99BLJqZLf1kWthlbWkxgdFsuBvcnuORIptU5grN pOf9Lgsz1rDUxr4Dju0RVllcypp1hu19irQSvanZ2b9kRQkrkE7+f3lKqgdTty0Ibg15 /DKuIf7pg/UybetfA2PG1wjVGmdN7NYgsZTsTKdGdfJKSmsHQz1uafRnad1e6EXmEgJt 0AWec2JNTqLtxYkEBv0IFEBGgI0XDlOcAp7gj7ZPSBwnsoSp6WxlkVcQbSrLRhMckO/Y +Kjj9JjXbIPK0I4Xz98lFA6DKgte3br2PqvO7VnieeTyyV8yIZMzQZ3S/B7Qlr6l9Bvr JC9g== X-Gm-Message-State: AOAM5325wqLx+wW1KXNqLXAVJT7a0i9edTRhReShJXOysUCG72K9tK3c qrMFGHqBCq7OOZHZkY1aGrRaL1GidNdYvw== X-Google-Smtp-Source: ABdhPJwhrCqkgSnztKBd2kTAk33ETnjfQCVLpdUZrudm5xX/oohkK2Kn4/voXDRWOMiTycUbD6ULiQ== X-Received: by 2002:a1c:a942:: with SMTP id s63mr26160194wme.45.1632094989964; Sun, 19 Sep 2021 16:43:09 -0700 (PDT) Received: from localhost ([2a02:8084:20e2:c380:d15:339e:aa10:60f1]) by smtp.gmail.com with ESMTPSA id u23sm16685280wmc.24.2021.09.19.16.43.07 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 19 Sep 2021 16:43:08 -0700 (PDT) From: "Basil L. Contovounesios" To: bug-gnu-emacs@gnu.org Subject: 28.0.50; Wrong VC repo URL detection in bug-reference-mode X-Debbugs-Cc: Tassilo Horn Date: Mon, 20 Sep 2021 00:43:07 +0100 Message-ID: <877dfcb08k.fsf@tcd.ie> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Received-SPF: pass client-ip=2a00:1450:4864:20::331; envelope-from=contovob@tcd.ie; helo=mail-wm1-x331.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.4 (-) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.4 (--) --=-=-= Content-Type: text/plain Tags: patch In a clone of https://github.com/abo-abo/swiper.git, with the following remotes: $ git remote -v elpa savannah:/srv/git/emacs/elpa.git (fetch) elpa savannah:/srv/git/emacs/elpa.git (push) origin git@github.com:basil-conto/swiper.git (fetch) origin git@github.com:basil-conto/swiper.git (push) upstream git@github.com:abo-abo/swiper.git (fetch) upstream git@github.com:abo-abo/swiper.git (push) 0. emacs -Q ivy.el 1. M-: (vc-call-backend 'Git 'repository-url "upstream") RET This returns: "git@github.com:basil-conto/swiper.git" instead of: "git@github.com:abo-abo/swiper.git" Step 1 is effectively what bug-reference-try-setup-from-vc does, and I believe the incorrect result is due to vc-git-repository-url expecting a file name, not a Git remote name, as its first argument. How's the attached fix? --=-=-= Content-Type: text/x-diff Content-Disposition: inline; filename=0001-Fix-VC-repo-URL-detection-in-bug-reference-mode.patch >From dd1be2b9c277a53078fb20242702ecf2599cbb7b Mon Sep 17 00:00:00 2001 From: "Basil L. Contovounesios" Date: Sun, 19 Sep 2021 21:13:17 +0100 Subject: [PATCH 1/2] Fix VC repo URL detection in bug-reference-mode * lisp/progmodes/bug-reference.el (bug-reference-try-setup-from-vc): Pass file or directory name in question as the first argument to the backend's repository-url implementation. Use when-let and seq-some to flatten nested conditionals. --- lisp/progmodes/bug-reference.el | 31 +++++++++++++------------------ 1 file changed, 13 insertions(+), 18 deletions(-) diff --git a/lisp/progmodes/bug-reference.el b/lisp/progmodes/bug-reference.el index b646a47c85..fd014a38d9 100644 --- a/lisp/progmodes/bug-reference.el +++ b/lisp/progmodes/bug-reference.el @@ -376,24 +376,19 @@ bug-reference-try-setup-from-vc Test each configuration in `bug-reference-setup-from-vc-alist' and `bug-reference--setup-from-vc-alist' and apply it if applicable." - (let ((file-or-dir (or buffer-file-name - ;; Catches modes such as vc-dir and Magit. - default-directory))) - (when file-or-dir - (let* ((backend (vc-responsible-backend file-or-dir t)) - (url - (or (ignore-errors - (vc-call-backend backend 'repository-url "upstream")) - (ignore-errors - (vc-call-backend backend 'repository-url))))) - (when url - (catch 'found - (dolist (config (append - bug-reference-setup-from-vc-alist - (bug-reference--setup-from-vc-alist))) - (when (apply #'bug-reference-maybe-setup-from-vc - url config) - (throw 'found t))))))))) + (when-let ((file-or-dir (or buffer-file-name + ;; Catches modes such as vc-dir and Magit. + default-directory)) + (backend (vc-responsible-backend file-or-dir t)) + (url (seq-some (lambda (remote) + (ignore-errors + (vc-call-backend backend 'repository-url + file-or-dir remote))) + '("upstream" nil)))) + (seq-some (lambda (config) + (apply #'bug-reference-maybe-setup-from-vc url config)) + (append bug-reference-setup-from-vc-alist + (bug-reference--setup-from-vc-alist))))) (defvar bug-reference-setup-from-mail-alist `((,(regexp-opt '("emacs" "auctex" "gnus" "tramp" "orgmode") 'words) -- 2.33.0 --=-=-= Content-Type: text/plain Thanks, -- Basil In GNU Emacs 28.0.50 (build 2, x86_64-pc-linux-gnu, X toolkit, cairo version 1.16.0, Xaw3d scroll bars) of 2021-09-20 built on tia Repository revision: 3c513435369826e44a53dcb12ecc14657e03c73d Repository branch: HEAD Windowing system distributor 'The X.Org Foundation', version 11.0.12011000 System Description: Debian GNU/Linux bookworm/sid Configured using: 'configure 'CC=ccache gcc' 'CFLAGS=-Og -ggdb' --config-cache --prefix=/home/blc/.local --enable-checking=structs --with-x-toolkit=lucid --with-file-notification=yes --with-x' Configured features: ACL CAIRO DBUS FREETYPE GIF GLIB GMP GNUTLS GPM GSETTINGS HARFBUZZ JPEG JSON LCMS2 LIBOTF LIBSELINUX LIBSYSTEMD LIBXML2 M17N_FLT MODULES NOTIFY INOTIFY PDUMPER PNG RSVG SECCOMP SOUND THREADS TIFF TOOLKIT_SCROLL_BARS X11 XAW3D XDBE XIM XPM LUCID ZLIB Important settings: value of $LANG: en_IE.UTF-8 value of $XMODIFIERS: @im=ibus locale-coding-system: utf-8-unix Major mode: ELisp/l Minor modes in effect: tooltip-mode: t global-eldoc-mode: t eldoc-mode: t electric-indent-mode: t mouse-wheel-mode: t tool-bar-mode: t menu-bar-mode: t file-name-shadow-mode: t global-font-lock-mode: t font-lock-mode: t blink-cursor-mode: t auto-composition-mode: t auto-encryption-mode: t auto-compression-mode: t line-number-mode: t transient-mark-mode: t Load-path shadows: None found. Features: (vc-git diff-mode easy-mmode vc-dispatcher help-mode pp shadow sort mail-extr emacsbug message rmc puny dired dired-loaddefs rfc822 mml mml-sec epa derived epg rfc6068 epg-config gnus-util rmail rmail-loaddefs auth-source cl-seq eieio eieio-core cl-macs eieio-loaddefs password-cache json map text-property-search time-date subr-x seq byte-opt gv bytecomp byte-compile cconv mm-decode mm-bodies mm-encode mail-parse rfc2231 mailabbrev gmm-utils mailheader cl-loaddefs cl-lib sendmail rfc2047 rfc2045 ietf-drums mm-util mail-prsvr mail-utils iso-transl tooltip eldoc electric uniquify ediff-hook vc-hooks lisp-float-type elisp-mode mwheel term/x-win x-win term/common-win x-dnd tool-bar dnd fontset image regexp-opt fringe tabulated-list replace newcomment text-mode lisp-mode prog-mode register page tab-bar menu-bar rfn-eshadow isearch easymenu timer select scroll-bar mouse jit-lock font-lock syntax font-core term/tty-colors frame minibuffer cl-generic cham georgian utf-8-lang misc-lang vietnamese tibetan thai tai-viet lao korean japanese eucjp-ms cp51932 hebrew greek romanian slovak czech european ethiopic indian cyrillic chinese composite charscript charprop case-table epa-hook jka-cmpr-hook help simple abbrev obarray cl-preloaded nadvice button loaddefs faces cus-face macroexp files window text-properties overlay sha1 md5 base64 format env code-pages mule custom widget hashtable-print-readable backquote threads dbusbind inotify lcms2 dynamic-setting system-font-setting font-render-setting cairo x-toolkit x multi-tty make-network-process emacs) Memory information: ((conses 16 57729 7685) (symbols 48 7242 5) (strings 32 21156 1629) (string-bytes 1 675261) (vectors 16 14813) (vector-slots 8 196771 13743) (floats 8 31 55) (intervals 56 350 15) (buffers 992 12)) --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Mon Sep 20 03:14:16 2021 Received: (at 50689) by debbugs.gnu.org; 20 Sep 2021 07:14:16 +0000 Received: from localhost ([127.0.0.1]:40875 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mSDVI-0002Xg-0H for submit@debbugs.gnu.org; Mon, 20 Sep 2021 03:14:16 -0400 Received: from eggs.gnu.org ([209.51.188.92]:50204) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mSDVF-0002XU-VS for 50689@debbugs.gnu.org; Mon, 20 Sep 2021 03:14:15 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:51706) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mSDV8-00079f-Lj; Mon, 20 Sep 2021 03:14:07 -0400 Received: from auth2-smtp.messagingengine.com ([66.111.4.228]:49073) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mSDV8-0007oD-8Q; Mon, 20 Sep 2021 03:14:06 -0400 Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailauth.nyi.internal (Postfix) with ESMTP id 3C69F27C0054; Mon, 20 Sep 2021 03:14:05 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute4.internal (MEProxy); Mon, 20 Sep 2021 03:14:05 -0400 X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvtddrudeiuddgudduiecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpehffgfhvffuffgjkfggtgesthdtredttdertdenucfhrhhomhepvfgrshhs ihhlohcujfhorhhnuceothhsughhsehgnhhurdhorhhgqeenucggtffrrghtthgvrhhnpe dvhfduveeuvddtveeifeefhedvffeugeehjedtfffhieevledvgfehueejgfehffenucff ohhmrghinhepghhithhhuhgsrdgtohhmnecuvehluhhsthgvrhfuihiivgeptdenucfrrg hrrghmpehmrghilhhfrhhomhepthhhohhrnhdomhgvshhmthhprghuthhhphgvrhhsohhn rghlihhthidqkeeijeefkeejkeegqdeifeehvdelkedqthhsughhpeepghhnuhdrohhrgh esfhgrshhtmhgrihhlrdhfmh X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA; Mon, 20 Sep 2021 03:14:04 -0400 (EDT) References: <877dfcb08k.fsf@tcd.ie> User-agent: mu4e 1.6.6; emacs 28.0.50 From: Tassilo Horn To: "Basil L. Contovounesios" Subject: Re: bug#50689: 28.0.50; Wrong VC repo URL detection in bug-reference-mode Date: Mon, 20 Sep 2021 08:45:18 +0200 In-reply-to: <877dfcb08k.fsf@tcd.ie> Message-ID: <87ee9jpvlz.fsf@gnu.org> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 50689 Cc: 50689@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) "Basil L. Contovounesios" writes: Hey Basil, > Tags: patch > > In a clone of https://github.com/abo-abo/swiper.git, with the following > remotes: > > $ git remote -v > elpa savannah:/srv/git/emacs/elpa.git (fetch) > elpa savannah:/srv/git/emacs/elpa.git (push) > origin git@github.com:basil-conto/swiper.git (fetch) > origin git@github.com:basil-conto/swiper.git (push) > upstream git@github.com:abo-abo/swiper.git (fetch) > upstream git@github.com:abo-abo/swiper.git (push) > > 0. emacs -Q ivy.el > 1. M-: (vc-call-backend 'Git 'repository-url "upstream") RET > > This returns: "git@github.com:basil-conto/swiper.git" > instead of: "git@github.com:abo-abo/swiper.git" > > Step 1 is effectively what bug-reference-try-setup-from-vc does, and I > believe the incorrect result is due to vc-git-repository-url expecting > a file name, not a Git remote name, as its first argument. Oh, good catch! BTW, I've thought I've checked that previously /issues/X redirected you to /issues/X but that doesn't seem to be the case right anymore... > How's the attached fix? LGTM. Not sure about when-let/seq-fns. I refrained from using them in bug-reference.el so that it doesn't require subr-x.el and seq.el. But OTHO, I very much like them and would happily use them once they are loaded anyway. Bye, Tassilo From debbugs-submit-bounces@debbugs.gnu.org Mon Sep 20 09:53:47 2021 Received: (at 50689) by debbugs.gnu.org; 20 Sep 2021 13:53:47 +0000 Received: from localhost ([127.0.0.1]:41276 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mSJju-0000GS-UT for submit@debbugs.gnu.org; Mon, 20 Sep 2021 09:53:47 -0400 Received: from mail-wr1-f50.google.com ([209.85.221.50]:44908) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mSJjo-0000Fr-Ln for 50689@debbugs.gnu.org; Mon, 20 Sep 2021 09:53:44 -0400 Received: by mail-wr1-f50.google.com with SMTP id d6so29821164wrc.11 for <50689@debbugs.gnu.org>; Mon, 20 Sep 2021 06:53:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tcd.ie; s=google21; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=tnxd8R78bDQHnvr64Xiv/U+PmlDfH76adAh1S02hl5U=; b=YJpqByjzx/8z8dOXNpT1nj4DEoYL+CO1sADPqmRLcF3enzKSD5tTltzgtIa7worpnn hWPRD9ggnQ/0sh19GhJjPbFKxy4DwEF9lcmN6hScyS1kyhtzd/oq3wGcFcupCA9C9g0b rDplIbfN37NPozvk+sUIMY6Mf2aVht6AnBfpaIl60460EPt/yfYSy8hNXshPMmWfqLz3 JIDZbru7qFZlMf7NK4zer+b1THY6hHy4ROSz0DEAVQ10f7rl774gnxVyN6kHE7orfp33 w2loEOCgBAmh5UGVi39mrFKqNeijJMKJkZr1k/FgNj7bGZ7GSTPu2V2ycS/CL+4vk5B3 gPow== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=tnxd8R78bDQHnvr64Xiv/U+PmlDfH76adAh1S02hl5U=; b=VfkVy3CRJAfN5cRn+3b4+Fy7B/FRDtI1QUJY789yR82SlRNXgfkFxDbRMm6WdXwUKC tuWttMwRCEuRhNnJlSFghr4+mOq4jF2M/ntEkAA7mePuWN46NJR/htaNTuCtPTUNWk6D Vhx5PsagZH2leHb+WsjQ5XCuimwvv/0Gh64RU7l0n5iqH9+TR9reqjcMGFSAJebgZLLH XYUSdemlp37iik9duloXKnAe0U9yHIdZREEOoZbQSIvl3ojDlAuC3NnVK2+ZkAVBKCes +EwzxJ+UY3gtECmiNNc2c3MlGt2Y9IpnEFj4ifiVoamUiYf7SQmBK94iM9PKFxYqH6ge h7hQ== X-Gm-Message-State: AOAM533upRhPn8rkEjqQm5ZB13dwAvp9s1j1iRzm3QreREtI08f0YITN mX6DY0B8TNPcHqScnx3hXmIxjg== X-Google-Smtp-Source: ABdhPJw03pIZvzXrvS/pL910vv2ru4y6wK2smGPwsipSmTPJlUvvVFYUS8H6uzijf4oEzf6lXSK2Pw== X-Received: by 2002:a05:6000:1a52:: with SMTP id t18mr28094410wry.21.1632146014569; Mon, 20 Sep 2021 06:53:34 -0700 (PDT) Received: from localhost ([86.43.127.200]) by smtp.gmail.com with ESMTPSA id a77sm4229759wme.28.2021.09.20.06.53.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 20 Sep 2021 06:53:34 -0700 (PDT) From: "Basil L. Contovounesios" To: Tassilo Horn Subject: Re: bug#50689: 28.0.50; Wrong VC repo URL detection in bug-reference-mode References: <877dfcb08k.fsf@tcd.ie> <87ee9jpvlz.fsf@gnu.org> Date: Mon, 20 Sep 2021 14:53:32 +0100 In-Reply-To: <87ee9jpvlz.fsf@gnu.org> (Tassilo Horn's message of "Mon, 20 Sep 2021 08:45:18 +0200") Message-ID: <87v92v9wv7.fsf@tcd.ie> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 50689 Cc: 50689@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) close 50689 28.1 quit Tassilo Horn [2021-09-20 08:45 +0200] wrote: > "Basil L. Contovounesios" writes: >> How's the attached fix? > > LGTM. Thanks, pushed: Fix VC repo URL detection in bug-reference-mode 7d5930a6f0 2021-09-20 14:41:13 +0100 https://git.sv.gnu.org/cgit/emacs.git/commit/?id=7d5930a6f0c7b44c00df403d5fe8a3f40e51902f > Not sure about when-let/seq-fns. I refrained from using them in > bug-reference.el so that it doesn't require subr-x.el and seq.el. when-let is an autoloaded macro, so subr-x.el won't be loaded at all at runtime (assuming everything is byte-compiled). seq-some is an autoloaded function, so seq.el won't be loaded until bug-reference-try-setup-from-vc is invoked (and anyway in practice it is hard to do anything in Emacs any more without seq.el being loaded at some point). > But OTHO, I very much like them and would happily use them once they > are loaded anyway. I'm therefore closing this report. Thanks, -- Basil From debbugs-submit-bounces@debbugs.gnu.org Mon Sep 20 09:58:22 2021 Received: (at 50689) by debbugs.gnu.org; 20 Sep 2021 13:58:22 +0000 Received: from localhost ([127.0.0.1]:43730 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mSJoL-00011G-N5 for submit@debbugs.gnu.org; Mon, 20 Sep 2021 09:58:22 -0400 Received: from eggs.gnu.org ([209.51.188.92]:43202) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mSJoD-00010o-MR for 50689@debbugs.gnu.org; Mon, 20 Sep 2021 09:58:20 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:60374) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mSJo6-0003Eg-Iv; Mon, 20 Sep 2021 09:58:08 -0400 Received: from auth2-smtp.messagingengine.com ([66.111.4.228]:44585) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mSJo3-0002HX-Ks; Mon, 20 Sep 2021 09:58:06 -0400 Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailauth.nyi.internal (Postfix) with ESMTP id C27F027C0054; Mon, 20 Sep 2021 09:58:02 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute5.internal (MEProxy); Mon, 20 Sep 2021 09:58:02 -0400 X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvtddrudeivddgjedtucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepfhgfhffvufffjgfkgggtsehttdertddtredtnecuhfhrohhmpefvrghsshhi lhhoucfjohhrnhcuoehtshguhhesghhnuhdrohhrgheqnecuggftrfgrthhtvghrnhepve evieekteekveeigfefffeivdetgeduvdffueeuudevgedttdehvdfhueevfffhnecuvehl uhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepthhhohhrnhdomh gvshhmthhprghuthhhphgvrhhsohhnrghlihhthidqkeeijeefkeejkeegqdeifeehvdel kedqthhsughhpeepghhnuhdrohhrghesfhgrshhtmhgrihhlrdhfmh X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA; Mon, 20 Sep 2021 09:58:01 -0400 (EDT) References: <877dfcb08k.fsf@tcd.ie> <87ee9jpvlz.fsf@gnu.org> <87v92v9wv7.fsf@tcd.ie> User-agent: mu4e 1.6.6; emacs 28.0.50 From: Tassilo Horn To: "Basil L. Contovounesios" Subject: Re: bug#50689: 28.0.50; Wrong VC repo URL detection in bug-reference-mode Date: Mon, 20 Sep 2021 15:57:13 +0200 In-reply-to: <87v92v9wv7.fsf@tcd.ie> Message-ID: <87a6k7pcwo.fsf@gnu.org> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 50689 Cc: 50689@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) "Basil L. Contovounesios" writes: >> Not sure about when-let/seq-fns. I refrained from using them in >> bug-reference.el so that it doesn't require subr-x.el and seq.el. > > when-let is an autoloaded macro, so subr-x.el won't be loaded at all > at runtime (assuming everything is byte-compiled). Ah, right. > seq-some is an autoloaded function, so seq.el won't be loaded until > bug-reference-try-setup-from-vc is invoked (and anyway in practice it > is hard to do anything in Emacs any more without seq.el being loaded > at some point). Allright with me. Thanks a lot! Tassilo From unknown Sat Sep 20 08:01:24 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Tue, 19 Oct 2021 11:24:08 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator