GNU bug report logs - #50688
[PATCH] gnu: go-github-com-alcortesm-tgz: Don't reset gzip timestamps.

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Sarah Morgensen <iskarian <at> mgsn.dev>
Subject: bug#50688: closed (Re: [bug#50688] [PATCH] gnu: go-github-com-alcortesm-tgz:
 Don't reset gzip timestamps.)
Date: Wed, 08 Dec 2021 18:38:02 +0000

[Message part 1 (text/plain, inline)]

Your bug report

#50688: [PATCH] gnu: go-github-com-alcortesm-tgz: Don't reset gzip timestamps.

which was filed against the guix-patches package, has been closed.

The explanation is attached below, along with your original report.
If you require more details, please reply to 50688 <at> debbugs.gnu.org.

-- 
50688: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=50688
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Leo Famulari <leo <at> famulari.name>
To: Sarah Morgensen <iskarian <at> mgsn.dev>
Cc: 50688-done <at> debbugs.gnu.org
Subject: Re: [bug#50688] [PATCH] gnu: go-github-com-alcortesm-tgz: Don't
 reset gzip timestamps.
Date: Wed, 8 Dec 2021 13:37:05 -0500

On Sun, Sep 19, 2021 at 04:32:13PM -0700, Sarah Morgensen wrote:
> The tgz files are committed test fixtures, so don't reset their timestamps.
> 
> * gnu/packages/golang.scm (go-github-com-alcortesm-tgz)[arguments]:
> Remove 'make-git-checkout-writable' phase.  Delete
> 'reset-gzip-timestamps' phase instead.

Thanks, pushed as 8ac2d303e4e01fb5a5b22e7fd78f174e0a931afd

[Message part 3 (message/rfc822, inline)]

From: Sarah Morgensen <iskarian <at> mgsn.dev>
To: guix-patches <at> gnu.org
Subject: [PATCH] gnu: go-github-com-alcortesm-tgz: Don't reset gzip timestamps.
Date: Sun, 19 Sep 2021 16:32:13 -0700

The tgz files are committed test fixtures, so don't reset their timestamps.

* gnu/packages/golang.scm (go-github-com-alcortesm-tgz)[arguments]:
Remove 'make-git-checkout-writable' phase.  Delete
'reset-gzip-timestamps' phase instead.
---
 gnu/packages/golang.scm | 7 ++-----
 1 file changed, 2 insertions(+), 5 deletions(-)

diff --git a/gnu/packages/golang.scm b/gnu/packages/golang.scm
index f02d0aa9df..b53a4e3686 100644
--- a/gnu/packages/golang.scm
+++ b/gnu/packages/golang.scm
@@ -7546,11 +7546,8 @@ (define-public go-github-com-alcortesm-tgz
        `(#:import-path "github.com/alcortesm/tgz"
          #:phases
          (modify-phases %standard-phases
-           (add-after 'unpack 'make-git-checkout-writable
-             (lambda* (#:key outputs #:allow-other-keys)
-               (for-each make-file-writable (find-files "."))
-               (for-each make-file-writable (find-files (assoc-ref outputs "out")))
-               #t)))))
+           ;; Files are test fixtures, not generated.
+           (delete 'reset-gzip-timestamps))))
       (home-page "https://github.com/alcortesm/tgz/")
       (synopsis "Go library to extract tgz files to temporal directories")
       (description "This package provides a Go library to extract tgz files to

base-commit: a640ee7da3311e4fa560c7163d2dd7d24a25585a
-- 
2.33.0

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.