GNU bug report logs - #50677
[PATCH] Minetest basic_materials really depends on moreores

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Tobias Geerinckx-Rice <me <at> tobias.gr>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#50677: closed ([PATCH] Minetest basic_materials really
 depends on moreores)
Date: Sat, 16 Oct 2021 15:49:02 +0000

[Message part 1 (text/plain, inline)]

Your message dated Sat, 16 Oct 2021 17:32:07 +0200
with message-id <871r4lc6np.fsf <at> nckx>
and subject line Re: bug#50677: [PATCH] Minetest basic_materials really depends on moreores
has caused the debbugs.gnu.org bug report #50677,
regarding [PATCH] Minetest basic_materials really depends on moreores
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
50677: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=50677
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Vivien Kraus <vivien <at> planete-kraus.eu>
To: bug-guix <at> gnu.org
Subject: [PATCH] Minetest basic_materials really depends on moreores
Date: Sun, 19 Sep 2021 17:23:50 +0200

[Message part 3 (text/plain, inline)]

Dear guix,

basic_materials actually requires moreores, otherwise some craft
recipes are just not possible. For instance,
basic_materials:silver_wire can only be crafted with
moreores:silver_ingot. This silver wire is actually needed for basic
technic machines, such as the LV compressor.

So, let’s add minetest-moreores!

Vivien

[0002-gnu-minetest-basic-materials-Depend-on-minetest-more.patch (text/x-patch, attachment)]

[0001-gnu-Add-minetest-moreores.patch (text/x-patch, attachment)]

[Message part 6 (message/rfc822, inline)]

From: Tobias Geerinckx-Rice <me <at> tobias.gr>
To: Vivien Kraus <vivien <at> planete-kraus.eu>
Cc: 50677-done <at> debbugs.gnu.org
Subject: Re: bug#50677: [PATCH] Minetest basic_materials really depends on
 moreores
Date: Sat, 16 Oct 2021 17:32:07 +0200

[Message part 7 (text/plain, inline)]

Vivien,

Thanks!  I've pushed this series as 
df2404482495bc3af03e7fc902af1e6b0d10b4a4 et al.

I made a only few small tweaks, mainly to the commit message:

> gnu: minetest-basic-materials: Depend on minetest-moreores.

‘Depend’ sounds wrong to me; it either does, or it doesn't, we 
don't determine that.  Changed to ‘Propagate …’

> * minetest.scm (minetest-basic-materials): Add minetest-moreores 
> as a propagated input.

Keep Git commit message body lines <=72 characters.  Most 
(non-Guix) tooling is built around that assumption.

Also use full relative file names, and use [field] notation where 
appropriate:

 * gnu/packages/foo.scm (foo)[propagated-inputs]: Add bar.

For the build system patches, I changed

> guix: minetest-build-system: […]

to

 build-system/minetest: […]

Why?  Because it's shorter.  Is this a documented rule?  I can't 
say!

> ;; basic_materials:silver_wire cannot be crafted without
> ;; moreores:silver_ingot.

Documenting this is a great idea.

> (commit "0b6f669df4c9b7771c03e0e6ba8effb471cdfcae")))

I changed this to

 (commit (string-append "v" version))

to use the git tag.

Both have advantages & disadvantages, but this is our currently 
preferred style.

> (synopsis "Adds new ore types")
> (description "More ores for Minetest.")

These aren't acceptable.  See (guix)Synopses and Descriptions.

This was my attempt at improving the importer's lazywork:

 (synopsis "Additional ore types, tools, swords, and rails for 
 Minetest")
 (description
  "This Minetest mod adds new ore types to the game (mithril, 
  silver) as well
as swords and tools made of different materials.  It also adds 
copper rails.")

Bit vague, but you know why.

Closing; thanks!

T G-R

[signature.asc (application/pgp-signature, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.