From debbugs-submit-bounces@debbugs.gnu.org Sun Sep 19 05:57:25 2021 Received: (at submit) by debbugs.gnu.org; 19 Sep 2021 09:57:25 +0000 Received: from localhost ([127.0.0.1]:37498 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mRtZc-0008Cu-OW for submit@debbugs.gnu.org; Sun, 19 Sep 2021 05:57:25 -0400 Received: from lists.gnu.org ([209.51.188.17]:41946) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mRtZb-0008Cm-1Q for submit@debbugs.gnu.org; Sun, 19 Sep 2021 05:57:23 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:54972) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mRtZa-0002h4-Oj for bug-guix@gnu.org; Sun, 19 Sep 2021 05:57:22 -0400 Received: from mail3-relais-sop.national.inria.fr ([192.134.164.104]:60887) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mRtZY-00070g-5O for bug-guix@gnu.org; Sun, 19 Sep 2021 05:57:22 -0400 IronPort-HdrOrdr: =?us-ascii?q?A9a23=3ABDqADKtu8rqTdxuM4mRMwNJm7skDjNV00zEX?= =?us-ascii?q?/kB9WHVpm62j5qaTdZsgpH3JYVoqM03I+urwX5VoI0mskKKdiLN5VYtKNzOKhI?= =?us-ascii?q?LHFutfBMfZslndMhy70NQ179YCT4FOTOTfNBxUjcH17BKgCNYm3bC8kJyAtKPm?= =?us-ascii?q?4U4obw17ApsA0y5JTj+0KwlVSBkDJbdRLvShz/sCnDa+f3EKc8S8AXEfT6zvr8?= =?us-ascii?q?DG/aiIXTc2QyIdzWC14Q+V1A=3D=3D?= X-IronPort-AV: E=Sophos;i="5.84,326,1620684000"; d="scan'208";a="393381677" Received: from 91-160-117-201.subs.proxad.net (HELO ribbon) ([91.160.117.201]) by mail3-relais-sop.national.inria.fr with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 19 Sep 2021 11:57:15 +0200 From: =?utf-8?Q?Ludovic_Court=C3=A8s?= To: bug-guix@gnu.org Subject: python-pytorch is not reproducible X-URL: http://www.fdn.fr/~lcourtes/ X-Revolutionary-Date: Jour du Travail de =?utf-8?Q?l'Ann=C3=A9e?= 229 de la =?utf-8?Q?R=C3=A9volution?= X-PGP-Key-ID: 0x090B11993D9AEBB5 X-PGP-Key: http://www.fdn.fr/~lcourtes/ludovic.asc X-PGP-Fingerprint: 3CE4 6455 8A84 FDC6 9DB4 0CFB 090B 1199 3D9A EBB5 X-OS: x86_64-pc-linux-gnu Date: Sun, 19 Sep 2021 11:57:14 +0200 Message-ID: <875yuwsxad.fsf@inria.fr> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Received-SPF: pass client-ip=192.134.164.104; envelope-from=ludovic.courtes@inria.fr; helo=mail3-relais-sop.national.inria.fr X-Spam_score_int: -41 X-Spam_score: -4.2 X-Spam_bar: ---- X-Spam_report: (-4.2 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.3 (-) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Bad news! --8<---------------cut here---------------start------------->8--- $ guix challenge python-pytorch /gnu/store/dgdswx4vvf07xmhih21n4fnr68dh3fhd-python-pytorch-1.9.0 contents d= iffer: no local build for '/gnu/store/dgdswx4vvf07xmhih21n4fnr68dh3fhd-python-py= torch-1.9.0' https://ci.guix.gnu.org/nar/lzip/dgdswx4vvf07xmhih21n4fnr68dh3fhd-python-= pytorch-1.9.0: 0i55iwy3z4da4lhn93dnrmz775s9ga5kyfli6cmrchacacf9xfpq https://bordeaux.guix.gnu.org/nar/lzip/dgdswx4vvf07xmhih21n4fnr68dh3fhd-p= ython-pytorch-1.9.0: 1fl2v4pd0gcw7wp5k662q0zd4lvvzsggcm5ii8b4kq4v6synhkic differing file: /lib/python3.8/site-packages/torch/lib/libtorch_cpu.so 1 store items were analyzed: - 0 (0.0%) were identical - 1 (100.0%) differed - 0 (0.0%) were inconclusive $ guix describe=20 Generacio 189 Aug 30 2021 12:09:27 (nuna) guix f91ae94 repository URL: https://git.savannah.gnu.org/git/guix.git branch: master commit: f91ae9425bb385b60396a544afe27933896b8fa3 --8<---------------cut here---------------end--------------->8--- The file is 165=C2=A0MiB and Diffoscope (which reads the output of =E2=80= =98objdump=E2=80=99) takes forever on it. However, by comparing the output of =E2=80=98strings=E2=80=99 on each file,= we get a hint: --=-=-= Content-Type: text/x-patch; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable diff -ubBr --show-c-function /tmp/str2 /tmp/str1 --- /tmp/str2 2021-09-19 11:14:47.806798779 +0200 +++ /tmp/str1 2021-09-19 11:14:41.962761127 +0200 @@ -1100584,472 +1100584,472 @@ compute_fast_convolution_input_gradient compute_grad_kernel_transform compute_fast_convolution_kernel_gradient.isra.0 compute_fast_convolution_output -nnp_fft8x8_with_offset_and_stream__avx2.__local0 -nnp_fft8x8_with_offset_and_stream__avx2.__local13 -nnp_fft8x8_with_offset_and_stream__avx2.__local18 -nnp_fft8x8_with_offset_and_stream__avx2.__local1 +nnp_fft8x8_with_offset_and_stream__avx2.__local5 nnp_fft8x8_with_offset_and_stream__avx2.__local16 +nnp_fft8x8_with_offset_and_stream__avx2.__local6 +nnp_fft8x8_with_offset_and_stream__avx2.__local11 +nnp_fft8x8_with_offset_and_stream__avx2.__local0 nnp_fft8x8_with_offset_and_stream__avx2.__local2 nnp_fft8x8_with_offset_and_stream__avx2.__local7 -nnp_fft8x8_with_offset_and_stream__avx2.__local17 -nnp_fft8x8_with_offset_and_stream__avx2.__local10 -nnp_fft8x8_with_offset_and_stream__avx2.__local8 nnp_fft8x8_with_offset_and_stream__avx2.__local15 +nnp_fft8x8_with_offset_and_stream__avx2.__local8 nnp_fft8x8_with_offset_and_stream__avx2.__local3 -nnp_fft8x8_with_offset_and_stream__avx2.__local6 -nnp_fft8x8_with_offset_and_stream__avx2.__local14 -nnp_fft8x8_with_offset_and_stream__avx2.__local9 +nnp_fft8x8_with_offset_and_stream__avx2.__local1 nnp_fft8x8_with_offset_and_stream__avx2.__local4 [=E2=80=A6] nnp_shdotxf8__avx2.__local13 -nnp_shdotxf8__avx2.__local15 nnp_shdotxf8__avx2.__local0 +nnp_shdotxf8__avx2.__local9 +nnp_shdotxf8__avx2.__local10 +nnp_shdotxf8__avx2.__local11 +nnp_shdotxf8__avx2.__local12 +nnp_shdotxf8__avx2.__local2 --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable This appears to come from NNPACK, one of the libraries that are still bundled. These functions seem to be generated by Python scripts that use PeachPy, such as NNPACK/src/x86_64-fma/2d-fourier-8x8.py: --8<---------------cut here---------------start------------->8--- for post_operation in ["stream", "store"]: fft8x8_arguments =3D (arg_t_pointer, arg_f_pointer, arg_t_stride, arg_f= _stride, arg_row_count, arg_column_count, arg_row_offset, arg_column_offset) with Function("nnp_fft8x8_with_offset_and_{post_operation}__avx2".forma= t(post_operation=3Dpost_operation), fft8x8_arguments, target=3Duarch.default + isa.fma3 + isa.avx2): [=E2=80=A6] --8<---------------cut here---------------end--------------->8--- The =E2=80=98__local=E2=80=99 bit in the name comes from PeachPy, in peachp= y/name.py: --8<---------------cut here---------------start------------->8--- suffixed_name =3D "__local" + str(suffix) for name_object in iter(unnamed_objects): # Generate a non-conflicting name by appending a suffix while suffixed_name in self.names: suffix +=3D 1 suffixed_name =3D "__local" + str(suffix) --8<---------------cut here---------------end--------------->8--- So the problem may be that these things get generated in parallel, and thus numbering is non-deterministic. NNPACK/CMakeLists.txt has this bit to generate targets to build all that: --8<---------------cut here---------------start------------->8--- ADD_CUSTOM_COMMAND( OUTPUT ${obj} COMMAND "PYTHONPATH=3D${PEACHPY_PYTHONPATH}" ${PYTHON_EXECUTABLE} -m peachpy.x86_64 -mabi=3Dsysv -g4 -mimage-format=3D${PEACHPY_IMAGE_FORMAT} "-I${PROJECT_SOURCE_DIR}/src" "-I${PROJECT_SOURCE_DIR}/src/x86_= 64-fma" "-I${FP16_SOURCE_DIR}/include" -o ${obj} "${PROJECT_SOURCE_DIR}/${src}" DEPENDS ${NNPACK_BACKEND_PEACHPY_OBJS}) --8<---------------cut here---------------end--------------->8--- It might be that building just those targets sequentially would solve the problem. To be continued=E2=80=A6 Ludo=E2=80=99. --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Tue Sep 21 11:17:37 2021 Received: (at 50672) by debbugs.gnu.org; 21 Sep 2021 15:17:37 +0000 Received: from localhost ([127.0.0.1]:47502 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mShWb-0002vf-KL for submit@debbugs.gnu.org; Tue, 21 Sep 2021 11:17:37 -0400 Received: from mail3-relais-sop.national.inria.fr ([192.134.164.104]:6516) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mShWa-0002vS-6b for 50672@debbugs.gnu.org; Tue, 21 Sep 2021 11:17:36 -0400 IronPort-HdrOrdr: =?us-ascii?q?A9a23=3A3WwbvK0aT5xlPeT0biF2WwqjBJAkLtp133Aq?= =?us-ascii?q?2lEZdPUnSL3/qynIpoVl6faUskdsZJlD8ersBEDkex/hHPFOkOos1NuZLXLbUS?= =?us-ascii?q?6TXfxfBOjZsl/d8k/FltK1BZ0QCZSWYeeYZTMR46fHCUuDYq4dKb+8gcSVbIzl?= =?us-ascii?q?vhBQpG9RGthdBktCe2Om+5JNKzV7OQ=3D=3D?= X-IronPort-AV: E=Sophos;i="5.84,326,1620684000"; d="scan'208";a="393613419" Received: from unknown (HELO ribbon) ([193.50.110.176]) by mail3-relais-sop.national.inria.fr with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 21 Sep 2021 17:17:29 +0200 From: =?utf-8?Q?Ludovic_Court=C3=A8s?= To: 50672@debbugs.gnu.org Subject: Re: bug#50672: python-pytorch is not reproducible References: <875yuwsxad.fsf@inria.fr> Date: Tue, 21 Sep 2021 17:17:29 +0200 In-Reply-To: <875yuwsxad.fsf@inria.fr> ("Ludovic =?utf-8?Q?Court=C3=A8s=22?= =?utf-8?Q?'s?= message of "Sun, 19 Sep 2021 11:57:14 +0200") Message-ID: <87a6k6j6uu.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 50672 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Ludovic Court=C3=A8s skribis: > $ guix challenge python-pytorch > /gnu/store/dgdswx4vvf07xmhih21n4fnr68dh3fhd-python-pytorch-1.9.0 contents= differ: > no local build for '/gnu/store/dgdswx4vvf07xmhih21n4fnr68dh3fhd-python-= pytorch-1.9.0' > https://ci.guix.gnu.org/nar/lzip/dgdswx4vvf07xmhih21n4fnr68dh3fhd-pytho= n-pytorch-1.9.0: 0i55iwy3z4da4lhn93dnrmz775s9ga5kyfli6cmrchacacf9xfpq > https://bordeaux.guix.gnu.org/nar/lzip/dgdswx4vvf07xmhih21n4fnr68dh3fhd= -python-pytorch-1.9.0: 1fl2v4pd0gcw7wp5k662q0zd4lvvzsggcm5ii8b4kq4v6synhkic > differing file: > /lib/python3.8/site-packages/torch/lib/libtorch_cpu.so > > 1 store items were analyzed: > - 0 (0.0%) were identical > - 1 (100.0%) differed > - 0 (0.0%) were inconclusive > $ guix describe=20 > Generacio 189 Aug 30 2021 12:09:27 (nuna) > guix f91ae94 > repository URL: https://git.savannah.gnu.org/git/guix.git > branch: master > commit: f91ae9425bb385b60396a544afe27933896b8fa3 Reported upstream: . Ludo=E2=80=99. From debbugs-submit-bounces@debbugs.gnu.org Fri Sep 24 10:04:26 2021 Received: (at 50672) by debbugs.gnu.org; 24 Sep 2021 14:04:26 +0000 Received: from localhost ([127.0.0.1]:58948 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mTloQ-0006ck-1v for submit@debbugs.gnu.org; Fri, 24 Sep 2021 10:04:26 -0400 Received: from mail3-relais-sop.national.inria.fr ([192.134.164.104]:1656) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mTloO-0006cR-B7 for 50672@debbugs.gnu.org; Fri, 24 Sep 2021 10:04:25 -0400 IronPort-HdrOrdr: =?us-ascii?q?A9a23=3A6Tgu6KGaxJSbeGyypLqEPceALOsnbusQ8zAX?= =?us-ascii?q?PiFKOHlom6mj/fxG88526faKskdtZJhNo7+90dC7MBThHMdOkO0s1NSZLWvbUQ?= =?us-ascii?q?mTTL2KtrGSvQEIcheWnoUx6U4HScZD4bbLfDtHZKjBgTVRKLsbsaa6GJrEv5ak?= =?us-ascii?q?85/pJzsaE52JxWxCe3ym+kQafnghOXJ7eaDsmvavDADQAEgqUg=3D=3D?= X-IronPort-AV: E=Sophos;i="5.84,326,1620684000"; d="scan'208";a="393937449" Received: from unknown (HELO ribbon) ([193.50.110.104]) by mail3-relais-sop.national.inria.fr with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 24 Sep 2021 16:04:17 +0200 From: =?utf-8?Q?Ludovic_Court=C3=A8s?= To: 50672@debbugs.gnu.org Subject: Re: bug#50672: python-pytorch is not reproducible References: <875yuwsxad.fsf@inria.fr> <87a6k6j6uu.fsf@gnu.org> Date: Fri, 24 Sep 2021 16:04:17 +0200 In-Reply-To: <87a6k6j6uu.fsf@gnu.org> ("Ludovic =?utf-8?Q?Court=C3=A8s=22'?= =?utf-8?Q?s?= message of "Tue, 21 Sep 2021 17:17:29 +0200") Message-ID: <87tuiam5ni.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 50672 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Ludovic Court=C3=A8s skribis: > Reported upstream: . PyTorch upstream noted that the problem is in NNPACK, not PyTorch proper. Having unbundled NNPACK in d326dec8115cf5e2cac9497633dc11ecc970361b, I can confirm that PyTorch itself is now reproducible, but NNPACK isn=E2=80= =99t. Reported at . Ludo=E2=80=99. From debbugs-submit-bounces@debbugs.gnu.org Sun Sep 26 16:27:32 2021 Received: (at control) by debbugs.gnu.org; 26 Sep 2021 20:27:32 +0000 Received: from localhost ([127.0.0.1]:38807 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mUakG-0006It-21 for submit@debbugs.gnu.org; Sun, 26 Sep 2021 16:27:32 -0400 Received: from hera.aquilenet.fr ([185.233.100.1]:52246) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mUakE-0006If-6V for control@debbugs.gnu.org; Sun, 26 Sep 2021 16:27:30 -0400 Received: from localhost (localhost [127.0.0.1]) by hera.aquilenet.fr (Postfix) with ESMTP id A028F6E3 for ; Sun, 26 Sep 2021 22:27:23 +0200 (CEST) X-Virus-Scanned: Debian amavisd-new at aquilenet.fr Received: from hera.aquilenet.fr ([127.0.0.1]) by localhost (hera.aquilenet.fr [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id DVjq9kuTyfw2 for ; Sun, 26 Sep 2021 22:27:22 +0200 (CEST) Received: from ribbon (unknown [IPv6:2a01:e0a:1d:7270:af76:b9b:ca24:c465]) by hera.aquilenet.fr (Postfix) with ESMTPSA id 9FA161B6 for ; Sun, 26 Sep 2021 22:27:22 +0200 (CEST) Date: Sun, 26 Sep 2021 22:27:22 +0200 Message-Id: <87h7e7krpx.fsf@gnu.org> To: control@debbugs.gnu.org From: =?utf-8?Q?Ludovic_Court=C3=A8s?= Subject: control message for bug #50672 MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Spamd-Bar: -- Authentication-Results: hera.aquilenet.fr X-Rspamd-Server: hera X-Rspamd-Queue-Id: A028F6E3 X-Spamd-Result: default: False [-3.00 / 15.00]; ARC_NA(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; FROM_HAS_DN(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; MIME_GOOD(-0.10)[text/plain]; PREVIOUSLY_DELIVERED(0.00)[control@debbugs.gnu.org]; TO_DN_NONE(0.00)[]; RCPT_COUNT_ONE(0.00)[1]; RCVD_NO_TLS_LAST(0.10)[]; FROM_EQ_ENVFROM(0.00)[]; RCVD_COUNT_TWO(0.00)[2]; MID_RHS_MATCH_FROM(0.00)[]; BAYES_HAM(-3.00)[100.00%] X-Spam-Score: 1.0 (+) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) retitle 50672 nnpack is not reproducible quit From debbugs-submit-bounces@debbugs.gnu.org Mon Sep 27 09:25:55 2021 Received: (at 50672) by debbugs.gnu.org; 27 Sep 2021 13:25:55 +0000 Received: from localhost ([127.0.0.1]:40087 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mUqdm-0000wP-S1 for submit@debbugs.gnu.org; Mon, 27 Sep 2021 09:25:55 -0400 Received: from mail-qk1-f169.google.com ([209.85.222.169]:33426) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mUqdl-0000wA-K2 for 50672@debbugs.gnu.org; Mon, 27 Sep 2021 09:25:54 -0400 Received: by mail-qk1-f169.google.com with SMTP id d207so37024456qkg.0 for <50672@debbugs.gnu.org>; Mon, 27 Sep 2021 06:25:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=VFRlwK4mV6naqyfCI5Y6XVMFjvh40/J3tb8OHLotFNI=; b=mATdSy4AJ6xux8Uw3jqN6KxrK2KcWYFbI1GHC9+/ut+baiqfO6Mk5myW8NipQOlGCY fvJrcLMVOroyV7kPsk+hEhyBLHoetBK8t/dK3tGtQ3IHbP4/lR9acHAKyjD6jznUu6Xn yy6jEP9xSbifFLVs+ViuSs+5wOizeAoXYblDZj4f2eXvI3S6s3bx+CJpbpQnkvKuk6Xe fIKMEoGo2XzTKtWfD5xKX5wvelEB+zelPDoI8LADFJS367akDCaVhzzWki1bQEXQI9Wj vA+kBepImqecb2d4Y9a3IrgxR5sc5bbFWIyFYUQ3KTKT4zyOwuNO4nfGaI7AXGDR8vce EVmw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=VFRlwK4mV6naqyfCI5Y6XVMFjvh40/J3tb8OHLotFNI=; b=HxZJk+nGYlGrN4XyvHXKTrVyiH0qK3UfvrrqCImkTe8mqQGXh76Qu9YQE/MmwJlxkN 5xRZa3SjxgP3Obm5VU75BJDRLx7kVUJdUt+EknM6RNDFTE8v4I8BgXvHIjOFF3PhbQPO iF/5sIclotnfxBJNuS3ErIr3XAZC9tmAwAj6gT6llN6c7rJ1WQ/EKXN3xUk7Xgn1xy1B GxdtFErzUTwyMYihYjp5Ox3rrX+ICFtbHSr8vdmIiAF+OGzrEdSfOKQsAqEMjxVCrRJZ +PJAWp82NiZ5TUVWInpDLPk3lDGTn2ELm3oWHT1QBeoVEIMVovQN1/K1Gu3PRKONvuew jbJg== X-Gm-Message-State: AOAM531o6HolOkG6c/LVIDE8gTmKJtLGppOISV6hn5sriLkUKP0a0WGN RHdTiV6CbRH80/p8O8lJGBmryhc3zCSKgWRLRUs= X-Google-Smtp-Source: ABdhPJyBGjuCRHfkYOt1u4CsdQWs84EDoSfFnBzNBdQSmJ3pBYeCttsYfyE6D2ZYh/jExbCH6OI8IKFw3Re84l0mMN8= X-Received: by 2002:a37:a943:: with SMTP id s64mr23986187qke.422.1632749147849; Mon, 27 Sep 2021 06:25:47 -0700 (PDT) MIME-Version: 1.0 References: <875yuwsxad.fsf@inria.fr> <87a6k6j6uu.fsf@gnu.org> <87tuiam5ni.fsf@gnu.org> In-Reply-To: <87tuiam5ni.fsf@gnu.org> From: zimoun Date: Mon, 27 Sep 2021 15:25:36 +0200 Message-ID: Subject: Re: bug#50672: python-pytorch is not reproducible To: =?UTF-8?Q?Ludovic_Court=C3=A8s?= Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 50672 Cc: 50672@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hi, On Fri, 24 Sept 2021 at 16:11, Ludovic Court=C3=A8s wrote: > Having unbundled NNPACK in d326dec8115cf5e2cac9497633dc11ecc970361b, I > can confirm that PyTorch itself is now reproducible, but NNPACK isn=E2=80= =99t. I reproduce: "guix build nnpack --no-grafts --check" differs. Pytorch, not= . > PyTorch upstream noted that the problem is in NNPACK, not PyTorch > proper. Closing this report? However, I notice 2 things: 1- Unbundled dependencies are still fetched 2- Does the Git submodule mechanism work with the SWH fallback? --8<---------------cut here---------------start------------->8--- Initialized empty Git repository in /gnu/store/=E2=80=A6-python-pytorch-1.9.0-checkout/.git/ >From https://github.com/pytorch/pytorch * tag v1.9.0 -> FETCH_HEAD [...] HEAD is now at d69c22d [docs] Add torch.package documentation for beta release (#59886) /gnu/store/=E2=80=A6-bash-minimal-5.0.16/bin/sh: warning: setlocale: LC_ALL= : cannot change locale (en_US.utf8) Submodule 'android/libs/fbjni' (https://github.com/facebookincubator/fbjni.git) registered for path 'android/libs/fbjni' Submodule 'third_party/NNPACK_deps/FP16' (https://github.com/Maratyszcza/FP16.git) registered for path 'third_party/FP16' Submodule 'third_party/NNPACK_deps/FXdiv' (https://github.com/Maratyszcza/FXdiv.git) registered for path 'third_party/FXdiv' Submodule 'third_party/NNPACK' (https://github.com/Maratyszcza/NNPACK.git) registered for path 'third_party/NNPACK' Submodule 'third_party/QNNPACK' (https://github.com/pytorch/QNNPACK) registered for path 'third_party/QNNPACK' Submodule 'third_party/XNNPACK' (https://github.com/google/XNNPACK.git) registered for path 'third_party/XNNPACK' [...] Submodule 'third_party/NNPACK_deps/psimd' (https://github.com/Maratyszcza/psimd.git) registered for path 'third_party/psimd' Submodule 'third_party/NNPACK_deps/pthreadpool' (https://github.com/Maratyszcza/pthreadpool.git) registered for path 'third_party/pthreadpool' [...] Cloning into '/gnu/store/=E2=80=A6-python-pytorch-1.9.0-checkout/third_part= y/NNPACK'... Cloning into '/gnu/store/=E2=80=A6-python-pytorch-1.9.0-checkout/third_part= y/QNNPACK'... Cloning into '/gnu/store/=E2=80=A6-python-pytorch-1.9.0-checkout/third_part= y/XNNPACK'... [...] Submodule path 'third_party/NNPACK': checked out 'c07e3a0400713d546e0dea2d5466dd22ea389c73' Submodule path 'third_party/QNNPACK': checked out '7d2a4e9931a82adc3814275b6219a03e24e36b4c' Submodule path 'third_party/XNNPACK': checked out '55d53a4e7079d38e90acd75dd9e4f9e781d2da35' [...] --8<---------------cut here---------------end--------------->8--- Cheers, simon From debbugs-submit-bounces@debbugs.gnu.org Tue Sep 28 05:24:09 2021 Received: (at 50672) by debbugs.gnu.org; 28 Sep 2021 09:24:09 +0000 Received: from localhost ([127.0.0.1]:43857 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mV9LM-0006pC-PU for submit@debbugs.gnu.org; Tue, 28 Sep 2021 05:24:08 -0400 Received: from mail3-relais-sop.national.inria.fr ([192.134.164.104]:12798) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mV9LL-0006on-KE for 50672@debbugs.gnu.org; Tue, 28 Sep 2021 05:24:08 -0400 IronPort-HdrOrdr: =?us-ascii?q?A9a23=3AtgXqtqBIA6CKOYnlHelO55DYdb4zR+YMi2TD?= =?us-ascii?q?GXoddfUzSL3jqynOpoVh6faaskd0ZJhNo7u90ey7MBThHP1OkPEs1NWZLW/bUQ?= =?us-ascii?q?KTRelfBMnZrAEIcBeTygcy781dmuRFeaTNJGk/q/yS2njcL/8QhOCoyeSGheDR?= =?us-ascii?q?w2x1VgFsdshbnmVEIzfeK2NOACtLFfMCZfmhz/sCnhSYPVYafoCaKxA+P9Trlp?= =?us-ascii?q?nxmI3hZAIaBxgh4BKfyR6h9bKSKXml9yZbbwhrqI1NzVT4?= X-IronPort-AV: E=Sophos;i="5.84,326,1620684000"; d="scan'208";a="394220743" Received: from unknown (HELO ribbon) ([193.50.110.206]) by mail3-relais-sop.national.inria.fr with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 28 Sep 2021 11:24:00 +0200 From: =?utf-8?Q?Ludovic_Court=C3=A8s?= To: zimoun Subject: Re: bug#50672: python-pytorch is not reproducible References: <875yuwsxad.fsf@inria.fr> <87a6k6j6uu.fsf@gnu.org> <87tuiam5ni.fsf@gnu.org> X-URL: http://www.fdn.fr/~lcourtes/ X-Revolutionary-Date: 7 =?utf-8?Q?Vend=C3=A9miaire?= an 230 de la =?utf-8?Q?R=C3=A9volution?= X-PGP-Key-ID: 0x090B11993D9AEBB5 X-PGP-Key: http://www.fdn.fr/~lcourtes/ludovic.asc X-PGP-Fingerprint: 3CE4 6455 8A84 FDC6 9DB4 0CFB 090B 1199 3D9A EBB5 X-OS: x86_64-pc-linux-gnu Date: Tue, 28 Sep 2021 11:24:00 +0200 In-Reply-To: (zimoun's message of "Mon, 27 Sep 2021 15:25:36 +0200") Message-ID: <87ilylf3yn.fsf@inria.fr> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 50672 Cc: 50672@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Hi, zimoun skribis: > On Fri, 24 Sept 2021 at 16:11, Ludovic Court=C3=A8s wrote: > >> Having unbundled NNPACK in d326dec8115cf5e2cac9497633dc11ecc970361b, I >> can confirm that PyTorch itself is now reproducible, but NNPACK isn=E2= =80=99t. > > I reproduce: "guix build nnpack --no-grafts --check" differs. Pytorch, n= ot. > >> PyTorch upstream noted that the problem is in NNPACK, not PyTorch >> proper. > > Closing this report? No, I=E2=80=99ve retitled it. Now looking at PeachPy: https://github.com/Maratyszcza/PeachPy/issues/88 > However, I notice 2 things: > > 1- Unbundled dependencies are still fetched Yes but the snippet wipes them right after. > 2- Does the Git submodule mechanism work with the SWH fallback? No, not yet; there=E2=80=99s a comment in (guix git-download). Fixing it s= hould be doable. Thanks, Ludo=E2=80=99. From debbugs-submit-bounces@debbugs.gnu.org Fri Oct 22 11:31:19 2021 Received: (at 50672) by debbugs.gnu.org; 22 Oct 2021 15:31:19 +0000 Received: from localhost ([127.0.0.1]:33647 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mdwVr-0004Xm-4r for submit@debbugs.gnu.org; Fri, 22 Oct 2021 11:31:19 -0400 Received: from mail3-relais-sop.national.inria.fr ([192.134.164.104]:48258) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mdwVn-0004XU-EC for 50672@debbugs.gnu.org; Fri, 22 Oct 2021 11:31:18 -0400 IronPort-HdrOrdr: =?us-ascii?q?A9a23=3AHRXCXqC5nwo1Ca3lHem555DYdb4zR+YMi2TD?= =?us-ascii?q?GXoddfU1SL38qynAppomPHPP4wr5HUtApTniAtjjfZq/z/5ICOAqVN+ftUvd11?= =?us-ascii?q?dAR7sP0WKN+Vfd8mHFh41g6Zs=3D?= X-IronPort-AV: E=Sophos;i="5.84,326,1620684000"; d="scan'208";a="397113127" Received: from unknown (HELO ribbon) ([193.50.110.110]) by mail3-relais-sop.national.inria.fr with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 22 Oct 2021 17:31:08 +0200 From: =?utf-8?Q?Ludovic_Court=C3=A8s?= To: zimoun Subject: Re: bug#50672: nnpack is not reproducible References: <875yuwsxad.fsf@inria.fr> <87a6k6j6uu.fsf@gnu.org> <87tuiam5ni.fsf@gnu.org> <87ilylf3yn.fsf@inria.fr> Date: Fri, 22 Oct 2021 17:31:08 +0200 In-Reply-To: <87ilylf3yn.fsf@inria.fr> ("Ludovic =?utf-8?Q?Court=C3=A8s=22?= =?utf-8?Q?'s?= message of "Tue, 28 Sep 2021 11:24:00 +0200") Message-ID: <87pmrxt6tf.fsf_-_@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 50672 Cc: 50672@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Hi, Ludovic Court=C3=A8s skribis: > No, I=E2=80=99ve retitled it. Now looking at PeachPy: > > https://github.com/Maratyszcza/PeachPy/issues/88 For the record, I tried the attached patch in an attempt to sort things as discussed in the issue above, but it doesn=E2=80=99t have the intended effect. There must be other unsorted dictionaries elsewhere. Suggestions welcome! Ludo=E2=80=99. --=-=-= Content-Type: text/x-patch Content-Disposition: inline; filename=python-peachpy-determinism.patch Content-Description: the patch Make PeachPy processes deterministic: https://github.com/Maratyszcza/PeachPy/issues/88 https://issues.guix.gnu.org/50672 diff --git a/peachpy/name.py b/peachpy/name.py index b6a03dc..c069fc2 100644 --- a/peachpy/name.py +++ b/peachpy/name.py @@ -95,6 +95,10 @@ class Namespace: self.prenames[scope_name.prename].add(scope) def assign_names(self): + # Step 0: sort the dictionary for deterministic output + self.prenames = dict(sorted(self.prenames.items(), + key=lambda item: "" if item[0] == None else item[0])) + # Step 1: assign names to symbols with prenames with no conflicts for prename in six.iterkeys(self.prenames): if prename is not None: --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Fri Oct 22 23:32:59 2021 Received: (at 50672) by debbugs.gnu.org; 23 Oct 2021 03:32:59 +0000 Received: from localhost ([127.0.0.1]:34102 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1me7mF-0002MD-H9 for submit@debbugs.gnu.org; Fri, 22 Oct 2021 23:32:59 -0400 Received: from out10.migadu.com ([46.105.121.227]:63844) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1me7mB-0002M2-9r for 50672@debbugs.gnu.org; Fri, 22 Oct 2021 23:32:57 -0400 X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kyleam.com; s=key1; t=1634959973; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=QT/HTpeYDAYXyfzH3QVhAa/aRDODw3qGJc44T4imny8=; b=snZ95C5t+2rcNPC7voDkUyGVwhOX+U3/N0h5q49iV5o0R4iVjI4HvLItR9wx0Kzl44cTUm 0D1V+ZVjygDTCpv66g+zN3+ivBOp+VBXwEeL+EpLlRO+AgMEv/sRtdeW1ypHzpnlKigaBl R/n4A8w55qli1d1+zDF7vXSmuWlQ9VQ62asO4TQI7si13hzM83EK1HomYCXbc3+MEl1d4r QaUWyJCVarReXL+sUNZU8kb37SZK0Z7a092NtgCrtucn3/01ongJrvuCXMioy7w1O8VYCI dltGydbd2ClpM3sbqIewmFfte8l3io4/iGyFw/47XUB68VmZ7ILvJPaFm+LGSA== From: Kyle Meyer To: Ludovic =?utf-8?Q?Court=C3=A8s?= Subject: Re: bug#50672: nnpack is not reproducible In-Reply-To: <87pmrxt6tf.fsf_-_@gnu.org> References: <875yuwsxad.fsf@inria.fr> <87a6k6j6uu.fsf@gnu.org> <87tuiam5ni.fsf@gnu.org> <87ilylf3yn.fsf@inria.fr> <87pmrxt6tf.fsf_-_@gnu.org> Date: Fri, 22 Oct 2021 23:32:50 -0400 Message-ID: <87ee8ch0v1.fsf@kyleam.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Migadu-Flow: FLOW_OUT X-Migadu-Auth-User: kyle@kyleam.com X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 50672 Cc: zimoun , 50672@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Ludovic Court=C3=A8s writes: > For the record, I tried the attached patch in an attempt to sort things > as discussed in the issue above, but it doesn=E2=80=99t have the intended > effect. There must be other unsorted dictionaries elsewhere. Hmm, I don't think dictionaries are a likely culprit here because Python's dict implementation preserves the insertion order as of Python v3.6 (and that behavior is declared as part of the language spec with v3.7). > diff --git a/peachpy/name.py b/peachpy/name.py > index b6a03dc..c069fc2 100644 > --- a/peachpy/name.py > +++ b/peachpy/name.py > @@ -95,6 +95,10 @@ class Namespace: > self.prenames[scope_name.prename].add(scope) >=20=20 > def assign_names(self): > + # Step 0: sort the dictionary for deterministic output > + self.prenames =3D dict(sorted(self.prenames.items(), > + key=3Dlambda item: "" if item[0] =3D= =3D None else item[0])) > + In cases where the order of the keys isn't specified (i.e. Python 3.5 and below), I think the end result after your change is the same: it creates a new dictionary for sorted _input_, but things won't necessarily come out in the same order. I'm not familiar with PeachPy, but taking a peek at name.py, the sets used for the values of the prenames dictionary could be the problem. And if that's the case, one solution would be switching those values from sets to dictionaries. With the change below (on top of PeachPy's 257881e), nnpack builds reliably for me across a couple of attempts: $ guix-dev build --with-git-url=3Dpython-peachpy=3D$local --no-grafts --c= heck nnpack successfully built /gnu/store/7z4nl55gssrf9na7wsvmw1dsqgawnj2p-nnpack-0.0= -1.c07e3a0.drv successfully built /gnu/store/7z4nl55gssrf9na7wsvmw1dsqgawnj2p-nnpack-0.0= -1.c07e3a0.drv /gnu/store/4ihjil42fbk53q73gpvdakynbv9q5q09-nnpack-0.0-1.c07e3a0 diff --git a/peachpy/name.py b/peachpy/name.py index b6a03dc..412079d 100644 --- a/peachpy/name.py +++ b/peachpy/name.py @@ -86,13 +86,13 @@ def add_scoped_name(self, scoped_name): self.names[scope_name.name] =3D scope else: assert scope_name.name is None - self.prenames.setdefault(scope_name.prename, set()) + self.prenames.setdefault(scope_name.prename, {}) if subscoped_name: for subscope in iter(self.prenames[scope_name.prename]): if isinstance(subscope, Namespace) and subscope.scope_= name is scope_name: subscope.add_scoped_name(subscoped_name) return - self.prenames[scope_name.prename].add(scope) + self.prenames[scope_name.prename][scope] =3D None =20 def assign_names(self): # Step 1: assign names to symbols with prenames with no conflicts From debbugs-submit-bounces@debbugs.gnu.org Mon Oct 25 08:54:38 2021 Received: (at 50672-done) by debbugs.gnu.org; 25 Oct 2021 12:54:38 +0000 Received: from localhost ([127.0.0.1]:41872 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mezUs-0003Nt-4Z for submit@debbugs.gnu.org; Mon, 25 Oct 2021 08:54:38 -0400 Received: from mail2-relais-roc.national.inria.fr ([192.134.164.83]:38385) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mezUp-0003Nb-Jb for 50672-done@debbugs.gnu.org; Mon, 25 Oct 2021 08:54:36 -0400 IronPort-Data: =?us-ascii?q?A9a23=3A6ZJDwat/JTMZBbpiBcMblcnVV+fnVJZcMUV32f8?= =?us-ascii?q?akzHdYEJGY0x3ymUdW2/SO/uNZGGgLttwbt+w/EID65HdyYIwSFc9rCBgHilAw?= =?us-ascii?q?SbnLYTAfx2oZ0t+DeWaERk5t51GAjX4wXFdokb0/n9BCZC86ykjvU20buCkUre?= =?us-ascii?q?dYnosHVYMpBoJ0nqPpcZo2+aEvvDpW2thifuqyyHuEAfNNwxcagr42IrfwP9bh?= =?us-ascii?q?8kejRtD1rAIiV+ni3eF/5UdJMp3yahctBIUSKEMdgKxb76rIL1UYgrkExkR5tO?= =?us-ascii?q?Nyt4Xc2UQQ7TYOg7mZnh+Avn5xEUa4HVriuBibaJ0hUR/0l1lm/h11dlKq527D?= =?us-ascii?q?wwuI7fQlf81Uh9CEig4M7cuFLrveiLu75XLp6HBWz62qxl0N2kkPIgf/KBrBnx?= =?us-ascii?q?S8uEeJRgCaxmCg6S9x7fTYrQ02Jt5acXsOo43tnxqxyzWFrApR42FRL/Fjfdbz?= =?us-ascii?q?TM9rsNfGfvXYowSbj8HUfhqS3WjIX9OWcl4wb/u3yCnNWQB8DqoSWMMyzC75GR?= =?us-ascii?q?MPHLFabI5ouC3ePg=3D?= IronPort-HdrOrdr: =?us-ascii?q?A9a23=3AmF8E3araS27xvJRUKttpNckaV5pIeYIsimQD?= =?us-ascii?q?101hICG9Ffb0qynOpp8mPHDP6Qr5NEtOpTniAsO9qBHnlaKdiLN5VYtKNzOLhI?= =?us-ascii?q?LHFu9f0bc=3D?= X-IronPort-AV: E=Sophos;i="5.87,180,1631570400"; d="scan'208";a="329610" Received: from unknown (HELO ribbon) ([193.50.110.110]) by mail2-relais-roc.national.inria.fr with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 25 Oct 2021 14:54:29 +0200 From: =?utf-8?Q?Ludovic_Court=C3=A8s?= To: Kyle Meyer Subject: Re: bug#50672: nnpack is not reproducible References: <875yuwsxad.fsf@inria.fr> <87a6k6j6uu.fsf@gnu.org> <87tuiam5ni.fsf@gnu.org> <87ilylf3yn.fsf@inria.fr> <87pmrxt6tf.fsf_-_@gnu.org> <87ee8ch0v1.fsf@kyleam.com> X-URL: http://www.fdn.fr/~lcourtes/ X-Revolutionary-Date: 4 Brumaire an 230 de la =?utf-8?Q?R=C3=A9volution?= X-PGP-Key-ID: 0x090B11993D9AEBB5 X-PGP-Key: http://www.fdn.fr/~lcourtes/ludovic.asc X-PGP-Fingerprint: 3CE4 6455 8A84 FDC6 9DB4 0CFB 090B 1199 3D9A EBB5 X-OS: x86_64-pc-linux-gnu Date: Mon, 25 Oct 2021 14:54:28 +0200 In-Reply-To: <87ee8ch0v1.fsf@kyleam.com> (Kyle Meyer's message of "Fri, 22 Oct 2021 23:32:50 -0400") Message-ID: <87a6ixl0xn.fsf@inria.fr> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 50672-done Cc: 50672-done@debbugs.gnu.org, zimoun X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Hi! Kyle Meyer skribis: > Ludovic Court=C3=A8s writes: > >> For the record, I tried the attached patch in an attempt to sort things >> as discussed in the issue above, but it doesn=E2=80=99t have the intended >> effect. There must be other unsorted dictionaries elsewhere. > > Hmm, I don't think dictionaries are a likely culprit here because > Python's dict implementation preserves the insertion order as of Python > v3.6 (and that behavior is declared as part of the language spec with > v3.7). Ah, silly me. > In cases where the order of the keys isn't specified (i.e. Python 3.5 > and below), I think the end result after your change is the same: it > creates a new dictionary for sorted _input_, but things won't > necessarily come out in the same order. Noted, thanks for explaining. > I'm not familiar with PeachPy, but taking a peek at name.py, the sets > used for the values of the prenames dictionary could be the problem. > And if that's the case, one solution would be switching those values > from sets to dictionaries. > > With the change below (on top of PeachPy's 257881e), nnpack builds > reliably for me across a couple of attempts: > > $ guix-dev build --with-git-url=3Dpython-peachpy=3D$local --no-grafts -= -check nnpack > successfully built /gnu/store/7z4nl55gssrf9na7wsvmw1dsqgawnj2p-nnpack-0= .0-1.c07e3a0.drv > successfully built /gnu/store/7z4nl55gssrf9na7wsvmw1dsqgawnj2p-nnpack-0= .0-1.c07e3a0.drv > /gnu/store/4ihjil42fbk53q73gpvdakynbv9q5q09-nnpack-0.0-1.c07e3a0 Your patch does the trick, indeed. I went ahead and pushed it as b87fe805aa66851f17f56078cb0e94f7cc4525df. Thank you! Ludo=E2=80=99. From unknown Sat Sep 20 11:29:45 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Tue, 23 Nov 2021 12:24:07 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator