Subject: bug#50667: Update ecomplete when used via standard UI

From: Augusto Stoffel <[email-masked]>
Date: Sat, 18 Sep 2021 23:01:30 +0200

Tags: patch

If one keeps sets

    (setq message-mail-alias-type nil ;; or keep the default 'abbrev
          message-expand-name-standard-ui t)

and an ecomplete database file, then everything works OOTB, except that
the ecomplete database doesn't get updated with new addresses.

Is the following change a reasonable fix for this?

>From 9cc0c8d8dd8343bc615f2a4a18e38e8940c340cb Mon Sep 17 00:00:00 2001
From: Augusto Stoffel <[email-masked]>
Date: Sat, 18 Sep 2021 22:51:00 +0200
Subject: [PATCH] * gnus/message.el (message-send): Always update ecomplete if
 loaded

---
 lisp/gnus/message.el | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lisp/gnus/message.el b/lisp/gnus/message.el
index 4a754b9856..98a70330c4 100644
--- a/lisp/gnus/message.el
+++ b/lisp/gnus/message.el
@@ -4391,7 +4391,7 @@ message-send
 	(run-hooks 'message-sent-hook))
       (message "Sending...done")
       ;; Do ecomplete address snarfing.
-      (when (and (message-mail-alias-type-p 'ecomplete)
+      (when (and (bound-and-true-p ecomplete-database)
 		 (not message-inhibit-ecomplete))
 	(message-put-addresses-in-ecomplete))
       ;; Mark the buffer as unmodified and delete auto-save.
-- 
2.31.1