From unknown Sat Sep 20 06:39:32 2025 X-Loop: help-debbugs@gnu.org Subject: bug#50667: Update ecomplete when used via standard UI Resent-From: Augusto Stoffel Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 18 Sep 2021 21:02:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 50667 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: 50667@debbugs.gnu.org X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.163199889913685 (code B ref -1); Sat, 18 Sep 2021 21:02:01 +0000 Received: (at submit) by debbugs.gnu.org; 18 Sep 2021 21:01:39 +0000 Received: from localhost ([127.0.0.1]:37073 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mRhSt-0003Yf-Ir for submit@debbugs.gnu.org; Sat, 18 Sep 2021 17:01:39 -0400 Received: from lists.gnu.org ([209.51.188.17]:38100) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mRhSr-0003YX-4o for submit@debbugs.gnu.org; Sat, 18 Sep 2021 17:01:38 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:45444) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mRhSq-000416-QQ for bug-gnu-emacs@gnu.org; Sat, 18 Sep 2021 17:01:36 -0400 Received: from mail-wm1-x32c.google.com ([2a00:1450:4864:20::32c]:39497) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mRhSp-0007M8-8Q for bug-gnu-emacs@gnu.org; Sat, 18 Sep 2021 17:01:36 -0400 Received: by mail-wm1-x32c.google.com with SMTP id 196-20020a1c04cd000000b002fa489ffe1fso12603489wme.4 for ; Sat, 18 Sep 2021 14:01:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:subject:date:message-id:mime-version; bh=KTnMx0pjyiOGvMTEF6v5mQ3PJ21D3sWTagobfNjnzPw=; b=pykZVubCg6IKZXsR4d8201xSJLgtFyrTrFgigar9BYA1qtvibXp5LYt+GYSJ/rgpE4 cQvDyt+EaY0yCqFUHJZz69cgJeX1gMTm6XjneEV3h5e2CfHQw3CiC4069txPPZyGVAWJ /tzpJUdCkTE+EUSkNryOSqABhxz/t2dswghMlH6mk0VtlOP1b3DO8idemC9TeFVSjyC+ JrVPLXUStB98pi995FuYyH3YyLMqyoW1Qd+kY3hWedLrNYjED9JyE5VLe7UX03zbB1uK q0EHt9L50/G7yoE73dxdtdSsPiZX0zLu6DyyaTWM2GOFjnG5YU8KeCHE1fFzeu1+sfwM Pm8g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:subject:date:message-id:mime-version; bh=KTnMx0pjyiOGvMTEF6v5mQ3PJ21D3sWTagobfNjnzPw=; b=bj6nsgZLGAhxe4TKycn9fXKJyJa42v47rlmoB/pPC8I5ZuDeT5IDFoYIXmb7HNd2+x uwhoCqMHzTosUVtM9hBCHQc6X3S4WhU3S0II/1yFLW/U1K1mEtX7DMGdNa6caPOf5gX3 j+J68bnklKppzcSwPIE2uFSxiuoSG1NJ3w9NX7a+GcOxIFYig4K24vqm33Mg9yXkMdLV GZpKP8giuCEM2rwxEv7qUJsC/V1JglL103QQnqmtEoWbf2leU6B7mPSZn7bk/S94L0xL eQnQO74I5NawuxQyj6Dec4rRhb9j6avUyvHa6PeRQ4k7uZywvSLiGdYEY6xpJgivWd9E 8QLw== X-Gm-Message-State: AOAM533Bq00JSGX1b6klwX6pC8Ji59r+vCRPYZM9mt0S0jFb9DnrVk9q Pl27Bfa8WKCYl1G6Ni8u+0AWl7Edm7c= X-Google-Smtp-Source: ABdhPJy9+FGYo2aq55fvmIzPdHTkMYYapcn6A5oLjlxxB6QAntfuzPLGqD4XLJt272tI1/no8Ob7Ug== X-Received: by 2002:a7b:c3d2:: with SMTP id t18mr16902342wmj.33.1631998892654; Sat, 18 Sep 2021 14:01:32 -0700 (PDT) Received: from ars3 ([2a02:8109:8ac0:56d0::3c3e]) by smtp.gmail.com with ESMTPSA id r9sm3165169wru.2.2021.09.18.14.01.31 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 18 Sep 2021 14:01:32 -0700 (PDT) From: Augusto Stoffel Date: Sat, 18 Sep 2021 23:01:30 +0200 Message-ID: <871r5l1tud.fsf@gmail.com> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Received-SPF: pass client-ip=2a00:1450:4864:20::32c; envelope-from=arstoffel@gmail.com; helo=mail-wm1-x32c.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.3 (-) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) --=-=-= Content-Type: text/plain Tags: patch If one keeps sets (setq message-mail-alias-type nil ;; or keep the default 'abbrev message-expand-name-standard-ui t) and an ecomplete database file, then everything works OOTB, except that the ecomplete database doesn't get updated with new addresses. Is the following change a reasonable fix for this? --=-=-= Content-Type: text/patch Content-Disposition: attachment; filename=0001-gnus-message.el-message-send-Always-update-ecomplete.patch >From 9cc0c8d8dd8343bc615f2a4a18e38e8940c340cb Mon Sep 17 00:00:00 2001 From: Augusto Stoffel Date: Sat, 18 Sep 2021 22:51:00 +0200 Subject: [PATCH] * gnus/message.el (message-send): Always update ecomplete if loaded --- lisp/gnus/message.el | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lisp/gnus/message.el b/lisp/gnus/message.el index 4a754b9856..98a70330c4 100644 --- a/lisp/gnus/message.el +++ b/lisp/gnus/message.el @@ -4391,7 +4391,7 @@ message-send (run-hooks 'message-sent-hook)) (message "Sending...done") ;; Do ecomplete address snarfing. - (when (and (message-mail-alias-type-p 'ecomplete) + (when (and (bound-and-true-p ecomplete-database) (not message-inhibit-ecomplete)) (message-put-addresses-in-ecomplete)) ;; Mark the buffer as unmodified and delete auto-save. -- 2.31.1 --=-=-=-- From unknown Sat Sep 20 06:39:32 2025 X-Loop: help-debbugs@gnu.org Subject: bug#50667: Update ecomplete when used via standard UI Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 18 Sep 2021 21:08:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 50667 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Augusto Stoffel Cc: 50667@debbugs.gnu.org Received: via spool by 50667-submit@debbugs.gnu.org id=B50667.163199923214176 (code B ref 50667); Sat, 18 Sep 2021 21:08:01 +0000 Received: (at 50667) by debbugs.gnu.org; 18 Sep 2021 21:07:12 +0000 Received: from localhost ([127.0.0.1]:37078 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mRhYG-0003ga-7u for submit@debbugs.gnu.org; Sat, 18 Sep 2021 17:07:12 -0400 Received: from quimby.gnus.org ([95.216.78.240]:33340) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mRhYE-0003gM-8M for 50667@debbugs.gnu.org; Sat, 18 Sep 2021 17:07:11 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=OCBU5iCAZS/tdC0rDV2Rv01EA72mwRanxFzHkHzzdxE=; b=qprj/sIvnnoJInGqYYkFWXvhpv sz+M52fp+iLmV2i7CcPaYXt4ciRLNhMsWFQAQibyOJ7thm0KySuNNxNsQugkh3guTfKzfmJ7skNZy M0p+x+z8wwCcwD0/lsi+PSpoFEwsdH1pYZQrRokhhaCEfoKKcks7VGymG0xHb85mGdUU=; Received: from [84.212.220.105] (helo=elva) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mRhY3-00088N-Uv; Sat, 18 Sep 2021 23:07:02 +0200 From: Lars Ingebrigtsen References: <871r5l1tud.fsf@gmail.com> Date: Sat, 18 Sep 2021 23:06:58 +0200 In-Reply-To: <871r5l1tud.fsf@gmail.com> (Augusto Stoffel's message of "Sat, 18 Sep 2021 23:01:30 +0200") Message-ID: <87r1dlpp8t.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Augusto Stoffel writes: > If one keeps sets > > (setq message-mail-alias-type nil ;; or keep the default 'abbrev > message-expand-name-standard-ui t) > > and an ecomplete database file, then everything works OOTB, Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Augusto Stoffel writes: > If one keeps sets > > (setq message-mail-alias-type nil ;; or keep the default 'abbrev > message-expand-name-standard-ui t) > > and an ecomplete database file, then everything works OOTB, Works in what way? > except that the ecomplete database doesn't get updated with new > addresses. > > Is the following change a reasonable fix for this? [...] > - (when (and (message-mail-alias-type-p 'ecomplete) > + (when (and (bound-and-true-p ecomplete-database) I think this would be highly surprising behaviour -- just loading a library shouldn't have such side effects. What's your use case here? You don't want to use ecomplete for alias expansions, but you still want to update the ecomplete database? -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From unknown Sat Sep 20 06:39:32 2025 X-Loop: help-debbugs@gnu.org Subject: bug#50667: Update ecomplete when used via standard UI Resent-From: Augusto Stoffel Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 18 Sep 2021 21:36:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 50667 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Lars Ingebrigtsen Cc: 50667@debbugs.gnu.org Received: via spool by 50667-submit@debbugs.gnu.org id=B50667.163200096016882 (code B ref 50667); Sat, 18 Sep 2021 21:36:02 +0000 Received: (at 50667) by debbugs.gnu.org; 18 Sep 2021 21:36:00 +0000 Received: from localhost ([127.0.0.1]:37106 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mRi07-0004OE-R4 for submit@debbugs.gnu.org; Sat, 18 Sep 2021 17:36:00 -0400 Received: from mail-ed1-f52.google.com ([209.85.208.52]:42677) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mRi06-0004O1-Li for 50667@debbugs.gnu.org; Sat, 18 Sep 2021 17:35:59 -0400 Received: by mail-ed1-f52.google.com with SMTP id t6so44197602edi.9 for <50667@debbugs.gnu.org>; Sat, 18 Sep 2021 14:35:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=SqmnvppMlktgJ4QJSpbAuhmVvuQN3TMXEhNVoJqXJxo=; b=Lex/AZbh9GRLN+qs2/PAv9tVHSA6aqIa776FxQdEuokyLLAms45wkfbDzq5waKr6W2 Dq30Q9zx6z9jTevpCOqQjOgVn1aiwtgUFesz0n9zyfpM4qldBDk4yJFvSu1h02T2rBVl NJiWS9zokFgItbVQMn2dfjWkEldVYC1EY7+N2Nr0C00kFvYNkLh5EVUF0F8V2kzWq9c3 YT0qfAlpWwX6tvYMVD2fQYIHsl2EOuHGWPT/Rtyk0g4lQY2ZeZGEAGjcKqi4Ny2xQ/Xt 6BLDEEGk1Tzy8gAKoWv0S7qeleHbaFoFmCWVB0yPe4KF13A0owHGxj0fL/QZZmNlLuxV BohA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=SqmnvppMlktgJ4QJSpbAuhmVvuQN3TMXEhNVoJqXJxo=; b=5u1LbxWo2l+oux+l8tpmbS6dogDjP0pxKwtzs8yJKNOnE6rBxsi+0QbRpDt30EEx6k 04W0NywJZiCwLEB6W6W/z96IHDKppDZ5KjHM7gPZuZaS8LgOeGnkKEQ5TBZO+/7qcRUq ZDYo6lcdYECX0eXcuQvc+0bV2NeBdTE1cRmAF5SR5TQkUkX/LWGECb1o6H5XiA4lgt66 iEraDHmHmBvelYZ5pJBX/ctouW7s9BB2GGLs/BbU9r6ds7oF20mLVcZmGVPB9ULYst0L owNkFIQG/Sh1X2HCcXQE8ptJRUcSVjONBUN4RTB5uA7DmlTUnVDrLT/VfsyTF5WdQGO/ rf9A== X-Gm-Message-State: AOAM533PMT6YqJi7y5W7gTiY38fFD6hbzA5mfo2T9brtAZHmVm4EbhAK pzOFaHKnAsktgkqaN8sapwxLBtqYzR0= X-Google-Smtp-Source: ABdhPJwsFfM8wV0GS1kBJmQVZTZwj8VSAWCDGJxE69kE53Y/D3EkLFcXEoS/1zN2LNJw4vDc/lFh6Q== X-Received: by 2002:a17:906:659:: with SMTP id t25mr19249673ejb.372.1632000952463; Sat, 18 Sep 2021 14:35:52 -0700 (PDT) Received: from ars3 ([2a02:8109:8ac0:56d0::3c3e]) by smtp.gmail.com with ESMTPSA id jl12sm4066935ejc.120.2021.09.18.14.35.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 18 Sep 2021 14:35:52 -0700 (PDT) From: Augusto Stoffel References: <871r5l1tud.fsf@gmail.com> <87r1dlpp8t.fsf@gnus.org> Date: Sat, 18 Sep 2021 23:35:51 +0200 In-Reply-To: <87r1dlpp8t.fsf@gnus.org> (Lars Ingebrigtsen's message of "Sat, 18 Sep 2021 23:06:58 +0200") Message-ID: <87ilyxk1mw.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) On Sat, 18 Sep 2021 at 23:06, Lars Ingebrigtsen wrote: > Augusto Stoffel writes: > >> If one keeps sets >> >> (setq message-mail-alias-type nil ;; or keep the default 'abbrev >> message-expand-name-standard-ui t) >> >> and an ecomplete database file, then everything works OOTB, > > Works in what way? If I hit TAB in an address field, my completion UI kicks in and I can choose an address from the ecomplete database. > >> except that the ecomplete database doesn't get updated with new >> addresses. >> >> Is the following change a reasonable fix for this? > > [...] > >> - (when (and (message-mail-alias-type-p 'ecomplete) >> + (when (and (bound-and-true-p ecomplete-database) > > I think this would be highly surprising behaviour -- just loading a > library shouldn't have such side effects. Loading ecomplete doesn't populate 'ecomplete-database'. But if you set 'message-expand-name-standard-ui' to t, then 'ecomplete-start' will be called when request completions. > > What's your use case here? You don't want to use ecomplete for alias > expansions, but you still want to update the ecomplete database? I want to use ecomplete via completion at point instead of ecomplete's electric UI. This is what the variable 'message-expand-name-standard-ui' is meant for, right? From unknown Sat Sep 20 06:39:32 2025 X-Loop: help-debbugs@gnu.org Subject: bug#50667: Update ecomplete when used via standard UI Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 19 Sep 2021 15:11:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 50667 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Augusto Stoffel Cc: 50667@debbugs.gnu.org Received: via spool by 50667-submit@debbugs.gnu.org id=B50667.163206422017265 (code B ref 50667); Sun, 19 Sep 2021 15:11:01 +0000 Received: (at 50667) by debbugs.gnu.org; 19 Sep 2021 15:10:20 +0000 Received: from localhost ([127.0.0.1]:39520 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mRySS-0004UP-EA for submit@debbugs.gnu.org; Sun, 19 Sep 2021 11:10:20 -0400 Received: from quimby.gnus.org ([95.216.78.240]:42982) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mRySQ-0004UC-8f for 50667@debbugs.gnu.org; Sun, 19 Sep 2021 11:10:19 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=VRE7EglFRoNrJNma5VC1OxG4gusRKnogUpP5GGbUthA=; b=IJ5J8Oa+cMKCz8IkZCsycJJSBd wkl3kcczZJLvMfclAeX00msIcnhPPRS1Org+i5PoMJkuTskCtSg5HY4eUv8sr8qDM9qy0+Y2npdyd xAblqz1dYWT/hplqUdJBYSC0z+jjyIGGFnwYxPIPPMkm6HiRqHnokykVJ4TBOctqX/Iw=; Received: from [84.212.220.105] (helo=elva) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mRySH-0000W4-Po; Sun, 19 Sep 2021 17:10:12 +0200 From: Lars Ingebrigtsen References: <871r5l1tud.fsf@gmail.com> <87r1dlpp8t.fsf@gnus.org> <87ilyxk1mw.fsf@gmail.com> Date: Sun, 19 Sep 2021 17:10:06 +0200 In-Reply-To: <87ilyxk1mw.fsf@gmail.com> (Augusto Stoffel's message of "Sat, 18 Sep 2021 23:35:51 +0200") Message-ID: <87fsu0ob3l.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Augusto Stoffel writes: >>> (setq message-mail-alias-type nil ;; or keep the default 'abbrev >>> message-expand-name-standard-ui t) >>> >>> and an ecomplete database file, then everything works OOTB, >> >> Works in what way? [...] Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Augusto Stoffel writes: >>> (setq message-mail-alias-type nil ;; or keep the default 'abbrev >>> message-expand-name-standard-ui t) >>> >>> and an ecomplete database file, then everything works OOTB, >> >> Works in what way? > > If I hit TAB in an address field, my completion UI kicks in and I can > choose an address from the ecomplete database. I think that's a bug -- I don't see anything in the documentation of `message-expand-name-standard-ui' that says that that's going to use ecomplete? -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From unknown Sat Sep 20 06:39:32 2025 X-Loop: help-debbugs@gnu.org Subject: bug#50667: Update ecomplete when used via standard UI Resent-From: Augusto Stoffel Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 19 Sep 2021 16:03:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 50667 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Lars Ingebrigtsen Cc: Stefan Monnier , 50667@debbugs.gnu.org Received: via spool by 50667-submit@debbugs.gnu.org id=B50667.16320673476851 (code B ref 50667); Sun, 19 Sep 2021 16:03:01 +0000 Received: (at 50667) by debbugs.gnu.org; 19 Sep 2021 16:02:27 +0000 Received: from localhost ([127.0.0.1]:39626 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mRzGn-0001mH-En for submit@debbugs.gnu.org; Sun, 19 Sep 2021 12:02:27 -0400 Received: from mail-wr1-f53.google.com ([209.85.221.53]:40660) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mRzGj-0001lz-Jz for 50667@debbugs.gnu.org; Sun, 19 Sep 2021 12:02:20 -0400 Received: by mail-wr1-f53.google.com with SMTP id q26so24204768wrc.7 for <50667@debbugs.gnu.org>; Sun, 19 Sep 2021 09:02:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=AvgTydB+kb2AVzp6JshP7Xa5O6WbqPa11jne9pIM3N0=; b=czK5UWazcHedOKytKPDhf3gP0ZXwW00SoTwNRIOK+82UtHtaZIKck6MKV8GbaSuTBO RXMXb8Sr6S5hjYp5yK0NYQFmigj7jPgiZNy8Rwff78sbQQKGJaxEbylCN8Trc303OQH4 lfTwS0A3Ut9hXTShc0WLXQH+tyLjsS8+SnevUpNqoh4A3427eSNEhwcCanKlaLD9OabY nwKYy6uK0deD9V18+jlADUNpYPjljl1ytGIOiRrtrveB1aqmhXkYEOBSba8OfnYKqsxX RhqdsuRnjIxuqgfWHlKcug6RZTsO81yGIoKsS5+RMvOKQraJAfW8Leuw99+JhBdVgRzT tkEg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=AvgTydB+kb2AVzp6JshP7Xa5O6WbqPa11jne9pIM3N0=; b=q5Mu/aq8CnBo4RuCly87FI8HW7y3ToEDKVRrEa49tYu3kWXYAFgREtJqErB9Q7flpL qSO+J4m4aKuyXbpR1nUQrX6IuCCpI1dOIr64Gin4tdLBGXe8njIbCAaQ/TFemLzG89NG 5BgwBniTsW8YDqhdD5gwf8qP0MfZBkr0TOtszOKOjJtUfTxQ0n8Kl4BEqkMDUONootBf XY93LK//ORKqmFRQwk5gTy2hPuQIB9v0Lsp4blhL+esH5iXKRk3GU6RYtvmBocLxdwkb DWccn3dzsyfPQrZ7mw/I1FIPwgQsFYAWTzP6aizXyh6wqFkb5QAse2wtmiOztfqOCceD nT5g== X-Gm-Message-State: AOAM532HsabZax5Zwt3FjEKOO2Am2v/IkfLwB7Ocu9vHu53Ffdhka3Ts mIbrKszNWKQb5806FjkulF8O/TlKzf8= X-Google-Smtp-Source: ABdhPJzU3LZeJ5uqmr7Ngt3ArdQhqgwmZo0p6cWjgvyzgAAUUna2nNoSdGGKBSf1gNr7dKTgTYzoow== X-Received: by 2002:adf:d1c5:: with SMTP id b5mr6793562wrd.252.1632067331390; Sun, 19 Sep 2021 09:02:11 -0700 (PDT) Received: from ars3 ([2a02:8109:8ac0:56d0::2f72]) by smtp.gmail.com with ESMTPSA id g205sm9463533wmg.18.2021.09.19.09.02.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 19 Sep 2021 09:02:10 -0700 (PDT) From: Augusto Stoffel References: <871r5l1tud.fsf@gmail.com> <87r1dlpp8t.fsf@gnus.org> <87ilyxk1mw.fsf@gmail.com> <87fsu0ob3l.fsf@gnus.org> Date: Sun, 19 Sep 2021 18:02:09 +0200 In-Reply-To: <87fsu0ob3l.fsf@gnus.org> (Lars Ingebrigtsen's message of "Sun, 19 Sep 2021 17:10:06 +0200") Message-ID: <877dfclfjy.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) On Sun, 19 Sep 2021 at 17:10, Lars Ingebrigtsen wrote: > Augusto Stoffel writes: > >>>> (setq message-mail-alias-type nil ;; or keep the default 'abbrev >>>> message-expand-name-standard-ui t) >>>> >>>> and an ecomplete database file, then everything works OOTB, >>> >>> Works in what way? >> >> If I hit TAB in an address field, my completion UI kicks in and I can >> choose an address from the ecomplete database. > > I think that's a bug -- I don't see anything in the documentation of > `message-expand-name-standard-ui' that says that that's going to use > ecomplete? Right, the docstring doesn't say anything but there is a NEWS entry saying this is the intended behavior. I've CCed Stefan, who introduced 'message-expand-name-standard-ui'. Let's see what he says. From unknown Sat Sep 20 06:39:32 2025 X-Loop: help-debbugs@gnu.org Subject: bug#50667: Update ecomplete when used via standard UI Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 05 Nov 2021 03:29:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 50667 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Augusto Stoffel Cc: 50667@debbugs.gnu.org, Stefan Monnier Received: via spool by 50667-submit@debbugs.gnu.org id=B50667.163608293725549 (code B ref 50667); Fri, 05 Nov 2021 03:29:02 +0000 Received: (at 50667) by debbugs.gnu.org; 5 Nov 2021 03:28:57 +0000 Received: from localhost ([127.0.0.1]:44179 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mipuT-0006e1-Aa for submit@debbugs.gnu.org; Thu, 04 Nov 2021 23:28:57 -0400 Received: from quimby.gnus.org ([95.216.78.240]:34524) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mipuR-0006dm-Ae for 50667@debbugs.gnu.org; Thu, 04 Nov 2021 23:28:55 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Transfer-Encoding:Content-Type:MIME-Version:Message-ID :In-Reply-To:Date:References:Subject:Cc:To:From:Sender:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=wLptvfvWUgcrvClUI+ewzT/e5fspoXL/XuhfCfnG19U=; b=qVOVPhIm/VKkUtJlKtF6KyYEHU pFWdnXeEP8my0Dlhyt0YO1z47SKFrqK8ryHzMbeolSG1IZ180A5i/1EWEFgmO4ciVaRaaFC/Xw98L wNMHlXCRlr3j+5zq/RQbt0Cj3Iwm0DyMXnxAECUQx3uF6s7vIkUB5C+4pdVZpNwUP6fc=; Received: from [84.212.220.105] (helo=elva) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mipuH-0000hf-6E; Fri, 05 Nov 2021 04:28:47 +0100 From: Lars Ingebrigtsen References: <871r5l1tud.fsf@gmail.com> X-Now-Playing: Fairport Convention's _Come All Ye (5)_: "White Dress" Date: Fri, 05 Nov 2021 04:28:41 +0100 In-Reply-To: <871r5l1tud.fsf@gmail.com> (Augusto Stoffel's message of "Sat, 18 Sep 2021 23:01:30 +0200") Message-ID: <87cznfmgba.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Augusto Stoffel writes: > If one keeps sets > > (setq message-mail-alias-type nil ;; or keep the default 'abbrev > message-expand-name-standard-ui t) > > and an ecomplete database file, then everything works OOTB, except tha [...] Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Augusto Stoffel writes: > If one keeps sets > > (setq message-mail-alias-type nil ;; or keep the default 'abbrev > message-expand-name-standard-ui t) > > and an ecomplete database file, then everything works OOTB, except that > the ecomplete database doesn't get updated with new addresses. [...] > - (when (and (message-mail-alias-type-p 'ecomplete) > + (when (and (bound-and-true-p ecomplete-database) > (not message-inhibit-ecomplete)) > (message-put-addresses-in-ecomplete)) There wasn't any response for Stefan for what he was thinking when adding the standard-ui variable =F0=9F=98=80, but this can't be the correct solution. If message-mail-alias-type isn't 'ecomplete, there's nothing to tell the code here that we want to put addresses in ecomplete. Furthermore, this would break the functionality of that setting -- ecomplete-database will be nil when you start, so it'll never put anything there. So I think the right solution here (if you want to combine these two things) is to put message-put-addresses-in-ecomplete into message-sent-hook. So I'm closing this bug report. --=20 (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Thu Nov 04 23:28:59 2021 Received: (at control) by debbugs.gnu.org; 5 Nov 2021 03:28:59 +0000 Received: from localhost ([127.0.0.1]:44182 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mipuV-0006eF-IH for submit@debbugs.gnu.org; Thu, 04 Nov 2021 23:28:59 -0400 Received: from quimby.gnus.org ([95.216.78.240]:34536) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mipuU-0006dr-92 for control@debbugs.gnu.org; Thu, 04 Nov 2021 23:28:58 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Subject:From:To:Message-Id:Date:Sender:Reply-To:Cc: MIME-Version:Content-Type:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:In-Reply-To:References:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=vfg/NSAI05D0mbvj9ReAa2RhE2h8deyeK2LgxtHrrB0=; b=lxGwmkkB4Ae9F/4YL7I7rUkvEF y7amfa66crOwno6UxoWL1GmwqRhgjUIKnr7ZhCD66cugW+iGboYFND9dTXJSMpsCFnpy7SawDohk4 pdvTTkCYSeOnHq58byy5+j0hev1S86zQA+smcBU5gyofSz2eM8IW646kPNos/ryCGlHo=; Received: from [84.212.220.105] (helo=elva) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mipuM-0000hp-IZ for control@debbugs.gnu.org; Fri, 05 Nov 2021 04:28:52 +0100 Date: Fri, 05 Nov 2021 04:28:50 +0100 Message-Id: <87bl2zmgb1.fsf@gnus.org> To: control@debbugs.gnu.org From: Lars Ingebrigtsen Subject: control message for bug #50667 X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: close 50667 quit Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) close 50667 quit