From unknown Sat Sep 20 00:09:39 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#50664] [PATCH core-updates-frozen] gnu: curl: Respect #:tests?. Resent-From: Sarah Morgensen Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sat, 18 Sep 2021 17:15:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 50664 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 50664@debbugs.gnu.org X-Debbugs-Original-To: guix-patches@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.163198528631640 (code B ref -1); Sat, 18 Sep 2021 17:15:02 +0000 Received: (at submit) by debbugs.gnu.org; 18 Sep 2021 17:14:46 +0000 Received: from localhost ([127.0.0.1]:36774 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mRdvK-0008EG-3n for submit@debbugs.gnu.org; Sat, 18 Sep 2021 13:14:46 -0400 Received: from lists.gnu.org ([209.51.188.17]:55198) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mRdvH-0008E7-Tu for submit@debbugs.gnu.org; Sat, 18 Sep 2021 13:14:44 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:44704) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mRdvH-000767-Od for guix-patches@gnu.org; Sat, 18 Sep 2021 13:14:43 -0400 Received: from out1.migadu.com ([91.121.223.63]:53472) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mRdvE-0005lF-Hj for guix-patches@gnu.org; Sat, 18 Sep 2021 13:14:43 -0400 X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mgsn.dev; s=key1; t=1631985277; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=WQRG53X5TfjlOcWC41/QqVGv1EYD1bNly5JCIxGQkpA=; b=Gdgn7vrzytD4zPrv0TQJimqg1ZD7SiH2xydO2rqZccDnOzyULm+DJFk4TjrglBRAX1w5/p 6uJwt+t4YC1qGozsSBaz/uLPSYV+7eByYvTP1RNYoWxLttLpGTZ3ka6a6AbARbOBN4Vs2O +Jck7U0OWmstOpYYGUbt6YWr5ANKTlo= From: Sarah Morgensen Date: Sat, 18 Sep 2021 10:14:34 -0700 Message-Id: <8d416ea3a4f64a4a4df52084e5a9e5cce11c3c0b.1631944982.git.iskarian@mgsn.dev> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Migadu-Flow: FLOW_OUT X-Migadu-Auth-User: iskarian@mgsn.dev Received-SPF: pass client-ip=91.121.223.63; envelope-from=iskarian@mgsn.dev; helo=out1.migadu.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.4 (-) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.4 (--) * gnu/packages/curl.scm (curl)[arguments]<#:phases>{check}: Respect #:tests?. --- gnu/packages/curl.scm | 18 +++++++++--------- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/gnu/packages/curl.scm b/gnu/packages/curl.scm index 063a919700..17aed51fdd 100644 --- a/gnu/packages/curl.scm +++ b/gnu/packages/curl.scm @@ -124,16 +124,16 @@ (rename-file (string-append out "/share/man/man3") (string-append doc "/share/man/man3")) #t))) - (replace - 'check - (lambda _ - (substitute* "tests/runtests.pl" - (("/bin/sh") (which "sh"))) + (replace 'check + (lambda* (#:key (tests? (not target)) #:allow-other-keys) + (substitute* "tests/runtests.pl" + (("/bin/sh") (which "sh"))) - ;; The top-level "make check" does "make -C tests quiet-test", which - ;; is too quiet. Use the "test" target instead, which is more - ;; verbose. - (invoke "make" "-C" "tests" "test")))))) + (when tests? + ;; The top-level "make check" does "make -C tests quiet-test", which + ;; is too quiet. Use the "test" target instead, which is more + ;; verbose. + (invoke "make" "-C" "tests" "test"))))))) (synopsis "Command line tool for transferring data with URL syntax") (description "curl is a command line tool for transferring data with URL syntax, base-commit: 8613652f3f80105f35db13d6d9308257bbff8474 -- 2.33.0 From unknown Sat Sep 20 00:09:39 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#50664] [PATCH core-updates-frozen] gnu: curl: Respect #:tests?. Resent-From: Mathieu Othacehe Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sun, 19 Sep 2021 15:51:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 50664 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Sarah Morgensen Cc: 50664@debbugs.gnu.org Received: via spool by 50664-submit@debbugs.gnu.org id=B50664.16320666435744 (code B ref 50664); Sun, 19 Sep 2021 15:51:02 +0000 Received: (at 50664) by debbugs.gnu.org; 19 Sep 2021 15:50:43 +0000 Received: from localhost ([127.0.0.1]:39621 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mRz5X-0001UZ-DG for submit@debbugs.gnu.org; Sun, 19 Sep 2021 11:50:43 -0400 Received: from eggs.gnu.org ([209.51.188.92]:48654) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mRz5V-0001UN-Q9 for 50664@debbugs.gnu.org; Sun, 19 Sep 2021 11:50:42 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:56126) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mRz5O-0005mY-HZ; Sun, 19 Sep 2021 11:50:35 -0400 Received: from [178.250.34.74] (port=33554 helo=meije) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mRz5B-00052l-3y; Sun, 19 Sep 2021 11:50:32 -0400 From: Mathieu Othacehe References: <8d416ea3a4f64a4a4df52084e5a9e5cce11c3c0b.1631944982.git.iskarian@mgsn.dev> Date: Sun, 19 Sep 2021 15:50:18 +0000 In-Reply-To: <8d416ea3a4f64a4a4df52084e5a9e5cce11c3c0b.1631944982.git.iskarian@mgsn.dev> (Sarah Morgensen's message of "Sat, 18 Sep 2021 10:14:34 -0700") Message-ID: <878rzsd0p1.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Hello Sarah, > + (lambda* (#:key (tests? (not target)) #:allow-other-keys) I'm not sure we need the default value here, as it's already part of the build system. Otherwise looks nice. We can apply when merging other world rebuilding changes, or directly on core-updates for the next round. Thanks, Mathieu From unknown Sat Sep 20 00:09:39 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#50664] [PATCH core-updates-frozen v2] gnu: curl: Respect #:tests?. Resent-From: Sarah Morgensen Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sun, 19 Sep 2021 18:47:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 50664 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 50664@debbugs.gnu.org Cc: othacehe@gnu.org Received: via spool by 50664-submit@debbugs.gnu.org id=B50664.163207721724611 (code B ref 50664); Sun, 19 Sep 2021 18:47:02 +0000 Received: (at 50664) by debbugs.gnu.org; 19 Sep 2021 18:46:57 +0000 Received: from localhost ([127.0.0.1]:39951 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mS1q4-0006Os-QI for submit@debbugs.gnu.org; Sun, 19 Sep 2021 14:46:57 -0400 Received: from out2.migadu.com ([188.165.223.204]:25661) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mS1q3-0006Oh-6Q for 50664@debbugs.gnu.org; Sun, 19 Sep 2021 14:46:56 -0400 X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mgsn.dev; s=key1; t=1632077214; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=/XNaXmMW70QGzvNgrd1TcE1P768IjpNgd4X2Ui9GJVs=; b=e9Ap/vYNWURo6DJNicJZTZedGwEXWKHPINqtYci1vfj4pS7Bq5H1OM2c1ZROl9ifqtxZ0p lRQVBSvzrHi1qGppuczFLgrqzhh7ZpBbAl4/8a8FlzcAfaV/J8jn05a3sZyPaTcV/hI255 nyvI0Qz7gVGEFYwIMQdhw2iw076s2ds= From: Sarah Morgensen Date: Sun, 19 Sep 2021 11:46:52 -0700 Message-Id: In-Reply-To: <8d416ea3a4f64a4a4df52084e5a9e5cce11c3c0b.1631944982.git.iskarian@mgsn.dev> References: <8d416ea3a4f64a4a4df52084e5a9e5cce11c3c0b.1631944982.git.iskarian@mgsn.dev> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Migadu-Flow: FLOW_OUT X-Migadu-Auth-User: iskarian@mgsn.dev X-Spam-Score: -0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) * gnu/packages/curl.scm (curl)[arguments]<#:phases>{check}: Respect #:tests?. --- Changes from v1: * Do not provide a default value for tests?, since gnu-build-system provides one. -- Sarah gnu/packages/curl.scm | 18 +++++++++--------- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/gnu/packages/curl.scm b/gnu/packages/curl.scm index 063a919700..4c90c7b301 100644 --- a/gnu/packages/curl.scm +++ b/gnu/packages/curl.scm @@ -124,16 +124,16 @@ (rename-file (string-append out "/share/man/man3") (string-append doc "/share/man/man3")) #t))) - (replace - 'check - (lambda _ - (substitute* "tests/runtests.pl" - (("/bin/sh") (which "sh"))) + (replace 'check + (lambda* (#:key tests? #:allow-other-keys) + (substitute* "tests/runtests.pl" + (("/bin/sh") (which "sh"))) - ;; The top-level "make check" does "make -C tests quiet-test", which - ;; is too quiet. Use the "test" target instead, which is more - ;; verbose. - (invoke "make" "-C" "tests" "test")))))) + (when tests? + ;; The top-level "make check" does "make -C tests quiet-test", which + ;; is too quiet. Use the "test" target instead, which is more + ;; verbose. + (invoke "make" "-C" "tests" "test"))))))) (synopsis "Command line tool for transferring data with URL syntax") (description "curl is a command line tool for transferring data with URL syntax, base-commit: 8613652f3f80105f35db13d6d9308257bbff8474 -- 2.33.0 From debbugs-submit-bounces@debbugs.gnu.org Sun Sep 19 14:54:00 2021 Received: (at control) by debbugs.gnu.org; 19 Sep 2021 18:54:00 +0000 Received: from localhost ([127.0.0.1]:39957 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mS1wu-0006aL-OM for submit@debbugs.gnu.org; Sun, 19 Sep 2021 14:54:00 -0400 Received: from eggs.gnu.org ([209.51.188.92]:44102) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mS1ws-0006a3-Sq for control@debbugs.gnu.org; Sun, 19 Sep 2021 14:53:59 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:60246) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mS1wn-00083k-Dz for control@debbugs.gnu.org; Sun, 19 Sep 2021 14:53:53 -0400 Received: from [178.250.34.74] (port=33558 helo=meije) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mS1wn-0002as-4Q for control@debbugs.gnu.org; Sun, 19 Sep 2021 14:53:53 -0400 Date: Sun, 19 Sep 2021 18:53:50 +0000 Message-Id: <87v92wpfb5.fsf@meije.i-did-not-set--mail-host-address--so-tickle-me> To: control@debbugs.gnu.org From: Mathieu Othacehe Subject: control message for bug #50664 X-Spam-Score: -1.9 (-) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.9 (--) block 50664 by 50358 quit From unknown Sat Sep 20 00:09:39 2025 MIME-Version: 1.0 X-Mailer: MIME-tools 5.505 (Entity 5.505) X-Loop: help-debbugs@gnu.org From: help-debbugs@gnu.org (GNU bug Tracking System) To: Sarah Morgensen Subject: bug#50664: closed (Re: bug#50664: [PATCH core-updates-frozen] gnu: curl: Respect #:tests?.) Message-ID: References: <87tughq5sk.fsf_-_@gmail.com> <8d416ea3a4f64a4a4df52084e5a9e5cce11c3c0b.1631944982.git.iskarian@mgsn.dev> X-Gnu-PR-Message: they-closed 50664 X-Gnu-PR-Package: guix-patches X-Gnu-PR-Keywords: patch Reply-To: 50664@debbugs.gnu.org Date: Fri, 12 Nov 2021 05:53:01 +0000 Content-Type: multipart/mixed; boundary="----------=_1636696381-4892-1" This is a multi-part message in MIME format... ------------=_1636696381-4892-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Your bug report #50664: [PATCH core-updates-frozen] gnu: curl: Respect #:tests?. which was filed against the guix-patches package, has been closed. The explanation is attached below, along with your original report. If you require more details, please reply to 50664@debbugs.gnu.org. --=20 50664: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D50664 GNU Bug Tracking System Contact help-debbugs@gnu.org with problems ------------=_1636696381-4892-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at 50664-done) by debbugs.gnu.org; 12 Nov 2021 05:52:51 +0000 Received: from localhost ([127.0.0.1]:43002 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mlPUZ-0001GY-Fi for submit@debbugs.gnu.org; Fri, 12 Nov 2021 00:52:51 -0500 Received: from mail-qv1-f43.google.com ([209.85.219.43]:42879) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mlPUY-0001GM-Lo for 50664-done@debbugs.gnu.org; Fri, 12 Nov 2021 00:52:51 -0500 Received: by mail-qv1-f43.google.com with SMTP id b17so5603709qvl.9 for <50664-done@debbugs.gnu.org>; Thu, 11 Nov 2021 21:52:50 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=LB2jDm4J2TIAFX9bEUz6JTld9JTUWIRzXVk/40oUV28=; b=LwZc8K21RsWc+frgRgSKvy7HUJJnYNl8Ar5J7wUFdzH+DRWVdjL4qrMCuUuid3QplO czS0cHn+BoBRvFMkUff9I8E+xC9fBv7UkAXxjd+BI107TrvdPLg8mPk2GGSXLLTkx4Ot 3BeFCRVhFz9LshaJNK0r6bl4Eas3UXjyQAOtLNhEe2Xm2qIPdu9vJQKCPvVGFZJIIhFE zoFkoH/SrIOnllg1JJ0HOBVoVwXNBp6Lml/5t9Yk4/mY4STeeiG0oAc1Xh4rwKPrWBV8 TptcmGapZw+phOQiAI70Ns4SdgKN+fJi9kuZyypWPzMlqNNjsNaY2lUcIQR+ntXf6Q/7 RHTA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=LB2jDm4J2TIAFX9bEUz6JTld9JTUWIRzXVk/40oUV28=; b=VgfgsccjWTCI4kr8gXX7VM0/0wnKNSO1WZpPzprBjv5qZSVfzqe43E8k1+yHGeltUU LNlA3m45inEirwan3lMxnGai8dY+H4Q5WQPHE6wq0t7nrpwlCb1DFuN2y91nQjmMwmJe jzKYdb3VTZ5UqCn7ZeNn7acPmdHitqA/vCk3tg3FqGGsqkR7VQyZts11Zlg+Azo1yndh ZYxE2OthYyO6sUDOaMsYnHECDpmmaCPYFEteI+h313VUwvdYSiQ3jINIjFG29OE6eG9E 987AxJFBWYmDT9utWDYEa+w8kZXgeg0a/Jt+mNDpA2AbDyfv6BOpcnb7IAx1wx6gBV/7 /hiA== X-Gm-Message-State: AOAM5332IgdqOYRXs66qEDBt3WzG1ehNOkqIhUWNXxHcjr8OFrO/r8Ly 7B9mZbzlXuzxAmBAtKzq38tkOrTyF8VtVJXi X-Google-Smtp-Source: ABdhPJyzdJWfuFFCJ5tENFGuQy9+gPclNwUd+pV/wxstvdcTJpPcfvRjQAwWVSFa3PkHXvYJZRn8vA== X-Received: by 2002:a05:6214:501b:: with SMTP id jo27mr12286761qvb.64.1636696365248; Thu, 11 Nov 2021 21:52:45 -0800 (PST) Received: from hurd (dsl-10-133-155.b2b2c.ca. [72.10.133.155]) by smtp.gmail.com with ESMTPSA id j13sm2392826qkp.111.2021.11.11.21.52.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 11 Nov 2021 21:52:44 -0800 (PST) From: Maxim Cournoyer To: Sarah Morgensen Subject: Re: bug#50664: [PATCH core-updates-frozen] gnu: curl: Respect #:tests?. References: <8d416ea3a4f64a4a4df52084e5a9e5cce11c3c0b.1631944982.git.iskarian@mgsn.dev> Date: Fri, 12 Nov 2021 00:52:43 -0500 In-Reply-To: (Sarah Morgensen's message of "Sun, 19 Sep 2021 11:46:52 -0700") Message-ID: <87tughq5sk.fsf_-_@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 50664-done Cc: othacehe@gnu.org, 50664-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hello, Sarah Morgensen writes: > * gnu/packages/curl.scm (curl)[arguments]<#:phases>{check}: Respect #:tests?. > --- > Changes from v1: > > * Do not provide a default value for tests?, since gnu-build-system provides > one. > > -- > Sarah > gnu/packages/curl.scm | 18 +++++++++--------- > 1 file changed, 9 insertions(+), 9 deletions(-) > > diff --git a/gnu/packages/curl.scm b/gnu/packages/curl.scm > index 063a919700..4c90c7b301 100644 > --- a/gnu/packages/curl.scm > +++ b/gnu/packages/curl.scm > @@ -124,16 +124,16 @@ > (rename-file (string-append out "/share/man/man3") > (string-append doc "/share/man/man3")) > #t))) > - (replace > - 'check > - (lambda _ > - (substitute* "tests/runtests.pl" > - (("/bin/sh") (which "sh"))) > + (replace 'check > + (lambda* (#:key tests? #:allow-other-keys) > + (substitute* "tests/runtests.pl" > + (("/bin/sh") (which "sh"))) > > - ;; The top-level "make check" does "make -C tests quiet-test", which > - ;; is too quiet. Use the "test" target instead, which is more > - ;; verbose. > - (invoke "make" "-C" "tests" "test")))))) > + (when tests? > + ;; The top-level "make check" does "make -C tests quiet-test", which > + ;; is too quiet. Use the "test" target instead, which is more > + ;; verbose. > + (invoke "make" "-C" "tests" "test"))))))) > (synopsis "Command line tool for transferring data with URL syntax") > (description > "curl is a command line tool for transferring data with URL syntax, > > base-commit: 8613652f3f80105f35db13d6d9308257bbff8474 This got merged in core-updates-frozen as 460d6aca0c9a8f8443d50e5a5cf2bf9841bcc559; and I just noticed I had forgotten to put my signed-off-by line; apologies. Thank you! Closing. Maxim ------------=_1636696381-4892-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at submit) by debbugs.gnu.org; 18 Sep 2021 17:14:46 +0000 Received: from localhost ([127.0.0.1]:36774 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mRdvK-0008EG-3n for submit@debbugs.gnu.org; Sat, 18 Sep 2021 13:14:46 -0400 Received: from lists.gnu.org ([209.51.188.17]:55198) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mRdvH-0008E7-Tu for submit@debbugs.gnu.org; Sat, 18 Sep 2021 13:14:44 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:44704) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mRdvH-000767-Od for guix-patches@gnu.org; Sat, 18 Sep 2021 13:14:43 -0400 Received: from out1.migadu.com ([91.121.223.63]:53472) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mRdvE-0005lF-Hj for guix-patches@gnu.org; Sat, 18 Sep 2021 13:14:43 -0400 X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mgsn.dev; s=key1; t=1631985277; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=WQRG53X5TfjlOcWC41/QqVGv1EYD1bNly5JCIxGQkpA=; b=Gdgn7vrzytD4zPrv0TQJimqg1ZD7SiH2xydO2rqZccDnOzyULm+DJFk4TjrglBRAX1w5/p 6uJwt+t4YC1qGozsSBaz/uLPSYV+7eByYvTP1RNYoWxLttLpGTZ3ka6a6AbARbOBN4Vs2O +Jck7U0OWmstOpYYGUbt6YWr5ANKTlo= From: Sarah Morgensen To: guix-patches@gnu.org Subject: [PATCH core-updates-frozen] gnu: curl: Respect #:tests?. Date: Sat, 18 Sep 2021 10:14:34 -0700 Message-Id: <8d416ea3a4f64a4a4df52084e5a9e5cce11c3c0b.1631944982.git.iskarian@mgsn.dev> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Migadu-Flow: FLOW_OUT X-Migadu-Auth-User: iskarian@mgsn.dev Received-SPF: pass client-ip=91.121.223.63; envelope-from=iskarian@mgsn.dev; helo=out1.migadu.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.4 (-) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.4 (--) * gnu/packages/curl.scm (curl)[arguments]<#:phases>{check}: Respect #:tests?. --- gnu/packages/curl.scm | 18 +++++++++--------- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/gnu/packages/curl.scm b/gnu/packages/curl.scm index 063a919700..17aed51fdd 100644 --- a/gnu/packages/curl.scm +++ b/gnu/packages/curl.scm @@ -124,16 +124,16 @@ (rename-file (string-append out "/share/man/man3") (string-append doc "/share/man/man3")) #t))) - (replace - 'check - (lambda _ - (substitute* "tests/runtests.pl" - (("/bin/sh") (which "sh"))) + (replace 'check + (lambda* (#:key (tests? (not target)) #:allow-other-keys) + (substitute* "tests/runtests.pl" + (("/bin/sh") (which "sh"))) - ;; The top-level "make check" does "make -C tests quiet-test", which - ;; is too quiet. Use the "test" target instead, which is more - ;; verbose. - (invoke "make" "-C" "tests" "test")))))) + (when tests? + ;; The top-level "make check" does "make -C tests quiet-test", which + ;; is too quiet. Use the "test" target instead, which is more + ;; verbose. + (invoke "make" "-C" "tests" "test"))))))) (synopsis "Command line tool for transferring data with URL syntax") (description "curl is a command line tool for transferring data with URL syntax, base-commit: 8613652f3f80105f35db13d6d9308257bbff8474 -- 2.33.0 ------------=_1636696381-4892-1--