GNU bug report logs - #50657
[PATCH] gnu: Add vpn-slice.

Previous Next

Full log

Message #20 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Nicolas Goaziou <mail <at> nicolasgoaziou.fr>
To: phodina via Guix-patches via <guix-patches <at> gnu.org>
Cc: 50657 <at> debbugs.gnu.org, Xinglu Chen <public <at> yoctocell.xyz>,
 phodina <phodina <at> protonmail.com>
Subject: Re: [bug#50657] [PATCH v2] gnu: Add vpn-slice.
Date: Sun, 05 Dec 2021 12:14:22 +0100

Hello,

phodina via Guix-patches via <guix-patches <at> gnu.org> writes:

> I checked the /etc/hosts and seems that on Guix System there aren't symlink to the /gnu/store.
>
> $ readlink -f /etc/hostname
> /etc/hostname

But it is read-only, isn't it? If so, how can the program do its stuff,
since it is supposed to modify the file?

> +        (sha256
> +          (base32
> +            "0lv3g1bq6ssz6fn6zlzn12dahc4d7nf7kjwxsnb5d7gdrfp36lbx"))))

Nitpick: Hash string should be on the same line as base32

> +    (description "This package allows you to minimize your contact with
> +an intrusive VPN --- split your traffic between the VPN tunnel and your normal
> +network interfaces")

Nitpick: I think English does not add spaces between "---".

> +    (license license:gpl3)))

You forgot to change the license, as suggested by Xinglu Chen.

Regards,
-- 
Nicolas Goaziou

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.