Subject: Re: [bug#50657] [PATCH] gnu: Add vpn-slice.

From: Xinglu Chen <[email-masked]>
Date: Mon, 20 Sep 2021 14:37:40 +0200

On Sat, Sep 18 2021, phodina via Guix-patches via wrote:

> * gnu/packages/vpn.scm (vpn-slice): New variable.
>
> diff --git a/gnu/packages/vpn.scm b/gnu/packages/vpn.scm
> index 330a3271b4..4d49597564 100644
> --- a/gnu/packages/vpn.scm
> +++ b/gnu/packages/vpn.scm
> @@ -18,6 +18,7 @@
>  ;;; Copyright © 2021 Domagoj Stolfa <[email-masked]>
>  ;;; Copyright © 2021 Raghav Gururajan <[email-masked]>
>  ;;; Copyright © 2021 jgart <[email-masked]>
> +;;; Copyright © 2021 Petr Hodina  <[email-masked]>
>  ;;;
>  ;;; This file is part of GNU Guix.
>  ;;;
> @@ -432,6 +433,31 @@ file for more details.")
>             ;; src/libstrongswan/plugins/des/des_crypter.c
>             license:bsd-4))))
>
> +(define-public vpn-slice
> +  (package
> +    (name "vpn-slice")
> +    (version "0.15")
> +    (source
> +      (origin
> +        (method url-fetch)
> +        (uri (pypi-uri "vpn-slice" version))
> +        (sha256
> +          (base32
> +            "0lv3g1bq6ssz6fn6zlzn12dahc4d7nf7kjwxsnb5d7gdrfp36lbx"))))
> +    (build-system python-build-system)
> +    (native-inputs `(("python-pytest" ,python-pytest)))
> +    (propagated-inputs
> +      `(("python-dnspython" ,python-dnspython)
> +        ("python-setproctitle" ,python-setproctitle)))
> +    (home-page
> +      "https://github.com/dlenski/vpn-slice")

Please avoid unnecessary newlines.

> +    (synopsis
> +      "Easy and secure split-tunnel VPN setup")

Likewise.

> +    (description
> +      "Minimize your contact with an intrusive VPN - split your traffic
> +between the VPN tunnel and your normal network interfaces")

The sentence lacks a subject and a period, and the single “-” should be
replaced by “---”, which is the proper Texinfo syntax.

I noticed that the README says

  It automatically looks up named hosts, using the VPN's DNS servers,
  and adds entries for them to your /etc/hosts

I don’t know about Guix System, but on NixOS /etc/hosts is read-only, so
this wouldn’t work.

> +    (license license:gpl3)))

‘LICENSE.txt’ says gpl3+.