From debbugs-submit-bounces@debbugs.gnu.org Sat Sep 18 05:49:33 2021 Received: (at submit) by debbugs.gnu.org; 18 Sep 2021 09:49:33 +0000 Received: from localhost ([127.0.0.1]:33550 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mRWyK-0003eQ-Fm for submit@debbugs.gnu.org; Sat, 18 Sep 2021 05:49:33 -0400 Received: from lists.gnu.org ([209.51.188.17]:56776) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mRWyG-0003eF-4C for submit@debbugs.gnu.org; Sat, 18 Sep 2021 05:49:22 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:41918) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mRWyF-0001Zy-Sh for guix-patches@gnu.org; Sat, 18 Sep 2021 05:49:19 -0400 Received: from mail-4323.protonmail.ch ([185.70.43.23]:59790) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mRWyD-0001W9-Qq for guix-patches@gnu.org; Sat, 18 Sep 2021 05:49:19 -0400 Date: Sat, 18 Sep 2021 09:49:10 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=protonmail.com; s=protonmail; t=1631958554; bh=RPkEbqF+egu2oqvOvS8yCb7hdC5A4wT5bYlZfZ/DMZ0=; h=Date:To:From:Reply-To:Subject:From; b=b14mSgG3LgXYGQ2pjB7FgKc0Pq185uvMozJ1I2KmbSz2uSKzi35Txi18PTq7TbPeB GZrgXdl5fb5XYsrq9uq+rzq3esDfjg+57Eqx7lSg4OcjERgma5nRSgkEWqnjPOc+UK dVmIOMyYrwxEINHvdMFPsHaS+dJlvBp54i/w9NG0= To: "guix-patches@gnu.org" From: phodina Subject: [PATCH] gnu: Add sdlpop. Message-ID: <-p2XzmyUeU34-LyC3z50Id77Y3mrwZAnC3s3bUigV4CSc1rE9Pz-FYX9HxF97dLz1oBPpUEx06AoVSLT5eJGyZRZOFmCSfXlSzKHc5U8iCc=@protonmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-0.2 required=10.0 tests=ALL_TRUSTED,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,FREEMAIL_REPLYTO shortcircuit=no autolearn=disabled version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on mailout.protonmail.ch Received-SPF: pass client-ip=185.70.43.23; envelope-from=phodina@protonmail.com; helo=mail-4323.protonmail.ch X-Spam_score_int: -10 X-Spam_score: -1.1 X-Spam_bar: - X-Spam_report: (-1.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, FREEMAIL_REPLYTO=1, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-Spam-Score: 1.0 (+) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: phodina Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) * gnu/packages/games.scm (sdlpop): New variable. [copyright]: Sort by date pkill9@runbox.com. diff --git a/gnu/packages/games.scm b/gnu/packages/games.scm index c39770c260..0eed238f32 100644 --- a/gnu/packages/games.scm +++ b/gnu/packages/games.scm @@ -45,6 +45,7 @@ ;;; Copyright =C2=A9 2019, 2020 Guillaume Le Vaillant ;;; Copyright =C2=A9 2019, 2020 Timotej Lazar ;;; Copyright =C2=A9 2019 Josh Holland +;;; Copyright =C2=A9 2019 Pkill -9 ;;; Copyright =C2=A9 2017, 2019 Hartmut Goebel ;;; Copyright =C2=A9 2020 Alberto Eleuterio Flores Guerrero ;;; Copyright =C2=A9 2020 Naga Malleswari @@ -63,7 +64,7 @@ ;;; Copyright =C2=A9 2021 Felix Gruber ;;; Copyright =C2=A9 2021 Solene Rapenne ;;; Copyright =C2=A9 2021 Noisytoot -;;; Copyright =C2=A9 2019 Pkill -9 +;;; Copyright =C2=A9 2021 Petr Hodina ;;; ;;; This file is part of GNU Guix. ;;; @@ -12480,6 +12481,62 @@ do so you need to explore the island, find food, b= uild a shelter and try to get attention, so you get found.") (license license:cc-by4.0)))) +(define-public sdlpop + (package + (name "sdlpop") + (version "1.22") + (source (origin + (method git-fetch) + (uri (git-reference + (url "https://github.com/NagyD/SDLPoP") + (commit (string-append "v" version)))) + (file-name (git-file-name name version)) + (sha256 + (base32 + "1yy5r1r0hv0xggk8qd8bwk2zy7abpv89nikq4flqgi53fc5q9xl7")))) + (build-system gnu-build-system) + (arguments + `(#:tests? #f + #:phases + (modify-phases %standard-phases + (delete 'configure) + (add-before 'build 'prepare-build + ;; Set correct environment for SDL. + (lambda* (#:key inputs #:allow-other-keys) + (setenv "CPATH" + (string-append (assoc-ref inputs "sdl") + "/include/SDL2:" + (or (getenv "CPATH") ""))))) + (add-after 'unpack 'chdir + (lambda* _ + (chdir "src"))) + (replace 'install + (lambda* (#:key outputs #:allow-other-keys) + (let* ((out (assoc-ref outputs "out")) + (bin (string-append out "/bin")) + (opt (string-append out "/opt/sdlpop")) + (app (string-append out "/usr/share/applications")) + (template "src/SDLPoP.desktop.template")) + (chdir "..") + (install-file "prince" bin) + (substitute* template (("\\$ROOT") out)) + (install-file template app) + (rename-file (string-append app "/SDLPoP.desktop.template") + (string-append app "/SDLPoP.desktop")) + (install-file "SDLPoP.ini" opt) + (copy-recursively "data" (string-append bin "/data")) + (copy-recursively "doc" opt) + (copy-recursively "mods" opt))))))) + (native-inputs `(("pkg-config" ,pkg-config))) + (inputs `(("sdl" ,(sdl-union (list sdl2 + sdl2-image + sdl2-mixer))))) + (synopsis "Open-source port of Prince of Persia") + (description "Open-source port of Prince of Persia, based on the disas= sembly +of the DOS version, extended with new features.") + (home-page "https://github.com/NagyD/SDLPoP") + (license license:gpl3))) + (define-public fheroes2 (package (name "fheroes2") -- 2.32.0 From debbugs-submit-bounces@debbugs.gnu.org Mon Sep 20 08:19:48 2021 Received: (at 50653) by debbugs.gnu.org; 20 Sep 2021 12:19:48 +0000 Received: from localhost ([127.0.0.1]:41173 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mSIGo-0006GS-PQ for submit@debbugs.gnu.org; Mon, 20 Sep 2021 08:19:47 -0400 Received: from h87-96-130-155.cust.a3fiber.se ([87.96.130.155]:53872 helo=mail.yoctocell.xyz) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mSIGn-0006GE-49 for 50653@debbugs.gnu.org; Mon, 20 Sep 2021 08:19:38 -0400 From: Xinglu Chen DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=yoctocell.xyz; s=mail; t=1632140368; bh=7jSwvU5Bk7+XEk9uMcsZCUBQWU4lKWzvDCDhuyIGKHc=; h=From:To:Subject:In-Reply-To:References:Date; b=oMOBzbv+YB07aE9srw2WrLQ2cXMlvZKe1dVUE9Pz8iu0otJgNeUBOo2H3mI91h/Dl Kr+ipzTsLas2Bs8iTdrdoBWDnnk/RtspiSMWjQjsUkKetdlo628ap8MD0B+b/3D7UV Km//KBitOO5qrPwklUd3+jkE3b6HaJo9qhC2JIYo= To: phodina , 50653@debbugs.gnu.org Subject: Re: [bug#50653] [PATCH] gnu: Add sdlpop. In-Reply-To: <-p2XzmyUeU34-LyC3z50Id77Y3mrwZAnC3s3bUigV4CSc1rE9Pz-FYX9HxF97dLz1oBPpUEx06AoVSLT5eJGyZRZOFmCSfXlSzKHc5U8iCc=@protonmail.com> References: <-p2XzmyUeU34-LyC3z50Id77Y3mrwZAnC3s3bUigV4CSc1rE9Pz-FYX9HxF97dLz1oBPpUEx06AoVSLT5eJGyZRZOFmCSfXlSzKHc5U8iCc=@protonmail.com> Date: Mon, 20 Sep 2021 14:19:26 +0200 Message-ID: <87y27rfnht.fsf@yoctocell.xyz> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha256; protocol="application/pgp-signature" X-Spam-Score: 2.9 (++) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: On Sat, Sep 18 2021, phodina via Guix-patches via wrote: > * gnu/packages/games.scm (sdlpop): New variable. > [copyright]: Sort by date pkill9@runbox.com. > > diff --git a/gnu/packages/games.scm b/gnu/packages/games.scm > index c39770c260..0eed238f32 100644 [...] Content analysis details: (2.9 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 SPF_PASS SPF: sender matches SPF record 2.0 PDS_OTHER_BAD_TLD Untrustworthy TLDs [URI: yoctocell.xyz (xyz)] 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record 0.5 FROM_SUSPICIOUS_NTLD From abused NTLD 0.4 RDNS_DYNAMIC Delivered to internal network by host with dynamic-looking rDNS 0.0 PDS_RDNS_DYNAMIC_FP RDNS_DYNAMIC with FP steps X-Debbugs-Envelope-To: 50653 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 2.9 (++) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: On Sat, Sep 18 2021, phodina via Guix-patches via wrote: > * gnu/packages/games.scm (sdlpop): New variable. > [copyright]: Sort by date pkill9@runbox.com. > > diff --git a/gnu/packages/games.scm b/gnu/packages/games.scm > index c39770c260..0eed238f32 100644 [...] Content analysis details: (2.9 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 SPF_PASS SPF: sender matches SPF record 2.0 PDS_OTHER_BAD_TLD Untrustworthy TLDs [URI: yoctocell.xyz (xyz)] 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record 0.5 FROM_SUSPICIOUS_NTLD From abused NTLD 0.4 RDNS_DYNAMIC Delivered to internal network by host with dynamic-looking rDNS 1.0 BULK_RE_SUSP_NTLD Precedence bulk and RE: from a suspicious TLD -1.0 MAILING_LIST_MULTI Multiple indicators imply a widely-seen list manager 0.0 PDS_RDNS_DYNAMIC_FP RDNS_DYNAMIC with FP steps --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On Sat, Sep 18 2021, phodina via Guix-patches via wrote: > * gnu/packages/games.scm (sdlpop): New variable. > [copyright]: Sort by date pkill9@runbox.com. > > diff --git a/gnu/packages/games.scm b/gnu/packages/games.scm > index c39770c260..0eed238f32 100644 > --- a/gnu/packages/games.scm > +++ b/gnu/packages/games.scm > @@ -45,6 +45,7 @@ > ;;; Copyright =C2=A9 2019, 2020 Guillaume Le Vaillant > ;;; Copyright =C2=A9 2019, 2020 Timotej Lazar > ;;; Copyright =C2=A9 2019 Josh Holland > +;;; Copyright =C2=A9 2019 Pkill -9 > ;;; Copyright =C2=A9 2017, 2019 Hartmut Goebel > ;;; Copyright =C2=A9 2020 Alberto Eleuterio Flores Guerrero > ;;; Copyright =C2=A9 2020 Naga Malleswari > @@ -63,7 +64,7 @@ > ;;; Copyright =C2=A9 2021 Felix Gruber > ;;; Copyright =C2=A9 2021 Solene Rapenne > ;;; Copyright =C2=A9 2021 Noisytoot > -;;; Copyright =C2=A9 2019 Pkill -9 > +;;; Copyright =C2=A9 2021 Petr Hodina I don=E2=80=99t think sorting copyright lines is necessary. > ;;; > ;;; This file is part of GNU Guix. > ;;; > @@ -12480,6 +12481,62 @@ do so you need to explore the island, find food,= build a shelter and try to > get attention, so you get found.") > (license license:cc-by4.0)))) > > +(define-public sdlpop > + (package > + (name "sdlpop") > + (version "1.22") > + (source (origin > + (method git-fetch) > + (uri (git-reference > + (url "https://github.com/NagyD/SDLPoP") > + (commit (string-append "v" version)))) > + (file-name (git-file-name name version)) > + (sha256 > + (base32 > + "1yy5r1r0hv0xggk8qd8bwk2zy7abpv89nikq4flqgi53fc5q9xl7"))= )) > + (build-system gnu-build-system) > + (arguments > + `(#:tests? #f What=E2=80=99s the reason for disabling tests? There should a comment explaining why. > + #:phases > + (modify-phases %standard-phases > + (delete 'configure) > + (add-before 'build 'prepare-build > + ;; Set correct environment for SDL. > + (lambda* (#:key inputs #:allow-other-keys) > + (setenv "CPATH" > + (string-append (assoc-ref inputs "sdl") > + "/include/SDL2:" > + (or (getenv "CPATH") ""))))) > + (add-after 'unpack 'chdir > + (lambda* _ Just =E2=80=98lambda=E2=80=99 would work. > + (chdir "src"))) > + (replace 'install > + (lambda* (#:key outputs #:allow-other-keys) > + (let* ((out (assoc-ref outputs "out")) > + (bin (string-append out "/bin")) > + (opt (string-append out "/opt/sdlpop")) > + (app (string-append out "/usr/share/applications")) > + (template "src/SDLPoP.desktop.template")) > + (chdir "..") > + (install-file "prince" bin) > + (substitute* template (("\\$ROOT") out)) > + (install-file template app) > + (rename-file (string-append app "/SDLPoP.desktop.template= ") > + (string-append app "/SDLPoP.desktop")) > + (install-file "SDLPoP.ini" opt) > + (copy-recursively "data" (string-append bin "/data")) > + (copy-recursively "doc" opt) > + (copy-recursively "mods" opt))))))) > + (native-inputs `(("pkg-config" ,pkg-config))) > + (inputs `(("sdl" ,(sdl-union (list sdl2 > + sdl2-image > + sdl2-mixer))))) > + (synopsis "Open-source port of Prince of Persia") > + (description "Open-source port of Prince of Persia, based on the dis= assembly > +of the DOS version, extended with new features.") The description should consist of one or more complete sentences, and try to keep lines <=3D80 characters. > + (home-page "https://github.com/NagyD/SDLPoP") > + (license license:gpl3))) The =E2=80=98src/GPLv3.h=E2=80=99 file says GPLv3 or later, so it should be =E2=80=98license:gpl3+=E2=80=99. Could you send an updated patch? --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQJJBAEBCAAzFiEEAVhh4yyK5+SEykIzrPUJmaL7XHkFAmFIfE8VHHB1YmxpY0B5 b2N0b2NlbGwueHl6AAoJEKz1CZmi+1x5GWYQAKohmEzCLac7qAXyAXAeYl+p15RO fzt9DHMgJHRd0z9VbseFgLeXsYRUsa7cv9Oiso4n82rbRyA/7TbpJmFkYtbAn61s pYdugqIVG4PkSq5PLhliJD3iuGj55mBvwZnxjDQQE+dfYIagnIh619bibpGRjXPQ Kh2vTzUme5mRnc9H2PC0b7wk4gomB7Ky/13tm9F/IISgDzG3cQM51szmpC0Zmyf2 gHl4cwFAyZV7wXHmELgabZqEc84j34u8qBciiKCZ7PXlJDYBRliaQSidBUdIHQq7 bdO/+9x6xuxfac1c0DkXq/bLt+2doNRoiKvaEBI1z5IrJtEW+sBCXWm3nWp2T+Io EvK3qtNExQlKpKDfBdU/D7pQ2AoE+0nefjbVL9p9qYMFzHxkDQcKNgsAWKmZiLxE DHn9aUm9GqcwIH6OBzElHdnv0bHe1TC3rce+3MGgswJFYcW3A2PvAHgC4CVImjqp MkHUMS4qh8gbWUhJ/OcQ2g8xhDzox+LtU2ATdyTGCRUiU2sTlVkQuINWoiv9zhd1 Gb25xA03lHmSDFHovgJhUShIJgDQ+8hrdli+Tl9aAM+TSSwkFzKNipBCz+y/zzgT g508vhA0S4Boy648JLLmYeW+Y7qkowyOdpgyvK2gqp+GjQPobws9KvhwxqW8BEjC FqH1TptA2WpUgKlf =Uzt9 -----END PGP SIGNATURE----- --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Mon Sep 27 18:16:40 2021 Received: (at 50653) by debbugs.gnu.org; 27 Sep 2021 22:16:40 +0000 Received: from localhost ([127.0.0.1]:43042 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mUyvI-0008UO-8A for submit@debbugs.gnu.org; Mon, 27 Sep 2021 18:16:40 -0400 Received: from mail-4316.protonmail.ch ([185.70.43.16]:29203) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mUyvG-0008U9-CI for 50653@debbugs.gnu.org; Mon, 27 Sep 2021 18:16:31 -0400 Date: Mon, 27 Sep 2021 22:16:19 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=protonmail.com; s=protonmail; t=1632780983; bh=W0dvzzR5Z3og1LNnT4XE+Ji7Jga3J05WB2bf38GcNqU=; h=Date:To:From:Cc:Reply-To:Subject:From; b=DaJ3mfwyaRgy8aTZ2dePPDY4lYFQzlE50o53RcFhuX3lJ2EbTbgoD8zqcrydXAj7b 70PYfedwFCrVlC6RLgMdidJfA6VFOGgcsYInm+ILT+dVIJSkYATOXBy3woPGsoxXKO kHEeLb61eALay3YvmcE3MfGS+AsYCkaPH3Sj8PbM= To: Xinglu Chen From: phodina Subject: [PATCH v2] gnu: Add sdlpop. Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-0.2 required=10.0 tests=ALL_TRUSTED,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,FREEMAIL_REPLYTO shortcircuit=no autolearn=disabled version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on mailout.protonmail.ch X-Spam-Score: 1.0 (+) X-Debbugs-Envelope-To: 50653 Cc: 50653@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: phodina Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hi Xinglu, thank you for the review and comments. Here's the updated patch. If you or anyone committing the patch disagrees with the copyright sorting = then be my guest and remove it. Otherwise IMHO the list should be sorted to= maintain order :-) --8<---------------cut here---------------start------------->8--- * gnu/packages/games.scm (sdlpop): New variable. [copyright]: Sort by date pkill9@runbox.com. diff --git a/gnu/packages/games.scm b/gnu/packages/games.scm index c39770c260..9a6e36ccc1 100644 --- a/gnu/packages/games.scm +++ b/gnu/packages/games.scm @@ -45,6 +45,7 @@ ;;; Copyright =C2=A9 2019, 2020 Guillaume Le Vaillant ;;; Copyright =C2=A9 2019, 2020 Timotej Lazar ;;; Copyright =C2=A9 2019 Josh Holland +;;; Copyright =C2=A9 2019 Pkill -9 ;;; Copyright =C2=A9 2017, 2019 Hartmut Goebel ;;; Copyright =C2=A9 2020 Alberto Eleuterio Flores Guerrero ;;; Copyright =C2=A9 2020 Naga Malleswari @@ -63,7 +64,7 @@ ;;; Copyright =C2=A9 2021 Felix Gruber ;;; Copyright =C2=A9 2021 Solene Rapenne ;;; Copyright =C2=A9 2021 Noisytoot -;;; Copyright =C2=A9 2019 Pkill -9 +;;; Copyright =C2=A9 2021 Petr Hodina ;;; ;;; This file is part of GNU Guix. ;;; @@ -12480,6 +12481,62 @@ do so you need to explore the island, find food, b= uild a shelter and try to get attention, so you get found.") (license license:cc-by4.0)))) +(define-public sdlpop + (package + (name "sdlpop") + (version "1.22") + (source (origin + (method git-fetch) + (uri (git-reference + (url "https://github.com/NagyD/SDLPoP") + (commit (string-append "v" version)))) + (file-name (git-file-name name version)) + (sha256 + (base32 + "1yy5r1r0hv0xggk8qd8bwk2zy7abpv89nikq4flqgi53fc5q9xl7")))) + (build-system gnu-build-system) + (arguments + `(#:tests? #f ; no tests provided + #:phases + (modify-phases %standard-phases + (delete 'configure) + (add-before 'build 'prepare-build + ;; Set correct environment for SDL. + (lambda* (#:key inputs #:allow-other-keys) + (setenv "CPATH" + (string-append (assoc-ref inputs "sdl") + "/include/SDL2:" + (or (getenv "CPATH") ""))))) + (add-after 'unpack 'chdir + (lambda _ + (chdir "src"))) + (replace 'install + (lambda* (#:key outputs #:allow-other-keys) + (let* ((out (assoc-ref outputs "out")) + (bin (string-append out "/bin")) + (opt (string-append out "/opt/sdlpop")) + (app (string-append out "/usr/share/applications")) + (template "src/SDLPoP.desktop.template")) + (chdir "..") + (install-file "prince" bin) + (substitute* template (("\\$ROOT") out)) + (install-file template app) + (rename-file (string-append app "/SDLPoP.desktop.template") + (string-append app "/SDLPoP.desktop")) + (install-file "SDLPoP.ini" opt) + (copy-recursively "data" (string-append bin "/data")) + (copy-recursively "doc" opt) + (copy-recursively "mods" opt))))))) + (native-inputs `(("pkg-config" ,pkg-config))) + (inputs `(("sdl" ,(sdl-union (list sdl2 + sdl2-image + sdl2-mixer))))) + (synopsis "Open-source port of Prince of Persia") + (description "This package provides port of Prince of Persia, based on= the +disassembly of the DOS version, extended with new features.") + (home-page "https://github.com/NagyD/SDLPoP") + (license license:gpl3+))) + (define-public fheroes2 (package (name "fheroes2") -- 2.32.0 From debbugs-submit-bounces@debbugs.gnu.org Tue Sep 28 15:11:16 2021 Received: (at 50653) by debbugs.gnu.org; 28 Sep 2021 19:11:16 +0000 Received: from localhost ([127.0.0.1]:47013 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mVIVR-0005iq-Ln for submit@debbugs.gnu.org; Tue, 28 Sep 2021 15:11:16 -0400 Received: from h87-96-130-155.cust.a3fiber.se ([87.96.130.155]:35286 helo=mail.yoctocell.xyz) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mVIVL-0005i6-JH for 50653@debbugs.gnu.org; Tue, 28 Sep 2021 15:11:08 -0400 From: Xinglu Chen DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=yoctocell.xyz; s=mail; t=1632856257; bh=KPO8b1L9yxeDZGujkcuyG3XYh9GNgk+5uAy/Ks4qYx0=; h=From:To:Cc:Subject:In-Reply-To:References:Date; b=FXqi/XNeQ11RE7yia3s/8GqByLgicUf2Hjb9X/CCXSXgNA55yMLLm5K7l28A5hofy y53dzjgr8RfAR7qqJIlSZUy1keR73119E7U1k+mCWwDkQsGh4h+V4OQSg3yN0HeB9H 38lR3pKNd80uTpD3DOEA13zkrF4llLvcaVKS8+R8= To: phodina Subject: Re: [PATCH v2] gnu: Add sdlpop. In-Reply-To: References: Date: Tue, 28 Sep 2021 21:10:56 +0200 Message-ID: <87h7e4348v.fsf@yoctocell.xyz> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha256; protocol="application/pgp-signature" X-Spam-Score: 2.9 (++) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: On Mon, Sep 27 2021, phodina wrote: > Hi Xinglu, > > thank you for the review and comments. Here's the updated patch. > > If you or anyone committing the patch disagrees with the copyright > sorting then be my guest and remove it. Other [...] Content analysis details: (2.9 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 SPF_PASS SPF: sender matches SPF record 2.0 PDS_OTHER_BAD_TLD Untrustworthy TLDs [URI: yoctocell.xyz (xyz)] 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record 0.5 FROM_SUSPICIOUS_NTLD From abused NTLD 0.4 RDNS_DYNAMIC Delivered to internal network by host with dynamic-looking rDNS 0.0 PDS_RDNS_DYNAMIC_FP RDNS_DYNAMIC with FP steps X-Debbugs-Envelope-To: 50653 Cc: 50653@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 2.9 (++) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: On Mon, Sep 27 2021, phodina wrote: > Hi Xinglu, > > thank you for the review and comments. Here's the updated patch. > > If you or anyone committing the patch disagrees with the copyright > sorting then be my guest and remove it. Other [...] Content analysis details: (2.9 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 SPF_PASS SPF: sender matches SPF record 2.0 PDS_OTHER_BAD_TLD Untrustworthy TLDs [URI: yoctocell.xyz (xyz)] 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record 0.5 FROM_SUSPICIOUS_NTLD From abused NTLD 0.4 RDNS_DYNAMIC Delivered to internal network by host with dynamic-looking rDNS 1.0 BULK_RE_SUSP_NTLD Precedence bulk and RE: from a suspicious TLD -1.0 MAILING_LIST_MULTI Multiple indicators imply a widely-seen list manager 0.0 PDS_RDNS_DYNAMIC_FP RDNS_DYNAMIC with FP steps --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On Mon, Sep 27 2021, phodina wrote: > Hi Xinglu, > > thank you for the review and comments. Here's the updated patch. > > If you or anyone committing the patch disagrees with the copyright > sorting then be my guest and remove it. Otherwise IMHO the list should > be sorted to maintain order :-) I don=E2=80=99t have any objections; I just don=E2=80=99t think it really m= atters. > --8<---------------cut here---------------start------------->8--- Not sure why you put this here. > * gnu/packages/games.scm (sdlpop): New variable. > [copyright]: Sort by date pkill9@runbox.com. > > diff --git a/gnu/packages/games.scm b/gnu/packages/games.scm > index c39770c260..9a6e36ccc1 100644 > --- a/gnu/packages/games.scm > +++ b/gnu/packages/games.scm > @@ -45,6 +45,7 @@ > ;;; Copyright =C2=A9 2019, 2020 Guillaume Le Vaillant > ;;; Copyright =C2=A9 2019, 2020 Timotej Lazar > ;;; Copyright =C2=A9 2019 Josh Holland > +;;; Copyright =C2=A9 2019 Pkill -9 > ;;; Copyright =C2=A9 2017, 2019 Hartmut Goebel > ;;; Copyright =C2=A9 2020 Alberto Eleuterio Flores Guerrero > ;;; Copyright =C2=A9 2020 Naga Malleswari > @@ -63,7 +64,7 @@ > ;;; Copyright =C2=A9 2021 Felix Gruber > ;;; Copyright =C2=A9 2021 Solene Rapenne > ;;; Copyright =C2=A9 2021 Noisytoot > -;;; Copyright =C2=A9 2019 Pkill -9 > +;;; Copyright =C2=A9 2021 Petr Hodina > ;;; > ;;; This file is part of GNU Guix. > ;;; > @@ -12480,6 +12481,62 @@ do so you need to explore the island, find food,= build a shelter and try to > get attention, so you get found.") > (license license:cc-by4.0)))) > > +(define-public sdlpop > + (package > + (name "sdlpop") > + (version "1.22") > + (source (origin > + (method git-fetch) > + (uri (git-reference > + (url "https://github.com/NagyD/SDLPoP") > + (commit (string-append "v" version)))) > + (file-name (git-file-name name version)) > + (sha256 > + (base32 > + "1yy5r1r0hv0xggk8qd8bwk2zy7abpv89nikq4flqgi53fc5q9xl7"))= )) > + (build-system gnu-build-system) > + (arguments > + `(#:tests? #f ; no tests provided > + #:phases > + (modify-phases %standard-phases > + (delete 'configure) > + (add-before 'build 'prepare-build > + ;; Set correct environment for SDL. > + (lambda* (#:key inputs #:allow-other-keys) > + (setenv "CPATH" > + (string-append (assoc-ref inputs "sdl") > + "/include/SDL2:" > + (or (getenv "CPATH") ""))))) > + (add-after 'unpack 'chdir > + (lambda _ > + (chdir "src"))) > + (replace 'install > + (lambda* (#:key outputs #:allow-other-keys) > + (let* ((out (assoc-ref outputs "out")) > + (bin (string-append out "/bin")) > + (opt (string-append out "/opt/sdlpop")) > + (app (string-append out "/usr/share/applications")) > + (template "src/SDLPoP.desktop.template")) > + (chdir "..") > + (install-file "prince" bin) > + (substitute* template (("\\$ROOT") out)) > + (install-file template app) > + (rename-file (string-append app "/SDLPoP.desktop.template= ") > + (string-append app "/SDLPoP.desktop")) > + (install-file "SDLPoP.ini" opt) > + (copy-recursively "data" (string-append bin "/data")) > + (copy-recursively "doc" opt) > + (copy-recursively "mods" opt))))))) > + (native-inputs `(("pkg-config" ,pkg-config))) > + (inputs `(("sdl" ,(sdl-union (list sdl2 > + sdl2-image > + sdl2-mixer))))) > + (synopsis "Open-source port of Prince of Persia") > + (description "This package provides port of Prince of Persia, based = on the > +disassembly of the DOS version, extended with new features.") > + (home-page "https://github.com/NagyD/SDLPoP") > + (license license:gpl3+))) > + The updated patch LGTM! --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQJJBAEBCAAzFiEEAVhh4yyK5+SEykIzrPUJmaL7XHkFAmFTaMAVHHB1YmxpY0B5 b2N0b2NlbGwueHl6AAoJEKz1CZmi+1x5YwAP/ifh1PH9zk4XpmNE512Tti3r9Db4 AHr26JNKLJXlkMXpDix/PdnzTXJ7m2IBosdikU9R+gWrVMlBcLJqSspm0Ry1KscR 8XRZO3jyxC16EAG0cyleph8fy9oujcfDt7U88QIWwi5C4xwEkF3STGvIY7PZodd3 SOrtaKaXYNGf2rc+ZNf3L3W2705C1lVwXtonfttV8V8xsIIQ8qNLaDHq0vuRZR3C gasJiEvwRw16Pdk0Gg2PzhGB6O2kAGLQjOne2wkZoGTAa2pm+ywFhzBELgtfxvlJ tGnsuyvtqRvk91EHhptxi8iAA2+w7VWX/3afh6stD00HXSsjKRGOtq0/hhHrH6tr xJ4jjCG1Uc+RCU5dUDSweBM/e6rXJediUYZ23oe8uNXg9PSse+QkTvdGyOsHv9gh sPn6ASUBGlS/wOgZR1SmXt9E1t0Z4hpiCz8LsOLwQVTXL+DWiV/WNydLtwRubFsT FdLFVfbUkq/QqehQFpSYIu85CYZUd516syM4zGIzSJ5jJNcnm8xUKJPCk7zTNYUI UkSJ3qqA3dRqllCnjvXhXY1U3lG9s1+ZGs8Enq92DcvGFBAzH2Kp3uTL4cYnE4yW 8dGujquuw+/7IOSFnBNadZDTDKtLren+j7BDYr3SkAzFw9NGBbNaRB/HLIfRJlg3 NgPHNNbGxaTC33Sz =R4ld -----END PGP SIGNATURE----- --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Tue Sep 28 15:37:36 2021 Received: (at 50653-done) by debbugs.gnu.org; 28 Sep 2021 19:37:36 +0000 Received: from localhost ([127.0.0.1]:47070 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mVIv2-0006Pj-Lo for submit@debbugs.gnu.org; Tue, 28 Sep 2021 15:37:36 -0400 Received: from relay4-d.mail.gandi.net ([217.70.183.196]:46217) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mVIv0-0006PS-Fu for 50653-done@debbugs.gnu.org; Tue, 28 Sep 2021 15:37:35 -0400 Received: (Authenticated sender: admin@nicolasgoaziou.fr) by relay4-d.mail.gandi.net (Postfix) with ESMTPSA id 9E1F9E0004; Tue, 28 Sep 2021 19:37:27 +0000 (UTC) From: Nicolas Goaziou To: Xinglu Chen Subject: Re: [bug#50653] [PATCH v2] gnu: Add sdlpop. References: <87h7e4348v.fsf@yoctocell.xyz> Date: Tue, 28 Sep 2021 21:37:26 +0200 In-Reply-To: <87h7e4348v.fsf@yoctocell.xyz> (Xinglu Chen's message of "Tue, 28 Sep 2021 21:10:56 +0200") Message-ID: <87a6jwze2x.fsf@nicolasgoaziou.fr> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 1.3 (+) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: Hello, Xinglu Chen writes: > The updated patch LGTM! Content analysis details: (1.3 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 SPF_PASS SPF: sender matches SPF record -0.7 RCVD_IN_DNSWL_LOW RBL: Sender listed at https://www.dnswl.org/, low trust [217.70.183.196 listed in list.dnswl.org] -0.0 RCVD_IN_MSPIKE_H3 RBL: Good reputation (+3) [217.70.183.196 listed in wl.mailspike.net] 2.0 PDS_OTHER_BAD_TLD Untrustworthy TLDs [URI: yoctocell.xyz (xyz)] 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.0 RCVD_IN_MSPIKE_WL Mailspike good senders X-Debbugs-Envelope-To: 50653-done Cc: 50653-done@debbugs.gnu.org, phodina X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.3 (/) Hello, Xinglu Chen writes: > The updated patch LGTM! Thank you for the review. I removed "Open-source" from the synopsis and pushed. Thanks to phodina for the patch. Regards, -- Nicolas Goaziou From unknown Sat Aug 16 21:20:25 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Wed, 27 Oct 2021 11:24:06 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator