Subject: bug#50631: closed (Re: bug#50631: [PATCH] gnu: gnunet: Fix libmicrohttpd test case using SSL3.)

From: [email-masked] (GNU bug Tracking System)
Date: Fri, 17 Sep 2021 20:47:02 +0000

Your bug report

#50631: [PATCH] gnu: gnunet: Fix libmicrohttpd test case using SSL3.

which was filed against the guix-patches package, has been closed.

The explanation is attached below, along with your original report.
If you require more details, please reply to [email-masked].

-- 
50631: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=50631
GNU Bug Tracking System
Contact [email-masked] with problems

Subject: Re: bug#50631: [PATCH] gnu: gnunet: Fix libmicrohttpd test case using SSL3.
From: Ludovic Courtès <[email-masked]>
To: muradm <[email-masked]>
Cc: [email-masked]
Date: Fri, 17 Sep 2021 22:46:18 +0200
List-Id: <debbugs-submit.debbugs.gnu.org>

Hi,

muradm <[email-masked]> skribis:

> * gnu/packages/patches/libmicrohttpd-0.9.73-test-ssl3.patch:
> Patch for failing test case as suggested by libmicrohttpd mailing list
> * gnu/packages/gnunet.scm (libmicrohttpd): use patch

I added the patch to gnu/local.mk and applied.

Thank you!

Ludo’.

Subject: [PATCH] gnu: gnunet: Fix libmicrohttpd test case using SSL3.
From: muradm <[email-masked]>
To: [email-masked]
Date: Fri, 17 Sep 2021 09:26:48 +0300
List-Id: <debbugs-submit.debbugs.gnu.org>

* gnu/packages/patches/libmicrohttpd-0.9.73-test-ssl3.patch:
Patch for failing test case as suggested by libmicrohttpd mailing list
* gnu/packages/gnunet.scm (libmicrohttpd): use patch
---
 gnu/packages/gnunet.scm                       |  3 +-
 .../libmicrohttpd-0.9.73-test-ssl3.patch      | 35 +++++++++++++++++++
 2 files changed, 37 insertions(+), 1 deletion(-)
 create mode 100644 gnu/packages/patches/libmicrohttpd-0.9.73-test-ssl3.patch

diff --git a/gnu/packages/gnunet.scm b/gnu/packages/gnunet.scm
index d0a9955005..c1ccf8d702 100644
--- a/gnu/packages/gnunet.scm
+++ b/gnu/packages/gnunet.scm
@@ -164,7 +164,8 @@ tool to extract metadata from a file and print the results.")
                                 version ".tar.gz"))
             (sha256
              (base32
-              "0bh39irwzkv48fkw43skfgkk8ka3793bx1lm21sgw6zxi0djyyx3"))))
+              "0bh39irwzkv48fkw43skfgkk8ka3793bx1lm21sgw6zxi0djyyx3"))
+            (patches (search-patches "libmicrohttpd-0.9.73-test-ssl3.patch"))))
    (build-system gnu-build-system)
    (inputs
     `(("curl" ,curl)
diff --git a/gnu/packages/patches/libmicrohttpd-0.9.73-test-ssl3.patch b/gnu/packages/patches/libmicrohttpd-0.9.73-test-ssl3.patch
new file mode 100644
index 0000000000..e8d5dce0ed
--- /dev/null
+++ b/gnu/packages/patches/libmicrohttpd-0.9.73-test-ssl3.patch
@@ -0,0 +1,35 @@
+ Disable usage of SSLv3 in testing
+
+ Integrated uptream version 0.9.74
+
+
+diff --git a/src/testcurl/https/test_tls_options.c b/src/testcurl/https/test_tls_options.c
+
+--- a/src/testcurl/https/test_tls_options.c
++++ b/src/testcurl/https/test_tls_options.c
+@@ -119,11 +119,6 @@ main (int argc, char *const *argv)
+     fprintf (stderr, "Curl does not support SSL.  Cannot run the test.\n");
+     return 77;
+   }
+-  if (0 != strncmp (ssl_version, "GnuTLS", 6))
+-  {
+-    fprintf (stderr, "This test can be run only with libcurl-gnutls.\n");
+-    return 77;
+-  }
+ 
+   if (! testsuite_curl_global_init ())
+     return 99;
+@@ -152,10 +147,10 @@ main (int argc, char *const *argv)
+   fprintf (stderr,
+            "The following handshake should fail (and print an error message)...\n");
+   if (0 !=
+-      test_wrap ("TLS1.0 vs SSL3",
++      test_wrap ("TLS1.1 vs TLS1.0",
+                  &test_unmatching_ssl_version, NULL, port, daemon_flags,
+                  aes256_sha,
+-                 CURL_SSLVERSION_SSLv3,
++                 CURL_SSLVERSION_TLSv1_1,
+                  MHD_OPTION_HTTPS_MEM_KEY, srv_key_pem,
+                  MHD_OPTION_HTTPS_MEM_CERT, srv_self_signed_cert_pem,
+                  MHD_OPTION_HTTPS_PRIORITIES,
+
-- 
2.33.0