Subject: Re: bug#50630: [PATCH] Add tests for insert-directory

From: Eli Zaretskii <[email-masked]>
Date: Sat, 25 Sep 2021 09:10:31 +0300

> Date: Fri, 24 Sep 2021 19:58:25 +0000
> From: John Cummings <[email-masked]>
> 
> Along those lines, I also attempted to skip the test when ls-lisp
> would be used during files-tests.el, which I predict might happen when
> building on Windows?

Why did you need to skip those tests?  Can you elaborate?

> +       ;;Try to verify that insert-directory will come from files.el,
> +       ;;not ls-lisp.el. Windows builds will probably use ls-lisp.el
> +       ;;by default, which will invalidate some tests.
> +       (insert-directory-program-used (or (not (featurep 'ls-lisp))
> +                                          ls-lisp-use-insert-directory-program)))

I guess this is part of the same question I asked above?  Because I
don't think I understand what you are trying to do here and why.

Thanks.