GNU bug report logs - #50627
[PATCH 0/2] Make wayland-protocols dependency native-input.

Previous Next

Full log

Message #38 received at 50627 <at> debbugs.gnu.org (full text, mbox):

From: Maxime Devos <maxime.devos <at> student.kuleuven.be>
To: 50627 <at> debbugs.gnu.org, muradm <mail <at> muradm.net>,
 Liliana Marie Prikler <liliana.prikler <at> gmail.com>
Subject: Re: [PATCH v1] gnu: gtk: Move wayland-protocols to inputs.
Date: Thu, 6 Oct 2022 10:18:21 +0200

[Message part 1 (text/plain, inline)]

Hi,

Removing a propagated input from gtk (by moving it to native-inputs) 
sounds good, but I don't see the point of the inputs->native-inputs 
changes.  Now I see there is a revised patch at

<https://issues.guix.gnu.org/50627#8>

(albeit named v1 instead of v2).

Some comments on the new patch:

> diff --git a/gnu/packages/patches/gtk3-wayland-protocols-dependency.patch b/gnu/packages/patches/gtk3-wayland-protocols-dependency.patch
> new file mode 100644
> index 0000000000..03196713bc
> --- /dev/null
> +++ b/gnu/packages/patches/gtk3-wayland-protocols-dependency.patch
> @@ -0,0 +1,23 @@
> +diff --git a/configure b/configure
> +index edd41ad..cb36877 100755
> +--- a/configure
> ++++ b/configure
> [...]

'configure' is generated stuff, not source code, so now the result of 
"guix build --source" is missing some source code (i.e., the revisions 
to configure.ac).

Proposal: modify configure.ac instead, add autotools inputs and delete 
'configure' such that Guix will automatically run autoreconf, see 
<https://lists.gnu.org/archive/html/guix-devel/2022-04/msg00009.html>.

Greetings,
Maxime

[Message part 2 (text/html, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.