GNU bug report logs - #5062
23.1.50; image-toggle-display overwrites nxml-mode local key map

Previous Next

Full log

View this message in rfc822 format

From: Stefan Monnier <monnier <at> iro.umontreal.ca>
To: Juri Linkov <juri <at> jurta.org>
Cc: 5062 <at> debbugs.gnu.org, Brent Goodrick <bgoodr <at> gmail.com>
Subject: bug#5062: 23.1.50; image-toggle-display overwrites nxml-mode local key map
Date: Sun, 29 Nov 2009 10:36:59 -0500

>> Better would be to save the major mode, and then switch to
>> "saved-major-mode + image-minor-mode".  No need to modify anybody's
>> keymap.  And I think that image-minor-mode should only be used while
>> displaying text: basically, image-toggle-display should toggle between
>> image-mode and the other major-mode (complemented with
>> image-minor-mode).
>> That would be cleaner,
> I see now how this is implemented with `doc-view-previous-major-mode'
> in doc-view.  Perhaps we should "sync" this with image-mode to use
> the same logic.

Yes.  Those two modes really need to be made more alike (ideally, they
should be merged, tho there might be some good reasons to keep some of
it separate).


        Stefan

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.