GNU bug report logs - #5062
23.1.50; image-toggle-display overwrites nxml-mode local key map

Previous Next

Package: emacs;

Reported by: Brent Goodrick <bgoodr <at> gmail.com>

Date: Sat, 28 Nov 2009 00:50:04 UTC

Severity: normal

Done: Juri Linkov <juri <at> jurta.org>

Bug is archived. No further changes may be made.

Full log

Message #30 received at 5062 <at> emacsbugs.donarmstrong.com (full text, mbox):

From: Juri Linkov <juri <at> jurta.org>
To: Stefan Monnier <monnier <at> iro.umontreal.ca>
Cc: 5062 <at> debbugs.gnu.org, Brent Goodrick <bgoodr <at> gmail.com>
Subject: Re: bug#5062: 23.1.50; image-toggle-display overwrites nxml-mode local key map
Date: Sun, 29 Nov 2009 00:54:16 +0200

> Better would be to save the major mode, and then switch to
> "saved-major-mode + image-minor-mode".  No need to modify anybody's
> keymap.  And I think that image-minor-mode should only be used while
> displaying text: basically, image-toggle-display should toggle between
> image-mode and the other major-mode (complemented with
> image-minor-mode).
>
> That would be cleaner,

I see now how this is implemented with `doc-view-previous-major-mode'
in doc-view.  Perhaps we should "sync" this with image-mode to use
the same logic.

-- 
Juri Linkov
http://www.jurta.org/emacs/
This bug report was last modified 15 years and 150 days ago.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.