Subject: Re: [PATCH v2] import: stackage: Don’t try to update packages not available on Stackage.

From: Xinglu Chen <[email-masked]>
Date: Mon, 27 Sep 2021 11:56:02 +0200

On Mon, Sep 27 2021, Lars-Dominik Braun wrote:

> Hi,
>
> for some reason I cannot get this patch to apply. `git am` fails and also
> `patch -Np1` spits out an error:
>
> patching file guix/import/stackage.scm
> patch: **** malformed patch at line 47: @@ -141,11 +145,23 @@

Hmm, it seems to fail for me as well, but with a different error.  I
have attached the patch below.

> Can you push it somewhere?

Sure, but I think its easier for you to just apply the attached patch.

  <https://git.yoctocell.xyz/guix/log/?h=stackage-import-predicate>

From 49f705217487aacfd6ab0b794b07eea9262d7661 Mon Sep 17 00:00:00 2001
Message-Id: <[email-masked]>
From: Xinglu Chen <[email-masked]>
Date: Thu, 16 Sep 2021 13:29:42 +0200
Subject: [PATCH] =?UTF-8?q?import:=20stackage:=20Don=E2=80=99t=20try=20to?=
 =?UTF-8?q?=20update=20packages=20not=20available=20on=20Stackage.?=
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

Previously, the ‘hackage-package?’ predicate was used which meant that
the updater would try to update non-Stackage packages, and lead to messages
like these:

  $ guix refresh -t stackage
  warning: failed to parse https://hackage.haskell.org/package/hurl/hurl.cabal
  warning: failed to parse https://hackage.haskell.org/package/idris/idris.cabal

Since ‘hurl’ and ‘idris’ aren’t available on the current Stackage LTS release,
they should be filtered out before the Stackage updater even tries to update
them.

* stackage.scm (stackage-package?): New procedure.
(%stackage-updater): Use it.
---
 guix/import/stackage.scm | 17 ++++++++++++++++-
 1 file changed, 16 insertions(+), 1 deletion(-)

diff --git a/guix/import/stackage.scm b/guix/import/stackage.scm
index bbd903a2cd..731e69651e 100644
--- a/guix/import/stackage.scm
+++ b/guix/import/stackage.scm
@@ -2,6 +2,7 @@
 ;;; Copyright © 2017 Federico Beffa <[email-masked]>
 ;;; Copyright © 2018 Ricardo Wurmus <[email-masked]>
 ;;; Copyright © 2020 Martin Becze <[email-masked]>
+;;; Copyright © 2021 Xinglu Chem <[email-masked]>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -21,10 +22,12 @@
 (define-module (guix import stackage)
   #:use-module (ice-9 match)
   #:use-module (ice-9 regex)
+  #:use-module (ice-9 control)
   #:use-module (srfi srfi-1)
   #:use-module (srfi srfi-26)
   #:use-module (srfi srfi-34)
   #:use-module (srfi srfi-35)
+  #:use-module (srfi srfi-43)
   #:use-module (guix import json)
   #:use-module (guix import hackage)
   #:use-module (guix import utils)
@@ -141,11 +144,23 @@ (define latest-lts-release
                 (version version)
                 (urls (list url))))))))))
 
+(define (stackage-package? package)
+  "Whether PACKAGE is available on the default Stackage LTS release."
+  (and (hackage-package? package)
+       (let ((packages (lts-info-packages
+                        (stackage-lts-info-fetch %default-lts-version)))
+             (hackage-name (guix-package->hackage-name package)))
+         (vector-any identity
+                     (vector-map
+                      (lambda (_ metadata)
+                        (string=? (cdr (list-ref metadata 2)) hackage-name))
+                      packages)))))
+
 (define %stackage-updater
   (upstream-updater
    (name 'stackage)
    (description "Updater for Stackage LTS packages")
-   (pred hackage-package?)
+   (pred stackage-package?)
    (latest latest-lts-release)))
 
 ;;; stackage.scm ends here

base-commit: 8c6c33a2a5bf385e1589b405ee7f842684ed80c1
-- 
2.33.0