From unknown Sat Sep 20 12:38:58 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#50618] [PATCH] import: stackage: =?UTF-8?Q?Don=E2=80=99t?= try to update packages not available on Stackage. Resent-From: Xinglu Chen Original-Sender: "Debbugs-submit" Resent-CC: lars@6xq.net, guix-patches@gnu.org Resent-Date: Thu, 16 Sep 2021 11:33:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 50618 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 50618@debbugs.gnu.org Cc: Lars-Dominik Braun X-Debbugs-Original-To: guix-patches@gnu.org X-Debbugs-Original-Xcc: Lars-Dominik Braun Received: via spool by submit@debbugs.gnu.org id=B.163179193224945 (code B ref -1); Thu, 16 Sep 2021 11:33:01 +0000 Received: (at submit) by debbugs.gnu.org; 16 Sep 2021 11:32:12 +0000 Received: from localhost ([127.0.0.1]:53963 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mQpce-0006Qw-Mc for submit@debbugs.gnu.org; Thu, 16 Sep 2021 07:32:12 -0400 Received: from lists.gnu.org ([209.51.188.17]:46416) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mQpcZ-0006N9-Ho for submit@debbugs.gnu.org; Thu, 16 Sep 2021 07:32:07 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:59918) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mQpcX-00047I-J3 for guix-patches@gnu.org; Thu, 16 Sep 2021 07:32:02 -0400 Received: from h87-96-130-155.cust.a3fiber.se ([87.96.130.155]:52154 helo=mail.yoctocell.xyz) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mQpcV-0008W0-BI for guix-patches@gnu.org; Thu, 16 Sep 2021 07:32:01 -0400 From: Xinglu Chen DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=yoctocell.xyz; s=mail; t=1631791912; bh=I/fOYEdAifK9DRIuRhK6snfgMiIkVYXpuiXV2c34NB0=; h=From:To:Subject:Date; b=Gz4Tp0sDnSmuoWeQwwxViw0IPAdbf/F9+i3JY14Es1pddWWMIl2DsUCzE4oXv2bMI ijnCJbILHI/8/0yB8CDs5zH4KFqFn8MxK9/VwZ37GfSYlme8h90WtAsRjeFD/TYbpL Vil1rIWC2gaxOf1AVOZKGf6E7KAyMSAAlWuDh3wA= Message-Id: <33ce44c6b5dc4f0c2ea2cf7a8402807d91e849a6.1631791821.git.public@yoctocell.xyz> Date: Thu, 16 Sep 2021 13:31:51 +0200 MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Received-SPF: pass client-ip=87.96.130.155; envelope-from=public@yoctocell.xyz; helo=mail.yoctocell.xyz X-Spam_score_int: 34 X-Spam_score: 3.4 X-Spam_bar: +++ X-Spam_report: (3.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FROM_SUSPICIOUS_NTLD=0.5, FROM_SUSPICIOUS_NTLD_FP=1.999, PDS_OTHER_BAD_TLD=1.999, RDNS_DYNAMIC=0.982, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-Spam-Score: 0.8 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.2 (/) Previously, the =E2=80=98hackage-package?=E2=80=99 predicate was used which= meant that the updater would try to update non-Stackage packages, and lead to messages like these: $ guix refresh -t stackage warning: failed to parse https://hackage.haskell.org/package/hurl/hurl.ca= bal warning: failed to parse https://hackage.haskell.org/package/idris/idris.= cabal Since =E2=80=98hurl=E2=80=99 and =E2=80=98idris=E2=80=99 aren=E2=80=99t ava= ilable on the current Stackage LTS release, they should be filtered out before the Stackage updater even tries to update them. * stackage.scm (stackage-package?): New procedure. (%stackage-updater): Use it. --- guix/import/stackage.scm | 15 ++++++++++++++- 1 file changed, 14 insertions(+), 1 deletion(-) diff --git a/guix/import/stackage.scm b/guix/import/stackage.scm index bbd903a2cd..5b19e2a03a 100644 --- a/guix/import/stackage.scm +++ b/guix/import/stackage.scm @@ -2,6 +2,7 @@ ;;; Copyright =C2=A9 2017 Federico Beffa ;;; Copyright =C2=A9 2018 Ricardo Wurmus ;;; Copyright =C2=A9 2020 Martin Becze +;;; Copyright =C2=A9 2021 Xinglu Chem ;;; ;;; This file is part of GNU Guix. ;;; @@ -25,6 +26,7 @@ #:use-module (srfi srfi-26) #:use-module (srfi srfi-34) #:use-module (srfi srfi-35) + #:use-module (guix http-client) #:use-module (guix import json) #:use-module (guix import hackage) #:use-module (guix import utils) @@ -141,11 +143,22 @@ PACKAGE or #f if the package is not included in the S= tackage LTS release." (version version) (urls (list url)))))))))) =20 +(define (stackage-package? package) + "Whether PACKAGE is available on the default Stackage LTS release." + (and (hackage-package? package) + (guard (c ((and (http-get-error? c) + (=3D 404 (http-get-error-code c))) + #f)) + (let* ((name (guix-package->hackage-name package)) + (url (string-append (%stackage-url) "/lts-" + %default-lts-version "/package/" name)= )) + (http-fetch url))))) + (define %stackage-updater (upstream-updater (name 'stackage) (description "Updater for Stackage LTS packages") - (pred hackage-package?) + (pred stackage-package?) (latest latest-lts-release))) =20 ;;; stackage.scm ends here base-commit: a840caccaee8c9492f4cc8a7ba802ef54391f199 --=20 2.33.0 From unknown Sat Sep 20 12:38:58 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#50618] [PATCH] import: stackage: =?UTF-8?Q?Don=E2=80=99t?= try to update packages not available on Stackage. Resent-From: Lars-Dominik Braun Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Wed, 22 Sep 2021 06:08:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 50618 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Xinglu Chen Cc: 50618@debbugs.gnu.org Received: via spool by 50618-submit@debbugs.gnu.org id=B50618.163229086729673 (code B ref 50618); Wed, 22 Sep 2021 06:08:02 +0000 Received: (at 50618) by debbugs.gnu.org; 22 Sep 2021 06:07:47 +0000 Received: from localhost ([127.0.0.1]:48624 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mSvQ3-0007iU-3F for submit@debbugs.gnu.org; Wed, 22 Sep 2021 02:07:47 -0400 Received: from mout-p-102.mailbox.org ([80.241.56.152]:53678) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mSvQ0-0007i8-2Y for 50618@debbugs.gnu.org; Wed, 22 Sep 2021 02:07:45 -0400 Received: from smtp202.mailbox.org (smtp202.mailbox.org [80.241.60.245]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-384) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mout-p-102.mailbox.org (Postfix) with ESMTPS id 4HDnrn628zzQk95; Wed, 22 Sep 2021 08:07:37 +0200 (CEST) X-Virus-Scanned: amavisd-new at heinlein-support.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6xq.net; s=MBO0001; t=1632290856; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=fa7VFuxz/6hJyRlexOsXdlIRNT7Y0gqNSY13IkFQRLs=; b=B101mtP/Vrbgk8P+q7ZnEQyI7CF7YNzrHA0DxnKMdY1arWj9qNoMeJidCBcH2llWmV6JJo cPBMCLHic/xKTneD3zEFlRVUwQ7mc+6cgzN1QR6vYIioG9aZ+mpSiDONC2aaNzd9otRsQG BEWfk8lYGzAsxUMKVJhZrg7gnR2F0+Fuw4SpUpbgtYGwBP3ToTJSysZqarFi9eZmaPsdKT f+JFBxpTsq0BfCJ4Nmr1H6ySDC+X/RFyxlVIbOqt6YsoIfbEptwzd1Ky3izYiNqxGH0cQ6 YkapW4h+CjLs0ubsCkicBoszRmheBCSpFFFMVUaGP+oMW2WoAJ+UVeFd2H2JcQ== Date: Wed, 22 Sep 2021 08:07:32 +0200 From: Lars-Dominik Braun Message-ID: References: <33ce44c6b5dc4f0c2ea2cf7a8402807d91e849a6.1631791821.git.public@yoctocell.xyz> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <33ce44c6b5dc4f0c2ea2cf7a8402807d91e849a6.1631791821.git.public@yoctocell.xyz> X-Rspamd-Queue-Id: E427926D X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Hi, > +(define (stackage-package? package) > + "Whether PACKAGE is available on the default Stackage LTS release." > + (and (hackage-package? package) > + (guard (c ((and (http-get-error? c) > + (= 404 (http-get-error-code c))) > + #f)) > + (let* ((name (guix-package->hackage-name package)) > + (url (string-append (%stackage-url) "/lts-" > + %default-lts-version "/package/" name))) > + (http-fetch url))))) > + since stackage-lts-info-fetch is memoized, wouldn’t it be cheaper to look up the package there? (At least for lots of packages.) Cheers, Lars From unknown Sat Sep 20 12:38:58 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#50618] [PATCH] import: stackage: =?UTF-8?Q?Don=E2=80=99t?= try to update packages not available on Stackage. Resent-From: Xinglu Chen Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Wed, 22 Sep 2021 12:39:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 50618 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Lars-Dominik Braun Cc: 50618@debbugs.gnu.org Received: via spool by 50618-submit@debbugs.gnu.org id=B50618.163231428320392 (code B ref 50618); Wed, 22 Sep 2021 12:39:02 +0000 Received: (at 50618) by debbugs.gnu.org; 22 Sep 2021 12:38:03 +0000 Received: from localhost ([127.0.0.1]:49035 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mT1Vi-0005Iq-Rc for submit@debbugs.gnu.org; Wed, 22 Sep 2021 08:38:03 -0400 Received: from h87-96-130-155.cust.a3fiber.se ([87.96.130.155]:36012 helo=mail.yoctocell.xyz) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mT1Vg-0005I3-8F for 50618@debbugs.gnu.org; Wed, 22 Sep 2021 08:38:01 -0400 From: Xinglu Chen DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=yoctocell.xyz; s=mail; t=1632314270; bh=xzvKnH9YIQeXMs8hknk1ECCmgNS87qXALwajevXHc0k=; h=From:To:Cc:Subject:In-Reply-To:References:Date; b=drwbNRR6lkgSOnyfWPpXY75MGkfYRPygNdSSaOe3qR83F9wcu91DgaqX6wrQVEiGx wJtFBO93kCdVhnsHba8Zfhsp6uPphAYs6qROuravyzQrHaMS0YbOigk/Myyr7WqTXP Ha7zJkEE45n0fZTG8tWk3/ZLo8VrbVkAqVSj2RVw= In-Reply-To: References: <33ce44c6b5dc4f0c2ea2cf7a8402807d91e849a6.1631791821.git.public@yoctocell.xyz> Date: Wed, 22 Sep 2021 14:37:39 +0200 Message-ID: <87wnn8lrak.fsf@yoctocell.xyz> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha256; protocol="application/pgp-signature" X-Spam-Score: 2.9 (++) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: On Wed, Sep 22 2021, Lars-Dominik Braun wrote: > Hi, > >> +(define (stackage-package? package) >> + "Whether PACKAGE is available on the default Stackage LTS release." >> + (and (hackage-package? package) >> + (guard (c ((and (http-get-error? c) > [...] Content analysis details: (2.9 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 SPF_PASS SPF: sender matches SPF record 2.0 PDS_OTHER_BAD_TLD Untrustworthy TLDs [URI: yoctocell.xyz (xyz)] 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record 0.5 FROM_SUSPICIOUS_NTLD From abused NTLD 0.4 RDNS_DYNAMIC Delivered to internal network by host with dynamic-looking rDNS 0.0 PDS_RDNS_DYNAMIC_FP RDNS_DYNAMIC with FP steps X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 2.9 (++) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: On Wed, Sep 22 2021, Lars-Dominik Braun wrote: > Hi, > >> +(define (stackage-package? package) >> + "Whether PACKAGE is available on the default Stackage LTS release." >> + (and (hackage-package? package) >> + (guard (c ((and (http-get-error? c) > [...] Content analysis details: (2.9 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 SPF_PASS SPF: sender matches SPF record 2.0 PDS_OTHER_BAD_TLD Untrustworthy TLDs [URI: yoctocell.xyz (xyz)] 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record 0.5 FROM_SUSPICIOUS_NTLD From abused NTLD 0.4 RDNS_DYNAMIC Delivered to internal network by host with dynamic-looking rDNS 1.0 BULK_RE_SUSP_NTLD Precedence bulk and RE: from a suspicious TLD -1.0 MAILING_LIST_MULTI Multiple indicators imply a widely-seen list manager 0.0 PDS_RDNS_DYNAMIC_FP RDNS_DYNAMIC with FP steps --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On Wed, Sep 22 2021, Lars-Dominik Braun wrote: > Hi, > >> +(define (stackage-package? package) >> + "Whether PACKAGE is available on the default Stackage LTS release." >> + (and (hackage-package? package) >> + (guard (c ((and (http-get-error? c) >> + (=3D 404 (http-get-error-code c))) >> + #f)) >> + (let* ((name (guix-package->hackage-name package)) >> + (url (string-append (%stackage-url) "/lts-" >> + %default-lts-version "/package/" na= me))) >> + (http-fetch url))))) >> + > since stackage-lts-info-fetch is memoized, wouldn=E2=80=99t it be cheaper > to look up the package there? (At least for lots of packages.) Ah, good idea! I will test if what the difference is terms of time. --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQJJBAEBCAAzFiEEAVhh4yyK5+SEykIzrPUJmaL7XHkFAmFLI5MVHHB1YmxpY0B5 b2N0b2NlbGwueHl6AAoJEKz1CZmi+1x5BZcP/2yd1cUJkBhp+nxYniW/TnDDvcuq VQjECbfnqgJrbiiApNkK1nT9NejW15vT07qvdqlCOa6OStHk7fGoClo7ZYoDnOVJ SiWEx0qQQeOcziQS6Ppa/gz9eOFM2nf97WrIOa65E8j8pyPT2cn5AbveoItZdFd3 tzUAMdkWqaMirXR3hizvnbNWBtAgLolCJCk3uVXPZd9QnDSIlM5G1OAb/tpFxva+ kNtLT6unFw7BQLnlreDSjwBoNWYr/aiYD7BmSMzz/XwQT/9o3l/uU9cRGVC1YCno HcIl0VhN0IyPpOQ1QQCTF29icrqTACfR7QDKX68KQtm5+xMp1/c60rcAKX01/nUS 83qoGlT2zbV4lZPbmvMPuZpc88MXJJvyp9nnturLv8xqLLJimrymv1fDYAHarzyp U+R892g7KjrFyQlDbjRhKJcS4sd4YX6wPhEq4XBimr+Fm3XBjKVk3PIzJnsyDtyA mrx2vh1SW47GwGlJTRKd3fx7OLclX1E1xaEshuFMSPpR3FRJCyYKgtFHhzN0xh33 cbJGjtZeqWBH41DubbCLh86uoFWcS6jj4g7YXPuYxsXuk6t0wLfqUzj6ARRH9HEd S/PCNPGC2AADL9vU+Q4wVFpEoySMbj5/Z1nsSQCGWWtZ9jRNUUZRbo+6KjK+0dzR xDKsn/Ciu2eAd+ii =I2+X -----END PGP SIGNATURE----- --=-=-=-- From unknown Sat Sep 20 12:38:58 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#50618] [PATCH v2] import: stackage: =?UTF-8?Q?Don=E2=80=99t?= try to update packages not available on Stackage. Resent-From: Xinglu Chen Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Wed, 22 Sep 2021 15:33:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 50618 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 50618@debbugs.gnu.org Cc: Lars-Dominik Braun Received: via spool by 50618-submit@debbugs.gnu.org id=B50618.163232473722059 (code B ref 50618); Wed, 22 Sep 2021 15:33:01 +0000 Received: (at 50618) by debbugs.gnu.org; 22 Sep 2021 15:32:17 +0000 Received: from localhost ([127.0.0.1]:51470 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mT4EL-0005jj-DZ for submit@debbugs.gnu.org; Wed, 22 Sep 2021 11:32:17 -0400 Received: from h87-96-130-155.cust.a3fiber.se ([87.96.130.155]:40110 helo=mail.yoctocell.xyz) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mT4EF-0005j7-2W for 50618@debbugs.gnu.org; Wed, 22 Sep 2021 11:32:16 -0400 From: Xinglu Chen DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=yoctocell.xyz; s=mail; t=1632324721; bh=HU5p31C05hPnjPmoFRFhDl/jqZFPgKfd2IrZAJRlic0=; h=From:To:Cc:Subject:In-Reply-To:References:Date; b=VzAvlhRRrbvUB1xzAkaLDsR8wS1hgSY/PN2xzQBc5NfcYBufvswlcw3TLnqpyyovX pYGNHXNhj5Jg2ZLs6YGrNjuaG6x50G5UHNkAuFBanGOorQMCbjD/vryTcSBkYxSnE8 5Y6Pj4HA3s71Zp7J/m+acPi8UAxVP8i2ljTt2gkk= In-Reply-To: <33ce44c6b5dc4f0c2ea2cf7a8402807d91e849a6.1631791821.git.public@yoctocell.xyz> References: <33ce44c6b5dc4f0c2ea2cf7a8402807d91e849a6.1631791821.git.public@yoctocell.xyz> Message-Id: <0aa369b60b785e933cab9de136cf9745dc4ea50a.1632324617.git.public@yoctocell.xyz> Date: Wed, 22 Sep 2021 17:31:49 +0200 MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 3.3 (+++) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: Previously, the =?UTF-8?Q?=E2=80=98hackage-package=3F=E2=80=99?= predicate was used which meant that the updater would try to update non-Stackage packages, and lead to messages like these: $ guix refresh -t stackage warning: failed to parse https://hackage.haskell.org/package/hurl/hurl.cabal warning: failed to parse https://hackage.haskell.org/package/idris/idris.cabal Content analysis details: (3.3 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 2.0 PDS_OTHER_BAD_TLD Untrustworthy TLDs [URI: yoctocell.xyz (xyz)] 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record 0.0 T_SPF_TEMPERROR SPF: test of record failed (temperror) 0.5 FROM_SUSPICIOUS_NTLD From abused NTLD 0.4 RDNS_DYNAMIC Delivered to internal network by host with dynamic-looking rDNS 0.0 PDS_RDNS_DYNAMIC_FP RDNS_DYNAMIC with FP steps 0.4 KHOP_HELO_FCRDNS Relay HELO differs from its IP's reverse DNS X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 1.9 (+) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: Previously, the =?UTF-8?Q?=E2=80=98hackage-package=3F=E2=80=99?= predicate was used which meant that the updater would try to update non-Stackage packages, and lead to messages like these: $ guix refresh -t stackage warning: failed to parse https://hackage.haskell.org/package/hurl/hurl.cabal warning: failed to parse https://hackage.haskell.org/package/idris/idris.cabal Content analysis details: (1.9 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 SPF_PASS SPF: sender matches SPF record 2.0 PDS_OTHER_BAD_TLD Untrustworthy TLDs [URI: yoctocell.xyz (xyz)] 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record 0.5 FROM_SUSPICIOUS_NTLD From abused NTLD 0.4 RDNS_DYNAMIC Delivered to internal network by host with dynamic-looking rDNS -1.0 MAILING_LIST_MULTI Multiple indicators imply a widely-seen list manager 0.0 PDS_RDNS_DYNAMIC_FP RDNS_DYNAMIC with FP steps Previously, the =E2=80=98hackage-package?=E2=80=99 predicate was used which= meant that the updater would try to update non-Stackage packages, and lead to messages like these: $ guix refresh -t stackage warning: failed to parse https://hackage.haskell.org/package/hurl/hurl.ca= bal warning: failed to parse https://hackage.haskell.org/package/idris/idris.= cabal Since =E2=80=98hurl=E2=80=99 and =E2=80=98idris=E2=80=99 aren=E2=80=99t ava= ilable on the current Stackage LTS release, they should be filtered out before the Stackage updater even tries to update them. * stackage.scm (stackage-package?): New procedure. (%stackage-updater): Use it. --- Changes since v1: * Use =E2=80=98stackage-lts-info-fetch=E2=80=99 to improve performance. guix/import/stackage.scm | 18 +++++++++++++++++- 1 file changed, 17 insertions(+), 1 deletion(-) diff --git a/guix/import/stackage.scm b/guix/import/stackage.scm index bbd903a2cd..9b757f1986 100644 --- a/guix/import/stackage.scm +++ b/guix/import/stackage.scm @@ -2,6 +2,7 @@ ;;; Copyright =C2=A9 2017 Federico Beffa ;;; Copyright =C2=A9 2018 Ricardo Wurmus ;;; Copyright =C2=A9 2020 Martin Becze +;;; Copyright =C2=A9 2021 Xinglu Chem ;;; ;;; This file is part of GNU Guix. ;;; @@ -21,10 +22,13 @@ (define-module (guix import stackage) #:use-module (ice-9 match) #:use-module (ice-9 regex) #:use-module (srfi srfi-1) #:use-module (srfi srfi-26) #:use-module (srfi srfi-34) #:use-module (srfi srfi-35) + #:use-module (srfi srfi-43) #:use-module (guix import json) #:use-module (guix import hackage) #:use-module (guix import utils) @@ -141,11 +145,23 @@ (define latest-lts-release (version version) (urls (list url)))))))))) =20 +(define (stackage-package? package) + "Whether PACKAGE is available on the default Stackage LTS release." + (and (hackage-package? package) + (let ((packages (lts-info-packages + (stackage-lts-info-fetch %default-lts-version))) + (hackage-name (guix-package->hackage-name package))) + (vector-any identity + (vector-map + (lambda (_ metadata) + (string=3D? (cdr (list-ref metadata 2)) hackage-na= me)) + packages))))) + (define %stackage-updater (upstream-updater (name 'stackage) (description "Updater for Stackage LTS packages") - (pred hackage-package?) + (pred stackage-package?) (latest latest-lts-release))) =20 ;;; stackage.scm ends here base-commit: 33bc3fb2a5f30a6e21f1b8d6d43867d921bd951c --=20 2.33.0 From unknown Sat Sep 20 12:38:58 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#50618] [PATCH v2] import: stackage: =?UTF-8?Q?Don=E2=80=99t?= try to update packages not available on Stackage. Resent-From: Lars-Dominik Braun Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Mon, 27 Sep 2021 09:19:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 50618 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Xinglu Chen Cc: 50618@debbugs.gnu.org Received: via spool by 50618-submit@debbugs.gnu.org id=B50618.163273432432182 (code B ref 50618); Mon, 27 Sep 2021 09:19:01 +0000 Received: (at 50618) by debbugs.gnu.org; 27 Sep 2021 09:18:44 +0000 Received: from localhost ([127.0.0.1]:39638 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mUmma-0008Mz-Cd for submit@debbugs.gnu.org; Mon, 27 Sep 2021 05:18:44 -0400 Received: from mout-p-202.mailbox.org ([80.241.56.172]:27546) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mUmmT-0008Md-S0 for 50618@debbugs.gnu.org; Mon, 27 Sep 2021 05:18:42 -0400 Received: from smtp202.mailbox.org (smtp202.mailbox.org [IPv6:2001:67c:2050:105:465:1:4:0]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-384) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mout-p-202.mailbox.org (Postfix) with ESMTPS id 4HHxrl5c7vzQkFV; Mon, 27 Sep 2021 11:18:31 +0200 (CEST) X-Virus-Scanned: amavisd-new at heinlein-support.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6xq.net; s=MBO0001; t=1632734310; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=dcxT6ox4XEibeH/agbudsc1rHhbqHkVwl/Iaj1oKncc=; b=Ve84B+vz+76xjtcZnwSvazUk8uWBRRKgGQrIG4ifIAjX16OTmwKITeK2sa17zt12LAvU2Y byvHqn7l6xWM4scPoP8kpeNSH9LDpZ3UNJybOw5durQGCRq7s4CfzeLIW5OeUIdIyuoHSy gp7mR/JvRePg+29OXni8Jdqyo4TI6UwqrcR5ZxvjWrLGfkNNjF3CR9eqsFW0i7x3d1GCLJ 6R2aqKAsMG1vtVRi3JoSDakKtFMqBGICP1AcOjaKokYnNj3VgjNX1yY3cJZGzqNu+F+g9J Hd7Z0sayJ9LK2iFmTe4imnLBpHNEmSk2g2Pmwk9auKswn1rgWtqlUxu+3Oj0EQ== Date: Mon, 27 Sep 2021 11:18:25 +0200 From: Lars-Dominik Braun Message-ID: References: <33ce44c6b5dc4f0c2ea2cf7a8402807d91e849a6.1631791821.git.public@yoctocell.xyz> <0aa369b60b785e933cab9de136cf9745dc4ea50a.1632324617.git.public@yoctocell.xyz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <0aa369b60b785e933cab9de136cf9745dc4ea50a.1632324617.git.public@yoctocell.xyz> X-Rspamd-Queue-Id: 078305BE X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Hi, for some reason I cannot get this patch to apply. `git am` fails and also `patch -Np1` spits out an error: patching file guix/import/stackage.scm patch: **** malformed patch at line 47: @@ -141,11 +145,23 @@ Can you push it somewhere? Thanks, Lars From unknown Sat Sep 20 12:38:58 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#50618] [PATCH v2] import: stackage: =?UTF-8?Q?Don=E2=80=99t?= try to update packages not available on Stackage. Resent-From: Xinglu Chen Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Mon, 27 Sep 2021 09:57:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 50618 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Lars-Dominik Braun Cc: 50618@debbugs.gnu.org Received: via spool by 50618-submit@debbugs.gnu.org id=B50618.16327365813301 (code B ref 50618); Mon, 27 Sep 2021 09:57:02 +0000 Received: (at 50618) by debbugs.gnu.org; 27 Sep 2021 09:56:21 +0000 Received: from localhost ([127.0.0.1]:39676 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mUnMw-0000r8-81 for submit@debbugs.gnu.org; Mon, 27 Sep 2021 05:56:21 -0400 Received: from h87-96-130-155.cust.a3fiber.se ([87.96.130.155]:45880 helo=mail.yoctocell.xyz) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mUnMt-0000qr-Is for 50618@debbugs.gnu.org; Mon, 27 Sep 2021 05:56:16 -0400 From: Xinglu Chen DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=yoctocell.xyz; s=mail; t=1632736563; bh=iz8zzMvei+yr4oVmWO6pvM5Ir9PHqGGHOk3tb6aUzIU=; h=From:To:Cc:Subject:In-Reply-To:References:Date; b=rGDBzqMNC97o2qsO9SFFqvnJ6KZeTsZOujaOVPTQKFIWz/Y+6OVvwtxpLP+WIeT6G bzucWto2TVejW2M3wj4ooElY4msKdCk3aBxSwvzTKAnTZw1OPqReN/RJS7i0l4mYyp ysT80Dd3vuuIhJcM6Fg72GAojBmD1Rupex47PvxY= In-Reply-To: References: <33ce44c6b5dc4f0c2ea2cf7a8402807d91e849a6.1631791821.git.public@yoctocell.xyz> <0aa369b60b785e933cab9de136cf9745dc4ea50a.1632324617.git.public@yoctocell.xyz> Date: Mon, 27 Sep 2021 11:56:02 +0200 Message-ID: <874ka67365.fsf@yoctocell.xyz> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="==-=-="; micalg=pgp-sha256; protocol="application/pgp-signature" X-Spam-Score: 2.9 (++) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: On Mon, Sep 27 2021, Lars-Dominik Braun wrote: > Hi, > > for some reason I cannot get this patch to apply. `git am` fails and also > `patch -Np1` spits out an error: > > patching file guix/import/stackage.scm > patch: **** malformed patch at line [...] Content analysis details: (2.9 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 SPF_PASS SPF: sender matches SPF record 2.0 PDS_OTHER_BAD_TLD Untrustworthy TLDs [URI: git.yoctocell.xyz (xyz)] 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record 0.5 FROM_SUSPICIOUS_NTLD From abused NTLD 0.4 RDNS_DYNAMIC Delivered to internal network by host with dynamic-looking rDNS 0.0 PDS_RDNS_DYNAMIC_FP RDNS_DYNAMIC with FP steps X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 2.9 (++) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: On Mon, Sep 27 2021, Lars-Dominik Braun wrote: > Hi, > > for some reason I cannot get this patch to apply. `git am` fails and also > `patch -Np1` spits out an error: > > patching file guix/import/stackage.scm > patch: **** malformed patch at line [...] Content analysis details: (2.9 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 SPF_PASS SPF: sender matches SPF record 2.0 PDS_OTHER_BAD_TLD Untrustworthy TLDs [URI: git.yoctocell.xyz (xyz)] 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record 0.5 FROM_SUSPICIOUS_NTLD From abused NTLD 0.4 RDNS_DYNAMIC Delivered to internal network by host with dynamic-looking rDNS 1.0 BULK_RE_SUSP_NTLD Precedence bulk and RE: from a suspicious TLD -1.0 MAILING_LIST_MULTI Multiple indicators imply a widely-seen list manager 0.0 PDS_RDNS_DYNAMIC_FP RDNS_DYNAMIC with FP steps --==-=-= Content-Type: multipart/mixed; boundary="=-=-=" --=-=-= Content-Type: text/plain On Mon, Sep 27 2021, Lars-Dominik Braun wrote: > Hi, > > for some reason I cannot get this patch to apply. `git am` fails and also > `patch -Np1` spits out an error: > > patching file guix/import/stackage.scm > patch: **** malformed patch at line 47: @@ -141,11 +145,23 @@ Hmm, it seems to fail for me as well, but with a different error. I have attached the patch below. > Can you push it somewhere? Sure, but I think its easier for you to just apply the attached patch. --=-=-= Content-Type: text/x-patch; charset=utf-8 Content-Disposition: attachment; filename=0001-import-stackage-Don-t-try-to-update-packages-not-ava.patch Content-Transfer-Encoding: quoted-printable From=2049f705217487aacfd6ab0b794b07eea9262d7661 Mon Sep 17 00:00:00 2001 Message-Id: <49f705217487aacfd6ab0b794b07eea9262d7661.1632736427.git.public= @yoctocell.xyz> From: Xinglu Chen Date: Thu, 16 Sep 2021 13:29:42 +0200 Subject: [PATCH] =3D?UTF-8?q?import:=3D20stackage:=3D20Don=3DE2=3D80=3D99t= =3D20try=3D20to?=3D =3D?UTF-8?q?=3D20update=3D20packages=3D20not=3D20available=3D20on=3D20Stac= kage.?=3D MIME-Version: 1.0 Content-Type: text/plain; charset=3DUTF-8 Content-Transfer-Encoding: 8bit Previously, the =E2=80=98hackage-package?=E2=80=99 predicate was used which= meant that the updater would try to update non-Stackage packages, and lead to messages like these: $ guix refresh -t stackage warning: failed to parse https://hackage.haskell.org/package/hurl/hurl.ca= bal warning: failed to parse https://hackage.haskell.org/package/idris/idris.= cabal Since =E2=80=98hurl=E2=80=99 and =E2=80=98idris=E2=80=99 aren=E2=80=99t ava= ilable on the current Stackage LTS release, they should be filtered out before the Stackage updater even tries to update them. * stackage.scm (stackage-package?): New procedure. (%stackage-updater): Use it. =2D-- guix/import/stackage.scm | 17 ++++++++++++++++- 1 file changed, 16 insertions(+), 1 deletion(-) diff --git a/guix/import/stackage.scm b/guix/import/stackage.scm index bbd903a2cd..731e69651e 100644 =2D-- a/guix/import/stackage.scm +++ b/guix/import/stackage.scm @@ -2,6 +2,7 @@ ;;; Copyright =C2=A9 2017 Federico Beffa ;;; Copyright =C2=A9 2018 Ricardo Wurmus ;;; Copyright =C2=A9 2020 Martin Becze +;;; Copyright =C2=A9 2021 Xinglu Chem ;;; ;;; This file is part of GNU Guix. ;;; @@ -21,10 +22,12 @@ (define-module (guix import stackage) #:use-module (ice-9 match) #:use-module (ice-9 regex) + #:use-module (ice-9 control) #:use-module (srfi srfi-1) #:use-module (srfi srfi-26) #:use-module (srfi srfi-34) #:use-module (srfi srfi-35) + #:use-module (srfi srfi-43) #:use-module (guix import json) #:use-module (guix import hackage) #:use-module (guix import utils) @@ -141,11 +144,23 @@ (define latest-lts-release (version version) (urls (list url)))))))))) =20 +(define (stackage-package? package) + "Whether PACKAGE is available on the default Stackage LTS release." + (and (hackage-package? package) + (let ((packages (lts-info-packages + (stackage-lts-info-fetch %default-lts-version))) + (hackage-name (guix-package->hackage-name package))) + (vector-any identity + (vector-map + (lambda (_ metadata) + (string=3D? (cdr (list-ref metadata 2)) hackage-na= me)) + packages))))) + (define %stackage-updater (upstream-updater (name 'stackage) (description "Updater for Stackage LTS packages") =2D (pred hackage-package?) + (pred stackage-package?) (latest latest-lts-release))) =20 ;;; stackage.scm ends here base-commit: 8c6c33a2a5bf385e1589b405ee7f842684ed80c1 =2D-=20 2.33.0 --=-=-=-- --==-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQJJBAEBCAAzFiEEAVhh4yyK5+SEykIzrPUJmaL7XHkFAmFRlTIVHHB1YmxpY0B5 b2N0b2NlbGwueHl6AAoJEKz1CZmi+1x5vi4P/1hOvAwhToZxNdRE9DM3KtwYMEzl iplJskNWEM2y5wXz4YUXqPOs77Bx7M1yOnQvrwCaZcJy/XPSd/2eopI0MhiBSRhU 2F9MYfEKAQgDu76AnOBwOq5yWEhDhfqL2oULAPff2aoYAkZEVNw4/IRmiZKcLi9e zFh/d88X7ME509/3OLEbAHkvGw11IPaiYA7WBzXGCr0ZsQ75kNvfRfdjy4ohGG2m u6HU25ZCF4LrG2xoG8RypcC3G1eVXMWuCyLebTGDIJ5Komxzyikw9LBsDk8p4v63 iHCd78OeV/rIe/VFFPcpHASJQUmO4q+fW68x4IPDHOHE7+dX/9/lLC9FpWEBJtJF egaTCZipm0Y2Hw06IfC21Q5tm8y6ImsN/4rK3flnPhIUSUvS7uIKhjNAgxdCEGgU yBD5AIQ/49WJnKanLjs4LiiGYI1GwNSSDEeB9fSFlYOSF5/TCN5yx+ZSiusyMJ4Y I6hPt5tdGWZXafjPNXjdEFc9VRpJV858xB01dhnscoU9yt7DgF++LwXbac1RBPGM UJodYZ4yHamdraDApQ83NnLjNEMOOECTwUFrSJrlX+HLGYVdB2Ydje9H7H4JgLWc z6C59bh228Zg/adpW4N2xirPLWjdk6kdSRDRfAkTmTprnqJnfM5HOCdIUA2CzLR/ Eao4hYzVCP23BWWj =Ax+7 -----END PGP SIGNATURE----- --==-=-=-- From unknown Sat Sep 20 12:38:58 2025 MIME-Version: 1.0 X-Mailer: MIME-tools 5.505 (Entity 5.505) X-Loop: help-debbugs@gnu.org From: help-debbugs@gnu.org (GNU bug Tracking System) To: Xinglu Chen Subject: bug#50618: closed (Re: [PATCH v2] import: stackage: =?UTF-8?Q?Don=E2=80=99t?= try to update packages not available on Stackage.) Message-ID: References: <33ce44c6b5dc4f0c2ea2cf7a8402807d91e849a6.1631791821.git.public@yoctocell.xyz> X-Gnu-PR-Message: they-closed 50618 X-Gnu-PR-Package: guix-patches X-Gnu-PR-Keywords: patch Reply-To: 50618@debbugs.gnu.org Date: Mon, 27 Sep 2021 12:00:02 +0000 Content-Type: multipart/mixed; boundary="----------=_1632744002-25831-1" This is a multi-part message in MIME format... ------------=_1632744002-25831-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Your bug report #50618: [PATCH] import: stackage: Don=E2=80=99t try to update packages not = available on Stackage. which was filed against the guix-patches package, has been closed. The explanation is attached below, along with your original report. If you require more details, please reply to 50618@debbugs.gnu.org. --=20 50618: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D50618 GNU Bug Tracking System Contact help-debbugs@gnu.org with problems ------------=_1632744002-25831-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at 50618-done) by debbugs.gnu.org; 27 Sep 2021 11:59:18 +0000 Received: from localhost ([127.0.0.1]:39919 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mUpHy-0006h7-C2 for submit@debbugs.gnu.org; Mon, 27 Sep 2021 07:59:18 -0400 Received: from mout-p-101.mailbox.org ([80.241.56.151]:38660) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mUpHv-0006gq-QQ for 50618-done@debbugs.gnu.org; Mon, 27 Sep 2021 07:59:16 -0400 Received: from smtp102.mailbox.org (smtp102.mailbox.org [80.241.60.233]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-384) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mout-p-101.mailbox.org (Postfix) with ESMTPS id 4HJ1Q51Wt3zQkBy; Mon, 27 Sep 2021 13:59:09 +0200 (CEST) X-Virus-Scanned: amavisd-new at heinlein-support.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6xq.net; s=MBO0001; t=1632743947; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=PQS1q/NfM2yZWlEkgPiAdeL/nUhfxd7irMXxJ9W84zk=; b=SNNVntWIEH9dl3LNfmxCpV2qhQ6gPK/4rPKNUcCGsc+PZDfrk8pabgBmhKP+AaurMYRUIT kQTqfC3RXk8RxSfW0QI18J7i6NJFYD7pKI+OGtqMHSJ89a2ycbbs9wcgC5JIigBa7E1Ta4 1aCN9UMoStqGVVK5cxZrpqEehFc2nQHfWsnEZ1HFqA37lRieZa2aQxnjZ4u0oMxaoH2Kst GArWcO7MlAGQNxEaNSYr83/Wnur79SpUnZC6z97nXKy0+wD1dSIwdsUukUQbkr1nuDkLeC 6fsEtWP2ok1GbdDd5d+TkoAMmF/ug1GWCQuuZNs9uoPb5VyEnFNASenjwq/Dig== Date: Mon, 27 Sep 2021 13:59:02 +0200 From: Lars-Dominik Braun To: Xinglu Chen Subject: Re: [PATCH v2] import: =?utf-8?Q?stackage?= =?utf-8?B?OiBEb27igJl0?= try to update packages not available on Stackage. Message-ID: References: <33ce44c6b5dc4f0c2ea2cf7a8402807d91e849a6.1631791821.git.public@yoctocell.xyz> <0aa369b60b785e933cab9de136cf9745dc4ea50a.1632324617.git.public@yoctocell.xyz> <874ka67365.fsf@yoctocell.xyz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <874ka67365.fsf@yoctocell.xyz> X-Rspamd-Queue-Id: E247726C X-Spam-Score: 1.3 (+) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: Hi, > Sure, but I think its easier for you to just apply the attached patch. > > > applied as 9c5e5ca1c0de56a0d5b2b924de10548172095b58. Content analysis details: (1.3 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.7 RCVD_IN_DNSWL_LOW RBL: Sender listed at https://www.dnswl.org/, low trust [80.241.56.151 listed in list.dnswl.org] -0.0 SPF_PASS SPF: sender matches SPF record -0.0 RCVD_IN_MSPIKE_H2 RBL: Average reputation (+2) [80.241.56.151 listed in wl.mailspike.net] 2.0 PDS_OTHER_BAD_TLD Untrustworthy TLDs [URI: git.yoctocell.xyz (xyz)] 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record X-Debbugs-Envelope-To: 50618-done Cc: 50618-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.3 (/) Hi, > Sure, but I think its easier for you to just apply the attached patch. > > > applied as 9c5e5ca1c0de56a0d5b2b924de10548172095b58. Thank you very much! Lars ------------=_1632744002-25831-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at submit) by debbugs.gnu.org; 16 Sep 2021 11:32:12 +0000 Received: from localhost ([127.0.0.1]:53963 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mQpce-0006Qw-Mc for submit@debbugs.gnu.org; Thu, 16 Sep 2021 07:32:12 -0400 Received: from lists.gnu.org ([209.51.188.17]:46416) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mQpcZ-0006N9-Ho for submit@debbugs.gnu.org; Thu, 16 Sep 2021 07:32:07 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:59918) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mQpcX-00047I-J3 for guix-patches@gnu.org; Thu, 16 Sep 2021 07:32:02 -0400 Received: from h87-96-130-155.cust.a3fiber.se ([87.96.130.155]:52154 helo=mail.yoctocell.xyz) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mQpcV-0008W0-BI for guix-patches@gnu.org; Thu, 16 Sep 2021 07:32:01 -0400 From: Xinglu Chen DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=yoctocell.xyz; s=mail; t=1631791912; bh=I/fOYEdAifK9DRIuRhK6snfgMiIkVYXpuiXV2c34NB0=; h=From:To:Subject:Date; b=Gz4Tp0sDnSmuoWeQwwxViw0IPAdbf/F9+i3JY14Es1pddWWMIl2DsUCzE4oXv2bMI ijnCJbILHI/8/0yB8CDs5zH4KFqFn8MxK9/VwZ37GfSYlme8h90WtAsRjeFD/TYbpL Vil1rIWC2gaxOf1AVOZKGf6E7KAyMSAAlWuDh3wA= To: guix-patches@gnu.org Subject: [PATCH] =?UTF-8?q?import:=20stackage:=20Don=E2=80=99t=20try=20to?= =?UTF-8?q?=20update=20packages=20not=20available=20on=20Stackage.?= X-Debbugs-CC: Lars-Dominik Braun Message-Id: <33ce44c6b5dc4f0c2ea2cf7a8402807d91e849a6.1631791821.git.public@yoctocell.xyz> Date: Thu, 16 Sep 2021 13:31:51 +0200 MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Received-SPF: pass client-ip=87.96.130.155; envelope-from=public@yoctocell.xyz; helo=mail.yoctocell.xyz X-Spam_score_int: 34 X-Spam_score: 3.4 X-Spam_bar: +++ X-Spam_report: (3.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FROM_SUSPICIOUS_NTLD=0.5, FROM_SUSPICIOUS_NTLD_FP=1.999, PDS_OTHER_BAD_TLD=1.999, RDNS_DYNAMIC=0.982, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-Spam-Score: 0.8 (/) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.2 (/) Previously, the =E2=80=98hackage-package?=E2=80=99 predicate was used which= meant that the updater would try to update non-Stackage packages, and lead to messages like these: $ guix refresh -t stackage warning: failed to parse https://hackage.haskell.org/package/hurl/hurl.ca= bal warning: failed to parse https://hackage.haskell.org/package/idris/idris.= cabal Since =E2=80=98hurl=E2=80=99 and =E2=80=98idris=E2=80=99 aren=E2=80=99t ava= ilable on the current Stackage LTS release, they should be filtered out before the Stackage updater even tries to update them. * stackage.scm (stackage-package?): New procedure. (%stackage-updater): Use it. --- guix/import/stackage.scm | 15 ++++++++++++++- 1 file changed, 14 insertions(+), 1 deletion(-) diff --git a/guix/import/stackage.scm b/guix/import/stackage.scm index bbd903a2cd..5b19e2a03a 100644 --- a/guix/import/stackage.scm +++ b/guix/import/stackage.scm @@ -2,6 +2,7 @@ ;;; Copyright =C2=A9 2017 Federico Beffa ;;; Copyright =C2=A9 2018 Ricardo Wurmus ;;; Copyright =C2=A9 2020 Martin Becze +;;; Copyright =C2=A9 2021 Xinglu Chem ;;; ;;; This file is part of GNU Guix. ;;; @@ -25,6 +26,7 @@ #:use-module (srfi srfi-26) #:use-module (srfi srfi-34) #:use-module (srfi srfi-35) + #:use-module (guix http-client) #:use-module (guix import json) #:use-module (guix import hackage) #:use-module (guix import utils) @@ -141,11 +143,22 @@ PACKAGE or #f if the package is not included in the S= tackage LTS release." (version version) (urls (list url)))))))))) =20 +(define (stackage-package? package) + "Whether PACKAGE is available on the default Stackage LTS release." + (and (hackage-package? package) + (guard (c ((and (http-get-error? c) + (=3D 404 (http-get-error-code c))) + #f)) + (let* ((name (guix-package->hackage-name package)) + (url (string-append (%stackage-url) "/lts-" + %default-lts-version "/package/" name)= )) + (http-fetch url))))) + (define %stackage-updater (upstream-updater (name 'stackage) (description "Updater for Stackage LTS packages") - (pred hackage-package?) + (pred stackage-package?) (latest latest-lts-release))) =20 ;;; stackage.scm ends here base-commit: a840caccaee8c9492f4cc8a7ba802ef54391f199 --=20 2.33.0 ------------=_1632744002-25831-1--