GNU bug report logs - #50588
[PATCH] import: cabal: Treat identifier names correctly.

Previous Next

Package: guix-patches;

Reported by: Xinglu Chen <public <at> yoctocell.xyz>

Date: Tue, 14 Sep 2021 18:43:02 UTC

Severity: normal

Tags: patch

Done: Lars-Dominik Braun <lars <at> 6xq.net>

Bug is archived. No further changes may be made.

Full log

Message #13 received at 50588 <at> debbugs.gnu.org (full text, mbox):

From: zimoun <zimon.toutoune <at> gmail.com>
To: Xinglu Chen <public <at> yoctocell.xyz>
Cc: 50588 <at> debbugs.gnu.org
Subject: Re: [bug#50588] [PATCH] import: cabal: Treat identifier names
 correctly.
Date: Wed, 15 Sep 2021 09:55:57 +0200

Hi,

On Tue, 14 Sept 2021 at 20:43, Xinglu Chen <public <at> yoctocell.xyz> wrote:

> * guix/import/cabal.scm (is-id): Accept the location as an argument.  Don’t
> check if the identifier name is a reserved keyword unless it is the first word
> on the line.
> (lex-word): Adjust accordingly.
> * tests/hackage ("hackage->guix-package tests flag executable"): Expect it to
> pass.
>
> Fixes: <https://issues.guix.gnu.org/25138>

Oh awesome!  Thanks!  Yesterday, I was reviewing old bugs and dig the
cabal parser was too intimidating. :-)

Cheers,
simon
This bug report was last modified 3 years and 244 days ago.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.