GNU bug report logs - #50565
[PATCH] services: tlp: added start-charge-thresh-bat0 & co. to the config

Previous Next

Full log

Message #8 received at 50565 <at> debbugs.gnu.org (full text, mbox):

From: Mathieu Othacehe <othacehe <at> gnu.org>
To: Attila Lendvai <attila <at> lendvai.name>
Cc: 50565 <at> debbugs.gnu.org
Subject: Re: bug#50565: [PATCH] services: tlp: added
 start-charge-thresh-bat0 & co. to the config
Date: Tue, 21 Sep 2021 14:02:30 +0000

Hello,

> +  (start-charge-thresh-bat0
> +   (maybe-non-negative-integer 'disabled)
> +   "Percentage when battery 0 should begin charging.")
> +
> +  (stop-charge-thresh-bat0
> +   (maybe-non-negative-integer 'disabled)
> +   "Percentage when battery 0 should stop charging.")
> +
> +  (start-charge-thresh-bat1
> +   (maybe-non-negative-integer 'disabled)
> +   "Percentage when battery 1 should begin charging.")
> +
> +  (stop-charge-thresh-bat1
> +   (maybe-non-negative-integer 'disabled)
> +   "Percentage when battery 1 should stop charging.")

It would be nice if you could document those new fields in the "TLP
daemon" section of the doc/guix.texi file.

Note that the commit message should also respect the conventions
specified here:
https://guix.gnu.org/manual/en/html_node/Submitting-Patches.html.

Could you send an updated version :)?

Thanks,

Mathieu

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.