From unknown Mon Jun 23 07:52:54 2025 X-Loop: owner@emacsbugs.donarmstrong.com Subject: bug#5056: Minor fix for a defcustom in savehist mode (patch included) Reply-To: "Ryan C. Thompson" , 5056@debbugs.gnu.org Resent-From: "Ryan C. Thompson" Resent-To: bug-submit-list@lists.donarmstrong.com Resent-CC: Emacs Bugs 2Resent-Date: Fri, 27 Nov 2009 06:45:04 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-Emacs-PR-Message: report 5056 X-Emacs-PR-Package: emacs X-Emacs-PR-Keywords: Received: via spool by submit@emacsbugs.donarmstrong.com id=B.125930395619190 (code B ref -1); Fri, 27 Nov 2009 06:45:04 +0000 Received: (at submit) by emacsbugs.donarmstrong.com; 27 Nov 2009 06:39:16 +0000 X-Spam-Checker-Version: SpamAssassin 3.2.5-bugs.debian.org_2005_01_02 (2008-06-10) on rzlab.ucr.edu X-Spam-Level: * X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. X-Spam-Status: No, score=1.1 required=4.0 tests=FOURLA,MIXEDBDN, MURPHY_DRUGS_REL8 autolearn=no version=3.2.5-bugs.debian.org_2005_01_02 Received: from lists.gnu.org (lists.gnu.org [199.232.76.165]) by rzlab.ucr.edu (8.14.3/8.14.3/Debian-5) with ESMTP id nAR6dFtj019187 for ; Thu, 26 Nov 2009 22:39:16 -0800 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1NDuU6-0007HM-Ku for bug-gnu-emacs@gnu.org; Fri, 27 Nov 2009 01:39:14 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1NDuU0-0007E5-Cz for bug-gnu-emacs@gnu.org; Fri, 27 Nov 2009 01:39:13 -0500 Received: from [199.232.76.173] (port=59770 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NDuU0-0007Dj-1L for bug-gnu-emacs@gnu.org; Fri, 27 Nov 2009 01:39:08 -0500 Received: from mail-pw0-f47.google.com ([209.85.160.47]:35588) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1NDuTz-0008VV-IQ for bug-gnu-emacs@gnu.org; Fri, 27 Nov 2009 01:39:07 -0500 Received: by pwi9 with SMTP id 9so949381pwi.26 for ; Thu, 26 Nov 2009 22:39:02 -0800 (PST) Received: by 10.114.237.24 with SMTP id k24mr1352245wah.5.1259303942142; Thu, 26 Nov 2009 22:39:02 -0800 (PST) Received: from ?192.168.1.100? (user-0c9h9j8.cable.mindspring.com [24.152.166.104]) by mx.google.com with ESMTPS id 22sm979475pzk.14.2009.11.26.22.39.01 (version=TLSv1/SSLv3 cipher=RC4-MD5); Thu, 26 Nov 2009 22:39:01 -0800 (PST) Message-ID: <4B0F7404.2080106@thompsonclan.org> Date: Thu, 26 Nov 2009 22:39:00 -0800 From: "Ryan C. Thompson" User-Agent: Thunderbird 2.0.0.23 (X11/20090817) MIME-Version: 1.0 To: bug-gnu-emacs@gnu.org Content-Type: multipart/mixed; boundary="------------010704090205080107080301" X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 2) This is a multi-part message in MIME format. --------------010704090205080107080301 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit While customizing savehist mode through the emacs Custom interface, I discovered that I could not set `savehist-autosave-interval' to nil because the custom buffer only had an integer entry field for that variable, although the docstring said that nil was a valid value. So I edited the custom definition to allow choosing either nil or an integer, instead of just an integer. I also added labels to the two choices to make things clearer for the user. Here is the one-line diff (assuming that it doesn't get too badly mangled in transit): BEGIN DIFF *** old/savehist.el 2009-11-26 21:47:52.378311830 -0800 --- new/savehist.el 2009-11-26 21:19:12.118518476 -0800 *************** *** 120,126 **** (defcustom savehist-autosave-interval (* 5 60) "The interval between autosaves of minibuffer history. If set to nil, disables timer-based autosaving." ! :type 'integer :group 'savehist) (defcustom savehist-mode-hook nil --- 120,127 ---- (defcustom savehist-autosave-interval (* 5 60) "The interval between autosaves of minibuffer history. If set to nil, disables timer-based autosaving." ! :type '(choice (const :tag "Disabled" nil) ! (integer :tag "Seconds" 300)) :group 'savehist) (defcustom savehist-mode-hook nil END DIFF Here is my attempt at manually writing a changelog entry: BEGIN CHANGELOG 2009-11-62 Ryan C. Thompson * savehist.el: Allow setting `savehist-autosave-interval' to nil in Custom. END CHANGELOG If it matters, you have my blessing to license this code however you please. - Ryan Thompson --------------010704090205080107080301 Content-Type: message/rfc822; name="Re: minor bugfix for savehist mode.eml" Content-Transfer-Encoding: 7bit Content-Disposition: inline; filename="Re: minor bugfix for savehist mode.eml" Delivered-To: rct@thompsonclan.org Received: by 10.223.107.1 with SMTP id z1cs24249fao; Mon, 31 Aug 2009 04:37:39 -0700 (PDT) Received: by 10.204.36.210 with SMTP id u18mr4281052bkd.19.1251718658921; Mon, 31 Aug 2009 04:37:38 -0700 (PDT) Return-Path: Received: from jimbo.globalnet.hr (jimbo.bnet.hr [213.149.32.23]) by mx.google.com with ESMTP id 25si5094087bwz.82.2009.08.31.04.37.38; Mon, 31 Aug 2009 04:37:38 -0700 (PDT) Received-SPF: neutral (google.com: 213.149.32.23 is neither permitted nor denied by best guess record for domain of hniksic@xemacs.org) client-ip=213.149.32.23; Authentication-Results: mx.google.com; spf=neutral (google.com: 213.149.32.23 is neither permitted nor denied by best guess record for domain of hniksic@xemacs.org) smtp.mail=hniksic@xemacs.org Received: from mail.globalnet.hr (cartman.globalnet.hr [213.149.32.10]) by jimbo.globalnet.hr (Postfix) with ESMTP id 693AB2D52AF for ; Mon, 31 Aug 2009 13:37:33 +0200 (CEST) Received: (qmail 15175 invoked from network); 31 Aug 2009 11:37:33 -0000 X-Mail-Scanner: Scanned by qSheff-II-2.1-r2 (http://www.enderunix.org/qsheff/) Received: from cpezg-94-253-142-222-cbl.xnet.hr (HELO mulj) ([94.253.142.222]) (envelope-sender ) by 0 (qmail-ldap-1.03) with SMTP for ; 31 Aug 2009 11:37:33 -0000 Received: from hniksic by mulj with local (Exim 4.69) (envelope-from ) id 1Mi5CN-00056D-Lo for rct@thompsonclan.org; Mon, 31 Aug 2009 13:37:23 +0200 From: Hrvoje Niksic To: "Ryan C. Thompson" Subject: Re: minor bugfix for savehist mode References: <4A9AE586.8060201@thompsonclan.org> Date: Mon, 31 Aug 2009 13:37:23 +0200 In-Reply-To: <4A9AE586.8060201@thompsonclan.org> (Ryan C. Thompson's message of "Sun, 30 Aug 2009 13:48:06 -0700") Message-ID: <87pracgqoc.fsf@busola.homelinux.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.0.91 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii "Ryan C. Thompson" writes: > I would like to submit a minor improvement for savehist mode. I > noticed that the variable savehist-autosave-interval could be either > an integer or nil, but its definition allowed it to be customized only > as an integer. I changed the definition to allow it to also be set to > nil in Custom. Please post your bugfix to Emacs maintainers so it gets incorporated into the next release. I no longer actively maintain savehist-mode. Thank you. --------------010704090205080107080301-- From unknown Mon Jun 23 07:52:54 2025 MIME-Version: 1.0 X-Mailer: MIME-tools 5.427 (Entity 5.427) X-Loop: owner@emacsbugs.donarmstrong.com From: help-debbugs@gnu.org (Emacs bug Tracking System) To: "Ryan C. Thompson" Subject: bug#5056 closed by Juanma Barranquero (Re: bug#5056: Minor fix for a defcustom in savehist mode (patch included)) Message-ID: References: <4B0F7404.2080106@thompsonclan.org> X-Emacs-PR-Message: they-closed 5056 X-Emacs-PR-Package: emacs Reply-To: 5056@debbugs.gnu.org Date: Mon, 30 Nov 2009 23:45:04 +0000 Content-Type: multipart/mixed; boundary="----------=_1259624704-7770-1" This is a multi-part message in MIME format... ------------=_1259624704-7770-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" This is an automatic notification regarding your bug report which was filed against the emacs package: #5056: Minor fix for a defcustom in savehist mode (patch included) It has been closed by Juanma Barranquero . Their explanation is attached below along with your original report. If this explanation is unsatisfactory and you have not received a better one in a separate message then please contact Juanma Barranquero by replying to this email. --=20 5056: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D5056 Emacs Bug Tracking System Contact help-debbugs@gnu.org with problems ------------=_1259624704-7770-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at 5056-done) by emacsbugs.donarmstrong.com; 30 Nov 2009 23:40:15 +0000 X-Spam-Checker-Version: SpamAssassin 3.2.5-bugs.debian.org_2005_01_02 (2008-06-10) on rzlab.ucr.edu X-Spam-Level: X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. X-Spam-Status: No, score=-2.4 required=4.0 tests=AWL,HAS_BUG_NUMBER, MURPHY_DRUGS_REL8 autolearn=ham version=3.2.5-bugs.debian.org_2005_01_02 Received: from mail-fx0-f215.google.com (mail-fx0-f215.google.com [209.85.220.215]) by rzlab.ucr.edu (8.14.3/8.14.3/Debian-5) with ESMTP id nAUNeClY007395 for <5056-done@emacsbugs.donarmstrong.com>; Mon, 30 Nov 2009 15:40:14 -0800 Received: by fxm7 with SMTP id 7so4569673fxm.9 for <5056-done@emacsbugs.donarmstrong.com>; Mon, 30 Nov 2009 15:40:07 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:received:in-reply-to:references :from:date:message-id:subject:to:cc:content-type; bh=pb6u0hUGIxNNNWp/uZKcSa/0jZRTu4899e+XNe58b8g=; b=shZvRpDsPWTi6ZIgADDNv9C1Kaf8IaxxZemi3WkwyX+8XQwGLTUH+ikevXAkwXGnzJ 2W+Xxs6kk4j8peE4WWkomND2REmL5BGUPXTImNNLVEIa5/67D6DWMR7bByWd6g0GYal9 OBVtD9hUe7968fAM37HVKOGU/VYpJCj62snws= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc:content-type; b=lgraT3LS4y4vcQWFckH7MVGTKmD93n4BvXP2b+OJ/PF2XLAqK+Pb0smTyNyGQLZUAC TzJ1mEH6XAiTLSrXnmQv3bj48GlkXYCO1qOlMVmfF1zYeDTmjQt0jPx9171bMec7psYU O8uocH1jgHBId6Qq1jYJND+Im115uQbbGjp08= MIME-Version: 1.0 Received: by 10.239.130.29 with SMTP id 29mr460974hbh.135.1259624407086; Mon, 30 Nov 2009 15:40:07 -0800 (PST) In-Reply-To: <4B0F7404.2080106@thompsonclan.org> References: <4B0F7404.2080106@thompsonclan.org> From: Juanma Barranquero Date: Tue, 1 Dec 2009 00:39:47 +0100 Message-ID: Subject: Re: bug#5056: Minor fix for a defcustom in savehist mode (patch included) To: "Ryan C. Thompson" Cc: 5056-done@debbugs.gnu.org Content-Type: text/plain; charset=UTF-8 On Fri, Nov 27, 2009 at 07:39, Ryan C. Thompson wrote: > make things clearer for the user. Here is the one-line diff (assuming > that it doesn't get too badly mangled in transit): Applied, thanks. Juanma ------------=_1259624704-7770-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at submit) by emacsbugs.donarmstrong.com; 27 Nov 2009 06:39:16 +0000 X-Spam-Checker-Version: SpamAssassin 3.2.5-bugs.debian.org_2005_01_02 (2008-06-10) on rzlab.ucr.edu X-Spam-Level: * X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. X-Spam-Status: No, score=1.1 required=4.0 tests=FOURLA,MIXEDBDN, MURPHY_DRUGS_REL8 autolearn=no version=3.2.5-bugs.debian.org_2005_01_02 Received: from lists.gnu.org (lists.gnu.org [199.232.76.165]) by rzlab.ucr.edu (8.14.3/8.14.3/Debian-5) with ESMTP id nAR6dFtj019187 for ; Thu, 26 Nov 2009 22:39:16 -0800 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1NDuU6-0007HM-Ku for bug-gnu-emacs@gnu.org; Fri, 27 Nov 2009 01:39:14 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1NDuU0-0007E5-Cz for bug-gnu-emacs@gnu.org; Fri, 27 Nov 2009 01:39:13 -0500 Received: from [199.232.76.173] (port=59770 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NDuU0-0007Dj-1L for bug-gnu-emacs@gnu.org; Fri, 27 Nov 2009 01:39:08 -0500 Received: from mail-pw0-f47.google.com ([209.85.160.47]:35588) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1NDuTz-0008VV-IQ for bug-gnu-emacs@gnu.org; Fri, 27 Nov 2009 01:39:07 -0500 Received: by pwi9 with SMTP id 9so949381pwi.26 for ; Thu, 26 Nov 2009 22:39:02 -0800 (PST) Received: by 10.114.237.24 with SMTP id k24mr1352245wah.5.1259303942142; Thu, 26 Nov 2009 22:39:02 -0800 (PST) Received: from ?192.168.1.100? (user-0c9h9j8.cable.mindspring.com [24.152.166.104]) by mx.google.com with ESMTPS id 22sm979475pzk.14.2009.11.26.22.39.01 (version=TLSv1/SSLv3 cipher=RC4-MD5); Thu, 26 Nov 2009 22:39:01 -0800 (PST) Message-ID: <4B0F7404.2080106@thompsonclan.org> Date: Thu, 26 Nov 2009 22:39:00 -0800 From: "Ryan C. Thompson" User-Agent: Thunderbird 2.0.0.23 (X11/20090817) MIME-Version: 1.0 To: bug-gnu-emacs@gnu.org Subject: Minor fix for a defcustom in savehist mode (patch included) Content-Type: multipart/mixed; boundary="------------010704090205080107080301" X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 2) This is a multi-part message in MIME format. --------------010704090205080107080301 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit While customizing savehist mode through the emacs Custom interface, I discovered that I could not set `savehist-autosave-interval' to nil because the custom buffer only had an integer entry field for that variable, although the docstring said that nil was a valid value. So I edited the custom definition to allow choosing either nil or an integer, instead of just an integer. I also added labels to the two choices to make things clearer for the user. Here is the one-line diff (assuming that it doesn't get too badly mangled in transit): BEGIN DIFF *** old/savehist.el 2009-11-26 21:47:52.378311830 -0800 --- new/savehist.el 2009-11-26 21:19:12.118518476 -0800 *************** *** 120,126 **** (defcustom savehist-autosave-interval (* 5 60) "The interval between autosaves of minibuffer history. If set to nil, disables timer-based autosaving." ! :type 'integer :group 'savehist) (defcustom savehist-mode-hook nil --- 120,127 ---- (defcustom savehist-autosave-interval (* 5 60) "The interval between autosaves of minibuffer history. If set to nil, disables timer-based autosaving." ! :type '(choice (const :tag "Disabled" nil) ! (integer :tag "Seconds" 300)) :group 'savehist) (defcustom savehist-mode-hook nil END DIFF Here is my attempt at manually writing a changelog entry: BEGIN CHANGELOG 2009-11-62 Ryan C. Thompson * savehist.el: Allow setting `savehist-autosave-interval' to nil in Custom. END CHANGELOG If it matters, you have my blessing to license this code however you please. - Ryan Thompson --------------010704090205080107080301 Content-Type: message/rfc822; name="Re: minor bugfix for savehist mode.eml" Content-Transfer-Encoding: 7bit Content-Disposition: inline; filename="Re: minor bugfix for savehist mode.eml" Delivered-To: rct@thompsonclan.org Received: by 10.223.107.1 with SMTP id z1cs24249fao; Mon, 31 Aug 2009 04:37:39 -0700 (PDT) Received: by 10.204.36.210 with SMTP id u18mr4281052bkd.19.1251718658921; Mon, 31 Aug 2009 04:37:38 -0700 (PDT) Return-Path: Received: from jimbo.globalnet.hr (jimbo.bnet.hr [213.149.32.23]) by mx.google.com with ESMTP id 25si5094087bwz.82.2009.08.31.04.37.38; Mon, 31 Aug 2009 04:37:38 -0700 (PDT) Received-SPF: neutral (google.com: 213.149.32.23 is neither permitted nor denied by best guess record for domain of hniksic@xemacs.org) client-ip=213.149.32.23; Authentication-Results: mx.google.com; spf=neutral (google.com: 213.149.32.23 is neither permitted nor denied by best guess record for domain of hniksic@xemacs.org) smtp.mail=hniksic@xemacs.org Received: from mail.globalnet.hr (cartman.globalnet.hr [213.149.32.10]) by jimbo.globalnet.hr (Postfix) with ESMTP id 693AB2D52AF for ; Mon, 31 Aug 2009 13:37:33 +0200 (CEST) Received: (qmail 15175 invoked from network); 31 Aug 2009 11:37:33 -0000 X-Mail-Scanner: Scanned by qSheff-II-2.1-r2 (http://www.enderunix.org/qsheff/) Received: from cpezg-94-253-142-222-cbl.xnet.hr (HELO mulj) ([94.253.142.222]) (envelope-sender ) by 0 (qmail-ldap-1.03) with SMTP for ; 31 Aug 2009 11:37:33 -0000 Received: from hniksic by mulj with local (Exim 4.69) (envelope-from ) id 1Mi5CN-00056D-Lo for rct@thompsonclan.org; Mon, 31 Aug 2009 13:37:23 +0200 From: Hrvoje Niksic To: "Ryan C. Thompson" Subject: Re: minor bugfix for savehist mode References: <4A9AE586.8060201@thompsonclan.org> Date: Mon, 31 Aug 2009 13:37:23 +0200 In-Reply-To: <4A9AE586.8060201@thompsonclan.org> (Ryan C. Thompson's message of "Sun, 30 Aug 2009 13:48:06 -0700") Message-ID: <87pracgqoc.fsf@busola.homelinux.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.0.91 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii "Ryan C. Thompson" writes: > I would like to submit a minor improvement for savehist mode. I > noticed that the variable savehist-autosave-interval could be either > an integer or nil, but its definition allowed it to be customized only > as an integer. I changed the definition to allow it to also be set to > nil in Custom. Please post your bugfix to Emacs maintainers so it gets incorporated into the next release. I no longer actively maintain savehist-mode. Thank you. --------------010704090205080107080301-- ------------=_1259624704-7770-1--