GNU bug report logs - #5056
Minor fix for a defcustom in savehist mode (patch included)

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 5056 in the body.
You can then email your comments to 5056 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> emacsbugs.donarmstrong.com (full text, mbox):

From: "Ryan C. Thompson" <rct <at> thompsonclan.org>
To: bug-gnu-emacs <at> gnu.org
Subject: Minor fix for a defcustom in savehist mode (patch included)
Date: Thu, 26 Nov 2009 22:39:00 -0800

[Message part 1 (text/plain, inline)]

While customizing savehist mode through the emacs Custom interface, I
discovered that I could not set `savehist-autosave-interval' to nil
because the custom buffer only had an integer entry field for that
variable, although the docstring said that nil was a valid value. So I
edited the custom definition to allow choosing either nil or an integer,
instead of just an integer. I also added labels to the two choices to
make things clearer for the user. Here is the one-line diff (assuming
that it doesn't get too badly mangled in transit):

BEGIN DIFF
*** old/savehist.el    2009-11-26 21:47:52.378311830 -0800
--- new/savehist.el    2009-11-26 21:19:12.118518476 -0800
***************
*** 120,126 ****
 (defcustom savehist-autosave-interval (* 5 60)
   "The interval between autosaves of minibuffer history.
 If set to nil, disables timer-based autosaving."
!   :type 'integer
   :group 'savehist)

 (defcustom savehist-mode-hook nil
--- 120,127 ----
 (defcustom savehist-autosave-interval (* 5 60)
   "The interval between autosaves of minibuffer history.
 If set to nil, disables timer-based autosaving."
!   :type '(choice (const :tag "Disabled" nil)
!                  (integer :tag "Seconds" 300))
   :group 'savehist)

 (defcustom savehist-mode-hook nil
END DIFF

Here is my attempt at manually writing a changelog entry:

BEGIN CHANGELOG
    2009-11-62  Ryan C. Thompson  <rct <at> thompsonclan.org>

            * savehist.el: Allow setting `savehist-autosave-interval'
              to nil in Custom.
END CHANGELOG

If it matters, you have my blessing to license this code however you please.

- Ryan Thompson

[Re: minor bugfix for savehist mode.eml (message/rfc822, inline)]

From: Hrvoje Niksic <hniksic <at> xemacs.org>
To: "Ryan C. Thompson" <rct <at> thompsonclan.org>
Subject: Re: minor bugfix for savehist mode
Date: Mon, 31 Aug 2009 13:37:23 +0200

"Ryan C. Thompson" <rct <at> thompsonclan.org> writes:

> I would like to submit a minor improvement for savehist mode. I
> noticed that the variable savehist-autosave-interval could be either
> an integer or nil, but its definition allowed it to be customized only
> as an integer. I changed the definition to allow it to also be set to
> nil in Custom.

Please post your bugfix to Emacs maintainers so it gets incorporated
into the next release.  I no longer actively maintain savehist-mode.

Thank you.

Message #10 received at 5056-done <at> emacsbugs.donarmstrong.com (full text, mbox):

From: Juanma Barranquero <lekktu <at> gmail.com>
To: "Ryan C. Thompson" <rct <at> thompsonclan.org>
Cc: 5056-done <at> debbugs.gnu.org
Subject: Re: bug#5056: Minor fix for a defcustom in savehist mode (patch 
	included)
Date: Tue, 1 Dec 2009 00:39:47 +0100

On Fri, Nov 27, 2009 at 07:39, Ryan C. Thompson <rct <at> thompsonclan.org> wrote:

> make things clearer for the user. Here is the one-line diff (assuming
> that it doesn't get too badly mangled in transit):

Applied, thanks.

    Juanma

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.