Subject: Re: bug#50509: 28.0.50; [PATCH] elisp-mode-tests regression

From: Dmitry Gutov <[email-masked]>
Date: Fri, 10 Sep 2021 18:12:24 +0300

Hi!

Do you mean to say that 'make check' fails for you, locally or on the CI?

On 10.09.2021 16:36, [email-masked] wrote:
>  From c8f9869ba7e022d1952c75fc5076bd26e0843072 Mon Sep 17 00:00:00 2001
> From: dickmao <none>
> Date: Fri, 10 Sep 2021 09:31:28 -0400
> Subject: [PATCH] A so-called "CICD" integrated into a PR-based submission
>   flow...
> 
> ... would have caught this.  Just saying.
> 
> * test/lisp/progmodes/elisp-mode-tests.el (find-defs-defgeneric-el):
> ---
>   test/lisp/progmodes/elisp-mode-tests.el | 6 ++++++
>   1 file changed, 6 insertions(+)
> 
> diff --git a/test/lisp/progmodes/elisp-mode-tests.el b/test/lisp/progmodes/elisp-mode-tests.el
> index f47d54e59c..2745aff670 100644
> --- a/test/lisp/progmodes/elisp-mode-tests.el
> +++ b/test/lisp/progmodes/elisp-mode-tests.el
> @@ -604,6 +604,12 @@ find-defs-defgeneric-el
>                   'xref-location-marker nil '(xref-etags-location))
>                  'cl-defmethod
>                  (expand-file-name "../../../lisp/progmodes/etags.el" emacs-test-dir)))
> +   (xref-make "(cl-defmethod xref-location-marker ((l xref-etags-apropos-location)))"
> +              (xref-make-elisp-location
> +               (cl--generic-load-hist-format
> +                'xref-location-marker nil '(xref-etags-apropos-location))
> +               'cl-defmethod
> +               (expand-file-name "../../../lisp/progmodes/etags.el" emacs-test-dir)))
>      ))
>   
>   (xref-elisp-deftest find-defs-defgeneric-eval

The change above doesn't make sense: elisp and 
xref-etags-apropos-location do not mix.