GNU bug report logs - #50507
New function in Emacs GnuTLS implementation

Previous Next

Package: emacs;

Reported by: Nikolaos Chatzikonstantinou <nchatz314 <at> gmail.com>

Date: Fri, 10 Sep 2021 12:02:02 UTC

Severity: wishlist

Tags: fixed, moreinfo

Fixed in version 30.1

Done: Robert Pluim <rpluim <at> gmail.com>

Bug is archived. No further changes may be made.

Full log

Message #99 received at 50507 <at> debbugs.gnu.org (full text, mbox):

From: Robert Pluim <rpluim <at> gmail.com>
To: Nikolaos Chatzikonstantinou <nchatz314 <at> gmail.com>
Cc: 50507 <at> debbugs.gnu.org, Eli Zaretskii <eliz <at> gnu.org>, larsi <at> gnus.org
Subject: Re: bug#50507: New function in Emacs GnuTLS implementation
Date: Mon, 03 Oct 2022 09:40:56 +0200

>>>>> On Fri, 30 Sep 2022 12:22:16 -0400, Nikolaos Chatzikonstantinou <nchatz314 <at> gmail.com> said:
    Nikolaos>   #if COND
    Nikolaos>   if (something)
    Nikolaos>     foo();
    Nikolaos>   else
    Nikolaos>     bar();
    Nikolaos>   #else
    Nikolaos>   bar();
    Nikolaos>   #endif

    Nikolaos> To be rewritten as

    Nikolaos>   #if COND
    Nikolaos>   if (something)
    Nikolaos>     foo();
    Nikolaos>   else
    Nikolaos>   #endif
    Nikolaos>   bar();

    Nikolaos> Because in this case, I don't trust that kind of code to survive the
    Nikolaos> test of time. Someone may come along and break it by modifying the
    Nikolaos> bar() line, and it might be a sneaky bug. It's not easy to tell.

In the first version thereʼs the risk that one of the calls to 'bar'
will be changed and the other missed.

In the second version thereʼs only one 'bar' to change. If someone
changes the 'bar' code so it doesnʼt compile under COND, thatʼs
immediately obvious.

Robert
--
This bug report was last modified 2 years and 197 days ago.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.